summaryrefslogtreecommitdiffstats
path: root/base/scoped_comptr_win.h
Commit message (Collapse)AuthorAgeFilesLines
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-161-155/+5
| | | | | | | | | | | | | | | | base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a non-templatized version of QI for times when the IID and type ↵tommi@chromium.org2009-07-081-0/+7
| | | | | | | | | | | | | aren't associated. Also fixing the ScopedComPtrVector unit test. The problem with the test was that it expected AddRef to be called twice and Release() once when pushing a pointer to the vector. However that only happens when a push causes a reallocation. When there's no reallocation, there's only a single call to AddRef and no call to Release, causing the test to report failure. The fix is to simply use std::list instead and fix the expected values. TEST=Run *ScopedComPtr* unit tests. BUG=none Review URL: http://codereview.chromium.org/149345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20183 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the explicit keyword from the ScopedComPtr constructor so it can be ↵maruel@chromium.org2009-05-131-1/+1
| | | | | | | | included in a STL container. Review URL: http://codereview.chromium.org/115247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15958 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in operator=() to ScopedComPtr.tommi@chromium.org2009-03-071-0/+3
| | | | | | Review URL: http://codereview.chromium.org/40256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11193 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ATL from wmi_utilcpu@google.com2009-01-211-18/+18
| | | | | | | | | | | | | - CComptr and CComBstr gone, baby gone - scoped_comptr_win.h file had a CRLF or at least VC thinks so - Future work: Grow variant helper class to be really helpful - Unit tests already exist It seems base is now free of ATL Review URL: http://codereview.chromium.org/18610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8419 0039d316-1c4b-4281-b951-d872f2087c98
* Renaming the following files to include the _win suffix:tommi@chromium.org2009-01-151-0/+148
scoped_comptr*.* scoped_bstr*.* addition: time_unittest_win.cc -> time_win_unittest.cc BUG=6409 Also renaming the scoped_comptr class to ScopedComPtr to conform with chromium style (and not boost as before). Review URL: http://codereview.chromium.org/18054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8098 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 20:02:37 +0000