summaryrefslogtreecommitdiffstats
path: root/base/stats_table_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-2/+2
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-2/+2
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StatsTable::RegisterThread so that it doesn't crash if shared memoryevan@chromium.org2009-06-161-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | couldn't be allocated. Instead, it just returns 0. Also, fix StatsTable::AddCounter so that it's not a fatal error if shared memory couldn't be allocated. Instead, it just returns 0. In StatsTableTest::StatsCounter, we now assert that the counter could be created, rather than just expecting it. Much of the remainder of the test relies on the fact that foo.Pointer() is non-NULL, and would crash if it were NULL. TEST= StatsTableTest.* RenderViewTest.* Didn't test on Linux (still figuring out how to build on that plaform). Instead, tested on Mac OS X by modifying StatsTablePrivate::New to return NULL, and then ran: unit_tests --gtest_filter='Render*' base_unittests --gtest_filter='StatsTableTest.*' Both tests tests crashed. Then, I applied the changes in this CL, reran the tests, and verified the crashing no longer occured. BUG=13193 BUG=13196 Review URL: http://codereview.chromium.org/126100 Patch from Neil Rhodes <nrhodes@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18527 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling flaky StatsTableTest.MultipleThreads on Linux too.robertshield@google.com2009-04-231-3/+2
| | | | | | | | | | | Fails here for example: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/7281/steps/base_unittests/logs/stdio BUG=http://code.google.com/p/chromium/issues/detail?id=10611 Review URL: http://codereview.chromium.org/92075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14330 0039d316-1c4b-4281-b951-d872f2087c98
* Disable StatsTableTest.MultipleThreads since it is flaky under heavy load.maruel@chromium.org2009-04-201-0/+5
| | | | | | | BUG=10611 Review URL: http://codereview.chromium.org/79010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14029 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated methods from StatsCounter.thestig@chromium.org2009-04-011-3/+3
| | | | | | Review URL: http://codereview.chromium.org/57078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12924 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the windows implementation of KillProcess and WaitForSingleProcess to ↵stoyan@chromium.org2009-02-091-0/+1
| | | | | | | | not close the process handle that they do not own. Review URL: http://codereview.chromium.org/24004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9400 0039d316-1c4b-4281-b951-d872f2087c98
* Properly honor base::SharedMemory semantics for name="" to meanjrg@chromium.org2009-02-041-5/+24
| | | | | | | | | | | | new/private shared memory on POSIX. Transition base::SharedMemory implementation to file/mmap() to prevent leaking of wired kernel resources and allow easier cleanup. Enable one more shared_memory unit test for POSIX. Enable stats_table_unittest.cc for Mac, and modify it so it cleans up. Review URL: http://codereview.chromium.org/19724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9114 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-221-64/+64
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback "Remove use of wide characters in stats table identifiers."evanm@google.com2008-11-211-64/+64
| | | | | | | This reverts commit r5847. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-211-64/+64
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Add Terminate() to the Process object, have RenderProcessHost use this to ↵brettw@google.com2008-11-141-4/+3
| | | | | | | | | | avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Review URL: http://codereview.chromium.org/10895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from the benighted PlatformThread to the shiny SimpleThreaddkegel@google.com2008-11-031-11/+13
| | | | | | | | | Also add a comment to explain the strange tls gyrations in SlotReturnFunction. Review URL: http://codereview.chromium.org/8972 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4481 0039d316-1c4b-4281-b951-d872f2087c98
* Port last remaining test case in base/stats_table_unittest.cc, anddkegel@google.com2008-10-311-17/+17
| | | | | | | | | | fix the bug it exposes on posix in StatsTable, i.e. UnregisterThread() breaks when called inside SlotReturnFunction() on posix because posix clears tls data before calling destructor. Review URL: http://codereview.chromium.org/8751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4309 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Add a new MULTIPROCESS_TEST_MAIN macro to store child process namesjeremy@chromium.org2008-10-291-1/+2
| | | | | | | | | | | | | | in a lookup table. Previously we were using different mechanisms on each platform to look up child process names at runtime. This broke on OS X where we strip the symbol table on release executables. 2) Enable process_util_unittest on OS X. Review URL: http://codereview.chromium.org/8864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4165 0039d316-1c4b-4281-b951-d872f2087c98
* Enable stats_tabe_unittest.cc on OS X.jeremy@chromium.org2008-10-271-3/+3
| | | | | | Review URL: http://codereview.chromium.org/8160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4024 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-0/+2
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Added linux process utilities and tests.estade@chromium.org2008-10-221-28/+35
| | | | | | Review URL: http://codereview.chromium.org/7202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3715 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add a trailing EOL to source files. This eliminates warnings in GCC.deanm@google.com2008-08-141-1/+1
| | | | | | No code change. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@865 0039d316-1c4b-4281-b951-d872f2087c98
* Add base to the repository.initial.commit2008-07-261-0/+396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 08:16:04 +0000