chromium_src.git - central chromium sources

	Commit message (Collapse)	Author	Age	Files	Lines
*	Fixes a corner case bug in the HexStringToInt conversion function which ↵	ali.akbar@gmail.com	2011-08-12	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	caused the string "0x" to be treated as a valid hexadecimal number. Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than or equal to 2 If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result Changed the condition from "greater than or equal to" to "greater than" Added another test cases which now properly treats "0x" as an invalid hex string Contributed by ali.akbar@gmail.com BUG=92054 Review URL: http://codereview.chromium.org/7584031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98
*	Fix a bug that could occur when converting strings with leading characters ↵	erikwright@chromium.org	2010-11-02	1	-0/+7
\| \| \| \| \| \| \| \| \| \| \|	above 127. BUG=None TEST=base_unittests --gtest_filter=StringToInt Review URL: http://codereview.chromium.org/4129012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64789 0039d316-1c4b-4281-b951-d872f2087c98
*	Add StringToInt and HexStringToInt for iterator ranges.	erikwright@chromium.org	2010-10-21	1	-4/+102
\| \| \| \| \| \| \| \|	BUG=52601 TEST=base_unittests / StringNumberConversionsTest.*StringToInt Review URL: http://codereview.chromium.org/3866001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63357 0039d316-1c4b-4281-b951-d872f2087c98
*	Add a newline to the end of the unit test file.	brettw@chromium.org	2010-07-30	1	-1/+1
\| \| \| \| \| \|	TEST=it compiles git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54358 0039d316-1c4b-4281-b951-d872f2087c98
*	Move the number conversions from string_util to a new file.	brettw@chromium.org	2010-07-30	1	-0/+339
	Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98