summaryrefslogtreecommitdiffstats
path: root/base/string_piece_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Resolve an ambiguous function call error in string_piece_unittest.ccpeter@chromium.org2012-01-101-3/+3
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/9167008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117050 0039d316-1c4b-4281-b951-d872f2087c98
* Extract common code from StringPiece and StringPiece16 into a templated base ↵erikwright@chromium.org2011-12-221-292/+194
| | | | | | | | | | | | | | | | | class. Convert copy-and-pasted unit tests into TYPED_TESTs. The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice. The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h . BUG=87634 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114242 Review URL: http://codereview.chromium.org/8659047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115616 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Extract common code from StringPiece and StringPiece16 into a ↵erikwright@chromium.org2011-12-131-173/+292
| | | | | | | | | | | | | | | templated base class.... ... Convert copy-and-pasted unit tests into TYPED_TESTs." This reverts commit 20543ba53ab8737affb06a21149c15f772246aed. BUG= TEST= Review URL: http://codereview.chromium.org/8933012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114255 0039d316-1c4b-4281-b951-d872f2087c98
* Extract common code from StringPiece and StringPiece16 into a templated base ↵erikwright@chromium.org2011-12-131-292/+173
| | | | | | | | | | | | | | | class. Convert copy-and-pasted unit tests into TYPED_TESTs. The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice. The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h . BUG=87634 TEST= Review URL: http://codereview.chromium.org/8659047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114242 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Convert ASCIIToUTF16("") to string16().jhawkins@chromium.org2011-11-281-8/+9
| | | | | | | | | | | | | Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize phishing page term feature extraction.gcasto@chromium.org2011-08-091-0/+231
| | | | | | | | | | | | | | | | | | | | | | | We've been seeing in the histograms that for some users, page feature extraction is taking much longer than we would like, up to 200ms between stops. This could possibly contribute to jankiness in the UI. These are some timings from my desktop for how long it takes to extract features before and after these changes. Obviously this is on much better hardware than the use case we are worried about, but hopefully the increase is speed is proportional. Before After CNN 19 7.5 ESPN 22 9.5 Google 12 4 Salon 40 12 BUG= TEST=Ran associated unit tests. Review URL: http://codereview.chromium.org/7549003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96097 0039d316-1c4b-4281-b951-d872f2087c98
* base: Replace "using namespace base;" by wrapping the tests around ↵tfarina@chromium.org2011-05-101-3/+4
| | | | | | | | | | | | | "namespace base { ... }" BUG=82078 TEST=base_unittests R=evan@chromium.org Review URL: http://codereview.chromium.org/7000011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84870 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-101-0/+2
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE. Update string_piece.h to new include style, and remove ↵deanm@chromium.org2008-11-081-1/+0
| | | | | | | | Ben's trailing whitespace. Really just want a buildbot run :\ Review URL: http://codereview.chromium.org/9730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5075 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some warnings found in string unittests.evanm@google.com2008-08-191-88/+88
| | | | | | | (Preparation for enabling -Wall -Werror.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1012 0039d316-1c4b-4281-b951-d872f2087c98
* rollback r922 to fix windows bustagedarin@google.com2008-08-151-85/+85
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@924 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more compiler warnings.darin@google.com2008-08-151-84/+84
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@922 0039d316-1c4b-4281-b951-d872f2087c98
* Add base to the repository.initial.commit2008-07-261-0/+565
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 07:35:55 +0000