| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=mark@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1538743002
Cr-Commit-Position: refs/heads/master@{#366910}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace most usage of MessageLoopProxy under base/ with SingleThreadTaskRunner
and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy
itself which will removed later).
This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002.
Depends on https://codereview.chromium.org/1086733002/.
BUG=465354
TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org
Review URL: https://codereview.chromium.org/1100773004
Cr-Commit-Position: refs/heads/master@{#327755}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1100773004/)
Reason for revert:
This CL caused this failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/2126
I would strongly recommend doing this in smaller pieces since it combines mechanical changes with more subtle ones (base/prefs, base/task).
Original issue's description:
> base: Remove use of MessageLoopProxy
>
> Replace usage of MessageLoopProxy under base/ with SingleThreadTaskRunner
> and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy
> itself which will removed later).
>
> This patch was mostly autogenerated with
> https://codereview.chromium.org/1010073002.
>
> Depends on https://codereview.chromium.org/1086733002/.
>
> BUG=465354
> TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org
>
> Committed: https://crrev.com/62aa5ca413e15738ebebbb9acd271138ec808739
> Cr-Commit-Position: refs/heads/master@{#327512}
TBR=danakj@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465354
Review URL: https://codereview.chromium.org/1113953002
Cr-Commit-Position: refs/heads/master@{#327573}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace usage of MessageLoopProxy under base/ with SingleThreadTaskRunner
and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy
itself which will removed later).
This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002.
Depends on https://codereview.chromium.org/1086733002/.
BUG=465354
TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org
Review URL: https://codereview.chromium.org/1100773004
Cr-Commit-Position: refs/heads/master@{#327512}
|
|
|
|
|
|
|
|
|
| |
BUG=417463
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/668783004
Cr-Commit-Position: refs/heads/master@{#300447}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/611153004
Cr-Commit-Position: refs/heads/master@{#298520}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found by a tweaked -Wunused-member-function Nuno Lopes is working on.
BUG=none
R=brettw@chromium.org, miket@chromium.org, rsleevi@chromium.org, sky@chromium.org
TBR=rogerta, sky
Review URL: https://codereview.chromium.org/213363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ConditionVariableTest.LargeFastTaskTest
ConditionVariableTest.MultiThreadConsumerTest
ConditionVariableTest.TimeoutTest
PosixDynamicThreadPoolTest.Complex
PosixDynamicThreadPoolTest.ReuseIdle
PosixDynamicThreadPoolTest.TwoActiveTasks
There's been a bug in the TSan runtime causing these tests to fail.
BUG=303007
TBR=jar@chromium.org
Review URL: https://codereview.chromium.org/27019012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the threadpool size:
ConditionVariableTest.LargeFastTaskTest
ConditionVariableTest.MultiThreadConsumerTest
ConditionVariableTest.TimeoutTest
PosixDynamicThreadPoolTest.Complex
PosixDynamicThreadPoolTest.ReuseIdle
PosixDynamicThreadPoolTest.TwoActiveTasks
BUG=303007
TBR=jar@chromium.org
Review URL: https://codereview.chromium.org/25675007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-Mac non-NaCl posix
Both use a relative time, and it's important that this relative time is consistent with the wall clock when the system time gets adjusted (e.g. NTP, tlsdate, etc.). The monotonic clock, when available, has that property. Unfortunately, by default, pthread_cond_timedwait takes the system time which doesn't have that property.
On Linux/Chrome OS, we use pthread_condattr_setclock which lets us use the monotonic clock. On Android, we use the non-portable pthread_cond_timedwait_monotonic_np which has the same effect.
Unfortunately, neither is supported by NaCl.
Mac can use the non-portable pthread_cond_timedwait_relative_np which uses a relative time.
BUG=293736
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/24158005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18119002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109874
R=darin@chromium.org,ajwong@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11961021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The style guide says that constructors which can be called with one
argument should be explicit.
For constructors which cannot be called with exactly one argument,
there is no reason to mark them explicit.
BUG=163357
Review URL: https://chromiumcodereview.appspot.com/11779022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/10004001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It suddenly got flaky around r124275-124280.
BUG=10607
TEST=none
TBR=jknotten@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9557012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: https://chromiumcodereview.appspot.com/6049006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the code that tests that Signal() will wake up just one thread.
According to base/synchronization/condition_variable.h, "there can/will be
spurious signals.". One reason for this is explained in the linux man page
for pthread_cond_signal: "The pthread_cond_signal() function shall unblock
*at least one* of the threads" and "On a multi-processor, it may be
impossible for an implementation of pthread_cond_signal() to avoid the
unblocking of more than one thread blocked on a condition variable."
BUG=10607
TEST=ConditionVariableTest.MultiThreadConsumerTest
Review URL: http://codereview.chromium.org/9309055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9055001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
I kept a base/lock.h in place with a using statement to avoid updating
all callers in one CL.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6018013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
|