summaryrefslogtreecommitdiffstats
path: root/base/sys_string_conversions.h
Commit message (Collapse)AuthorAgeFilesLines
* Don't attempt to forward declare StringPiece.erikwright@chromium.org2011-12-131-2/+1
| | | | | | | | | | | | | 1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types. 2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'. BUG=87634 R=brettw@chromium.org Review URL: http://codereview.chromium.org/8820016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114124 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-21/+21
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Components build for base, easy partthakis@chromium.org2011-07-291-12/+12
| | | | | | | | | | BUG=90078 TEST=none Review URL: http://codereview.chromium.org/7474010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94636 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more files using BASE_API (for base.dll)rvargas@google.com2011-03-241-7/+11
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6729002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79303 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NSString conversions to treat a null NSString as a string of length 0, ↵mirandac@chromium.org2009-11-081-1/+2
| | | | | | | | | | | instead of crashing. This allows Cocoa to use null objects as empties, as is its wont, and we only run a check when needed. This CL also removes the now-superfluous checks for null NSStrings from BugReportWindowController. A cursory look through the code shows that there are many places where a check for null precedes a call to an NSString conversion; filed another bug against myself to go through and fix all of these (http://code.google.com/p/chromium/issues/detail?id=27055). Also filed a bug to expand unit tests for NSString conversion methods (http://code.google.com/p/chromium/issues/detail?id=27059). Review URL: http://codereview.chromium.org/371057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31408 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-101-2/+2
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE (except one global std::wstring changed to const wchar_t* ↵maruel@chromium.org2009-03-031-3/+3
| | | | | | | | | | | const per style compliance). Preliminary work to enforce new PRESUBMIT.py rules: - <=80 cols - no trailing whitespaces - svn:eol-style=LF git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10791 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we deal with string16s, provide some useful conversions for them.avi@chromium.org2009-02-181-0/+5
| | | | | | Review URL: http://codereview.chromium.org/21473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9970 0039d316-1c4b-4281-b951-d872f2087c98
* Provide converters to and from NSString* in sys_string_conversionsmark@chromium.org2008-10-081-2/+14
| | | | | | Review URL: http://codereview.chromium.org/6355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3050 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Impl of platform mime typing for Mac.avi@google.com2008-08-221-0/+21
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1238 0039d316-1c4b-4281-b951-d872f2087c98
* Pass StringPieces by constant reference.deanm@google.com2008-08-201-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1085 0039d316-1c4b-4281-b951-d872f2087c98
* Move the system string conversion functions from std::string to StringPiece. ↵deanm@google.com2008-08-191-3/+5
| | | | | | We often work with char* in the system layer, so this should save extra copying. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1027 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sys_string_conversions for use on the Mac.mmentovai@google.com2008-08-071-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@528 0039d316-1c4b-4281-b951-d872f2087c98
* Add defines for the size of wchar_t to build_config.h. Use this in places ↵brettw@google.com2008-08-071-3/+3
| | | | | | | | | | where we currently have an OS-specific check. Remove all WIN32 ifdefs from base and replace them with proper defined(OS...). I also fixed random style bits when I encountered them. I made major style fixes to string16. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@524 0039d316-1c4b-4281-b951-d872f2087c98
* This is the addition of the system-dependent string conversions. This is ↵brettw@google.com2008-08-071-0/+67
just the new code and changing logging to use it. I will change other things to use this and delete the code in string_util in a subsequent pass. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@479 0039d316-1c4b-4281-b951-d872f2087c98