summaryrefslogtreecommitdiffstats
path: root/base/test
Commit message (Collapse)AuthorAgeFilesLines
* Clean up some API in trace_event_analyzer.h and add some getters.jbates@chromium.org2011-11-043-29/+126
| | | | | | Review URL: http://codereview.chromium.org/8438058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108672 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the SignalingTask class to base/test.tommi@chromium.org2011-11-022-0/+51
| | | | | | | | | | | As requested in another review (http://codereview.chromium.org/8427031/diff/1009/content/renderer/media/webrtc_audio_device_unittest.cc#newcode132). so that it can be reused in content tests. TEST=none BUG=none Review URL: http://codereview.chromium.org/8438034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108271 0039d316-1c4b-4281-b951-d872f2087c98
* Expose the sandbox related code through the content API. I did a bit of ↵jam@chromium.org2011-10-291-1/+5
| | | | | | | | | | | | | cleanup while I was doing this. -got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo -got rid of the duplicated code to initialize the broker -since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs. BUG=98716 Review URL: http://codereview.chromium.org/8414020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98
* add classes trace_analyzer::Query and TraceAnalyzer to improve testing (retry)jbates@chromium.org2011-10-293-0/+1647
| | | | | | | | | | | http://codereview.chromium.org/7981004/ BUG=95714 TEST=base_unittests Review URL: http://codereview.chromium.org/8418044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107813 - add classes trace_analyzer::Query and TraceAnalyzer to make ↵jbates@chromium.org2011-10-293-1647/+0
| | | | | | | | | | | | | | | | it easy to search through trace data. This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code. BUG=95714 TEST=base_unittests Review URL: http://codereview.chromium.org/7981004 TBR=jbates@chromium.org Review URL: http://codereview.chromium.org/8413063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107845 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107830 - Fix BASE_EXPORT on QueryNodejbates@chromium.org2011-10-291-1/+1
| | | | | | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/8400079 TBR=jbates@chromium.org Review URL: http://codereview.chromium.org/8400081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107843 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BASE_EXPORT on QueryNodejbates@chromium.org2011-10-291-1/+1
| | | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/8400079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107830 0039d316-1c4b-4281-b951-d872f2087c98
* add classes trace_analyzer::Query and TraceAnalyzer to make it easy to ↵jbates@chromium.org2011-10-283-0/+1647
| | | | | | | | | | | | | search through trace data. This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code. BUG=95714 TEST=base_unittests Review URL: http://codereview.chromium.org/7981004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107813 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-262-13/+13
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-252-13/+13
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-252-13/+13
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream: The test stub for Androidmichaelbai@google.com2011-10-043-0/+243
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8086004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103912 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Tracked, and move Location to its own file.ajwong@chromium.org2011-09-211-0/+2
| | | | | | | | | | | | | The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure. Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7879006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid long test_server timeouts by using action_timeout_msphajdan.jr@chromium.org2011-09-121-1/+1
| | | | | | | | | | | | | | | instead of action_max_timeout_ms. This increases action_timeout_ms a little bit, otherwise test_server becomes more flaky (fails to start in time). This effectively reduces the timeout for TestServer start from 45s to 10s. BUG=93770 Review URL: http://codereview.chromium.org/7744004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100706 0039d316-1c4b-4281-b951-d872f2087c98
* Move test utilities into test_file_util.*.ahendrickson@chromium.org2011-09-023-0/+79
| | | | | | | | | | | | | Split from CL 7134019. brettw: base. BUG=None TEST=None Review URL: http://codereview.chromium.org/7740081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99416 0039d316-1c4b-4281-b951-d872f2087c98
* Enable smooth scrolling on macthakis@chromium.org2011-09-011-3/+4
| | | | | | | | | | | This confuses a few unit tests, so add some machinery to disable the feature in tests and do so in the tests that need it. BUG=61140,575 TEST=Go to en.wikipedia.org, hit space. Scroll should be animated. Review URL: http://codereview.chromium.org/7693019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99186 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete test timeouts and convert callers.phajdan.jr@chromium.org2011-08-251-15/+0
| | | | | | | | | | This will make it easier to choose the right timeout. BUG=none Review URL: http://codereview.chromium.org/7744031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98273 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused test command-line switches.phajdan.jr@chromium.org2011-08-253-15/+0
| | | | | | | | BUG=none Review URL: http://codereview.chromium.org/7743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98263 0039d316-1c4b-4281-b951-d872f2087c98
* Tommi: I need an owner review for the chrome frame changes.rogerta@chromium.org2011-08-242-0/+129
| | | | | | | | | | | | | | Moving the test helper class TempRegKeyOverride since I need to do something similar in some new RLZ tests, and I don't want to duplicate the code. Please suggest a better namespace name if needed, I was just following the same pattern found in test_file_util in the same directory. BUG=None TEST=No new tests, just refactoring test helpers Review URL: http://codereview.chromium.org/7669061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98100 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Reduce number of different timeouts.phajdan.jr@chromium.org2011-08-222-15/+7
| | | | | | | | | | | This will help choosing the right timeouts and avoid many confusions. BUG=none Review URL: http://codereview.chromium.org/7712013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97741 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename FileEnumerator::FILE_TYPE to FileEnumerator::FileType.tfarina@chromium.org2011-08-151-5/+5
| | | | | | | | | | | | | | enum types should be named using CamelCase as class and function names, not using MACRO_STYLE. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7618037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96766 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeout to 45s.thakis@chromium.org2011-08-081-1/+1
| | | | | | | | | | | | | This is so that long running tests don't flakily bump into the timeout every now and then. BUG=none TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7595008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95860 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeout by 2 more seconds.thakis@chromium.org2011-08-071-1/+1
| | | | | | | | | | | | | | | | | | The previous increase made almost all interactive_ui_tests pass in Debug, but DevToolsSanityTest.TestShowScriptsTab DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh are still failing. They used to take 23.3s and 24s with gcc, and the DevToolsSanityTests got about 5s slower in Debug on 10.5 (less on 10.6). BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7583029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95771 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeout for out of process tests by 4 seconds.thakis@chromium.org2011-08-071-1/+1
| | | | | | | | | | | | | | This is to test if the browser_test and interactive_ui_test failures on the mac dbg builds after the switch to clang are due to tests narrowly missing their timeout -- that's what it looks like locally. BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7569033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95770 0039d316-1c4b-4281-b951-d872f2087c98
* In test_file_util_mac.cc, when evicting file from cache, do not map a file ↵hnguyen@chromium.org2011-08-031-3/+16
| | | | | | | | | | | | when it is empty. BUG=none TEST=none Review URL: http://codereview.chromium.org/7484052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95334 0039d316-1c4b-4281-b951-d872f2087c98
* Change base::LaunchProcess API slightlyevan@chromium.org2011-07-151-2/+1
| | | | | | | | | | | Rather than passing the out param process handle via the options, take it as a function argument. This simplifies many callers. BUG=88990 Review URL: http://codereview.chromium.org/7377012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-132-32/+16
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92393 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up users of a deprecated base::LaunchApp API."evan@chromium.org2011-07-122-16/+32
| | | | | | This reverts commit r92240, ChromeOS failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92244 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-122-32/+16
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92240 0039d316-1c4b-4281-b951-d872f2087c98
* Added last_modified field to TemplateURL and database. Updated unit tests, ↵stevet@chromium.org2011-06-282-0/+97
| | | | | | | | | | including refactoring MockTimeProvider out of media/. BUG=None TEST=No visible changes. Ensure that changed unittests all pass. Review URL: http://codereview.chromium.org/7232023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90764 0039d316-1c4b-4281-b951-d872f2087c98
* Move the thread test helper to base/testjochen@chromium.org2011-06-282-0/+82
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7239023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90723 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in base/test.joaodasilva@chromium.org2011-06-203-41/+53
| | | | | | | | | | | | | | This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89664 Review URL: http://codereview.chromium.org/7129056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89664 - Cleanup in base/test.joaodasilva@chromium.org2011-06-203-53/+41
| | | | | | | | | | | | | | | This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Review URL: http://codereview.chromium.org/7129056 TBR=joaodasilva@chromium.org Review URL: http://codereview.chromium.org/7212008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89669 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in base/test.joaodasilva@chromium.org2011-06-203-41/+53
| | | | | | | | | | | | This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Review URL: http://codereview.chromium.org/7129056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89664 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing inclusionstzik@chromium.org2011-06-181-1/+2
| | | | | | | | | | BUG=None TEST='LoggingTest.*,FileUtilTest.*,PlatformFile.*,StringNumberConversionsTest.*,Time,TimeTicks,TimeDelta' Review URL: http://codereview.chromium.org/7108033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89595 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move --test-terminate-timeout logic to base/test/test_timeoutsphajdan.jr@chromium.org2011-06-103-0/+5
| | | | | | | | | | | | | | | | | This is the first step towards removing --test-terminate-timeout completely. In this CL --test-terminate-timeout becomes a synonym for --ui-test-action-max-timeout. This makes it possible to switch callers to --ui-test-action-max-timeout and remove --test-terminate-timeout. Removing number of different kinds of timeouts makes it easier to pick one. BUG=none Review URL: http://codereview.chromium.org/7111035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88653 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Initialize TestTimeouts in out-of-process test runner.phajdan.jr@chromium.org2011-06-091-5/+22
| | | | | | | | | | | This is needed to make command-line changes take effect. Also, added checks to prevent a similar mistake from happening in the future. Actually, the checks detected such misuse in process_util_unittests, and this CL fixes it. BUG=85287 Review URL: http://codereview.chromium.org/7044048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88561 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 88111 - GTTF: Move --test-terminate-timeout logic to ↵rsimha@chromium.org2011-06-083-5/+0
| | | | | | | | | | | | | | | | | | | | | | | base/test/test_timeouts Reason for revert: This patch causes --test-terminate-timeout to be disregarded by out_of_proc_test_runner.cc, resulting in redness on the sync buildbots. This is the first step towards removing --test-terminate-timeout completely. In this CL --test-terminate-timeout becomes a synonym for --ui-test-action-max-timeout. This makes it possible to switch callers to --ui-test-action-max-timeout and remove --test-terminate-timeout. Removing number of different kinds of timeouts makes it easier to pick one. BUG=none Review URL: http://codereview.chromium.org/7111035 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/7104059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88352 0039d316-1c4b-4281-b951-d872f2087c98
* Added a test verifying that TimeFormat:: functions convertjoaodasilva@chromium.org2011-06-081-0/+41
| | | | | | | | | | | | | numbers to "NaN" on certain locales. This is a bug on icu. Rolled third_party/icu version to @88321. BUG=60476 TEST=browser_tests:TimeFormat.DecimalPointNotDot Review URL: http://codereview.chromium.org/7003028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88329 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move --test-terminate-timeout logic to base/test/test_timeoutsphajdan.jr@chromium.org2011-06-073-0/+5
| | | | | | | | | | | | | | | | This is the first step towards removing --test-terminate-timeout completely. In this CL --test-terminate-timeout becomes a synonym for --ui-test-action-max-timeout. This makes it possible to switch callers to --ui-test-action-max-timeout and remove --test-terminate-timeout. Removing number of different kinds of timeouts makes it easier to pick one. BUG=none Review URL: http://codereview.chromium.org/7111035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88111 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Remove wait_for_terminate_timeout_ms in favor of action_max_timeout_msphajdan.jr@chromium.org2011-05-202-12/+0
| | | | | | | | | | Reducing number of different timeouts makes it easier to choose one. BUG=none Review URL: http://codereview.chromium.org/7055007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86127 0039d316-1c4b-4281-b951-d872f2087c98
* Use the IAttachmentExecute service to set the Zone.Identifier stream,joaodasilva@chromium.org2011-04-291-13/+16
| | | | | | | | | | | | | | | | | when available. This is used to mark files as untrusted, because they were downloaded from the internet. The DownloadTest.CheckInternetZone browser test was failing previously because the Zone.Identifier stream created by the IAttachmentExecute service uses \r\n for newlines, and the test was checking for \n. See also http://codereview.chromium.org/590001, which this should close. BUG=5719 TEST=DownloadTest.CheckInternetZone Review URL: http://codereview.chromium.org/6880236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83502 0039d316-1c4b-4281-b951-d872f2087c98
* Move crypto files out of base, to a top level directory.rvargas@google.com2011-04-141-9/+0
| | | | | | | | | | | | | src/crypto is now an independent project that contains our cryptographic primitives (except md5 and sha1). This removes the base dependency from nss, openssl and sqlite. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6805019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81611 0039d316-1c4b-4281-b951-d872f2087c98
* Removing command_execution_timeout_ms in favor of action_max_timeout_ms.hnguyen@chromium.org2011-04-114-19/+5
| | | | | | | R=jcivelli@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,nirnimesh@chromium.org Review URL: http://codereview.chromium.org/6685099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81164 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS for base/testphajdan.jr@chromium.org2011-03-211-0/+1
| | | | | | | | R=brettw@chromium.org Review URL: http://codereview.chromium.org/6713077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78899 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove some simple uses of FromWStringHackevan@chromium.org2011-03-153-0/+7
| | | | | | | | BUG=76112 Review URL: http://codereview.chromium.org/6695008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78247 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: allow converting FilePath to wstring in testsevan@chromium.org2011-03-033-0/+16
| | | | | | | | | | | | Many of our tests want to use Unicode literal strings with the L"foobar" syntax. Allow us to test FilePaths against these strings. BUG=69467 Review URL: http://codereview.chromium.org/6606025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76763 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gtest 492:539 and gmock 300:358thakis@chromium.org2011-02-241-0/+3
| | | | | | | | | | | | | | | | | | | | Skimming their changelogs, it looks like this range contains only minor tweaks for the most part. gtest r500 is interesting: http://code.google.com/p/googletest/source/detail?spec=svn500&r=500 "Modifies handling of C++ exceptions in death tests to treat exceptions escaping them as failures." This confuses to death tests in message_loop_unittest on Windows, MessageLoopTest::Crasher and MessageLoopTest::CrasherNasty. These two tests set the global SEH handler. gtest now uses a frame-level exception handler, which overrides this global handler. Hence, disable gtest's new death test behavior for base_unittests on windows. This is to prepare a gmock roll to 359, which should improve build speed on mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/6580010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Downloads Windows Zone identifier test.rdsmith@chromium.org2011-02-232-34/+23
| | | | | | | | | | | Changes the setting of the Zone Identifier to not include an unnecessary trailing null byte, modifies the test to check for any of a range of options known to be acceptable to Windows, and makes explicit the restriction the utility test function works under. BUG=20809 TEST=Test run on windows and successful try bot run (with test enabled). Review URL: http://codereview.chromium.org/6541003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75762 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 06:56:05 +0000