summaryrefslogtreecommitdiffstats
path: root/base/test
Commit message (Collapse)AuthorAgeFilesLines
* Add missing, and remove unnecessary, 'explicit' from constructors. (base/)hans@chromium.org2013-01-151-4/+4
| | | | | | | | | | | | | | | The style guide says that constructors which can be called with one argument should be explicit. For constructors which cannot be called with exactly one argument, there is no reason to mark them explicit. BUG=163357 Review URL: https://chromiumcodereview.appspot.com/11779022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Add java InvalidationController for Android.nyquist@chromium.org2013-01-122-0/+290
| | | | | | | | | | | | | | | | | | | * Adds InvalidationController to facilitate the move to the new invalidation client, but still supporting the old way. * Sets up the chromium test shell to be able to run the new tests for sync. * Upstreaming a few base test utilities for MockContext and SharedPreferences. InvalidationController and InvalidationControllerTest provided by dsmyers@chromium.org. BUG=159221 Review URL: https://chromiumcodereview.appspot.com/11778084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176533 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SequenceChecker, which is a generalization of ThreadCheckerakalin@chromium.org2012-12-272-0/+65
| | | | | | | | | | | | | | SequenceChecker will be used in WeakPtr instead of ThreadChecker, since WeakPtr needs only the guarantees of a SequencedTaskRunner. Add NullTaskRunner implementation and make test_browser_context.cc use it. BUG=165590 Review URL: https://codereview.chromium.org/11550031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174693 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: No more FLAKY_ .phajdan.jr@chromium.org2012-12-212-66/+0
| | | | | | | | | | | | | | | | | | | | | | | Please note that FLAKY_ tests have been ignored anyway. When tests started crashing, people just flipped that to DISABLED_ . Why not go straight to DISABLED_ then, so that we avoid wasting time on stupid test prefix games? With DISABLED_ it is clear to everyone that there is no coverage from given test. FLAKY_ creates an illusion of coverage, while in fact the test is still ignored. If a FLAKY_ test fails and nobody notices, does it still make a sound? ;-) Finally, note that gtest has a --gtest_also_run_disabled_tests if you need to run tests manually. TBR=jam BUG=none Review URL: https://codereview.chromium.org/11664013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174472 0039d316-1c4b-4281-b951-d872f2087c98
* Restore previous large_test_timeout_ms.tonyg@chromium.org2012-12-211-2/+1
| | | | | | | | | | | | It was lowered for release builds by r169997 and since then the database page cycler has been frequently timing out. BUG=166984 TEST=None Review URL: https://chromiumcodereview.appspot.com/11647023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174336 0039d316-1c4b-4281-b951-d872f2087c98
* Unify various test TaskRunner implementationsakalin@chromium.org2012-12-194-0/+247
| | | | | | | | | | | | | | Remove various ad-hoc test implementations of TaskRunner and implement TestSimpleTaskRunner instead. Add TestPendingTask class for use by test TaskRunner implementations. Clean up TestTaskRunner implementation in net/ and make it use TestPendingTask. BUG=165806 Review URL: https://codereview.chromium.org/11554036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174016 0039d316-1c4b-4281-b951-d872f2087c98
* Add a base::ParseJson() function to help tests construct Values.jyasskin@chromium.org2012-12-172-1/+30
| | | | | | | | | | | | | | This is very similar to base::JSONReader::Read() except that it allows trailing commas and EXPECT-fails with a good message when the json is malformed. I migrated two tests to use this as a demonstration that it's widely useful and makes things more readable. Review URL: https://chromiumcodereview.appspot.com/11567027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 172358: this messes up our GPU debug bots.zmo@chromium.org2012-12-151-0/+5
| | | | | | | | | | | | | | | build.chromium.org/p/chromium.gpu/waterfall > GTTF: Lower timeouts. > > BUG=none > > Review URL: https://codereview.chromium.org/11442027 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/11570047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173255 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new utility class for instrumentation tests.jcivelli@chromium.org2012-12-131-0/+143
| | | | | | | | | | | | | | | Some instrumentation tests that exercise class that post tasks require the message loop to be flushed. This TestThread provides a way to run that class on a different thread that takes care of processing all pending events. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/11473014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172942 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Lower timeouts.phajdan.jr@chromium.org2012-12-111-5/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11442027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172358 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Lower timeouts for Release mode.phajdan.jr@chromium.org2012-11-281-0/+5
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11421012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169997 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProcessUtilTest.FDRemapping on Android.pliard@chromium.org2012-11-271-9/+33
| | | | | | | | | | | This provides a simple implementation of file descriptors remapping on Android. BUG=136720 Review URL: https://chromiumcodereview.appspot.com/11417115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169652 0039d316-1c4b-4281-b951-d872f2087c98
* [base] Move AutoReset to base namespace.dbeam@chromium.org2012-11-211-1/+1
| | | | | | | | | | | NOTRY=true R=darin@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11308132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168978 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-161-1/+1
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnableInProcessStackDumping to base/debugphajdan.jr@chromium.org2012-11-011-1/+2
| | | | | | | | | | | | | | This is a preparation to fix async-signal unsafety of the stack dumping signal handler, and I'd like to share code between the handler and stack trace code that wouldn't be useful outside those two. BUG=101155 TEST=if it compiles, it is perfect Review URL: https://codereview.chromium.org/11293021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165514 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards component build for Android.yfriedman@chromium.org2012-11-011-4/+6
| | | | | | | | | | Add symbol exports needed to build content shell. BUG=158821 Review URL: https://codereview.chromium.org/11368031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165420 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: remove FAILS_ prefix, part 1phajdan.jr@chromium.org2012-11-011-13/+1
| | | | | | | | | | | See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion BUG=none Review URL: https://codereview.chromium.org/11293028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
* Removing myself from OWNERs and WATCHLISTsatish@chromium.org2012-10-291-1/+0
| | | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/11345006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164693 0039d316-1c4b-4281-b951-d872f2087c98
* Adds EnormousTest annotation.klundberg@chromium.org2012-10-111-0/+24
| | | | | | | | | | | | | | | The EnormousTest annotation is used for Android Instrumentation tests that access external web sites, are long running, or in general doesn't fall under the small, medium and large test categories. Enormous tests should never run on tree closing bots. BUG= Review URL: https://chromiumcodereview.appspot.com/11066109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161379 0039d316-1c4b-4281-b951-d872f2087c98
* Update all unit tests that override paths to use the ScopedPathOverride.pastarmovj@chromium.org2012-10-091-4/+6
| | | | | | | | | | | | | This makes sure that overrides are removed when tests are over and don't pollute the global singleton state shared by all tests. BUG=149161 TEST=All unit tests should still pass. Review URL: https://chromiumcodereview.appspot.com/10947008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160855 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming chrome/common/chrome_* diff.aurimas@chromium.org2012-10-021-4/+2
| | | | | | | | | | | Upstreaming chrome/common/chrome_* diff for Android. BUG=152827 Review URL: https://chromiumcodereview.appspot.com/11031008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159777 0039d316-1c4b-4281-b951-d872f2087c98
* - Implement delayed task posting for SequencedWorkerPool.nhiroki@chromium.org2012-10-022-25/+142
| | | | | | | | | | | - Copy unit tests from MessageLoop. BUG=119657 TEST=base_unittests Review URL: https://chromiumcodereview.appspot.com/10828299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159657 0039d316-1c4b-4281-b951-d872f2087c98
* Add ScopedPathOverride to the unit test suite.pastarmovj@chromium.org2012-09-272-0/+64
| | | | | | | | | | | | | | | Unit tests have to restore the Overrdies they make because they all live in the same process and not cleaning up their mess means other tests will run against possibly modified profiles. This class allows tests to set up path overrides and clean them up in a convenient way and makes sure the global path map stays clean afterwards. BUG=149161 TEST=unit_tests still pass. Review URL: https://chromiumcodereview.appspot.com/10948010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158951 0039d316-1c4b-4281-b951-d872f2087c98
* Use gtest failures and EXPECTS instead of returning a failure enum in test ↵gab@chromium.org2012-09-262-84/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | target base/test/test_shortcut_win.cc BUG=148539 TEST=base_unittests.exe --gtest_filter=ShortcutTest* installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests --gtest_filter=ProfileShortcutManagerTest* Locally tried a test meant to fail for every property: TEST_F(ShortcutTest, CreateShortcutVerifyPropertiesWrong) { ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink( link_file_, link_properties_, base::win::SHORTCUT_CREATE_ALWAYS)); base::win::ShortcutProperties wrong_properties = link_properties_; wrong_properties.set_target(FilePath(L"g:\\src\\component\\.gclient")); wrong_properties.set_working_dir(temp_dir_2_.path()); wrong_properties.set_arguments(string16()); wrong_properties.set_description(L"foo"); wrong_properties.set_icon(temp_dir_2_.path().Append(L"joe.ico"), 8); wrong_properties.set_app_id(L"JOE"); wrong_properties.set_dual_mode(true); base::win::ValidateShortcut(link_file_, wrong_properties); } And got expected failure output for every property: [ RUN ] ShortcutTest.CreateShortcutVerifyPropertiesWrong g:\src\component\src\base\test\test_shortcut_win.cc(54): error: Value of: long_actual_path Actual: G:\src\temp\scoped_dir14192_645\Target 1.txt Expected: long_expected_path Which is: g:\src\component\.gclient g:\src\component\src\base\test\test_shortcut_win.cc(54): error: Value of: long_actual_path Actual: G:\src\temp\scoped_dir14192_645 Expected: long_expected_path Which is: G:\src\temp\scoped_dir14192_27681 g:\src\component\src\base\test\test_shortcut_win.cc(95): error: Value of: read_arguments Actual: L"--magic --awesome" Expected: properties.arguments Which is: L"" g:\src\component\src\base\test\test_shortcut_win.cc(101): error: Value of: read_description Actual: L"Chrome is awesome." Expected: properties.description Which is: L"foo" g:\src\component\src\base\test\test_shortcut_win.cc(43): error: Expected: (0U) != (::GetLongPathNameW( expected_path.val ue().c_str(), long_expected_path_chars, 260)), actual: 0 vs 0 Failed to get LongPathName of G:\src\temp\scoped_dir14192_27681\joe.ico g:\src\component\src\base\test\test_shortcut_win.cc(108): error: Value of: read_icon_index Actual: 4 Expected: properties.icon_index Which is: 8 g:\src\component\src\base\test\test_shortcut_win.cc(129): error: Value of: read_app_id Actual: L"Chrome" Expected: properties.app_id Which is: L"JOE" g:\src\component\src\base\test\test_shortcut_win.cc(138): error: Value of: static_cast<bool>(read_dual_mode) Actual: false Expected: properties.dual_mode Which is: true [ FAILED ] ShortcutTest.CreateShortcutVerifyPropertiesWrong (37 ms) Review URL: https://chromiumcodereview.appspot.com/10996005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158909 0039d316-1c4b-4281-b951-d872f2087c98
* Move base Java utils to base/test/android/javatests.nyquist@chromium.org2012-09-247-0/+216
| | | | | | | | | | | | | | | | | | | gyp targets should not depend on tests from other packages, but instead be able to depend on their test utils. The target including the base utilities is called base_java_test_support and contains files from base/test/android/javatests. base_java_test_support was also the name of the wrongly named target for building base/android/javatests, but since only contained util-classes, no new target has been created for tests of base/android/java. BUG=151561,150773 Review URL: https://chromiumcodereview.appspot.com/10974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158422 0039d316-1c4b-4281-b951-d872f2087c98
* Add some TraceAnalyzer utility methods to simplify test codejbates@chromium.org2012-09-133-28/+108
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10911268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in ↵gab@chromium.org2012-09-122-0/+180
| | | | | | | | | | | | | | | | | | | | | | | http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98
* Fix trace event macro naming issuejbates@chromium.org2012-09-111-5/+5
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10908183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155955 0039d316-1c4b-4281-b951-d872f2087c98
* installer_util_unittests has failed on XP Tests (dbg)(1) since this landeddgrogan@chromium.org2012-09-112-180/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Revert 155869 - Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. BUG=132825 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* Review URL: https://chromiumcodereview.appspot.com/10914109 TBR=gab@chromium.org Review URL: https://chromiumcodereview.appspot.com/10910183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155918 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring and tests for the highly undertested ↵gab@chromium.org2012-09-102-0/+180
| | | | | | | | | | | | | | | | | | | | | | file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. BUG=132825 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* Review URL: https://chromiumcodereview.appspot.com/10914109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155869 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Use external storage for test data.nileshagrawal@chromium.org2012-09-041-8/+5
| | | | | | | | | | | Also increasing priority for logging test markers. BUG= Review URL: https://chromiumcodereview.appspot.com/10896050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154786 0039d316-1c4b-4281-b951-d872f2087c98
* implement SetWatchEvent and WaitForEvent for trace-based-tests.jbates@chromium.org2012-09-011-5/+4
| | | | | | | | | | | | Up until now, tracing-based tests have been required to either run a trace for some amount of time or use existing notification mechanisms to return control to the test. This change adds a 'watch event' feature to trace_event_impl which can be used by tests to wait for an event to occur. This mechanism could replace the use of test-only notifications which is frowned upon as well as mock classes for catching events. Trace events also have the huge advantage of working on all chrome processes as opposed to the browser-only notification service. BUG=139939 Review URL: https://chromiumcodereview.appspot.com/10837082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154552 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DCHECKs in non-official release builds on Android.wangxianzhu@chromium.org2012-08-291-1/+1
| | | | | | | | | | | | | | | | | | | This is to better match tests expectations on other platforms. This should have been modified when switching default build from Release to Debug. I thought defining NDEBUG was enough to disable DCHECKs (though it really improves the performance of Release build because of other debug code disabled.) Change-Id: I16f346d73a6bcc0fe5a1c18d040d7dd184b37e2f R=yfriedman@chromium.org,ilevy@chromium.org,nileshagrawal@chromium.org TBR=phajdan.jr@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10885002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153810 0039d316-1c4b-4281-b951-d872f2087c98
* Rename SystemMonitor's MediaDevice calls to RemovableStorage. Functional ↵thestig@chromium.org2012-08-261-2/+2
| | | | | | | | changes to follow in future CLs. Review URL: https://chromiumcodereview.appspot.com/10873072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153428 0039d316-1c4b-4281-b951-d872f2087c98
* SystemMonitor: Pull device type into the device idvandebo@chromium.org2012-08-211-2/+1
| | | | | | | | | | | Add a utility class to create an split device ids as well as to get some information about devices. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/10829384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TraceEventTestFixture flakinessjbates@chromium.org2012-08-161-1/+2
| | | | | | | | | BUG=142804 Review URL: https://chromiumcodereview.appspot.com/10828326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151851 0039d316-1c4b-4281-b951-d872f2087c98
* Change the type of file_type parameter to int, as the parameter actually ↵haruki@chromium.org2012-08-121-3/+2
| | | | | | | | | | | | | takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/10855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some clang errors on Android.nileshagrawal@chromium.org2012-08-011-0/+3
| | | | | | | | | BUG= Review URL: https://chromiumcodereview.appspot.com/10843029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149498 0039d316-1c4b-4281-b951-d872f2087c98
* add device type as an argument in OnDevicesChanged.wjia@chromium.org2012-07-311-1/+2
| | | | | | | | | This allows DevicesChangedObserver to listen to desired events, instead of being woken up by change of uninterested devices. BUG=137799 Review URL: https://chromiumcodereview.appspot.com/10836004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149103 0039d316-1c4b-4281-b951-d872f2087c98
* Correct const accessors in base/values.(h|cc)vabr@chromium.org2012-07-272-5/+4
| | | | | | | | | | | | | For problem description and other info please see the BUG page. This is for DictionaryValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar scottbyer achuith agl mnissler davemoore garykac akalin hans bulach phajdan.jr jamesr Review URL: https://chromiumcodereview.appspot.com/10834004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148833 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old test timeout and process waiting function interfaces.tedvessenes@gmail.com2012-07-261-27/+0
| | | | | | | | | BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10808069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148656 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144488 - For unit tests, track additions to AtExitManager and warn.scottbyer@chromium.org2012-07-254-75/+4
| | | | | | | | | | | | | | | | | | | While trying to bullet proof a unit test, I had trouble getting very far when running all tests in shuffle mode. Tracked that back to a few other tests doing stuff that accessed Singleton()s outside of a test-scoped ShadowingAtExitManager. Seemed to me that should be an invariant around any unit test, so created this towards that end, hopefully helping stabilize out unit_tests a bit more. BUG=133403 Review URL: https://chromiumcodereview.appspot.com/10582012 TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148405 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MessagePumpForUI with MessagePumpDefault in unit tests.rohitrao@chromium.org2012-07-253-0/+46
| | | | | | | | | | | | | | | | Uses the MessagePumpFactory functionality to install a default message pump in unit tests. This allows us to stop hard-coding a default message pump in many separate tests and instead centralizes the logic. When tests ask for a MessageLoopForUI now, they will actually receive a message loop that is backed by a default message pump, which means that calling Run() and Quit() will work without crashing. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10701172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148384 0039d316-1c4b-4281-b951-d872f2087c98
* Change base::SystemMonitor's media device functions to take a type and ↵thestig@chromium.org2012-07-212-11/+7
| | | | | | | | | | | FilePath::StringType instead of a FilePath. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10780023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147758 0039d316-1c4b-4281-b951-d872f2087c98
* Make it possible to run gtests on iOS.leng@chromium.org2012-07-138-4/+209
| | | | | | | | | | | | | | | Adds MainHook object to run_all_unittests main() and run_all_perftest main(), so tests run without beng killed by the OS. (If an application does not check in within a certain amount of time after launch, it will be killed.) The object is empty for non-iOS. Adds test_listener_ios to test_suite, which registers to be notified on test end. At test end, it runs the run loop to prevent the test run from being killed by the OS. Disables two tests for iOS: BooleanOperators and StringPattern. BUG=b/6753976 TEST=None Review URL: https://chromiumcodereview.appspot.com/10690161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146542 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-1113-13/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Get base_unittests closer to compiling for iOSstuartmorgan@chromium.org2012-07-111-2/+4
| | | | | | | | | | | | | MessageLoop still needs to be brought on line in order for this to link, but it's much closer to working. TBR= BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10700158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146119 0039d316-1c4b-4281-b951-d872f2087c98
* Add base::RunLoop and update ui_test_utils to use it to reduce flakinessjbates@chromium.org2012-06-281-0/+1
| | | | | | | | | | | | | | Timeout flakiness has been observed in multiple tests that use Quit. This changes various test utility APIs to use QuitNow via base::RunLoop instead. Some instances of Quit are left as-is where it appears they may have a use case. The ui_test_utils QuitThisRunLoop function does a safer form of MessageLoop::QuitWhenIdle that allows a few generations of tasks to run before actually quitting the MessageLoop. This addresses the design assumptions of many existing tests while hopefully reducing flaky timeouts by moving away from QuitWhenIdle. This fixes throughput_tests.cc which is currently timing out on Mac. BUG=124906,130141,131220,128305,132932 Review URL: https://chromiumcodereview.appspot.com/10479018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144824 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ANDROID_APK_TEST_TARGETnileshagrawal@chromium.org2012-06-282-10/+2
| | | | | | | | | | | | It is always true now and can be replaced with OS_ANDROID. BUG=125059 TEST= Review URL: https://chromiumcodereview.appspot.com/10690019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144775 0039d316-1c4b-4281-b951-d872f2087c98
* For unit tests, track additions to AtExitManager and warn.scottbyer@chromium.org2012-06-274-4/+75
| | | | | | | | | | | | | | | | While trying to bullet proof a unit test, I had trouble getting very far when running all tests in shuffle mode. Tracked that back to a few other tests doing stuff that accessed Singleton()s outside of a test-scoped ShadowingAtExitManager. Seemed to me that should be an invariant around any unit test, so created this towards that end, hopefully helping stabilize out unit_tests a bit more. BUG=133403 Review URL: https://chromiumcodereview.appspot.com/10582012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144488 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 22:34:59 +0000