summaryrefslogtreecommitdiffstats
path: root/base/test
Commit message (Collapse)AuthorAgeFilesLines
* Use the IAttachmentExecute service to set the Zone.Identifier stream,joaodasilva@chromium.org2011-04-291-13/+16
| | | | | | | | | | | | | | | | | when available. This is used to mark files as untrusted, because they were downloaded from the internet. The DownloadTest.CheckInternetZone browser test was failing previously because the Zone.Identifier stream created by the IAttachmentExecute service uses \r\n for newlines, and the test was checking for \n. See also http://codereview.chromium.org/590001, which this should close. BUG=5719 TEST=DownloadTest.CheckInternetZone Review URL: http://codereview.chromium.org/6880236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83502 0039d316-1c4b-4281-b951-d872f2087c98
* Move crypto files out of base, to a top level directory.rvargas@google.com2011-04-141-9/+0
| | | | | | | | | | | | | src/crypto is now an independent project that contains our cryptographic primitives (except md5 and sha1). This removes the base dependency from nss, openssl and sqlite. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6805019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81611 0039d316-1c4b-4281-b951-d872f2087c98
* Removing command_execution_timeout_ms in favor of action_max_timeout_ms.hnguyen@chromium.org2011-04-114-19/+5
| | | | | | | R=jcivelli@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,nirnimesh@chromium.org Review URL: http://codereview.chromium.org/6685099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81164 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS for base/testphajdan.jr@chromium.org2011-03-211-0/+1
| | | | | | | | R=brettw@chromium.org Review URL: http://codereview.chromium.org/6713077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78899 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove some simple uses of FromWStringHackevan@chromium.org2011-03-153-0/+7
| | | | | | | | BUG=76112 Review URL: http://codereview.chromium.org/6695008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78247 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: allow converting FilePath to wstring in testsevan@chromium.org2011-03-033-0/+16
| | | | | | | | | | | | Many of our tests want to use Unicode literal strings with the L"foobar" syntax. Allow us to test FilePaths against these strings. BUG=69467 Review URL: http://codereview.chromium.org/6606025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76763 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gtest 492:539 and gmock 300:358thakis@chromium.org2011-02-241-0/+3
| | | | | | | | | | | | | | | | | | | | Skimming their changelogs, it looks like this range contains only minor tweaks for the most part. gtest r500 is interesting: http://code.google.com/p/googletest/source/detail?spec=svn500&r=500 "Modifies handling of C++ exceptions in death tests to treat exceptions escaping them as failures." This confuses to death tests in message_loop_unittest on Windows, MessageLoopTest::Crasher and MessageLoopTest::CrasherNasty. These two tests set the global SEH handler. gtest now uses a frame-level exception handler, which overrides this global handler. Hence, disable gtest's new death test behavior for base_unittests on windows. This is to prepare a gmock roll to 359, which should improve build speed on mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/6580010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Downloads Windows Zone identifier test.rdsmith@chromium.org2011-02-232-34/+23
| | | | | | | | | | | Changes the setting of the Zone Identifier to not include an unnecessary trailing null byte, modifies the test to check for any of a range of options known to be acceptable to Windows, and makes explicit the restriction the utility test function works under. BUG=20809 TEST=Test run on windows and successful try bot run (with test enabled). Review URL: http://codereview.chromium.org/6541003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75762 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Prefetch the browser with a longer timeout before running browser tests.phajdan.jr@chromium.org2011-02-111-1/+1
| | | | | | | | | | | | Also remove hacky code to increase timeout for specific tests. Instead, allow to increase test termination timeout via SLOW_ prefix (should be used as last resort). BUG=none TEST=none Review URL: http://codereview.chromium.org/6410059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74649 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup base & app unit test MockCrApp NSApp initialization.msw@chromium.org2011-02-031-0/+9
| | | | | | | | | | | | | | Provide chrome unit test CrApplication NSApp initialization. Chrome requires a legitimate message loop for its unit tests. Ensure that init occurs before the base class MockCrApp init. BUG=71686 TEST=Run all base/app/chrome unit tests on Mac; try bug repro Review URL: http://codereview.chromium.org/6349058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73581 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-4/+6
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-6/+4
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-4/+6
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-091-3/+3
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-071-3/+3
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-071-3/+3
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-6/+4
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-4/+6
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Increasing live (sync) operation timeout to 45 seconds.rsimha@chromium.org2011-01-041-1/+1
| | | | | | | | | | | | | | | | | The sync integration tests were using a timeout of 30 seconds for live operations. Some of the sync stress tests are timing out because it takes longer for a full sync cycle to complete. This patch increases the timeout to 45 seconds, and should eliminate the occasional failures on the builders. TBR=tim@chromium.org BUG=68207 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6023011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70451 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/debug_on_start to base/debugger and rename it to be _win since itbrettw@chromium.org2011-01-011-2/+2
| | | | | | | | | | only does anything on Windows. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5984007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70362 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/debug_util. Move the debug UI related functions to ↵brettw@google.com2011-01-011-3/+1
| | | | | | | | | | | | base/debug/debugger.h Move the OS X specific crash report changing function to base/mac/os_crash_dumps TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6092005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70358 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/platform_thread.h stub and fix up all callers to use the new ↵brettw@google.com2011-01-011-3/+3
| | | | | | | | | location and namespace. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70346 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CrApplication dependency from basethakis@chromium.org2010-12-182-0/+47
| | | | | | | | | | | | | | | | | Add a @protocol CrAppProtocol that clients of base must implement in their NSApplication subclass, and let base depend only on this protocol. Let MessagePumpNSApplication::DoRun() no longer initialize NSApplication (fixes a TODO). Add a MockCrApplication that the simple unittests in base and app can use, move chrome_application to chrome/common. Test shell might run nested run loops, so I gave it a real but simplified CrAppProtocol implementation. BUG=62968,46929 TEST=Everything still works. The PDF plugin prints one fewer warning when loaded. Review URL: http://codereview.chromium.org/5950003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69615 0039d316-1c4b-4281-b951-d872f2087c98
* Separate BufferedDataSource and BufferedResourceLoader into two files.annacc@chromium.org2010-12-164-1/+11
| | | | | | | | | | | | | | | It's time to finally separate the huge monster files buffered_data_source.[h/cc] into two. ericroman: There are some variables and short methods that both BufferedDataSource and BufferedResourceLoader rely on and that I have moved to src/net/http/http_util.h. Could you please verify that this is an ok place to put them? Also, appcache issues have been resolved (and approved by michaeln) so I've removed those comments. BUG=None. TEST=Compiles. Review URL: http://codereview.chromium.org/5756004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69429 0039d316-1c4b-4281-b951-d872f2087c98
* Initial conversion of download unit test to browser test with enhancedrdsmith@google.com2010-11-242-0/+66
| | | | | | | | | | | download completion detection (DownloadsObserver). BUG=None TEST=browser_tests --gtest_filter=DownloadTest.DownloadMimeType Review URL: http://codereview.chromium.org/4658001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67279 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-262-3/+5
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_nsdisable_screen_update from base to app/macbrettw@chromium.org2010-10-181-2/+2
| | | | | | | | | | | Move scoped_aedesc from base to base/mac Use namespace and proper Google-style class naming. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3828009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-161-2/+2
| | | | | | | | | | | | | | | | base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
* seccomp: disable seccomp for RendererMainTestevan@chromium.org2010-10-151-2/+4
| | | | | | | | | | | | This test *could* work, but it requires refactoring as outlined in the bug. BUG=59376 TEST=test works with seccomp enabled at compile-time Review URL: http://codereview.chromium.org/3797010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62775 0039d316-1c4b-4281-b951-d872f2087c98
* Move PerfTestSuite implementation into a .cc file and add it to the basebrettw@chromium.org2010-10-103-37/+55
| | | | | | | | | | namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3695001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62095 0039d316-1c4b-4281-b951-d872f2087c98
* Move TestTimeouts from chrome/test to base/test.sergeyu@chromium.org2010-10-055-0/+197
| | | | | | | | | BUG=None TEST=unittests Review URL: http://codereview.chromium.org/3544008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61540 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land part of r55416, minus actually moving the test_suite.h contents to a ↵brettw@chromium.org2010-08-176-140/+337
| | | | | | | | | | | | | | | | | | | | | | | .cc file. Cleanup in base. This moves the implementation (and a bunch of header file dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56399 0039d316-1c4b-4281-b951-d872f2087c98
* Remove test isolation enforcement code.phajdan.jr@chromium.org2010-08-162-29/+1
| | | | | | | | | | | | | | | | | | | I think it was a failed experiment, and it only ever worked for base_unittests. This removes some potentially risky code from LazyInstance that was only needed for the test isolation. The lesson from this experiment is that removing singletons works better than trying to make tests work fine even when singletons are overused. TEST=none BUG=12710 Review URL: http://codereview.chromium.org/3127012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56229 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out the constructor and Run from test_suite.cc. This is an isolatedbrettw@chromium.org2010-08-162-52/+81
| | | | | | | | | | part of r55416 to test that the files that use test_suite have the proper project dependencies. TEST=everything compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56182 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded #includes of <string> and <vector> from src/app and ↵viettrungluu@chromium.org2010-08-141-3/+1
| | | | | | | | | | | src/base. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3173020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56144 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55400 - Cleanup in base. This moves the implementation (and a bunch ↵nsylvain@chromium.org2010-08-098-500/+245
| | | | | | | | | | | | | | | | | | | | | | | | of header file dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/3035062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55416 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in base. This moves the implementation (and a bunch of header filebrettw@chromium.org2010-08-098-245/+500
| | | | | | | | | | | | | | | | | | | dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55400 0039d316-1c4b-4281-b951-d872f2087c98
* rid of more OS_LINUX defines, to help the BSD port (work by sprewell & I)pvalchev@google.com2010-08-061-3/+3
| | | | | | Review URL: http://codereview.chromium.org/2089010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55289 0039d316-1c4b-4281-b951-d872f2087c98
* De-wstringify perf_test_suite.h and test_suite.h.evan@chromium.org2010-08-032-14/+8
| | | | | | Review URL: http://codereview.chromium.org/3007029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54812 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-263-0/+3
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome from statically enabling high resolution timers on windowsmbelshe@chromium.org2010-06-291-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | to enabling them dynamically - only when the application really needs them. I am working on some test cases for this, and will add them. But wanted to send out the concept for review. In this implementation, I modify the message loop to detect when the application has requested high resolution timers. Note that there are multiple MessageLoops active in a single process. After a period of time, we simply shut it off again. We could have set a timer or kept a count of active timers, or any number of more complex algorithms. But I think this algorithm is very simple and good enough. If an application continues needing high resolution timers for more than 1s, we'll turn the high-resolution timers back on again. One last change - since we've implemented the clamp at 4ms, there isn't a lot of point to our use of 1ms for timeBeginPeriod. I've modified that to 2 (which is half of 4ms, our target minimal interval). BUG=46531 TEST=MessageLoop.HighResolutionTimers Review URL: http://codereview.chromium.org/2822035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51102 0039d316-1c4b-4281-b951-d872f2087c98
* Make gtest report an error if there are tests marked as "MAYBE"glider@chromium.org2010-06-111-0/+25
| | | | | | Review URL: http://codereview.chromium.org/2762016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49526 0039d316-1c4b-4281-b951-d872f2087c98
* Record out-of-proc-tests' FAILS/FLAKY failures in the XML output.kinuko@chromium.org2010-06-031-0/+6
| | | | | | | | | BUG=40473 TEST=Run browser_tests and see if failed FAILS_ or FLAKY_ tests are recorded in its XML output. Also make sure that failures of FAILS/FLAKY tests don't make the browser_tests exit with non-zero return value. Review URL: http://codereview.chromium.org/2431003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48873 0039d316-1c4b-4281-b951-d872f2087c98
* [TTF] [GTTF] Implement the FAILS_ prefix for tests.phajdan.jr@chromium.org2010-05-121-13/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | After this change, the meaning of the prefixes is as follows: - DISABLED_: the test is not run unless --gtest_also_run_disabled_tests flag is used; should be used for tests that crash or exceed the time limit - FLAKY_: for tests that behave intermittently, and don't crash nor time out - FAILS_: for tests that fail consistently, but don't crash nor time out The Testing Task Force aims to run as much tests as possible, to keep the coverage high. The Green Tree Task Force aims to fix the flaky tests because they are unpredictable. To satisfy both goals, we should differentiate between the two cases, and that's why we have both the FLAKY_ and FAILS_ prefixes. When a test crashes or exceeds time limit (even intermittently), we have no choice other than disable it, and that's why we have DISABLED_ (and it's built-in the gtest framework anyway). TEST=none BUG=none Review URL: http://codereview.chromium.org/2015013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47011 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up suppressing error dialogs for buildbots.phajdan.jr@chromium.org2010-05-041-12/+5
| | | | | | | | | | | | - also suppress dialogs caused by __debugbreak on Windows - avoid bad interactions with gtest (they cause odd problems, really) TEST=none BUG=29997 Review URL: http://codereview.chromium.org/1867001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46343 0039d316-1c4b-4281-b951-d872f2087c98
* Switch base to using CHECK_*.willchan@chromium.org2010-03-021-2/+2
| | | | | | Review URL: http://codereview.chromium.org/660357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40394 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use xmessage for the dialog used in LOG(FATAL)evan@chromium.org2010-03-011-10/+7
| | | | | | | | | | | | The previous code printed to stderr, but since the logging code already had logged to stderr we'd end up printing the message twice, which was making me nervous. BUG=29997,31243,37026 Review URL: http://codereview.chromium.org/660269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40271 0039d316-1c4b-4281-b951-d872f2087c98
* Use the USE_NSS macro to help porting to FreeBSD, OpenBSD, etc.wtc@chromium.org2010-01-281-2/+2
| | | | | | | | | | | Fix cpplint nits. R=evan,pvalchev BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/558008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37358 0039d316-1c4b-4281-b951-d872f2087c98