| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is step 1 -- refactor the code to allow us to split up trace_event.h into trace_event.h and trace_event_export.h/cc.
Step 2 is to cut out trace_event_export.h/cc.
The _export.h/cc will be laid out so they can be copied to other third_party libraries and then tweaked to call through to chromium's internal tracing API via platform APIs or function pointers.
To make these APIs easily exportable, this change primarily aims to eliminate the custom objects (ie: TraceValue) and types that will cause problems when defined in multiple libraries. The macros and internal namespace are destined for trace_event_export.h/cc in a future CL.
BUG=109779
Review URL: http://codereview.chromium.org/9155024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9187015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=phajdan.jr@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9057001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/8952022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object directly."
This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.
Also makes the static type checking a bit more strict when assigning into a Callback<>.
BUG=none
TEST=new unittests
Review URL: http://codereview.chromium.org/8915024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the following:-
1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed
as there is an Atlmodule instance instantiated by the content code.
2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow
test instances to control whether an AtExitManager instance is created for the duration of the
test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435
BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8907054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8900001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object directly.
This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.
BUG=none
TEST=new unittests
Review URL: http://codereview.chromium.org/8738001
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8914022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.
BUG=none
TEST=new unittests
Review URL: http://codereview.chromium.org/8738001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IE versions 8 and below. Changes include the following:-
1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed
as there is a module instance instantiated by the content code.
2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager
instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also
instantiates an AtExitManager instance.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435
BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8898026
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/8937020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the following:-
1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed
as there is a module instance instantiated by the content code.
2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager
instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also
instantiates an AtExitManager instance.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435
BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8898026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.
Review URL: http://codereview.chromium.org/8894007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This initialization must have been implicit with gtk. On ChromeOS we go down a different code path for these tests.
TBR=phajdan.jr@chromium.org
BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.
Review URL: http://codereview.chromium.org/8889002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull the CrAppProtocol autorelease-pool handling down into
MessagePumpCrApplication, which is selected at Create() if NSApp
implements the right protocol. UsingCrApp() allows clients to
confirm the correct setup (unfortunately, synchronizing NSApp
initialization and MessagePump::Create() would be intrusive).
Also push CrAppProtocol and CrAppControlProtocol implementation into
BrowserCrApplication, and reparent that class from NSApplication.
Reparent ServiceCrApplication on NSApplication and rename.
Remove CrApplication registration from gpu, plugin, and renderer
mains.
Remove MockCrApp dependency from remoting sample code.
BUG=102224
Review URL: http://codereview.chromium.org/8771028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8682027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=100131
Review URL: http://codereview.chromium.org/8590015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also merge content/ MockCrControlApp into base/ MockCrApp.
Also use MockCrApp in test_shell_tests, and slight tweak to autorelease pool in test_shell's initialization.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/mac.
Also merge content/ MockCrControlApp into base/ MockCrApp.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/8762020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8678035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also merge content/ MockCrControlApp into base/ MockCrApp.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8696001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Increases the ASAN timeout multiplier in an attempt to avoid timeout errors in OutOfProcessPPAPITest.* test when running under ASAN.
BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/8618014
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Increases the ASAN timeout multiplier in an attempt to avoid timeout errors in OutOfProcessPPAPITest.* test when running under ASAN.
BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/8618014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was split out of http://codereview.chromium.org/8588067/.
BUG=none
TEST=none, but this does make testing easier.
Review URL: http://codereview.chromium.org/8561031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybot compile
Review URL: http://codereview.chromium.org/8572034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8520018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I've preferred using kTimeoutMultiplier only once to duplicating it for each timeout.
This however makes InitializeTimeout(0, 0, &value) non-unipotent.
BUG=103371
Review URL: http://codereview.chromium.org/8510053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also provide appropriate test support, which will allow content/
clients of ScopedSendingEvent to participate.
BUG=102224
Review URL: http://codereview.chromium.org/8432014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux CPU profiles indicate that at least 2.7% of CPU usage is spent in glib atomic operations. This used to be necessary in the browser process due to loading plugins which may invoke gtk/glib. Plugin loading has been moved out of process now, so this should no longer be necessary. I also removed dbus_g_thread_init() which *should* be safe too, although it's possible that we have unknown dbus-glib use off the UI thread.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8474012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8438058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As requested in another review (http://codereview.chromium.org/8427031/diff/1009/content/renderer/media/webrtc_audio_device_unittest.cc#newcode132).
so that it can be reused in content tests.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/8438034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup while I was doing this.
-got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo
-got rid of the duplicated code to initialize the broker
-since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs.
BUG=98716
Review URL: http://codereview.chromium.org/8414020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7981004/
BUG=95714
TEST=base_unittests
Review URL: http://codereview.chromium.org/8418044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it easy to search through trace data.
This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code.
BUG=95714
TEST=base_unittests
Review URL: http://codereview.chromium.org/7981004
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/8413063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/8400079
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/8400081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/8400079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
search through trace data.
This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code.
BUG=95714
TEST=base_unittests
Review URL: http://codereview.chromium.org/7981004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
[ Reland of 107042 http://codereview.chromium.org/8368009 ]
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8341026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
statements in base.
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8351025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8086004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure.
Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7879006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of action_max_timeout_ms.
This increases action_timeout_ms a little bit,
otherwise test_server becomes more flaky (fails to start in time).
This effectively reduces the timeout for TestServer start from 45s to 10s.
BUG=93770
Review URL: http://codereview.chromium.org/7744004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split from CL 7134019.
brettw: base.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7740081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This confuses a few unit tests, so add some machinery to disable the feature in tests and do so in the tests that need it.
BUG=61140,575
TEST=Go to en.wikipedia.org, hit space. Scroll should be animated.
Review URL: http://codereview.chromium.org/7693019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to choose the right timeout.
BUG=none
Review URL: http://codereview.chromium.org/7744031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/7743006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the test helper class TempRegKeyOverride since I need to do something
similar in some new RLZ tests, and I don't want to duplicate the code. Please
suggest a better namespace name if needed, I was just following the same
pattern found in test_file_util in the same directory.
BUG=None
TEST=No new tests, just refactoring test helpers
Review URL: http://codereview.chromium.org/7669061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will help choosing the right timeouts
and avoid many confusions.
BUG=none
Review URL: http://codereview.chromium.org/7712013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enum types should be named using CamelCase as class and function names,
not using MACRO_STYLE.
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7618037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96766 0039d316-1c4b-4281-b951-d872f2087c98
|