summaryrefslogtreecommitdiffstats
path: root/base/test
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup in base/test/launcher: move more code to anonymous namespacePaweł Hajdan, Jr2014-09-032-141/+131
| | | | | | | | | BUG=none R=machenbach@chromium.org Review URL: https://codereview.chromium.org/531003002 Cr-Commit-Position: refs/heads/master@{#293108}
* Force-enable the software keyboard when running tests in iOS simulator.lliabraa2014-09-021-0/+20
| | | | | | | | | | | | | Xcode 6 introduced behavior in the iOS Simulator where the software keyboard does not appear if a hardware keyboard is connected. This CL enables the software keyboard when a gtest app starts up. BUG=392433 Review URL: https://codereview.chromium.org/514223002 Cr-Commit-Position: refs/heads/master@{#292916}
* Fix out-of-bounds read in RegistryOverrideManager.grt2014-08-291-1/+2
| | | | | | | | | | | | This fixes a class of test flakes that impacts all Windows tests that use registry_util::RegistryOverrideManager. BUG=none R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/519773002 Cr-Commit-Position: refs/heads/master@{#292665}
* Add ChannelProxy benchmark to ipc_perftests.morrita2014-08-293-0/+126
| | | | | | | | | | | | | | | | This CL add a ChannelProxy equivalent of the Channel benchmark to ipc_perftests. To use it in the benchmark, TestIOThread is extracted from mojo/system/ to base/test TEST=IPChannelPerfTest.ChannelProxyPingPong R=viettrungluu@chromium.org,brettw@chromium.org,darin@chromium.org BUG=none Review URL: https://codereview.chromium.org/488003003 Cr-Commit-Position: refs/heads/master@{#292518}
* Manual fixups for scoped_refptr operator T* removal in base/dcheng2014-08-282-2/+4
| | | | | | | | BUG=110610 Review URL: https://codereview.chromium.org/511153002 Cr-Commit-Position: refs/heads/master@{#292429}
* Adding tracing and gtest pretty printing support to TestPendingTask.mithro2014-08-283-1/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | These functions where invaluable when trying to debug and fix the cc::OrderedTestRunner as they let me easily inspect the tasks without having to fire up GDB. They should also be useful in development / testing of other task runners. Added a very simple test for ShouldRunBefore which shows this stuff working. If that test fails, the output looks like the following; ------------------------------------------------------------------------------- ../../base/test/test_pending_task_unittest.cc:49: Failure Value of: task_after.ShouldRunBefore(task_first) Actual: false Expected: true TestPendingTask( {"delay":2000,"nestability":"NESTABLE","post_time":0, "posting_function":"Unknown@Unknown:-1","run_at":2000} ).ShouldRunBefore(TestPendingTask( {"delay":1000,"nestability":"NESTABLE","post_time":0, "posting_function":"Unknown@Unknown:-1","run_at":1000}) ) ------------------------------------------------------------------------------- BUG=380889 Review URL: https://codereview.chromium.org/491743002 Cr-Commit-Position: refs/heads/master@{#292370}
* Revert of Initialize the now_funciton to the HighResNowWrapper in case High ↵fmeawad2014-08-281-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Res is supported (patchset #7 of https://codereview.chromium.org/446203002/) Reason for revert: It causes a Canary crash https://code.google.com/p/chromium/issues/detail?id=408354 The added static initializer causes a crash in libpeerconnetion used by WebRTC Fix to reland: remove static initializer. Original issue's description: > We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots > https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928 > > It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC). > This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper. > > By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize. > > BUG=158234 > > Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430 TBR=jar@chromium.org,willchan@chromium.org,maruel@chromium.org,thakis@chromium.org,jam@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=158234 Review URL: https://codereview.chromium.org/516693002 Cr-Commit-Position: refs/heads/master@{#292288}
* We have noticed a clock shift when QPC was deployed. It shows as a ↵fmeawad2014-08-261-1/+0
| | | | | | | | | | | | | | | | | regression on the perf bots https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928 It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC). This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper. By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize. BUG=158234 Review URL: https://codereview.chromium.org/446203002 Cr-Commit-Position: refs/heads/master@{#291974}
* Revert of Implement unit test specific test launcher timeout (patchset #6 of ↵phajdan.jr2014-08-255-21/+6
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/476543004/) Reason for revert: Multiple tests are timing out on dbg bots. Original issue's description: > Implement unit test specific test launcher timeout > > BUG=402213 TBR=jam@chromium.org,dalecurtis@chromium.org,rileya@chromium.org NOTREECHECKS=true NOTRY=true BUG=402213 Review URL: https://codereview.chromium.org/504813003 Cr-Commit-Position: refs/heads/master@{#291682}
* Implement unit test specific test launcher timeoutPaweł Hajdan, Jr2014-08-255-6/+21
| | | | | | | | | BUG=402213 R=dalecurtis@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/476543004 Cr-Commit-Position: refs/heads/master@{#291673}
* Support --wait-for-debugger in tests.vitalybuka@chromium.org2014-08-221-0/+7
| | | | | | | Review URL: https://codereview.chromium.org/486193003 Cr-Commit-Position: refs/heads/master@{#291456} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291456 0039d316-1c4b-4281-b951-d872f2087c98
* Rework UMAHistogramHelper and StatisticsDeltaReader into ↵mlerman@chromium.org2014-08-217-125/+286
| | | | | | | | | | | | | | | [Chrome]HistogramTester. Design Doc (Googlers Only): https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit BUG=384011 TBR=timsteele@chromium.org Review URL: https://codereview.chromium.org/379283002 Cr-Commit-Position: refs/heads/master@{#291207} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98
* Remove large test timeout. It's large and only used at one place.phajdan.jr@chromium.org2014-08-204-16/+0
| | | | | | | | | | | | | | | It seems the last place where it was used is no longer needed. The special case was added in 2012 (https://chromiumcodereview.appspot.com/10890031) and if somehow we still need it now, I'd rather adjust action_max_timeout for android (in C++ sources) rather than have another kind of timeout. BUG=none R=ajwong@chromium.org, yfriedman@chromium.org Review URL: https://codereview.chromium.org/485173002 Cr-Commit-Position: refs/heads/master@{#290808} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290808 0039d316-1c4b-4281-b951-d872f2087c98
* Will no longer force jobs=1 with filters in bot mode.phoglund@chromium.org2014-08-181-10/+9
| | | | | | | | | | | | | The WebRTC bots happen to run with gtest filters, but want to run tests in parallel anyway. It makes sense for bot mode to disregard the gtest filter rule, which is a good heuristic in other cases. BUG=402089 Review URL: https://codereview.chromium.org/485733002 Cr-Commit-Position: refs/heads/master@{#290274} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290274 0039d316-1c4b-4281-b951-d872f2087c98
* Change gtest launcher, telemetry unittests to run in parallel and retry ↵dpranke@chromium.org2014-08-151-14/+8
| | | | | | | | | | | | | | | | | | | | | | failures by default. Previously, gtest-based tests would not run tests in parallel or retry failures by default unless you specified the --test-launcher-bot-mode flag This patch changes the behavior so that we run tests in parallel and retry failures by default if we are running *all* of the tests (i.e., --gtest_filter was *not* specified). You can still pass --test-launcher-jobs=X to control how many tests run in parallel, and --test-launcher-retry-limit=0 to turn retries off and --test-launcher-retry-limit=X to control how many times to retry. R=jam@chromium.org, phajdan.jr@chromium.org, ojan@chromium.org, tonyg@chromium.org BUG=402089 Review URL: https://codereview.chromium.org/469533002 Cr-Commit-Position: refs/heads/master@{#289839} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289839 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow breakaway from job on Windows 8, which supports nested jobsphajdan.jr@chromium.org2014-08-141-2/+7
| | | | | | | | | | BUG=371406, 392108 R=sky@chromium.org Review URL: https://codereview.chromium.org/467673002 Cr-Commit-Position: refs/heads/master@{#289523} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289523 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util to base/files/ directory.brettw@chromium.org2014-08-139-10/+10
| | | | | | | | | | | This updates the includes in base but leaves a forwarding header for the rest of the project for now. R=yzshen@chromium.org Review URL: https://codereview.chromium.org/468253002 Cr-Commit-Position: refs/heads/master@{#289360} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289360 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow breakaway from job for unit testsphajdan.jr@chromium.org2014-08-083-16/+30
| | | | | | | | | | BUG=328592, 371406 R=sky@chromium.org Review URL: https://codereview.chromium.org/441333002 Cr-Commit-Position: refs/heads/master@{#288305} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288305 0039d316-1c4b-4281-b951-d872f2087c98
* Fix how --gtest_filter interacts with PRE_ testsphajdan.jr@chromium.org2014-08-081-3/+3
| | | | | | | | | | BUG=371785 R=sky@chromium.org Review URL: https://codereview.chromium.org/445953002 Cr-Commit-Position: refs/heads/master@{#288298} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288298 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of test_file_util to base namespace.brettw@chromium.org2014-08-075-53/+32
| | | | | | | | R=rvargas@chromium.org Review URL: https://codereview.chromium.org/444163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288158 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring file path helpers from test_file_util.brettw@chromium.org2014-08-073-22/+0
| | | | | | | | | | | | These were only used by one test file, so I moved the implementation there. I considered updating the test, but the way the test uses wstrings seems reasonable. R=rvargas@chromium.org, rvargas Review URL: https://codereview.chromium.org/448763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288084 0039d316-1c4b-4281-b951-d872f2087c98
* Factored out duplicate code for formatting full test namesergiyb@chromium.org2014-08-053-4/+14
| | | | | | | | R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/418093004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287628 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tracing to pass around base::debug::TraceOptions to reduce spaghettinednguyen@google.com2014-08-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Previously, the options for tracing were passed around with different ad hoc systems. Strings in some places, base::debug::TraceOptions enum in others, and a content::TraceOptions in yet another. There were two separate ad-hoc string formats. Similar messes were present with category filters: sometimes we passed strings, sometimes the CategoryFilter. This patch though enormous looking simply consolidates all this ad-hockery into base::debug::TraceOptions. It may look like the call sites have gotten more verbose, but the end result of this is a consistent understanding of TraceOptions. There is one exception to this consolidation: devtools has to maintain its own mapping of string->TraceOptions encoding. This is because DevTools makes guarantees about backward compatibility: if base changes its mind about the string form of a TraceOption, devtools needs to keep supporting the old form. BUG=396081 TBR=cevans@chromium.org Review URL: https://codereview.chromium.org/425593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287348 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Configurable instrumentation test runner + test SDK levels.jbudorick@chromium.org2014-07-281-0/+19
| | | | | | | | | | | | | | | | | This patch: - extracts the instrumentation test runner from the AndroidManifest.xml file in the apk. - allows test authors to specify a minimum SDK level for instrumentation test classes via the MinAndroidSdkLevel annotation. - filters the list of instrumentation tests according to the sdk levels of all attached devices. - speeds up our proguard function by dumping to a temporary file. BUG= Review URL: https://codereview.chromium.org/415463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286014 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/data to base/test/data to be with the rest of the test data.jam@chromium.org2014-07-282-0/+0
| | | | | | | | R=brettw@chromium.org Review URL: https://codereview.chromium.org/421913008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285961 0039d316-1c4b-4281-b951-d872f2087c98
* MSan: increase the test timeout multiplier to 6x.earthdok@chromium.org2014-07-281-1/+3
| | | | | | | | | | BUG=178409 TBR=phajdan.jr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/424693005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285891 0039d316-1c4b-4281-b951-d872f2087c98
* android tests: don't override DIR_MODULE (take 2)tim@chromium.org2014-07-251-3/+0
| | | | | | | | | | | | | another attempt at https://codereview.chromium.org/408063002/ to try fixing the iOS Simulator:URLFixerTest failures writing to DIR_TEST_DATA. R=nyquist@chromium.org TBR=brettw@chromium.org, nyquist@chromium.org, sky@chromium.org BUG= Review URL: https://codereview.chromium.org/411253010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285451 0039d316-1c4b-4281-b951-d872f2087c98
* MSan: increase the test timeout multiplier to 4x.earthdok@chromium.org2014-07-241-1/+1
| | | | | | | | | | | | | A couple of browser tests still take too long when build with msan_track_origins > 0. BUG=178409 TBR=phajdan.jr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/413133005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285286 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of android tests: don't override DIR_MODULE ↵tim@chromium.org2014-07-241-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/408063002/) Reason for revert: Need to fix components_unittests on iOS simulator (try was green, but test actually failed) Original issue's description: > android tests: don't override DIR_MODULE > > BUG= > R=brettw@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org, sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285096 TBR=nyquist@chromium.org,brettw@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/417943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285157 0039d316-1c4b-4281-b951-d872f2087c98
* android tests: don't override DIR_MODULEtim@chromium.org2014-07-241-3/+0
| | | | | | | | | BUG= R=brettw@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/408063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285096 0039d316-1c4b-4281-b951-d872f2087c98
* clang/win: Fix most -Wwriteable-strings warnings.thakis@chromium.org2014-07-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | Many win32 APIs take non-const string pointers. I checked that MSDN documents them as _In_ and says that they are inputs, and then added const_cast<>s at the calling sites. (In one test, I introduced a helper struct so that there can be fewer casts.) This wasn't just busywork, I found one function that we were handing string literals where the documentation explicitly said that that's not valid (filed http://crbug.com/396705). I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print; it sounds like that'll fix itself when we update to the 2014 sdk: http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013 BUG=396705,82385 R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org Review URL: https://codereview.chromium.org/413763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98
* Bring back the retry limit to 3.jam@chromium.org2014-07-231-3/+1
| | | | | | | | | | | This reverts r284650. There is one test that is flaky 34% of the time, but that is the exception and not the norm. We don't need 12 retries to make browser_tests or other test suites not flaky. If there are very flaky tests, we should disable them instead. I've disabled all the tests that flake more than 5% of the time. BUG=395189 R=brettw@chromium.org, sergeyberezin@chromium.org Review URL: https://codereview.chromium.org/413733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285006 0039d316-1c4b-4281-b951-d872f2087c98
* Added an annotation to label Integration tests.yojan@google.com2014-07-231-0/+26
| | | | | | | | | | | | | An IntegrationTest label will be required for tests that may require a greater timeout value than LargeTest allows. These tests will run against real instances of other services (e.g. Search). They may use command-line flags to change the backends that are being tested against. BUG=None Review URL: https://codereview.chromium.org/407173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284821 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily increase retry limit in test_launchersergeyberezin@chromium.org2014-07-221-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | In bot mode, test_launcher would normally retry tests up to 3 times. This is sufficient to keep large test suites like browser_tests under 1% flakiness rate if the flakiness of individual tests is also within 1%. However, some tests especially in browser_tests are up to 33% flaky, making the browser_tests suite 40% flaky. Subsequent top-level retries effectively double the runtime of all bots running these tests, and we need a solution to shorten the try job runtime. A longer-term solution is the ignorer bot (see the bug), but until it's deployed, a quick hack is to increase the number of retries so statistically we should see about 1% flakiness of browser_tests at the expense of a slight runtime increase. R=sergiyb@chromium.org BUG=390600, 395189 Review URL: https://codereview.chromium.org/393283006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284650 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StackOverFlow in AdvancedMockContext.nyquist@chromium.org2014-07-181-0/+15
| | | | | | | | | | | | | | | | | | The AdvancedMockContext previously did not override registerComponentCallbacks and unregisterComponentCallbacks. The implementation of these methods in Context calls getApplicationContext before delegating the call to it, and since AdvancedMockContext returns |this| in getApplicationContext, this leads to a loop. This CL adds overrides for these two methods that make the calls to the base context instead, which will typically either be a MockContext or the target context being instrumented. BUG=394464 Review URL: https://codereview.chromium.org/404553005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284023 0039d316-1c4b-4281-b951-d872f2087c98
* [Android][gn] Add android resources templatescjhopman@chromium.org2014-07-161-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for android resources to gn. Two new templates are introduced: java_string_grd: This is like gyp's build/java_strings_grd.gypi. It runs grit and generates Android strings.xml files and then zips them together. android_resources: This is the target for android resources. It is mostly a wrapper around process_resources.py. This is *not part* of android_library (like it is in gyp). Making these two things separate is more like facebook's BUCK and google's internal build rules (and gyp's java.gypi and java_apk.gypi have gotten way too big and complicated). Changes to the actual build scripts are very minor except for the added support for andoid_resources to write_build_config.py. Building resources requires getting all the transitive resource dependencies, and so this reuses the simple sorted transitive dependency thing from write_ordered_libraries.py. TBR=rch@chromium.org BUG=359249 Review URL: https://codereview.chromium.org/361633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283293 0039d316-1c4b-4281-b951-d872f2087c98
* Move logging.h's definitions of operator<< into namespace std.jyasskin@chromium.org2014-07-081-3/+0
| | | | | | | | | | | See the bug for a more detailed discussion of the problem when we don't make this accessible through ADL. BUG=391117 Review URL: https://codereview.chromium.org/367063006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281864 0039d316-1c4b-4281-b951-d872f2087c98
* [Android]: Replace calls to getdtablesize with sysconf(_SC_OPEN_MAX) in tools.rmcilroy@chromium.org2014-06-281-1/+1
| | | | | | | | | | | | | | | The getdtablesize functions has been deprecated by Posix and has been removed from Android's LB64 ABI. Replace calls to it with the modern equivalent sysconf(_SC_OPEN_MAX). This fixes a build breakage in tryserver.blink/builders/android_blink_compile_rel/dbg. BUG=354405 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/349323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280533 0039d316-1c4b-4281-b951-d872f2087c98
* Removes bulach@ from OWNERS.bulach@chromium.org2014-06-271-1/+0
| | | | | | | | | | | May our paths cross again soon! BUG= TBR=jochen@chromium.org,thakis@chromium.org Review URL: https://codereview.chromium.org/343323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280313 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the test output line limit 50 -> 5000phajdan.jr@chromium.org2014-06-241-1/+1
| | | | | | | | | BUG=386566 R=sky@chromium.org Review URL: https://codereview.chromium.org/349343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279304 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the no-op reconcilor so that it doesn't "hang" after the first ↵mlerman@chromium.org2014-06-191-0/+4
| | | | | | | | | | | | | | | | execution, but instead successfully completes the reconciliation. Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test. Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag. BUG=357693 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277605 Review URL: https://codereview.chromium.org/309843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278223 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Improve the no-op reconcilor so that it doesn't "hang" after the ↵hirono@chromium.org2014-06-181-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | first execution, but instead successfully completes the reconciliation." (https://codereview.chromium.org/309843002/) The original CL causes crashes about 20 secs after launching the linux build of chromeos. This reverts commit 660a4d00c835a21b6972647df37e75f4e22f8d73. Conflicts: chrome/browser/signin/account_reconcilor_unittest.cc Original issue's description: > Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation. > Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test. > Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag. > > BUG=357693 > TBR=phajdan.jr@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277605 BUG=357693,386045 TEST=None TBR=mlerman@chromium.org Review URL: https://codereview.chromium.org/344513005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277990 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively increase test timeouts under MSan.earthdok@chromium.org2014-06-171-2/+4
| | | | | | | | | | | | | | Looks like a 2x multiplier might not be enough for browser_tests. Let's try 3x. We'll probably want to do the same for TSan once we start running browser_tests under TSan. BUG=178409 TBR=phajdan.jr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/344433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277751 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the no-op reconcilor so that it doesn't "hang" after the first ↵mlerman@chromium.org2014-06-171-0/+4
| | | | | | | | | | | | | | execution, but instead successfully completes the reconciliation. Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test. Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag. BUG=357693 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/309843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277605 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeouts under MSan.earthdok@chromium.org2014-06-161-2/+3
| | | | | | | | | | | | Do for MSan the same thing that we already do for ASan/TSan. BUG=178409 TBR=phajdan.jr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/337033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277426 0039d316-1c4b-4281-b951-d872f2087c98
* Update OS version functions.avi@chromium.org2014-06-121-1/+4
| | | | | | | | | | BUG=none TEST=covered R=asvitkine@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/325423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276752 0039d316-1c4b-4281-b951-d872f2087c98
* Mark test results with unknown status as unreliablephajdan.jr@chromium.org2014-06-113-25/+46
| | | | | | | | | | | | This takes into account test retries, and only looks at the final result. BUG=381733 R=sky@chromium.org Review URL: https://codereview.chromium.org/316903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276403 0039d316-1c4b-4281-b951-d872f2087c98
* Truncate huge output snippets in the test launcher before printing themphajdan.jr@chromium.org2014-06-111-1/+15
| | | | | | | | | | | | | | This avoids flooding the logs with lots of data that gums up the infrastructure. The summary contains the full snippet for debugging. BUG=382648 R=sky@chromium.org Review URL: https://codereview.chromium.org/324893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276335 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Revert of Convert installer_util_unittests, ↵alph@chromium.org2014-06-096-83/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/314173005/) Reason for revert: Looks like it was a flake. Original issue's description: > Revert of Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/315403006/) > > Reason for revert: > Broke a bunch of unit tests on Win. > http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19568 > > Original issue's description: > > Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to new test launcher > > > > Also add them to the Windows trybots > > > > BUG=381071 > > R=grt@chromium.org, rvargas@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275801 > > TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=381071 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275805 TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=381071 Review URL: https://codereview.chromium.org/327543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Convert installer_util_unittests, sbox_integration_tests, ↵alph@chromium.org2014-06-096-140/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/315403006/) Reason for revert: Broke a bunch of unit tests on Win. http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19568 Original issue's description: > Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to new test launcher > > Also add them to the Windows trybots > > BUG=381071 > R=grt@chromium.org, rvargas@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275801 TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=381071 Review URL: https://codereview.chromium.org/314173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275805 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-14 12:11:05 +0000