| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2825006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make loops use {} instead of a ';' to make it clear there is no body to the loop.
- Remove checks of unsigned values for <0
- coordinates should be CGFloat, not NSUInteger.
BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2865003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
License checker change:
Since most projects have a LICENSE file, look for that by default.
Since as far as I can tell NSS and NSPR are both just MPL tri-license without
a per project copyright, I think I will amend the license-checker to source
those licenses separately.
Review URL: http://codereview.chromium.org/1121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r24792.
TBR=estade
Review URL: http://codereview.chromium.org/179028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc
This should fix the gcc 4.4. strict aliasing issues. More info here:
http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html
Also update gcc_warnings.patch to match.
BUG=9104
Original change by Craig Schlenter via
http://codereview.chromium.org/99315
Review URL: http://codereview.chromium.org/99367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r15232.
Review URL: http://codereview.chromium.org/99366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix the gcc 4.4. strict aliasing issues. More info here:
http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html
Also update gcc_warnings.patch to match.
BUG=9104
Original change by Craig Schlenter <craig.schlenter@gmail.com> via
http://codereview.chromium.org/99315
Review URL: http://codereview.chromium.org/99364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/101005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We build dmg_fp as part of libbase, which mostly contains our own code. As
such, we want to build libbase with -Wall -Werror or equivalent. Since the
gyp model does not allow per-file compilation settings, we can't do this
without modifying dmg_fp or building it into its own library with its own
settings. The former seems less invasive.
The following gcc warnings are fixed by this patch:
- suggest parentheses around assignment used as truth value
- deprecated conversion from string constant to 'char*'
- comparison between signed and unsigned integer expressions
- label 'something' defined but not used
- 'whatever' may be used uninitialized in this function
Review URL: http://codereview.chromium.org/21093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
No code change.
B=4380
Review URL: http://codereview.chromium.org/19501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DoubleToString methods and only leave the
locale independent methods. It turns out this code is
only used in the json code and if people want locale
formatting, they should use ICU.
Review URL: http://codereview.chromium.org/11423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove third_party/dmg_fp complete since nothing else depends on it.
Review URL: http://codereview.chromium.org/10963
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
files directly in base.vcproj. Remove the old dmg_fp.vcproj file
and remove it from the *.sln files.
I've kept third_party/dmg_fp around for the mac and scons build
which I will fix up in follow up changes.
Review URL: http://codereview.chromium.org/10716
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5514 0039d316-1c4b-4281-b951-d872f2087c98
|