summaryrefslogtreecommitdiffstats
path: root/base/third_party
Commit message (Collapse)AuthorAgeFilesLines
* Copying the following files AS-IS from google.glog r141:ivanpe@google.com2014-03-054-173/+430
| | | | | | | | | | | | | | | | | - demangle.cc - demangle.h - symbolize.cc - symbolize.h The new functionality is a callback mechanism to allow users of google.glog to provide their own implementation of OpenObjectFileContainingPcAndGetStartAddress. BUG= Review URL: https://codereview.chromium.org/180163013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254996 0039d316-1c4b-4281-b951-d872f2087c98
* Moved SuperFastHash function from base/hash.cc to base/third_party.mgiuca@chromium.org2014-03-034-0/+142
| | | | | | | | | | | | | | | | | | | | This code was written by Paul Hsieh under a 3-clause BSD license. It belongs in third_party. I did not move the existing implementation, but re-downloaded the code from upstream: http://www.azillionmonkeys.com/qed/hash.html This version is formatted differently and is written in plain C, but it is identical to the version that was previously in hash.cc. Added LICENSE and README.chromium files, as well as adding license text to the top of superfasthash.cc, as required by checklicenses.py. BUG=347393 Review URL: https://codereview.chromium.org/181643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254437 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use_system_nspr build flag. It's not "officially" supportedrsleevi@chromium.org2014-02-151-41/+0
| | | | | | | | | | BUG=none R=wtc@chromium.org, phajdan.jr@chromium.org TBR=willchan Review URL: https://codereview.chromium.org/167693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251527 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GN single-item list concat to use lists.brettw@chromium.org2014-01-172-4/+4
| | | | | | | | R=scottmg@chromium.org, scottmg Review URL: https://codereview.chromium.org/138273007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245594 0039d316-1c4b-4281-b951-d872f2087c98
* Move base BUILD.gn files to main tree.brettw@chromium.org2014-01-025-0/+95
| | | | | | | | | | | This also removes thread_local_storage.cc which was removed from the .gyp file. R=viettrungluu@chromium.org TBR=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/119323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242810 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes in base for [P]NaCl port of remoting clientsergeyu@chromium.org2013-12-231-1/+1
| | | | | | | | | | | | | | | | | | | | | Various minor fixes in base needed for [P]NaCl port of remoting client: - added base_i18n_untrusted target - md5 is included in base_untrusted. - base/metrics is compiled in base_untrusted (src/net depends on it). - enabled PNaCl build of base_untrusted - __builtin_extract_return_addr() is not allowed in PNaCl (validator rejects it). - sys_byteorder.h now works in NaCl. BUG=276739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242270 R=brettw@chromium.org Review URL: https://codereview.chromium.org/116803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242347 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242270 "Fixes in base for [P]NaCl port of remoting client"thakis@chromium.org2013-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Somewhat speculative, to try and fix chromeos-chrome-34.0.1755.0_alpha-r1: armv7a-cros-linux-gnueabi-g++ -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.22-gold '-DV8_DEPRECATION_WARNINGS' '-D_FILE_OFFSET_BITS=64' '-DCHROMIUM_BUILD' '-DTOOLKIT_VIEWS=1' '-DUI_COMPOSITOR_IMAGE_TRANSPORT' '-DUSE_AURA=1' '-DUSE_ASH=1' '-DUSE_CAIRO=1' '-DUSE_CRAS=1' '-DUSE_GLIB=1' '-DUSE_DEFAULT_RENDER_THEME=1' '-DUSE_NSS=1' '-DUSE_X11=1' '-DOS_CHROMEOS=1' '-DUSE_XI2_MT=2' '-DFILE_MANAGER_EXTENSION=1' '-DIMAGE_LOADER_EXTENSION=1' '-DENABLE_REMOTING=1' '-DENABLE_WEBRTC=1' '-DENABLE_PEPPER_CDMS' '-DENABLE_CONFIGURATION_POLICY' '-DENABLE_INPUT_SPEECH' '-DENABLE_NOTIFICATIONS' '-DENABLE_HIDPI=1' '-DUSE_UDEV' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DENABLE_EGLIMAGE=1' '-DENABLE_TASK_MANAGER=1' '-DENABLE_EXTENSIONS=1' '-DENABLE_PLUGINS=1' '-DENABLE_SESSION_SERVICE=1' '-DENABLE_THEMES=1' '-DENABLE_AUTOFILL_DIALOG=1' '-DENABLE_BACKGROUND=1' '-DENABLE_AUTOMATION=1' '-DENABLE_GOOGLE_NOW=1' '-DCLD_VERSION=2' '-DENABLE_FULL_PRINTING=1' '-DENABLE_PRINTING=1' '-DENABLE_SPELLCHECK=1' '-DENABLE_CAPTIVE_PORTAL_DETECTION=1' '-DENABLE_APP_LIST=1' '-DENABLE_MANAGED_USERS=1' '-DENABLE_MDNS=1' '-DNET_IMPLEMENTATION' '-DENABLE_BUILT_IN_DNS' '-DU_USING_ICU_NAMESPACE=0' '-DU_STATIC_IMPLEMENTATION' '-D__STDC_CONSTANT_MACROS' '-D__STDC_FORMAT_MACROS' '-DNDEBUG' '-DNVALGRIND' '-DDYNAMIC_ANNOTATIONS_ENABLED=0' '-D_FORTIFY_SOURCE=2' -I. -Isdch/open-vcdiff/src -Ithird_party/icu/source/i18n -Ithird_party/icu/source/common -Ithird_party/zlib -Ic/Release/obj/gen/net -Inet/third_party/nss/ssl -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -pthread -I/build/daisy/usr/include/glib-2.0 -I/build/daisy/usr/lib/glib-2.0/include -I/build/daisy/usr/include/nss -I/build/daisy/usr/include/nspr -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=hard -mthumb --sysroot=/build/daisy/ -O2 -fno-ident -fdata-sections -ffunction-sections -g -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi -MMD -MF c/Release/.deps/c/Release/obj.target/net/net/quic/quic_crypto_stream.o.d.raw -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -c -o c/Release/obj.target/net/net/quic/quic_crypto_stream.o net/quic/quic_crypto_stream.cc chromeos-chrome-34.0.1755.0_alpha-r1: md5.cc: In function 'void base::MD5Final(base::MD5Digest*, char (*)[88])': chromeos-chrome-34.0.1755.0_alpha-r1: md5.cc:254:33: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] chromeos-chrome-34.0.1755.0_alpha-r1: ((uint32 *)ctx->in)[ 14 ] = ctx->bits[0]; chromeos-chrome-34.0.1755.0_alpha-r1: ^ chromeos-chrome-34.0.1755.0_alpha-r1: md5.cc:255:33: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] chromeos-chrome-34.0.1755.0_alpha-r1: ((uint32 *)ctx->in)[ 15 ] = ctx->bits[1]; chromeos-chrome-34.0.1755.0_alpha-r1: ^ on http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/15156/steps/BuildPackages/logs/stdio (We don't build with type-based alias analysis enabled, so the warning isn't all that helpful, but the bot is red none the less.) > Fixes in base for [P]NaCl port of remoting client > > Various minor fixes in base needed for [P]NaCl port of remoting client: > - added base_i18n_untrusted target > - md5 is included in base_untrusted. > - base/metrics is compiled in base_untrusted (src/net depends on it). > - enabled PNaCl build of base_untrusted > - __builtin_extract_return_addr() is not allowed in PNaCl (validator > rejects it). > - sys_byteorder.h now works in NaCl. > > BUG=276739 > > Review URL: https://codereview.chromium.org/116803005 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/120463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242276 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes in base for [P]NaCl port of remoting clientsergeyu@chromium.org2013-12-211-1/+1
| | | | | | | | | | | | | | | | | Various minor fixes in base needed for [P]NaCl port of remoting client: - added base_i18n_untrusted target - md5 is included in base_untrusted. - base/metrics is compiled in base_untrusted (src/net depends on it). - enabled PNaCl build of base_untrusted - __builtin_extract_return_addr() is not allowed in PNaCl (validator rejects it). - sys_byteorder.h now works in NaCl. BUG=276739 Review URL: https://codereview.chromium.org/116803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiler errors when using CBU16_{LEAD,TRAIL} from ↵rsesek@chromium.org2013-12-101-2/+5
| | | | | | | | | | | | | base/third_party/icu/icu_utf.h. These macros referenced type UChar which is not defined in base_icu. Define a type for it in the base_icu:: namespace. R=brettw@chromium.org Review URL: https://codereview.chromium.org/93973007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239652 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to get base compiling on VS2013scottmg@chromium.org2013-10-153-1/+25
| | | | | | | | | | | | | | - Missing includes of <algorithm> for std::min/std::max. - Update prep_libc.py for different obj path in runtime library. - Disable optimization in a couple files that currently fail in /O2. Upstream bugs filed that are supposedly fixed in the next release. R=thakis@chromium.org BUG=288948 Review URL: https://codereview.chromium.org/26885007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228754 0039d316-1c4b-4281-b951-d872f2087c98
* Merge google-glog r137.thakis@chromium.org2013-07-292-1/+4
| | | | | | | | | | | No behavior change, makes code compliant with C++11 user-defined literals. BUG=263960 R=mark@chromium.org Review URL: https://codereview.chromium.org/21044003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214211 0039d316-1c4b-4281-b951-d872f2087c98
* import x32 updates for nspr codevapier@chromium.org2013-02-061-0/+49
| | | | | | | | | | | This is taken from the upstream nspr code base to support x32. BUG=chromium-os:36866 TEST=compiled the code for x86_64 (64bit) & x86_64 (x32) Review URL: https://chromiumcodereview.appspot.com/12180007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181067 0039d316-1c4b-4281-b951-d872f2087c98
* add upstream nspr maintainers to the owners listvapier@chromium.org2013-02-051-0/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/12192026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180648 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make stack trace symbolization code recognize more symbols.phajdan.jr@chromium.org2013-01-251-22/+20
| | | | | | | | | | One example is __libc_start_main (easy to check), there may be more. BUG=none Review URL: https://codereview.chromium.org/12041109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178924 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling nacl_win64 targets when building in target_arch!=ia32 mode.bradnelson@google.com2013-01-211-1/+1
| | | | | | | | | | | | | | | | When building on windows with target_arch=x64, we no longer need win32 targets forced to be 64-bit. This gates out these targets when target_arch!=ia32. (Prior CL dropped the minimal set to break the dependency between these targets and the rest of the build. This eliminates them completely.) BUG=None TEST=None R=jschuh@chromium.org,thestig@chromium.org TBR=darin@chromium.org,abodenha@chromium.org,apatrick@chromium.org,sra@chromium.org,wtc@chromium.org Review URL: https://chromiumcodereview.appspot.com/11929039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177959 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add option to use system nspr.phajdan.jr@chromium.org2013-01-081-0/+41
| | | | | | | | | | Note that for NaCl bundles nspr files will be used anyway, since NaCl toolchain doesn't looks for libraries in system directories. BUG=none Review URL: https://codereview.chromium.org/11685002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175539 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes dtoa warning with VS2012cpu@chromium.org2012-10-123-1/+17
| | | | | | | | TEST=base compiles clean with vs2012 BUG=143646 Review URL: https://codereview.chromium.org/11117007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161638 0039d316-1c4b-4281-b951-d872f2087c98
* Update license tool to check several additional directoriessteveblock@chromium.org2012-08-091-0/+5
| | | | | | | | | | | | | | | | Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS. Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS. To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field. This will simplify the process of adding a tool to check license compatibility for the Android WebView build. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10830201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150800 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: update base/third_party/xdg_mime from upstream.thestig@chromium.org2012-08-0913-122/+294
| | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10824186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150696 0039d316-1c4b-4281-b951-d872f2087c98
* Fix license for valgrindsteveblock@chromium.org2012-08-062-10/+5
| | | | | | | | | | Make the LICENSE file more explicit about the fact that the headers used by Chromium use a BSD license. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10843032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix license for xdg_mimesteveblock@chromium.org2012-08-022-18/+174
| | | | | | | | | | | | | It looks like the existing MIT license was added incorrectly in http://codereview.chromium.org/1121003. The README file and source headers state that the correct license is Academic Free License version 2.0 or LGPL v2. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10843034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149709 0039d316-1c4b-4281-b951-d872f2087c98
* Make 'License' field in third-party metadata requiredsteveblock@chromium.org2012-08-015-0/+5
| | | | | | | | | | | | | | | | This will simplify the addition of a tool to check licenses for the purpose of the Android WebView build. See also http://codereview.chromium.org/10827099 Also adds other missing fields to these README.chromium files as required by presubmit checks and fixes a regex used to enforce this. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10821103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149423 0039d316-1c4b-4281-b951-d872f2087c98
* Update dynamic_annotations to r4384.glider@chromium.org2012-07-032-5/+18
| | | | | | | TBR=darin,timurrrr Review URL: https://chromiumcodereview.appspot.com/10696089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145281 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a crash in dtoa.tony@chromium.org2012-05-153-1/+16
| | | | | | | | | | | | This is a patch that FireFox has had for > 5 years. This is just a guess based on where the crash is happening. BUG=123157 TEST=Covered by exising unit tests. Review URL: https://chromiumcodereview.appspot.com/10332147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137020 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the fix for NSPR bug 689188.wtc@chromium.org2012-03-131-2/+3
| | | | | | | | | | | | | | Cast char to unsigned char before passing it to isalpha to prevent it from becoming a negative integer if char is a signed type. See https://bugzilla.mozilla.org/show_bug.cgi?id=689188. R=mark@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/9691017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126338 0039d316-1c4b-4281-b951-d872f2087c98
* Make more of base compile with the Native Client toolchain.bbudge@chromium.org2012-02-251-0/+2
| | | | | | | | | | | | This is needed to get parts of the PPAPI proxy to compile as untrusted code. Leaving base.gypi unchanged even though this adds files, as they are only used by experimental target. BUG=none TEST=none Review URL: http://codereview.chromium.org/9465017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123613 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all remaining explicit LeakyLazyInstanceTraits users to ::Leakyfischman@chromium.org2012-01-261-6/+4
| | | | | | | | | | | | | and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting new users. BUG=none TEST=none Review URL: http://codereview.chromium.org/9117038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-2/+2
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* add missing header dependencyensonic@google.com2011-11-081-1/+2
| | | | | | | | | | | R=tony BUG= TEST= Review URL: http://codereview.chromium.org/8200001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109055 0039d316-1c4b-4281-b951-d872f2087c98
* Change three LazyInstances I added earlier to be leaky.thakis@chromium.org2011-11-041-2/+6
| | | | | | | | | | | | | | | | Without this, they were still be cleaned up at exit, which is unnecessary and slow, and some threads might not even have an AtExitManager. With this, we leak 2 Locks and 1 ThreadLocalBoolean at exit. BUG=101600 TEST=none Review URL: http://codereview.chromium.org/8450015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108605 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 2 exit time destructors and 2 static initializers.thakis@chromium.org2011-11-031-7/+11
| | | | | | | | | | BUG=101600,94925 TEST=none Review URL: http://codereview.chromium.org/8450008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108531 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD patches for base / split from CR #8275005mark@chromium.org2011-10-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | base/base.gypi: - Add native_library_linux.cc to the openbsd build. - Add '..' to include_dirs so that OS_* definitions are available in symbolize.cc base/debug/debugger_posix.cc: - Add support for figuring out if the process is being debugged on OpenBSD by sharing some code with Mac. base/process_util_unittest.cc: - Disable the OutOfMemoryTest on OpenBSD base/third_party/symbolize/symbolize.cc: - Include the correct elf header on OpenBSD build/linux/system.gyp: - The dl library is linux only, so only use it there. BUG= TEST= Review URL: http://codereview.chromium.org/8329023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106078 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth attempt at the following. Unreviewed, this was originally reviewed ↵pkasting@chromium.org2011-09-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7903016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98885 - Third attempt at the following. Unreviewed, this was ↵rsleevi@chromium.org2011-08-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | originally reviewed in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7778035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98917 0039d316-1c4b-4281-b951-d872f2087c98
* Third attempt at the following. Unreviewed, this was originally reviewed in ↵pkasting@chromium.org2011-08-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98885 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream misc changes for android.michaelbai@google.com2011-08-261-2/+5
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7701014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98432 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Purify and Quantify.Doing so will reduce substantially the size of ↵jeanluc@chromium.org2011-08-174-301/+0
| | | | | | | | | the project files. BUG=92102 Review URL: http://codereview.chromium.org/7528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, ↵mnissler@chromium.org2011-08-111-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7623015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96391 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95910 - Revert 95907 - Clean up SSL false start blacklist code.pkasting@chromium.org2011-08-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host. Original comments follow. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 TBR=fischman@chromium.org Review URL: http://codereview.chromium.org/7587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96211 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, ↵fischman@chromium.org2011-08-081-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95910 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SSL false start blacklist code. Numerous changes, including:pkasting@chromium.org2011-08-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95907 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-2/+2
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94426 - Removed wchat_t from Time::FromString.morrita@chromium.org2011-07-281-1/+1
| | | | | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 TBR=shinyak@google.com Review URL: http://codereview.chromium.org/7520021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94427 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchat_t from Time::FromString.shinyak@google.com2011-07-281-1/+1
| | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94426 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android debug and log related filesmichaelbai@google.com2011-07-072-1/+3
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7238012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91748 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream process and thread related code.michaelbai@google.com2011-06-291-1/+1
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7247015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91009 0039d316-1c4b-4281-b951-d872f2087c98
* Patch for Solaris support, mostly ifdefs and header files, plus adds ↵chromium@hybridsource.org2011-06-251-0/+203
| | | | | | | | | | | libevent configuration. BUG=30101 TEST=compiles Review URL: http://codereview.chromium.org/7238021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90494 0039d316-1c4b-4281-b951-d872f2087c98
* Remove msvs_guids from app, base, breakpad and build.tony@chromium.org2011-06-131-2/+0
| | | | | | | | BUG=28727 Review URL: http://codereview.chromium.org/7108053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
* Update dynamic_annotations.h to r3494.glider@chromium.org2011-06-011-1/+1
| | | | | | | This is necessary for linking the Chromium binaries with ThreadSanitizer runtime library Review URL: http://codereview.chromium.org/7105019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87469 0039d316-1c4b-4281-b951-d872f2087c98
* Globally replace <(library) with static_libraryevan@chromium.org2011-05-191-2/+2
| | | | | | | | | | | We provided <(library) as a variable to support a peculiar build configuration on Linux. We no longer support that build configuration, so we can simplify this code to no longer use a variable. Review URL: http://codereview.chromium.org/7051014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 03:55:22 +0000