| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I started by adding virtual destructors to the following
classes:
base::FileTracing::Provider
base::internal::PostTaskAndReplyImpl
base::PostTaskAndReplyWorkerPool
base::TraceLog::EnabledStateObserver
But then that triggered a bunch of other errors in
downstream classes that are missing 'override', so I'm
updating those too.
BUG=none
Review URL: https://codereview.chromium.org/1223393002
Cr-Commit-Position: refs/heads/master@{#338509}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace most usage of MessageLoopProxy under base/ with SingleThreadTaskRunner
and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy
itself which will removed later).
This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002.
Depends on https://codereview.chromium.org/1086733002/.
BUG=465354
TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org
Review URL: https://codereview.chromium.org/1100773004
Cr-Commit-Position: refs/heads/master@{#327755}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1100773004/)
Reason for revert:
This CL caused this failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/2126
I would strongly recommend doing this in smaller pieces since it combines mechanical changes with more subtle ones (base/prefs, base/task).
Original issue's description:
> base: Remove use of MessageLoopProxy
>
> Replace usage of MessageLoopProxy under base/ with SingleThreadTaskRunner
> and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy
> itself which will removed later).
>
> This patch was mostly autogenerated with
> https://codereview.chromium.org/1010073002.
>
> Depends on https://codereview.chromium.org/1086733002/.
>
> BUG=465354
> TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org
>
> Committed: https://crrev.com/62aa5ca413e15738ebebbb9acd271138ec808739
> Cr-Commit-Position: refs/heads/master@{#327512}
TBR=danakj@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465354
Review URL: https://codereview.chromium.org/1113953002
Cr-Commit-Position: refs/heads/master@{#327573}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace usage of MessageLoopProxy under base/ with SingleThreadTaskRunner
and ThreadTaskRunnerHandle (excluding the implementation of MessageLoopProxy
itself which will removed later).
This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002.
Depends on https://codereview.chromium.org/1086733002/.
BUG=465354
TBR=nkostylev@chromium.org,pkasting@chromium.org,pauljensen@chromium.org
Review URL: https://codereview.chromium.org/1100773004
Cr-Commit-Position: refs/heads/master@{#327512}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turned out this is not necessary,
we have a better warning already enabled in clang
(-Wdelete-non-virtual-dtor, part of -Wall).
TBR=darin,satorux,fischman,jamesr,jar,sky
BUG=45135
Review URL: https://codereview.chromium.org/12224027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar
TBR=darin,satorux,fischman,jamesr,sky
BUG=45135
Review URL: https://codereview.chromium.org/12086018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ajwong
Review URL: http://codereview.chromium.org/8956019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This factors out the PostTaskAndReply implementation out of MessageLoopProxy so that it can be used for any destination thread accessible via a PostTask-like interface, and uses that code from both MessageLoopProxy and WorkerPool.
The DhcpProxyScriptFetcherWin and DhcpProxyScriptAdapterFetcher classes were both using a PostTaskAndReply-like mechanism with a WorkerPool thread, and on inspection it looks like there are several places in net/ where this is done, and this motivated the larger change (vs. patch set 1 which was a mechanical switch to base::Bind from NewRunnableMethod).
BUG=97516
TEST=net_unittests
Review URL: http://codereview.chromium.org/8139028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105512 0039d316-1c4b-4281-b951-d872f2087c98
|