summaryrefslogtreecommitdiffstats
path: root/base/win/registry.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove sanity check in RegKey to prevent usage of checkingamit@chromium.org2011-01-211-17/+17
| | | | | | | | | | | | return value as a bool BUG=none TEST=none Review URL: http://codereview.chromium.org/6346010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary DCHECK causing unit test failure.amit@chromium.org2011-01-191-1/+0
| | | | | | | | | | BUG=none TEST=GoogleUpdateSettings::SetCollectStatsConsent TBR=cevans Review URL: http://codereview.chromium.org/6281008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71773 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-191-111/+101
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Order function definitions in base/win/registry.cc according to the header.tfarina@chromium.org2011-01-141-161/+167
| | | | | | | | | BUG=68682 TEST=trybots Review URL: http://codereview.chromium.org/6354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71511 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-011-1/+1
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Making a few RegKey methods that only read data, const.tommi@chromium.org2010-12-071-5/+5
| | | | | | | | | | | This is so that we can make methods that don't alter the contained HKEY or the data it represents accept const references of RegKey. TEST=none BUG=none Review URL: http://codereview.chromium.org/5623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68489 0039d316-1c4b-4281-b951-d872f2087c98
* Make DeleteKey support GetLastError.tommi@chromium.org2010-11-231-1/+6
| | | | | | | | | | | | | | | | | | | | | | | When SHDeleteKey returns, the last error value hasn't been set. With this change, it's possible to have checks like: if (!key.DeleteKey(...) && GetLastError() != ERROR_NOT_FOUND) { HandleErrorCase(); return false; } return true; As it stands, the last error value will always be ERROR_SUCCESS, which is not all that useful. In fact there is code in the installer that attempts to do this, but doesn't currently work correctly (also because it's checking for the wrong GLE value, but I'm fixing that in a separate change). BUG=none TEST=Should have no side effects. Review URL: http://codereview.chromium.org/5182009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67049 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-041-0/+24
| | | | | | | | | BUG=60211 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64960 - Turn on file access checks on Win.rafaelw@chromium.org2010-11-031-24/+0
| | | | | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/4431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-031-0/+24
| | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-171-0/+387
removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98