summaryrefslogtreecommitdiffstats
path: root/base/win
Commit message (Collapse)AuthorAgeFilesLines
* Revert 280152 "Base: Disable the scoped handle verifier"rvargas@google.com2014-06-261-1/+1
| | | | | | | | | | | | | | | | | > Base: Disable the scoped handle verifier > > This is intended for the M37 branch > > BUG=389346 > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/337123006 TBR=rvargas@google.com Review URL: https://codereview.chromium.org/356113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280160 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Disable the scoped handle verifierrvargas@google.com2014-06-261-1/+1
| | | | | | | | | | | This is intended for the M37 branch BUG=389346 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/337123006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280152 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where OpenKey() would call Close() and reset the wow64_access to 0 ↵wfh@chromium.org2014-06-172-1/+20
| | | | | | | | | | | causing subsequent OpenKey() to fail. BUG=384587 TEST=base_unittests --gtest_filter=RegistryTest.SameWowFlags Review URL: https://codereview.chromium.org/334973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277889 0039d316-1c4b-4281-b951-d872f2087c98
* No longer relaunch into metro mode by default on touch devices.grt@chromium.org2014-06-122-15/+0
| | | | | | | | | | | | r232828 removed the touch device check in the delegate execute handler. It should be removed from the "You're almost done" dialog and the process singleton as well. BUG=314818,374360 Review URL: https://codereview.chromium.org/329393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276853 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/memory/scoped_handle.hbrettw@chromium.org2014-06-101-1/+1
| | | | | | | | | | Move the existing 8 users of ScopedStdioHandle (the only thing in this header) to using ScopedFILE like most other code. Remove the dead references to this header from other files in the codebase. R=rvargas@chromium.org Review URL: https://codereview.chromium.org/324773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276071 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Wow64 tests. These appear to be causing issues on a Vista bot.wfh@chromium.org2014-05-271-2/+4
| | | | | | | | | BUG=377917 TBR=cpu Review URL: https://codereview.chromium.org/306543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273001 0039d316-1c4b-4281-b951-d872f2087c98
* Add WOW64 support to DeleteKey. Add DeleteEmptyKey to mimic ↵wfh@chromium.org2014-05-223-16/+344
| | | | | | | | | | | | | | | SHDeleteEmptyKey. Add lots of WOW64 tests. Add a DeleteKey and a CreateKey test. These additions are needed to support Win64 installer logic. BUG=338706,348626 TEST=base_unittests --gtest_filter=Registry* on XP (x86), Vista (x86/x64), Win7 (x86/x64). TEST=installer_util_unittests R=cpu@chromium.org, grt@chromium.org Review URL: https://codereview.chromium.org/275103012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272213 0039d316-1c4b-4281-b951-d872f2087c98
* Removed LOG_GETLASTERROR and LOG_ERRNO macros.vitalybuka@chromium.org2014-05-212-4/+4
| | | | | | | | | | | Most code uses PLOG with the same effect. TBR=bradchen NOTRY=true Review URL: https://codereview.chromium.org/281223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271949 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270611 "Disable ScopedHandle verifier for M36"rvargas@google.com2014-05-151-1/+1
| | | | | | | | | | | | | | | | | | > Disable ScopedHandle verifier for M36 > > This is intended for the M36 branch. > > BUG=373428 > TBR=cpu@chromium.org > R=cpu@chromium.org > > Review URL: https://codereview.chromium.org/281263002 TBR=rvargas@chromium.org Review URL: https://codereview.chromium.org/290063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270733 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where RegKey data would be changed if Open() or Create() calls fail.wfh@chromium.org2014-05-151-10/+23
| | | | | | | | | BUG=373486 R=cpu@chromium.org Review URL: https://codereview.chromium.org/288063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270613 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ScopedHandle verifier for M36rvargas@chromium.org2014-05-151-1/+1
| | | | | | | | | | | | This is intended for the M36 branch. BUG=373428 TBR=cpu@chromium.org R=cpu@chromium.org Review URL: https://codereview.chromium.org/281263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270611 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit "Add an UMA metric to track whether running on a tablet".zturner@chromium.org2014-05-132-0/+32
| | | | | | | | | | | Original review: https://codereview.chromium.org/262773015/ BUG=353701 TBR=thakis@chromium.org, cpu@chromium.org, isherman@chromium.org Review URL: https://codereview.chromium.org/271953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270197 0039d316-1c4b-4281-b951-d872f2087c98
* Adding myself as owner of base/files and base/winrvargas@chromium.org2014-05-111-0/+1
| | | | | | | | | R=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/279623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269651 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 268825 "Add an UMA metric to track whether chrome is runn..."dalecurtis@google.com2014-05-072-32/+0
| | | | | | | | | | | | | | | > Add an UMA metric to track whether chrome is running on a tablet. > > BUG=353701 > R=cpu@chromium.org, isherman@chromium.org, thakis@chromium.org > > Review URL: https://codereview.chromium.org/262773015 TBR=zturner@chromium.org Review URL: https://codereview.chromium.org/271643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268836 0039d316-1c4b-4281-b951-d872f2087c98
* Add an UMA metric to track whether chrome is running on a tablet.zturner@chromium.org2014-05-072-0/+32
| | | | | | | | | BUG=353701 R=cpu@chromium.org, isherman@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/262773015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268825 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a file extension in a commenttimurrrr@chromium.org2014-05-061-3/+3
| | | | | | | | | | | Also use a complete path to make it more obvious that this file is packaged with VC rather than located in Chromium sources (Similar to base/threading/thread_local_storage_win.cc) BUG= Review URL: https://codereview.chromium.org/266973004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268492 0039d316-1c4b-4281-b951-d872f2087c98
* Support COM in SequencedWorkerPool. This will be used by some code thatpkasting@chromium.org2014-04-211-0/+5
| | | | | | | | | | | | | | | | | | currently uses WorkerPool instead. Unlike base::Thread, here COM support does not extend to running a TYPE_UI MessageLoop, since SequencedWorkerPool doesn't use MessageLoop. I think* I don't actually need that. *I have no real idea. :( BUG=251774,328135 TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/242513006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265078 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262303 "base: Disable win::ScopedHandle"rvargas@google.com2014-04-081-1/+1
| | | | | | | | | | | | | | | | | | > base: Disable win::ScopedHandle > > This patch is intended for M35 > > BUG=360757 > R=cpu@chromium.org > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/225283015 TBR=rvargas@chromium.org Review URL: https://codereview.chromium.org/228253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262413 0039d316-1c4b-4281-b951-d872f2087c98
* base: Disable win::ScopedHandlervargas@chromium.org2014-04-081-1/+1
| | | | | | | | | | | | This patch is intended for M35 BUG=360757 R=cpu@chromium.org TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/225283015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262303 0039d316-1c4b-4281-b951-d872f2087c98
* Expose original_function in IATPatchFunction and use that to set ↵hans@chromium.org2014-03-212-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | g_iat_orig_duplicate_handle Previously, the code would initialize g_iat_orig_duplicate_handle like this, before patching the IAT: g_iat_orig_duplicate_handle = ::DuplicateHandle; However, there is no guarantee that this actually ends up storing the original function pointer from the IAT. It could also just store the address of the thunk. Or, in the case of Clang, ::DuplicateHandle would get constant propagated to the call site that used g_iat_orig_duplicate_handle, which would then end up calling the patched ::DuplicateHandle and not the original one. The best way to get the address of the unpatched function is to get it from IATPatchFunction itself. BUG=82385 Review URL: https://codereview.chromium.org/205033009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702) in base/.pkasting@chromium.org2014-03-201-7/+2
| | | | | | | | | | | | This also does a little bit of code formatting in the hopes of shorter, more readable code. BUG=346399 TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/202993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258398 0039d316-1c4b-4281-b951-d872f2087c98
* Style changes split off of https://codereview.chromium.org/202993003/ .pkasting@chromium.org2014-03-191-34/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Violations: * If any conditional arms have braces, all arms must have braces. * Don't handle DCHECK failure. * No else after return * Use DCHECK instead of CHECK unless CHECK is truly necessary * Declare variables in the most local scope possible * Prefer (foo == 0) to (0 == foo) * Avoid unnecessary vertical whitespace * All lines of args should begin at the same position Not violations: * Use DCHECK_EQ() where possible for better error messages * Split compound DCHECKs into separate ones so it's easier to see which failed * Reverse conditionals where doing so allows removing braces and reducing indenting of more lines * Rewrap to avoid splitting a string constant * Don't use at(), it buys nothing over [] when exceptions are off * delete [] -> delete[] * Avoid unnecessary temps BUG=none TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/203223008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258095 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of multiprocess_test's debug_on_start arguments.viettrungluu@chromium.org2014-03-092-3/+2
| | | | | | | | | | | (It was only ever given a "true" value once, and even that seemed dubious.) R=phajdan.jr@chromium.org TBR=darin@chromium.org, jeremy@chromium.org Review URL: https://codereview.chromium.org/191483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255498 "base: Disable win::ScopedHandle"rvargas@google.com2014-03-071-1/+1
| | | | | | | | | | | | | | | | | > base: Disable win::ScopedHandle > > This patch is intended for M34 > > BUG=350063 > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/188793004 TBR=rvargas@chromium.org Review URL: https://codereview.chromium.org/191133004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255681 0039d316-1c4b-4281-b951-d872f2087c98
* base: Disable win::ScopedHandlervargas@chromium.org2014-03-071-1/+1
| | | | | | | | | | | This patch is intended for M34 BUG=350063 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/188793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255498 0039d316-1c4b-4281-b951-d872f2087c98
* Move WriteFile and WriteFileDescriptor from file_util to base namespace.brettw@chromium.org2014-03-061-5/+3
| | | | | | | | | R=viettrungluu@chromium.org TBR=viettrungluu Review URL: https://codereview.chromium.org/184563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
* Make the domain membership test only once per run.pastarmovj@chromium.org2014-02-252-6/+25
| | | | | | | | | | | | | This is not going to change while in session so why bother asking windows again. BUG=none TEST=none R=cpu@chromium.org Review URL: https://codereview.chromium.org/145443009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253164 0039d316-1c4b-4281-b951-d872f2087c98
* Create an interface WindowEventTarget to enable a class to receiveananta@chromium.org2014-02-201-3/+0
| | | | | | | | | | | | | | | | | | | | | | Windows input events. This interface is defined in the newly added ui\base\window_event_target.cc/.h files. It is implemented by the HWNDMessageHandler class. The class sets the interface as window property on the HWND. The LegacyRenderWidgetHostHWND class retrieves this interface via the window property and invokes the corresponding methods. This is much cleaner than the current method of forwarding input messages from the LegacyRenderWidgetHostHWND class via SendMessage and also avoids mucking with the WPARAM of WM_MOUSEMOVE messages to ensure that the parent does not track those messages. BUG=342323 R=sky@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/165753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252365 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some typo and nits while reading the code.etienneb@chromium.org2014-02-203-3/+3
| | | | | | | | | | | | | Removed from this CL: https://codereview.chromium.org/171143002/ R=cpu, dsinclair BUG= Review URL: https://codereview.chromium.org/172563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252222 0039d316-1c4b-4281-b951-d872f2087c98
* Don't track mouse events in HWNDMessageHandler when they are forwarded by ↵ananta@chromium.org2014-02-131-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | the LegacyRenderWidgetHostHWND class. We use the TrackMouseEvent API in HWNDMessageHandler when we receive a WM_MOUSEMOVE message. This is to ensure that Windows sends us a WM_MOUSELEAVE message when the cursor leaves our window bounds. Tooltips use this message to dismiss the tooltip for e.g. Technically when the mouse enters the child window (LegacyRenderWidgetHostHWND) it has left the parent window. We end up getting WM_MOUSELEAVE messages for WM_MOUSEMOVES which are sent to the parent window by the LegacyRenderWidgetHostHWND class causing tooltips to not show up and some other bugs. Fixes as below:- 1. Add a special marker in the hiword of the WPARAM in WM_MOUSEMOVE messages sent by the LegacyRenderWidgetHostHWND class. This is to indicate to the parent that it should not track these mouse moves. 2. When we lose activation in HWNDMessageHandler we post a dummy WM_MOUSELEAVE message. This is enable tooltips if they were visible to be dismissed for e.g Based on code inspection a WM_MOUSELEAVE message should not cause any issues. 3. Forward WM_MOUSEWHEEL and WM_MOUSEHWHEEL messages via SendMessage to the parent without mucking with the parameters. The offsets are in screen coordinates in these messages. 4. Reposting events today fails when we click on the (LegacyRenderWidgetHostHWND) HWND. This is because the current code attempts to find an aura Window at the location which fails. I changed the RepostLocatedEvent function to allow a NULL window parameter on Windows. We attempt to forward the event to the HWND at the current location if it is on the same thread. BUG=342323,342298,342299,341879,343246 R=cpu@chromium.org, sky@chromium.org, sky Review URL: https://codereview.chromium.org/159713012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251190 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete comment referring to Receive() in scoped_handle.h.robertshield@chromium.org2014-02-111-3/+1
| | | | | | | | | BUG=318531 TBR=rvargas,cpu Review URL: https://codereview.chromium.org/159143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r151669 and r155589 as non-Aura Metro mode is goneyukawa@chromium.org2014-02-114-140/+0
| | | | | | | | | | | | | Now TSF-related code is completely consolidated into the metro_driver process. We can safely revert the following CLs: - r155589 : Call TSF-based UI message pump APIs by introducing an injection mechanism into MessageLoopForUI. - r151669 : Introduce base::win::IsTSFAwareRequired() which indicates if TSF-awareness is required or not. BUG=319122, 330735 TEST=manually done on Windows 8.1 Review URL: https://codereview.chromium.org/141773009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250381 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r156303 as non-Aura Metro mode is goneyukawa@chromium.org2014-02-032-40/+1
| | | | | | | | | | | | | | | We no longer need to support TSF in the browser code. Now TSF-related code is completely consolidated into the metro_driver process and the browser process doesn't need to know about TSF any more. Note: TSF-related code remaining in base/win/metro.{cc, h} and content/browser/browser_main_runner.{h, cc} will be reverted by subsequent CLs. BUG=319122, 330735 Review URL: https://codereview.chromium.org/137493006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248475 0039d316-1c4b-4281-b951-d872f2087c98
* Use an alternate mechanism for CreateFile calls in Chromecaitkp@chromium.org2014-02-021-2/+13
| | | | | | | | | | | | BUG=334379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246313 Review URL: https://codereview.chromium.org/138593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248380 0039d316-1c4b-4281-b951-d872f2087c98
* Declare the explicit specialization of ScopedGDIObject::Close 'inline'hans@chromium.org2014-01-311-1/+1
| | | | | | | | | | | | Defining it without inline in the header file violates the ODR rule. MSVC doesn't seem to care, but it causes link failures with Clang. BUG=82385 NOTRY=true Review URL: https://codereview.chromium.org/150833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248296 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetMonitorInfoWrapper, which is no longer needed.brettw@chromium.org2014-01-272-31/+0
| | | | | | | | | | | We always use ASH on Windows, so the code in the wrapper does not have any effect. This removes the wrapper and updates the callers to use the unwrapped Windows API verison. R=shrikant@chromium.org BUG=247430 Review URL: https://codereview.chromium.org/137353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247204 0039d316-1c4b-4281-b951-d872f2087c98
* Add Windows utillity function to verify if a computer is part of a domain.pastarmovj@chromium.org2014-01-232-0/+14
| | | | | | | | | BUG=none TEST=none Review URL: https://codereview.chromium.org/140553005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246600 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 246313 "Use an alternate mechanism for CreateFile calls i..."kochi@google.com2014-01-231-13/+2
| | | | | | | | | | | | | | | | | | This caused reading profile error on Windows8 platform. > Use an alternate mechanism for CreateFile calls in Chrome > > BUG=334379 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464 > > Review URL: https://codereview.chromium.org/138593004 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/144333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246541 0039d316-1c4b-4281-b951-d872f2087c98
* Use an alternate mechanism for CreateFile calls in Chromecaitkp@chromium.org2014-01-221-2/+13
| | | | | | | | | | BUG=334379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464 Review URL: https://codereview.chromium.org/138593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246313 0039d316-1c4b-4281-b951-d872f2087c98
* During the self-destruct flow (user-level Chrome being replaced by ↵huangs@chromium.org2014-01-083-38/+195
| | | | | | | | | | | | | | | | | | | | system-level Chrome), existing code to retarget shortcuts failed to update icon executables. This CL fixes this. The heuristics are summarized below: 1. Only considering shortcuts with parameters . 2. Shortcuts whose icon file == old target (user-level chrome.exe) gets updated to new target (system-level chrome.exe). 3. Shortcut index is kept same as before. (1) lets us delete user-level (pure) Chrome shortcut since system-level Chrome shortcut is already present. (2) lets us select migrate App Launcher shortcut (points to chrome.exe), without changing app shortcuts (points to fixed .ico files). (3) prevents App Launcher shortcut from mutating into Chrome shortcut (it assumes icon resources enumeration don't change. To make (2) and (3) possible, we need to read the icon file and icon index. This is done by generalizing ResolveShortcut() to ResolveShortcutProperties(). The new logic requires a new flow in ShellUtils, and no longer uses the UpdateShortcutsWithArgs() flow. BUG=326562 Review URL: https://codereview.chromium.org/108193019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243642 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Comment Typos in registry.hcsharp@chromium.org2014-01-021-2/+2
| | | | | | | | | TBR=cpu@chromium.org BUG= Review URL: https://codereview.chromium.org/123463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242841 0039d316-1c4b-4281-b951-d872f2087c98
* Add code to fetch the windows type along its version to base.pastarmovj@chromium.org2013-12-092-2/+76
| | | | | | | | | BUG=none TEST=none Review URL: https://codereview.chromium.org/105283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239507 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239400 "Revert 239280 "Move more file_util functions to b..."thakis@chromium.org2013-12-081-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke all bots 9_9 > Revert 239280 "Move more file_util functions to base namespace." > > dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). > This CL is the only in the intersection of CLs in the first failing build on > the two builders, so giving a speculative revert a try (rlarocque already > tried a clobber, it didn't help). > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > > > > Move more file_util functions to base namespace. > > > > TBR=sky > > > > Review URL: https://codereview.chromium.org/109043002 > > TBR=brettw@chromium.org > > Review URL: https://codereview.chromium.org/105823009 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/100923007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239401 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239280 "Move more file_util functions to base namespace."thakis@chromium.org2013-12-081-3/+3
| | | | | | | | | | | | | | | | | | | | | | | dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). This CL is the only in the intersection of CLs in the first failing build on the two builders, so giving a speculative revert a try (rlarocque already tried a clobber, it didn't help). http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > Move more file_util functions to base namespace. > > TBR=sky > > Review URL: https://codereview.chromium.org/109043002 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/105823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239400 0039d316-1c4b-4281-b951-d872f2087c98
* Move more file_util functions to base namespace.brettw@chromium.org2013-12-071-3/+3
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/109043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239280 0039d316-1c4b-4281-b951-d872f2087c98
* Move temp file functions to base namespace.brettw@chromium.org2013-12-032-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/99923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-286-108/+35
| | | | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459 Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/71013004/hashimoto@chromium.org2013-11-276-35/+108
| | | | | | | | | | | | Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803 TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/90963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-276-108/+35
| | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 234738 "base: Disable the scoped handle verifier."rvargas@google.com2013-11-131-1/+1
| | | | | | | | | | | | | | | | | | > base: Disable the scoped handle verifier. > > Intended for M32 branch > > BUG=318496 > TEST=none > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/68113012 TBR=rvargas@google.com Review URL: https://codereview.chromium.org/62833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234742 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-27 10:39:34 +0000