summaryrefslogtreecommitdiffstats
path: root/base/win_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fixing scoped_ptr misusage in base/win_util.cctimurrrr@chromium.org2009-10-091-7/+10
| | | | | | | | | BUG=24266 This patch was originally created by Alexander Potapenko (cc'ed) as http://codereview.chromium.org/264013 Review URL: http://codereview.chromium.org/262023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28537 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-051-2/+0
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-291-0/+2
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-291-0/+8
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-281-8/+0
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-281-0/+8
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27113, it breaks the ChomeOS build.jcampan@chromium.org2009-09-241-2/+0
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/231022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring some of the NativeViewHost and NativeControl focus management so ↵jcampan@chromium.org2009-09-241-0/+2
| | | | | | | | | | | their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Review URL: http://codereview.chromium.org/214029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98
* Regression: Shift modifier on Find was reversed.finnur@chromium.org2009-09-241-3/+3
| | | | | | | | We were also not using GetKeyState correctly in win_util, as the documentation mentions. We should be looking at the high-order bit (&-ing with 0x8000, not 0x80). BUG=22849TEST=Try to use Enter during FindInPage. Notice it should search forwards when Shift key is not pressed and backwards when Shift is pressed. Review URL: http://codereview.chromium.org/218009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27074 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was ↵jam@chromium.org2009-05-201-63/+0
| | | | | | | | created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least). Review URL: http://codereview.chromium.org/115553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16462 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15832 since this test is finished.hbono@chromium.org2009-05-141-20/+0
| | | | | | | BUG=11046 "Need to back out hbono's test fix" Review URL: http://codereview.chromium.org/112021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16047 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental fix for Issue 11046.hbono@chromium.org2009-05-121-0/+20
| | | | | | | | | This change replaces some ImmAssociateContextEx() calls with a LoadLibrary() call and a GetProcAddress() call to prevent Chrome from loading "imm32.dll" on a PC which doesn't have valid "imm32.dll" installed. (Since I have not been able to reproduce this issue on my XP box, this is just a blind fix.) BUG=11046 "repeated crash on launch" Review URL: http://codereview.chromium.org/113096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15832 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-131-0/+1
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Fix all places where we used the GetWinVersion functionnsylvain@chromium.org2009-02-251-1/+1
| | | | | | | | | incorrectly. bug:7802 Review URL: http://codereview.chromium.org/28128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10366 0039d316-1c4b-4281-b951-d872f2087c98
* Add code to be able to detect windows7 and 2008 in GetWinVersion.nsylvain@chromium.org2009-02-121-4/+15
| | | | | | Review URL: http://codereview.chromium.org/21274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9694 0039d316-1c4b-4281-b951-d872f2087c98
* Turning on the tracking of double-delete of HWND in the hope of catching one ↵jcampan@chromium.org2009-02-111-1/+1
| | | | | | | | that would be the cause of the infamous NCDestroy crasher (bug #4714). Review URL: http://codereview.chromium.org/20269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9611 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-041-0/+63
| | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Note: this CL was previously committed and reverted because it broke the sandbox integration module. Review URL: http://codereview.chromium.org/21032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9161 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9109.ojan@google.com2009-02-031-63/+0
| | | | | | | Broke the build. Review URL: http://codereview.chromium.org/20029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9110 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-031-0/+63
| | | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Review URL: http://codereview.chromium.org/21018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/12434jcampan@chromium.org2008-11-251-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5990 0039d316-1c4b-4281-b951-d872f2087c98
* More fun with detecting UAC. Reports in the field indicate that some ↵finnur@google.com2008-09-171-1/+3
| | | | | | | | | | computers have EnableLUA set to 2, which Vista treats as UAC 'on' but since our check checks for uac == 1 we think UAC is 'off'. Changed the check to look for != 0 instead. Review URL: http://codereview.chromium.org/3110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2330 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging to file_util::WriteFile to figure out why writingsky@google.com2008-09-171-1/+22
| | | | | | | | | | | | | bookmarks is failing for some people. As a result of this I moved some code from common/win_util to base/win_util so that file_util_win could call it. The only changes to this code are formatting. BUG=none TEST=none Review URL: http://codereview.chromium.org/2931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2312 0039d316-1c4b-4281-b951-d872f2087c98
* Google Update gave us a new IDL and asked us to change the CLSID const we ↵finnur@google.com2008-09-101-1/+1
| | | | | | | | use. Effectively there should be no change here. This is not required for the beta branch. Review URL: http://codereview.chromium.org/1901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2008 0039d316-1c4b-4281-b951-d872f2087c98
* The About box was needlessly blocking Chrome on Vista SP1 (with UAC ↵finnur@google.com2008-09-101-0/+18
| | | | | | | | disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit. Review URL: http://codereview.chromium.org/1708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2003 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Make the error message extra verbose when the external developper didn't ↵maruel@google.com2008-08-151-1/+5
| | | | | | correctly install and register the SDK. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@942 0039d316-1c4b-4281-b951-d872f2087c98
* Use %ls instead of %s in wprintf format strings for wchar_t fields.mmentovai@google.com2008-08-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@846 0039d316-1c4b-4281-b951-d872f2087c98
* Fix most issues when building base as a x64 target.maruel@google.com2008-07-301-1/+1
| | | | | | BUG=1282556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112 0039d316-1c4b-4281-b951-d872f2087c98
* Add base to the repository.initial.commit2008-07-261-0/+359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8 0039d316-1c4b-4281-b951-d872f2087c98