summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Change LOG(DFATAL) to avoid dialog in production buildjar@chromium.org2010-06-241-3/+3
| | | | | | | | | | | | | | Old semantics: In DEBUG mode: no change: Fatal CHECK error and dialog. In Release mode: Dialog for user, but allow user to continue. New semantics: In Release mode: LOG(ERROR), but don't bother the user. r=brettw,willchan Review URL: http://codereview.chromium.org/2872014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50679 0039d316-1c4b-4281-b951-d872f2087c98
* Add a locked version of CryptAcquireContextdavidben@chromium.org2010-06-233-0/+85
| | | | | | | | | | | | The function is not thread-safe when called with certain flags. This will be useful when we move keygen onto a worker thread. BUG=none TEST=KeygenHandlerTest.SmokeTest (existing) Review URL: http://codereview.chromium.org/2828019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50661 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the SecureHashAlgorithm class using Windows CryptoAPI.wtc@chromium.org2010-06-233-12/+128
| | | | | | | | | | | | sha1.cc is renamed sha1_portable.cc. Change the swapends function to take a pointer instead of a non-const reference parameter. R=jhawkins,davidben,eroman BUG=47218 TEST=SHA1Test.* in base_unittests should pass. Review URL: http://codereview.chromium.org/2849018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50648 0039d316-1c4b-4281-b951-d872f2087c98
* Replace wstring with string16 in history. The only time wstring is used now ↵brettw@chromium.org2010-06-235-90/+128
| | | | | | | | | | | | in history is for bookmark-related stuff (the bookmarks system is still wstring-based). The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code). TEST=none BUG=none Review URL: http://codereview.chromium.org/2808017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix files with svn:executable permissions.thestig@chromium.org2010-06-231-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: Do not ignore result of HANDLE_EINTR.thakis@chromium.org2010-06-233-9/+19
| | | | | | Review URL: http://codereview.chromium.org/2805026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50556 0039d316-1c4b-4281-b951-d872f2087c98
* Safeguard histogram accesses against null pointers.mbelshe@chromium.org2010-06-221-10/+10
| | | | | | | | | | | | This can happen when various tasks run as the static destructors for histograms are concurrently running. BUG=none TEST=none Review URL: http://codereview.chromium.org/2873009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50478 0039d316-1c4b-4281-b951-d872f2087c98
* Log the value of RUNNING_ON_VALGRIND in message_loop.ccglider@chromium.org2010-06-221-0/+4
| | | | | | | BUG=46569 Review URL: http://codereview.chromium.org/2868020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50454 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals resources from resources.pak.tony@chromium.org2010-06-222-4/+4
| | | | | | | | | | | | | | | This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50433 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively revert 50374 (miniinstaller breakage) - Load netinternals ↵willchan@chromium.org2010-06-212-4/+4
| | | | | | | | | | | | | | | | | | | | resources from resources.pak. This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2799022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50392 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals resources from resources.pak.erg@chromium.org2010-06-212-4/+4
| | | | | | | | | | | | | | | This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50374 0039d316-1c4b-4281-b951-d872f2087c98
* mac: use errno instead of return value of pthread_setname_npevan@chromium.org2010-06-211-4/+2
| | | | | | | | | | It appears the return value is always -1 on error. BUG=47058 Review URL: http://codereview.chromium.org/2824018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50373 0039d316-1c4b-4281-b951-d872f2087c98
* Revert debugging printf()s occasionally landed in r50350glider@chromium.org2010-06-212-3/+0
| | | | | | | | TBR=tim Review URL: http://codereview.chromium.org/2818018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50352 0039d316-1c4b-4281-b951-d872f2087c98
* Make the memory waterfall green -- more suppressions for bug 19775.glider@chromium.org2010-06-212-1/+3
| | | | | | | | | BUG=19775 TBR=tim Review URL: http://codereview.chromium.org/2870016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50350 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated version of file_util::EndsWithSeparator.tfarina@chromium.org2010-06-212-8/+2
| | | | | | | | | BUG=24672 TEST=out/Debug/base_unittests Review URL: http://codereview.chromium.org/2842015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50330 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50257 - Reland r50057. This is exactly the same except with two lines ↵erg@chromium.org2010-06-182-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | cherrypicked from tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h} files. Load net-internals from the newly created resources.pak file. This patch also forces the loading of the optional DataPack for const correctness reasons Original Review: http://codereview.chromium.org/2855003 BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2800014 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2811016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50260 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r50057. This is exactly the same except with two lines cherrypicked fromerg@chromium.org2010-06-182-4/+4
| | | | | | | | | | | | | | | | | | | tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h} files. Load net-internals from the newly created resources.pak file. This patch also forces the loading of the optional DataPack for const correctness reasons Original Review: http://codereview.chromium.org/2855003 BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2800014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50257 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to TruncateUtF8ToByteSize to cleanup the code. jerrica@google.com2010-06-172-5/+6
| | | | | | | | | | | I made some corrections to my previously submitted function TruncateUTF8ToByteSize, in order to clean up the code, and use it to truncate sync node titles above 255 bytes. BUG=43675 TEST=base/string_util_unittest.cc Review URL: http://codereview.chromium.org/2632005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50112 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50057 - Load net-internals from the newly created resources.pak file.erg@chromium.org2010-06-172-4/+4
| | | | | | | | | | | | | | This patch also forces the loading of the optional DataPack for const correctness reasons BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2855003 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2852011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50059 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals from the newly created resources.pak file.erg@chromium.org2010-06-172-4/+4
| | | | | | | | | | | This patch also forces the loading of the optional DataPack for const correctness reasons BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2855003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50057 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProcessSingletonWinTest using default profile.mattm@chromium.org2010-06-161-1/+10
| | | | | | | | | | | | | Rename to ProcessSingletonTest. Fix issues preventing the test from working on Linux, and enable it there. Test both normal start up and first-run startup paths(win-only). BUG=38572 TEST=run the test (both with and without an existing profile in the default place) Review URL: http://codereview.chromium.org/2721007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50022 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49982 - patchthakis@chromium.org2010-06-166-40/+23
| | | | | | | TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2825006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50002 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49983 - patchthakis@chromium.org2010-06-161-3/+1
| | | | | | | TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2847011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50001 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49984 - patch from issue 2762014thakis@chromium.org2010-06-162-25/+17
| | | | | | | TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2835007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50000 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49985 - dohthakis@chromium.org2010-06-161-1/+1
| | | | | | | TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2813012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49999 0039d316-1c4b-4281-b951-d872f2087c98
* dohthakis@chromium.org2010-06-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49985 0039d316-1c4b-4281-b951-d872f2087c98
* patch from issue 2762014thakis@chromium.org2010-06-162-17/+25
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49984 0039d316-1c4b-4281-b951-d872f2087c98
* patchthakis@chromium.org2010-06-161-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49983 0039d316-1c4b-4281-b951-d872f2087c98
* patchthakis@chromium.org2010-06-166-23/+40
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49982 0039d316-1c4b-4281-b951-d872f2087c98
* Working towards -Wextrathomasvl@chromium.org2010-06-164-5/+59
| | | | | | | | | | | | - Make loops use {} instead of a ';' to make it clear there is no body to the loop. - Remove checks of unsigned values for <0 - coordinates should be CGFloat, not NSUInteger. BUG=34160 TEST=none Review URL: http://codereview.chromium.org/2865003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49939 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of new AssertAcquired() functionality for Posix.rdsmith@google.com2010-06-166-74/+111
| | | | | | | | | | | | | | | | Hoisted the windows LockImpl funcitonality up into Lock and added material to ConditionVariable to adjust those shadow variables when needed. Also got rid of os_lock() primitive in Lock class by piggybacking on friend decl needed for accessing shadow variables. BUG=44091 TEST=Try bot run on Windows, Linux, Mac. Will land during low traffic time and revert on any problems or perf degradation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49648 Review URL: http://codereview.chromium.org/2196001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49926 0039d316-1c4b-4281-b951-d872f2087c98
* Add DISABLE_RUNNABLE_METHOD_REFCOUNT to make disabling refcounts in ↵ajwong@chromium.org2010-06-162-6/+28
| | | | | | | | | | | RunnableMethods easier. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
* Compile base_fpic for 32 bits as well.jam@chromium.org2010-06-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2804004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49873 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error messages for bad SocketParams.willchan@chromium.org2010-06-152-0/+30
| | | | | | | | | | Make it a compile-time error instead of link-time. Add a check to make sure you don't try to use it with a pointer. BUG=41016 Review URL: http://codereview.chromium.org/1604042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49823 0039d316-1c4b-4281-b951-d872f2087c98
* Support for DIR_SOURCE_ROOT in a case of WebKit-only checkout.tkent@chromium.org2010-06-152-3/+23
| | | | | | | | | BUG=none TEST=none. It's hard to write tests for DIR_SOURCE_ROOT without DIR_SOURCE_ROOT. Review URL: http://codereview.chromium.org/2865002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49769 0039d316-1c4b-4281-b951-d872f2087c98
* Fix fpic build on official builders by taking out -gstabs.jam@chromium.org2010-06-151-0/+5
| | | | | | Review URL: http://codereview.chromium.org/2862003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49756 0039d316-1c4b-4281-b951-d872f2087c98
* If CreateDirectory() fails during extension unpacking, log the exact OS call ↵skerner@chromium.org2010-06-142-20/+52
| | | | | | | | | | | | | that failed. This change is designed to help understand bug 35198, which we can not reproduce locally. BUG=35198 TEST=manual Review URL: http://codereview.chromium.org/2714016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49703 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49648 - Initial implementation of new AssertAcquired() functionality ↵rdsmith@google.com2010-06-136-107/+74
| | | | | | | | | | | | | | | | for Posix. Webkit compile failing. BUG=44091 TEST=Try bot run on Windows, Linux, Mac. Will land during low traffic time and revert on any problems or perf degradation. Review URL: http://codereview.chromium.org/2196001 TBR=rdsmith@google.com Review URL: http://codereview.chromium.org/2805001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49649 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of new AssertAcquired() functionality for Posix.rdsmith@google.com2010-06-136-74/+107
| | | | | | | | | | | | | | Hoisted the windows LockImpl funcitonality up into Lock and added material to ConditionVariable to adjust those shadow variables when needed. Also got rid of os_lock() primitive in Lock class by piggybacking on friend decl needed for accessing shadow variables. BUG=44091 TEST=Try bot run on Windows, Linux, Mac. Will land during low traffic time and revert on any problems or perf degradation. Review URL: http://codereview.chromium.org/2196001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49648 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms to track the size of the profile data.rvargas@google.com2010-06-113-0/+33
| | | | | | | | | | BUG=16705 TEST=FileUtilTest.FileAndDirectorySize Review URL: http://codereview.chromium.org/2778006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49606 0039d316-1c4b-4281-b951-d872f2087c98
* Moving link settings to individual targets.bradnelson@google.com2010-06-111-10/+20
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2711012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49604 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use CRT strcmp function in PEImage.victorw@chromium.org2010-06-111-1/+22
| | | | | | | | | | | | | | | | | | | | This is for chromium dev build with MSVCRT dll. On render process dll initialization, sandbox interception agent patches the dlls, calls PEImage::GetProcOrdinal and GetProcOrdinal calls CRT strcmp function. This may happen before MSVCRT dll loads and crash render process. Using a local string compare function in PEImgage fixes the issue. The patch does not add new functionality and GetProcOrdinal is already covered by existing unittests. R=nsylvain,rvargas BUG=46311 TEST=none Review URL: http://codereview.chromium.org/2756008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49598 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of building a version of base with -fPIC for internal plugin. ↵jam@chromium.org2010-06-111-158/+210
| | | | | | | | Credit to bradnelson. Review URL: http://codereview.chromium.org/2767010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49597 0039d316-1c4b-4281-b951-d872f2087c98
* Mac/clang: Uncontentious fixes.thakis@chromium.org2010-06-111-1/+1
| | | | | | | | | | | | | * Remove unused variables * Make types in h and cc files agree * Use subclasses if we call subclass methods * Fix one real bug (`if (a); a->foo()`) * Fix forward declarations to be correct * Don't mark some definitions with "extern" Review URL: http://codereview.chromium.org/2730015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49570 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanups of usage of process_util code.maruel@chromium.org2010-06-113-17/+26
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2791006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49568 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sync to be called on ChromeOS after a delete operation has. This ↵dhg@chromium.org2010-06-111-0/+3
| | | | | | | | | | ensures that if the user deleted something on a sd card, its synced right after. BUG=chromium-os:2661 TEST=none Review URL: http://codereview.chromium.org/2735013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49550 0039d316-1c4b-4281-b951-d872f2087c98
* Make gtest report an error if there are tests marked as "MAYBE"glider@chromium.org2010-06-111-0/+25
| | | | | | Review URL: http://codereview.chromium.org/2762016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted an occasional change to ToolsSanityTests brought by r49524glider@chromium.org2010-06-111-1/+1
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/2758008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49525 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress another leak from bug 46343.glider@chromium.org2010-06-111-1/+1
| | | | | | | | | | | Suppress bug 46345 BUG=46345,46343 TBR=jam,darin Review URL: http://codereview.chromium.org/2779017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49502 - Build a version of base with -fPIC turned on. Use it for ↵jam@chromium.org2010-06-111-217/+165
| | | | | | | | | | | internal plugin. Credit to bradnelson who did this. Review URL: http://codereview.chromium.org/2796002 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/2778007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49505 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 22:19:31 +0000