summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* linux: reduce header interdependenciesevan@chromium.org2009-12-292-52/+0
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify licenses on a bunch of files.evan@chromium.org2009-12-291-0/+4
| | | | | | | | | | | In this process, I also filed bugs on various projects we depend on that also have unclear licenses. BUG=28291 Review URL: http://codereview.chromium.org/521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35323 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to base/ from a combination of FreeBSD and OpenBSD patches.evan@chromium.org2009-12-2929-68/+99
| | | | | | Review URL: http://codereview.chromium.org/495002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35321 0039d316-1c4b-4281-b951-d872f2087c98
* Typo spelling in comment corrected.jar@chromium.org2009-12-281-1/+1
| | | | | | | TBR=raman.tenneti Review URL: http://codereview.chromium.org/515042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35303 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac tree bustagejar@chromium.org2009-12-281-1/+0
| | | | | | | | | | | Remove overly aggressive DCHECK() which was tripping in HISTOGRAM_ENUMERATION on the mac. BUG=31206 TBR=ramana.tenneti Review URL: http://codereview.chromium.org/519006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35296 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup histogram classes mixing SetFlags into FactoryGet argumentsjar@chromium.org2009-12-284-448/+195
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet, along with reformatting. The macros were cleaned up to use common sub-macros rather than repeating code as much. Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros) since this class was not getting used. I introduced UMA_HISTOGRAM_ENUMERATION to support the common use of LinearHistograms to count various enumerated values. I added a Flags argument to all the FactoryGet routines to help avoid needing to call SetFlags each time a new sample is Add()ed. This also simplifies the code. This will all help prepare for a "don't histogram at all" macro setting so that I can test the impact of the histogram macro calls on performance (since there are now so many active histograms). BUG=31206 r=raman.tenneti Review URL: http://codereview.chromium.org/515033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98
* Add a change that was supposed to be part of the previous CL - see ↵gregoryd@google.com2009-12-221-1/+1
| | | | | | | | http://codereview.chromium.org/501127/show Review URL: http://codereview.chromium.org/507074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35182 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-221-2/+2
| | | | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Create a pid->task_t mapping in the browser process.thakis@chromium.org2009-12-212-7/+8
| | | | | | | | | | | Since nothing writes to this map in the browser atm, this does not have any visible effect. BUG=13156,25454 TEST=unittest Review URL: http://codereview.chromium.org/501138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35092 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory ↵viettrungluu@chromium.org2009-12-194-54/+177
| | | | | | | | | | | | | | | | | | | measurements on OS X. Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156,25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/504068 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/505056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35043 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34994, maybe it regressed startup perf - Fix cpu/memory measurements ↵thakis@chromium.org2009-12-194-177/+54
| | | | | | | | | | | | | | | | on OS X. Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156,25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/504068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35025 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Port browser action popup test to mac.kkania@chromium.org2009-12-192-0/+20
| | | | | | | | BUG=29710 TEST=none Review URL: http://codereview.chromium.org/506069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35020 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-191-2/+2
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-191-2/+2
| | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cpu/memory measurements on OS X.thakis@chromium.org2009-12-184-54/+177
| | | | | | | | | | | Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156,25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34994 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: file handling clean up.estade@chromium.org2009-12-182-0/+9
| | | | | | | | | | | | | | | - remove various invalid uses of ASCII functions - properly escape resource requests - clean up file path handling Some work remains to be done on the last bullet point but this is enough to fix the bug. BUG=30509 TEST=see bug Review URL: http://codereview.chromium.org/501046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34923 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression introduced by r33225.huanr@chromium.org2009-12-172-1/+14
| | | | | | | | | | | | On windows, if CreateDirectory is called with an path on an inaccessible drive, it will enter an infinite loop. BUG=30415 TEST=base_unittests.exe --gtest_filter=FileUtilTest.CreateDirectoryTest Review URL: http://codereview.chromium.org/500075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34871 0039d316-1c4b-4281-b951-d872f2087c98
* Added the ToolsSanityTest test case to base_unittests.glider@chromium.org2009-12-172-0/+51
| | | | | | | | | | | | | | | | tools_sanity_test.cc contains positive tests for tools used on the buildbots. ToolsSanityTest.MemoryLeak contains an memory leak reportable by Memcheck and heap leak checker. ToolsSanityTest.DataRace contains a data race reportable by ThreadSanitizer. The corresponding suppressions are in tools/valgrind/{memcheck,tsan}/suppressions.txt The idea is to check the tools' reports for their presence when testing base_unittests. Review URL: http://codereview.chromium.org/491044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34826 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Pump nestable tasks while web popups are visible.shess@chromium.org2009-12-161-0/+17
| | | | | | | | | BUG=30147 TEST=Go to site with select control and flash animation, popping up control shouldn't pause the flash. See the bug for an example. Review URL: http://codereview.chromium.org/486042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34772 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected destructors instead of ↵jamesr@chromium.org2009-12-163-2/+12
| | | | | | | | | | | | | | | | | | | | | | implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
* Adds baselines for windows 7jamesr@chromium.org2009-12-151-9/+17
| | | | | | | | | TEST=run base_unittests.exe on a Windows 7 machine BUG=none Review URL: http://codereview.chromium.org/466058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34623 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a string leak in GetFunctionPointerFromNativeLibrarystuartmorgan@chromium.org2009-12-151-3/+4
| | | | | | | | | BUG=none TEST=Mac WebKit valgrind Review URL: http://codereview.chromium.org/501031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34616 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the example for weak_ptr so it is correctbrettw@chromium.org2009-12-151-2/+2
| | | | | | | | | BUG=NONE TEST=NONE Patch by dhg@chromium.org Original review: http://codereview.chromium.org/476010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix treejar@chromium.org2009-12-151-1/+2
| | | | | | | | | | Avoid carrying across planned to leak flag, which will cause a DCHECK in the browser process. tbr=mbelshe,raman.tenneti Review URL: http://codereview.chromium.org/503016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34575 0039d316-1c4b-4281-b951-d872f2087c98
* Deserialize UMA flag on histograms moving from renderer to browsersjar@chromium.org2009-12-151-0/+1
| | | | | | | | | | | | | | During a recent migration, we forgot to properly resurrect the flags in a histogram as they are carried from the renderer processes into the browser process. Since the flag is the critical marker that identifies which histograms to upload via UMA, this caused renderer histograms to not get reported. BUG=30478 r=raman.tenetti,mbelshe Review URL: http://codereview.chromium.org/505006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34574 0039d316-1c4b-4281-b951-d872f2087c98
* Make ProcessWatcher use kqueues on Mac.jeremy@chromium.org2009-12-155-1/+55
| | | | | | | | | | | | | * Port ProcessWatcher::EnsureProcessTerminated() to kqueue() APIs on OS X. * Make ProcessWatcher::EnsureProcessGetsReaped() Linux-only, since it's only used there. * Add a unit test. BUG=12731 TEST=Open Chrome/Mac, open and close a few tabs. Processes shouldn't stay around. Review URL: http://codereview.chromium.org/496007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34547 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASSERT_EQ instead of EXPECT_EQ to avoid accessing invalid index in the ↵hayato@chromium.org2009-12-151-12/+12
| | | | | | | | | | | following tests. TEST=FileDescriptorsShuffleTest in base_unitest BUG=None Review URL: http://codereview.chromium.org/486029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34542 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2: Completely redo how themes are stored on disk and processed at ↵erg@google.com2009-12-145-28/+135
| | | | | | | | | | | | | | | | | install time. Same as previous patch, except we now have a BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in ntp_resource_cache.cc. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Previous Review URL: http://codereview.chromium.org/460050 Review URL: http://codereview.chromium.org/499004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
* Use namespace in mac_util_unittest.hayato@chromium.org2009-12-141-14/+21
| | | | | | | | | BUG=None TEST=MacUtilTest in base_unittest Review URL: http://codereview.chromium.org/491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34455 0039d316-1c4b-4281-b951-d872f2087c98
* Made chrome_test to fail when the test itself failed.oshima@chromium.org2009-12-121-0/+3
| | | | | | | | | | | Exclude tests that does not pass on valgrind BUG=29578,29579,29853,29586,29587,29592,29598 TEST=run valgrind test Review URL: http://codereview.chromium.org/466047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Completely redo how themes are stored on disk and processed at installerg@google.com2009-12-115-135/+28
| | | | | | | | | | time," as it fails valgrind tests. This reverts commit 86faccd1028937a69ccc718718fd48c06c0cd471 (r34379). Review URL: http://codereview.chromium.org/490025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34385 0039d316-1c4b-4281-b951-d872f2087c98
* Improve unit tests to verify that directories are listed before files in ↵vandebo@chromium.org2009-12-113-0/+11
| | | | | | | | | | | | | file:/// urls. And fix current regression. BUG=28420 TEST=improved unit tests Review URL: http://codereview.chromium.org/492015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34382 0039d316-1c4b-4281-b951-d872f2087c98
* Completely redo how themes are stored on disk and processed at install time.erg@google.com2009-12-115-28/+135
| | | | | | | | | | | | | | | | | | | | Rewrites most of BrowserThemeProvider and adds a new class BrowserThemePack. BrowserThemePack takes all the logic of generating resources out of the BrowserThemeProvider, does all of them at theme install time (previously, we lazily generated all the button images and a good number of colors, which muddled logic quite a bit), and then writes all the data out into an mmap()able file to speed startup when a theme is installed. In addition, this changes how the GtkThemeProvider works. The GtkThemeProvider now generates all of its images lazily and doesn't reach into the implementation details of BrowserThemeProvider as it used to. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Review URL: http://codereview.chromium.org/460050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34379 0039d316-1c4b-4281-b951-d872f2087c98
* Force failing CHECK/DCHECKs to end the process on Windows.timurrrr@chromium.org2009-12-102-15/+17
| | | | | | | | | | | | | The current implementation of Windows-only hook simply calls FAIL. According to http://code.google.com/p/googletest/issues/list?cursor=234 it is a misuse of FAIL macros (it may not shut down the process). As a result, it was impossible to write death tests on windows. BUG=24885 Review URL: http://codereview.chromium.org/482001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34273 0039d316-1c4b-4281-b951-d872f2087c98
* Separate ProxyResolverMac and ProxyConfigServiceMac into their own files and ↵hayato@chromium.org2009-12-103-0/+47
| | | | | | | | | | extract common utility functions into other files. TEST=trybot and MacUtilTest in base_unittests BUG=27310 Review URL: http://codereview.chromium.org/463028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34243 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Adjust /proc/pid/oom_adj to sacrifice plugin and renderer processes ↵thestig@chromium.org2009-12-102-2/+23
| | | | | | | | | | to the OOM killer. BUG=29752 TEST=During out of memory conditions, Linux kernel picks a plugin/renderer over the browser process. Review URL: http://codereview.chromium.org/467058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the NO_TCMALLOC_SAMPLES option from allocator.gyptimurrrr@chromium.org2009-12-091-3/+0
| | | | | | | | | | | | This brings the heap leak checker back again. The patch was originally prepared by Alexander Potapenko (cc'ed) and reviewed as http://codereview.chromium.org/464034 TBR=willchan,antonm Review URL: http://codereview.chromium.org/478002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34170 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup; remove deprecate file_util function and some obsolete TODOs.estade@chromium.org2009-12-092-5/+0
| | | | | | Review URL: http://codereview.chromium.org/467030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34133 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test failure: SysInfoTest.GoogleChromeOSVersionNumbersFirstcmasone@google.com2009-12-092-12/+10
| | | | | | Review URL: http://codereview.chromium.org/467053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34129 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: The member variable |pattern_| has a different type (FilePath) ↵thestig@chromium.org2009-12-083-26/+25
| | | | | | | | | | | | | | | from the constructor parameter (StringType). So fix this type to match with the constructor. Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/465119/show BUG=none TEST=none Review URL: http://codereview.chromium.org/466071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34092 0039d316-1c4b-4281-b951-d872f2087c98
* Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe.willchan@chromium.org2009-12-082-0/+48
| | | | | | | | | | * Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h) * Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop. BUG=http://crbug.com/29240 Review URL: http://codereview.chromium.org/460094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34036 0039d316-1c4b-4281-b951-d872f2087c98
* Add StringPrintV, fix libxml_utils.cc to use itpiman@chromium.org2009-12-082-0/+9
| | | | | | Review URL: http://codereview.chromium.org/464064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34029 0039d316-1c4b-4281-b951-d872f2087c98
* Make base::GetProcId() thread-safe on windows and drop w2k supportjamesr@chromium.org2009-12-071-68/+2
| | | | | | | | | | | base::GetProcId() was previously not threadsafe since it relied upon threads observing reads between two different static variables in the same order that they were written without any explicit synchronization. This probably is responsible for a small number of our startup crashes (http://crash/search?query=product:%22Chrome%22+base::GetProcIdViaGetProcessId). This fixes the race by dropping w2k support and directly calling the function. TEST=start up without crashing BUG=none Review URL: http://codereview.chromium.org/460063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33987 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement font and encoding settings in Under the Hood preferencesrsesek@chromium.org2009-12-071-0/+1
| | | | | | | | | | | | | * Font settings can now be changed for serif, sans serif, and fixed width. * The default encoding can now be changed via preferences. * Language settings are not yet implemented. See http://crbug.com/23828 BUG=20845 TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings Review URL: http://codereview.chromium.org/461005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33963 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce damage rects that share an edge.darin@chromium.org2009-12-073-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | This fixes the Bloat HTTP page cycler regression, and allows me to remove the hack I checked in to disable multiple-paints due to an observed DHTML page cycler regression. I added a new histogram, RW_IntermediatePaintRectCount, that would have shown the problem clearly had it been there before. I included some cleanup in PaintAggregator: 1- rename "r" to "existing_rect" for clarity 2- check for contained (i.e., redundant) invalidates up front I also changed the opacity of the paint rects used when --show-paint-rects is specified. I find myself dogfooding with this command line option enabled, and I want it to be a little less annoying but still just as useful. R=brettw BUG=29477 TEST=none Review URL: http://codereview.chromium.org/464057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33949 0039d316-1c4b-4281-b951-d872f2087c98
* Add an implementation of base::SyncSocket::Peek for posix platforms. Alsosehr@google.com2009-12-061-3/+7
| | | | | | | | | update the unit test to test the result. TEST=ipc_tests/sync_socket_unittest.cc Review URL: http://codereview.chromium.org/468023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33944 0039d316-1c4b-4281-b951-d872f2087c98
* Use factory to create histograms, and refcounts to track lifetimesjar@chromium.org2009-12-065-232/+485
| | | | | | | | | | | | | | | This is CL patch 377028 by Raman Tenneti, with minor changes to make the try-bots happier. It is cleanup that better ensures lifetimes of histograms (making it harder for users to abuse them). bug=16495 (repairs leak induced by the first landing) bug=18840 (should make leaks less possible) tbr=raman.tenneti Review URL: http://codereview.chromium.org/462027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
* Add non-blocking peek for the syncsocketcpu@chromium.org2009-12-043-0/+18
| | | | | | | | | | | | - Windows only BUG=none TEST=unit test included Review URL: http://codereview.chromium.org/464020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33876 0039d316-1c4b-4281-b951-d872f2087c98
* Split base.gyp and add base_nacl_win64 targetgregoryd@google.com2009-12-043-536/+613
| | | | | | | | | | TEST=none BUG=28176 Review URL: http://codereview.chromium.org/462009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33872 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid including gtk & glib headers in message_pump_glib.h, saves 1 sec on ↵mattm@chromium.org2009-12-042-10/+18
| | | | | | | | | | | do-nothing make. TEST=manual browser test, trybots BUG=none Review URL: http://codereview.chromium.org/464031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98