summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Undisable the now not-flaky unittests!ojan@google.com2008-11-031-5/+2
| | | | | | Review URL: http://codereview.chromium.org/9264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4473 to fix build breakage (local time zone tests failed)amanda@chromium.org2008-11-032-3/+33
| | | | | | | TBR mmentovai@chromium.org Review URL: http://codereview.chromium.org/9274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4496 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from the benighted PlatformThread to the shiny SimpleThreaddkegel@google.com2008-11-032-11/+16
| | | | | | | | | Also add a comment to explain the strange tls gyrations in SlotReturnFunction. Review URL: http://codereview.chromium.org/8972 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4481 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TODO from Jar.mbelshe@google.com2008-11-031-0/+3
| | | | | | Review URL: http://codereview.chromium.org/9262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4475 0039d316-1c4b-4281-b951-d872f2087c98
* Update Mac implemention of Time to prevent problems withamanda@chromium.org2008-11-033-34/+126
| | | | | | | | | times later than the UNIX epoch 32 bit rollover in 2038 (such as cookie expirations). time_t is only 32 bits in MacOS X, so we can't just use time_posix.cc Review URL: http://codereview.chromium.org/9249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4473 0039d316-1c4b-4281-b951-d872f2087c98
* Update idle timer test to use longer intervals.mbelshe@google.com2008-11-031-33/+40
| | | | | | | | | This should increase reliability issues seen on the bbots. Review URL: http://codereview.chromium.org/9261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4471 0039d316-1c4b-4281-b951-d872f2087c98
* Weee. More TODO(darin)s. :)ojan@google.com2008-11-031-3/+5
| | | | | | | Disabled two flaky unittests. Review URL: http://codereview.chromium.org/9258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4468 0039d316-1c4b-4281-b951-d872f2087c98
* The base unittests were succeeding for the isolatedmbelshe@google.com2008-11-031-0/+2
| | | | | | | | | | | | | | | tests, but failed when all tests were run because some tests run without a message loop. The observer_list_threadsafe allowed AddObserver to run with null message loops. But, if you call Notify after doing so, then the notify call would attempt to use the registered "null" ptr to a message loop. This crashed, of course. Review URL: http://codereview.chromium.org/9045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4459 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test for system monitor.mbelshe@google.com2008-11-031-0/+11
| | | | | | | | Not sure how I missed this! Review URL: http://codereview.chromium.org/9250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4457 0039d316-1c4b-4281-b951-d872f2087c98
* quick build fix for Linuxerikkay@google.com2008-11-031-1/+1
| | | | | | | | TBR=sgk Review URL: http://codereview.chromium.org/9043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4455 0039d316-1c4b-4281-b951-d872f2087c98
* * Add write and read/write support to FileStream (renamed from FileInputStream).erikkay@google.com2008-11-036-10/+189
| | | | | | | | * Moved net/disk_cache/os_file to base/platform_file. Review URL: http://codereview.chromium.org/8843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4454 0039d316-1c4b-4281-b951-d872f2087c98
* Make the SystemMonitor observer list thread safe.mbelshe@google.com2008-11-036-64/+119
| | | | | | | | This is done by using the new observer_list_threadsafe. Review URL: http://codereview.chromium.org/4288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4452 0039d316-1c4b-4281-b951-d872f2087c98
* Always show file extensions in the shelf.glen@chromium.org2008-11-032-2/+13
| | | | | | | | BUG=1208 Review URL: http://codereview.chromium.org/8991 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4450 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation error on Windows and link error on Macdkegel@google.com2008-10-311-8/+5
| | | | | | Review URL: http://codereview.chromium.org/8781 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4320 0039d316-1c4b-4281-b951-d872f2087c98
* Port GetProcessCount(), KillProcesses(), and CleanupProcesses().dkegel@google.com2008-10-313-5/+278
| | | | | | | | | Also switch to fork() from vfork(), since strace on my box doesn't support vfork! It's deprecated, anyway. Review URL: http://codereview.chromium.org/8880 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4315 0039d316-1c4b-4281-b951-d872f2087c98
* Port last remaining test case in base/stats_table_unittest.cc, anddkegel@google.com2008-10-313-39/+45
| | | | | | | | | | fix the bug it exposes on posix in StatsTable, i.e. UnregisterThread() breaks when called inside SlotReturnFunction() on posix because posix clears tls data before calling destructor. Review URL: http://codereview.chromium.org/8751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4309 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for ObserverList to not notify observers added duringsky@google.com2008-10-312-5/+67
| | | | | | | | | | | | | notification. I need this for bookmarks. If a new observer is added while the bookmark model is in the process of sending out notification the newly added observer gets confused. BUG=674 TEST=none Review URL: http://codereview.chromium.org/8919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4267 0039d316-1c4b-4281-b951-d872f2087c98
* AbsolutePath should probably also work on non-Windows platforms.evanm@google.com2008-10-311-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/8949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4264 0039d316-1c4b-4281-b951-d872f2087c98
* AbsolutePath should probably actually use its input somewhere.evanm@google.com2008-10-311-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/8948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4263 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using the message loop rather than gtk_main().agl@chromium.org2008-10-301-2/+10
| | | | | | | | | | | Include more code from the main test_shell.cc into the GTK version. Wherever possible the code has been copied and pasted in directly to make the future merge easy. Review URL: http://codereview.chromium.org/8670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4255 0039d316-1c4b-4281-b951-d872f2087c98
* Begin the first small step towards using FilePath everywhere:evanm@google.com2008-10-3016-307/+469
| | | | | | | | | | - Add some transition APIs. - Start migrating some code to transition APIs. Review URL: http://codereview.chromium.org/8825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4254 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage - remove reference to exported_sybmols file.jeremy@chromium.org2008-10-291-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4175 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Add a new MULTIPROCESS_TEST_MAIN macro to store child process namesjeremy@chromium.org2008-10-298-59/+23
| | | | | | | | | | | | | | in a lookup table. Previously we were using different mechanisms on each platform to look up child process names at runtime. This broke on OS X where we strip the symbol table on release executables. 2) Enable process_util_unittest on OS X. Review URL: http://codereview.chromium.org/8864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4165 0039d316-1c4b-4281-b951-d872f2087c98
* System includes need to use angle brackets for check_depsagl@chromium.org2008-10-291-1/+1
| | | | | | | | | TBR=tc Review URL: http://codereview.chromium.org/8706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4141 0039d316-1c4b-4281-b951-d872f2087c98
* Start writing the GTK code for test_shell.agl@chromium.org2008-10-293-13/+49
| | | | | | | Review URL: http://codereview.chromium.org/8000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4136 0039d316-1c4b-4281-b951-d872f2087c98
* Removed magic number for owner rights, avoid to call close(-1).brettw@google.com2008-10-291-2/+2
| | | | | | Patch committed for mendola@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4128 0039d316-1c4b-4281-b951-d872f2087c98
* * Revert "Start writing the GTK code for test_shell."agl@chromium.org2008-10-283-48/+12
| | | | | | | | | This reverts commit 54dfed3ab933cea7492ae1ed2f35cdbfe822e8a4. Review URL: http://codereview.chromium.org/8839 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4072 0039d316-1c4b-4281-b951-d872f2087c98
* Start writing the GTK code for test_shell.agl@chromium.org2008-10-283-12/+48
| | | | | | | Review URL: http://codereview.chromium.org/8000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4071 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back project file portion of r4024. The unit test is not ready on Macmark@chromium.org2008-10-281-8/+0
| | | | | | | OS X, it fails in release mode. Review URL: http://codereview.chromium.org/8662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4067 0039d316-1c4b-4281-b951-d872f2087c98
* Add base\field_trial_unittest.cc to the SCons build.sgk@google.com2008-10-281-0/+1
| | | | | | Review URL: http://codereview.chromium.org/8650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4057 0039d316-1c4b-4281-b951-d872f2087c98
* Add a file I forgot in the last change.evanm@google.com2008-10-271-0/+25
| | | | | | | Review URL: http://codereview.chromium.org/8637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4035 0039d316-1c4b-4281-b951-d872f2087c98
* Port a few test_shell_tests. Now it runs 45 of them.evanm@google.com2008-10-271-0/+1
| | | | | | | | | | | | | | | | I removed some files from test_files because scons complains (warns) when a file is both in test_files and input_files. So the files removed from test_files also exist in input_files and at some pointed will be ported anyway. I also made some linking stubs. BUG=3674 Review URL: http://codereview.chromium.org/7974 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4031 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build by making sure APICALL is defined ontc@google.com2008-10-271-2/+2
| | | | | | | | | | | all platforms TBR=jeremy Review URL: http://codereview.chromium.org/8805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4028 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky test IdleTimerTest.RepeatIdleResetmaruel@google.com2008-10-271-1/+2
| | | | | | Review URL: http://codereview.chromium.org/8632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4025 0039d316-1c4b-4281-b951-d872f2087c98
* Enable stats_tabe_unittest.cc on OS X.jeremy@chromium.org2008-10-276-9/+86
| | | | | | Review URL: http://codereview.chromium.org/8160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4024 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-2747-67/+121
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Lint message loop code (added explicit to a class definition)jar@google.com2008-10-271-6/+6
| | | | | | | | | Incidental lint of code noted the need for explicit... so I tossed it in. r=mbelshe Review URL: http://codereview.chromium.org/8623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4014 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up filter and content encoding handling jar@google.com2008-10-272-1/+5
| | | | | | | | | | | | | | | | Centralize translation functions (text of "Content-Encoding" to enum) in filter.cc Centralize error recovery (for damaged content encoding headers) in filter.cc Error recovery includes a loss of SDCH encoding headers, plus handling of Apache server bug with gzip files are tagged as also being gzip encoded. Centralize and add a pile of unit tests to this filter code. r=openvcdiff,huanr Review URL: http://codereview.chromium.org/8018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4004 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure it's possible to download to a network share.nsylvain@chromium.org2008-10-272-43/+20
| | | | | | | | | | | | | | | | The function to move the file was failing to set the security descriptor. Now we use SHFileOperation, which has a flag to do everything we want. Eventually we might want to display ui on errors and use the ui features of SHFileOperation, but for the 1.0 build we want to stick to a smaller and less risky change. BUG: 984 Review URL: http://codereview.chromium.org/8128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3996 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons modules build on Windows:sgk@google.com2008-10-252-3/+2
| | | | | | | | | | | | | | | * Add 'midl' Tool module. * Filter out the default OS_WINDOWS= definition from the Hammer modules, which messes up our build. * Fix the $PLATFORMSDK_VISTA definition. * Remove the current directory from the 'base' Alias (avoid cycles). * Remove by-hand addition of .lib, .pdb and .ilk files to the target list when build shared libraries (multiple places). * Comment out a post-action Touch() of the themes/default resource. (Thanks to bradnelson for many of the above individual fixes.) Review URL: http://codereview.chromium.org/8207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3980 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC::SyncChannel not duplicate the underlying MessageLoop ↵jam@chromium.org2008-10-243-0/+14
| | | | | | | | implementation by pumping messages on its own. This fixes the problem of windowless plugins not painting on right click, and generally makes this class almost ported, other than using a generic version of events/locks.Through this change I've also cleaned up the class and hopefully made it more understandable. Review URL: http://codereview.chromium.org/8001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3934 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial support to base on the Macamanda@chromium.org2008-10-231-0/+10
| | | | | | Review URL: http://codereview.chromium.org/7927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3830 0039d316-1c4b-4281-b951-d872f2087c98
* Simultaneously store multiple formats on the linux clipboard.estade@chromium.org2008-10-235-69/+192
| | | | | | Review URL: http://codereview.chromium.org/8038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3819 0039d316-1c4b-4281-b951-d872f2087c98
* Create a thread-safe observer list. Will be usedmbelshe@google.com2008-10-225-6/+413
| | | | | | | | | by SystemMonitor. Right now the class requires that Observers be RefCounted<>. This is because we invoke tasks via NewRunnableMethod for them. However, because we manually track lifecycle via AddObserver/RemoveObserver, we could override the RunnableMethodTraits to not require RefCounted<>. This would have the advantage that callers do not need to make all Observers be RefCounted, but makes it more critical that observers not forget to call RemoveObserver(). Review URL: http://codereview.chromium.org/7353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3787 0039d316-1c4b-4281-b951-d872f2087c98
* Use ETS_FOCUSED instead of TS_CHECKED to signify that a buttontc@google.com2008-10-221-1/+1
| | | | | | | | is focused. They both happen to have the same value, but this is much clearer. Review URL: http://codereview.chromium.org/7888 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3781 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies.evanm@google.com2008-10-223-28/+47
| | | | | | | | | Random files in V8Bindings were getting rebuilt when I touched process_util.h. I tracked it down to stats_table.h and shared_memory.h. This change cuts down some dependencies there; more could be removed if we made some of our FooHandle typedefs into abstract data types instead. Review URL: http://codereview.chromium.org/7307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3770 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to how we draw buttons.tc@google.com2008-10-221-6/+15
| | | | | | | | | | | | | 1) Change RenderThemeWin.cpp so that pressed buttons have priority over focused buttons. I.e., if a button is focused and pressed, we should draw it pressed. 2) In classic mode, add the black border for focused buttons and properly add the dotted focus rect. http://crbug.com/135 Review URL: http://codereview.chromium.org/8071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3763 0039d316-1c4b-4281-b951-d872f2087c98
* Make String Conversion Unittest x-platform + fix a small bug the tests exposed.jeremy@chromium.org2008-10-225-11/+19
| | | | | | Review URL: http://codereview.chromium.org/8067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3760 0039d316-1c4b-4281-b951-d872f2087c98
* Port SSLClientSocket to Linuxdkegel@google.com2008-10-221-0/+13
| | | | | | | | | | | | | | | | Passes tests (once you enable them by removing DISABLED_). Probably want to add a mock https server so we can leave those tests enabled when we check in. Had to add full duplex support to TCPClientSocket on Linux to avoid kludgy plumbing issues. Also had to add dummy implementation of X509Certificate::~X509Certificate to prevent link error. Rediffed to current trunk, addressed all review issues. Review URL: http://codereview.chromium.org/4049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3751 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-223-4/+4
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98