summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* There's no need to export the key_iterator class, and exporting itdarin@chromium.org2011-04-291-1/+1
| | | | | | | | | | | breaks VS2005 compilation. R=rvargas BUG=80925 TEST=none Review URL: http://codereview.chromium.org/6880306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83548 0039d316-1c4b-4281-b951-d872f2087c98
* Mac base cleanup.avi@chromium.org2011-04-295-44/+38
| | | | | | | | | | | Move the sole inhabitant of base/foundation_utils_mac.h into base/mac/foundation_util.h|mm. BUG=none TEST=none Review URL: http://codereview.chromium.org/6904128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83514 0039d316-1c4b-4281-b951-d872f2087c98
* Use the IAttachmentExecute service to set the Zone.Identifier stream,joaodasilva@chromium.org2011-04-291-13/+16
| | | | | | | | | | | | | | | | | when available. This is used to mark files as untrusted, because they were downloaded from the internet. The DownloadTest.CheckInternetZone browser test was failing previously because the Zone.Identifier stream created by the IAttachmentExecute service uses \r\n for newlines, and the test was checking for \n. See also http://codereview.chromium.org/590001, which this should close. BUG=5719 TEST=DownloadTest.CheckInternetZone Review URL: http://codereview.chromium.org/6880236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83502 0039d316-1c4b-4281-b951-d872f2087c98
* Field trials are currently implemented (commonly) using a static variable ↵rtenneti@chromium.org2011-04-293-23/+140
| | | | | | | | | | | | | | | | | | | | that is set once, the first time it is necessary to decide if there is an experiment by a given name active. With this change the field-test system can "push" a group that is selected for the given field trial (field test) if/when an experiment does arrive. This change implements a simple IPC notification of the result of a FieldTrial setting being sent to any previously started renderers. BUG=16494 TEST=field trial tests R=jar Review URL: http://codereview.chromium.org/6883029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83488 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one more time the linux tests, in other words giving up on improving the ↵cpu@chromium.org2011-04-291-10/+14
| | | | | | | | tests TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83469 0039d316-1c4b-4281-b951-d872f2087c98
* fix failing linux tests.cpu@chromium.org2011-04-291-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83458 0039d316-1c4b-4281-b951-d872f2087c98
* Add a more comprehensive background mode for a process.cpu@chromium.org2011-04-282-8/+40
| | | | | | | | | | | | | | It also lowers the priority of IO. -Windows vista, win7 only -Bad usage of closehandle fixed BUG=none TEST=unittest included Review URL: http://codereview.chromium.org/6880265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83447 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 83186: Enable building base.dll for the multi-dll build.rvargas@google.com2011-04-281-1/+21
| | | | | | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6883173 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/6902117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83369 0039d316-1c4b-4281-b951-d872f2087c98
* Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() ↵kushi.p@gmail.com2011-04-281-1/+1
| | | | | | | | | | | usages for DCHECK_EQ/LE/GE() equivalents. BUG=58409 TEST=None Review URL: http://codereview.chromium.org/6880166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83362 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83186 - Enable building base.dll for the multi-dll build.rvargas@google.com2011-04-271-21/+1
| | | | | | | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6883173 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/6883197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DirectoryLister not to require refcounting.willchan@chromium.org2011-04-271-2/+4
| | | | | | | | | | | | Also prevent DirectoryLister from blocking the IO thread when cancelled (blocked on joining file IO thread). Allows us to remove refcounting from URLRequestFileDirJob. BUG=65331 TEST=Browse to file:/// and make sure it still works. Test cancellation by closing the tab. Review URL: http://codereview.chromium.org/6898047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83193 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building base.dll for the multi-dll build.rvargas@google.com2011-04-271-1/+21
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6883173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83186 0039d316-1c4b-4281-b951-d872f2087c98
* Moved mru_cache from content/common to base/memory.agayev@chromium.org2011-04-274-0/+525
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6883187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83182 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Adjust dependencies to build with base.dllrvargas@google.com2011-04-261-0/+3
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6894040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83082 0039d316-1c4b-4281-b951-d872f2087c98
* X message pump: Remove unnecessary code.sadrul@chromium.org2011-04-261-9/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6901039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83081 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Fix the logging export api to fix release builds ofrvargas@google.com2011-04-261-1/+1
| | | | | | | | | | chrome using base.dll BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6904010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83073 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r83048 "Removed wchar_t from Time::FromString."maruel@chromium.org2011-04-267-253/+163
| | | | | | | | | | | | This causes regression on KeywordProviderTest.Edit on clang produced executable. TBR=shinyak BUG= TEST= Review URL: http://codereview.chromium.org/6893031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83055 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ReleasableInstanceName to account for the fact that the V propertymark@chromium.org2011-04-262-83/+234
| | | | | | | | | | | | | | | | | attribute isn't always last, despite what the documentation says. Add a CHECK that trips when a property's attributes indicates that it has a named instance variable backing it but no such instance variable is found in the object. Beef up the Sesame Street unit test to give ReleasableInstanceName a more thorough test. BUG=none TEST=none Review URL: http://codereview.chromium.org/6902035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83054 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchar_t from Time::FromString.shinyak@google.com2011-04-267-163/+253
| | | | | | | | | | | | | Also, some of the test case are moved from pr_time_unittests to time_unittests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/6903022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83048 0039d316-1c4b-4281-b951-d872f2087c98
* added md5_unittestshinyak@google.com2011-04-252-0/+199
| | | | | | | | | | BUG=77458 TEST=base_unittests:MD5.* Review URL: http://codereview.chromium.org/6896006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82953 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstring functions from base/i18n/rtl.hevan@chromium.org2011-04-253-83/+18
| | | | | | | | | | And update callers. BUG=23581 Review URL: http://codereview.chromium.org/6883140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82924 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my recent changes regarding title directionality.evan@chromium.org2011-04-251-22/+0
| | | | | | | | | | | | | | | | This reverts: r82400: Plumb direction of document title through IPC layer. r82582: Add and use a base::i18n::StringWithDirection for carrying titles. r82778: Change NavigationEntry's title fields to carry the text direction. I'm going to take an alternative approach; after getting this far, I can see that this approach was too complicated. BUG=27094 Review URL: http://codereview.chromium.org/6901003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82908 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@chromium.org2011-04-252-3/+14
| | | | | | | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82686 Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82891 0039d316-1c4b-4281-b951-d872f2087c98
* Delete a few unused functions.thakis@chromium.org2011-04-251-3/+0
| | | | | | | | | BUG=none TEST=Compiles. Review URL: http://codereview.chromium.org/6880164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82884 0039d316-1c4b-4281-b951-d872f2087c98
* Change NavigationEntry's title fields to carry the text direction.evan@chromium.org2011-04-231-0/+5
| | | | | | | | | | | Mark most of the users with a tag pointing at the bug, so they can be fixed incrementally. BUG=27094 Review URL: http://codereview.chromium.org/6894009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82778 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Fix FileVersionInfo::CreateFileVersionInfoForCurrentModule so thatrvargas@google.com2011-04-223-11/+41
| | | | | | | | | | | when base is built as a dll, the module that is inspected for the version info is the one that makes the call instead of base.dll BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6897016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82754 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Change the AtExitManager so that if base is builtrvargas@google.com2011-04-221-4/+10
| | | | | | | | | | | as a dll, multiple managers could coexist in the same address space. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6897015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82724 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82686 - Extend PathService::Get to be able to return the X86 program ↵abodenha@google.com2011-04-222-10/+3
| | | | | | | | | files path.Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly.BUG=TEST=Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567Review URL: http://codereview.chromium.org/6873159 TBR=abodenha@chromium.org Review URL: http://codereview.chromium.org/6880147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82699 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@chromium.org2011-04-222-3/+10
| | | | | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567 Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82686 0039d316-1c4b-4281-b951-d872f2087c98
* Update DCHECK() usage to utilize the more expressive debugging functions.kushi.p@gmail.com2011-04-228-18/+18
| | | | | | | | BUG=58409 Review URL: http://codereview.chromium.org/6891008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82639 0039d316-1c4b-4281-b951-d872f2087c98
* Use the real Mac browser app's bundle identifier everywhere that a basemark@chromium.org2011-04-224-6/+61
| | | | | | | | | | | | | | | | | | | | | bundle identifier is needed on the Mac. This means that everything will use up using org.chromium.Chromium, com.google.Chrome, or com.google.Chrome.canary when it's important to get the base bundle identifier. .helper and .framework will not be appended. Note, however, that things that run inside the helper and use CFPreferences or NSUserDefaults will continue to write their defaults as org.chromium.Chromium.helper or com.google.Chrome.helper. Mostly this just affects the Flash plug-in's settings for the NSNav open dialog. There is no com.google.Chrome.canary.helper, but that's not expected to be a problem. This change ensures that Chromes, canaries, and Chromiums don't get in each other's way. BUG=79814 TEST=none Review URL: http://codereview.chromium.org/6896003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82626 0039d316-1c4b-4281-b951-d872f2087c98
* Add and use a base::i18n::StringWithDirection for carrying titles.evan@chromium.org2011-04-211-1/+18
| | | | | | | | | | | | This is a refactoring of r82400. We're going to need the title direction in a bunch of different places; it's better to package it up as one object. BUG=27094 Review URL: http://codereview.chromium.org/6878089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82582 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82567 - Extend PathService::Get to be able to return the X86 program ↵arv@chromium.org2011-04-212-10/+3
| | | | | | | | | files path.Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly.BUG=TEST=Review URL: http://codereview.chromium.org/6873159 TBR=abodenha@google.com Review URL: http://codereview.chromium.org/6899005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82572 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@google.com2011-04-212-3/+10
| | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82567 0039d316-1c4b-4281-b951-d872f2087c98
* Base: More adjustments to BASE_API and project dependencies torvargas@google.com2011-04-2112-41/+38
| | | | | | | | | | use base.dll from chrome. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6877053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82460 - Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can ↵glider@chromium.org2011-04-213-19/+1
| | | | | | | | | be used to markheap allocated objects as intentionally leaked ones.Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked.Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions.BUG=79322Review URL: http://codereview.chromium.org/6869009 TBR=cbentzel Review URL: http://codereview.chromium.org/6873152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82483 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to markglider@chromium.org2011-04-213-1/+19
| | | | | | | | | | | | heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 Review URL: http://codereview.chromium.org/6869009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82460 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82405 - Support more than 9 arguments for ↵nsylvain@chromium.org2011-04-212-40/+8
| | | | | | | | | ReplaceStringPlaceholders()- support more than 9 arguments ($1, $2, $3, ..., $9 and $10, $11, $12, ...) for ReplaceStringPlaceholders()- add the unittest named ReplaceStringPlaceholdersMoreThan9Replacements for testing more than 9 arguments for ReplaceStringPlaceholders()BUG=16963TEST=string_util_unittest:StringUtilTest.ReplaceStringPlaceholdersMoreThan9ReplacementsPatch by haraken@google.com.Review URL: http://codereview.chromium.org/6877008 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/6882108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82423 0039d316-1c4b-4281-b951-d872f2087c98
* Support more than 9 arguments for ReplaceStringPlaceholders()tony@chromium.org2011-04-202-8/+40
| | | | | | | | | | | | | | - support more than 9 arguments ($1, $2, $3, ..., $9 and $10, $11, $12, ...) for ReplaceStringPlaceholders() - add the unittest named ReplaceStringPlaceholdersMoreThan9Replacements for testing more than 9 arguments for ReplaceStringPlaceholders() BUG=16963 TEST=string_util_unittest:StringUtilTest.ReplaceStringPlaceholdersMoreThan9Replacements Patch by haraken@google.com. Review URL: http://codereview.chromium.org/6877008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82405 0039d316-1c4b-4281-b951-d872f2087c98
* I can't count.mark@chromium.org2011-04-201-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6873135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82387 0039d316-1c4b-4281-b951-d872f2087c98
* 10.5 SDK compatibility for ObjCPropertyReleaserTest.mark@chromium.org2011-04-201-23/+8
| | | | | | | | BUG=none TEST=green trees Review URL: http://codereview.chromium.org/6880088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82386 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ObjCPropertyReleaser for automatic releasing of Objective-Cmark@chromium.org2011-04-205-0/+474
| | | | | | | | | | properties marked "retain" or "copy" backed by synthesized instance variables. BUG=none TEST=base_unittests ObjCPropertyReleaserTest.SesameStreet Review URL: http://codereview.chromium.org/6881091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82383 0039d316-1c4b-4281-b951-d872f2087c98
* Maintain the list of devices all in one place.sadrul@chromium.org2011-04-202-125/+0
| | | | | | | | | | | | This effectively moves a bunch of code from the message-pump to the touch-factory. This way, the list of devices is maintained in one place. BUG=none TEST=none Review URL: http://codereview.chromium.org/6882083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82307 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for base::Closure in the MessageLoop, and reimplement the whole ↵ajwong@chromium.org2011-04-206-642/+766
| | | | | | | | | | | sucker on top of base::Closure. After this, all Task objects that are posted will be wrapped in a closure prior to dispatch. BUG=35223 TEST=unittests. Review URL: http://codereview.chromium.org/6463013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82300 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed file/directory url resolution for external mount point provider.zelidrag@chromium.org2011-04-201-0/+1
| | | | | | | | | | Per Eric's request, refactored FileSystemDirURLRequestJob and FileSystemURLRequestJob classes to resolve local file system through a new operation. BUG=chromium-os:14225 TEST=added new test cases to FileSystemPathManagerTest.*, added FileSystemOperationTest.TestGetLocalFilePathSuccess Review URL: http://codereview.chromium.org/6864040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82266 0039d316-1c4b-4281-b951-d872f2087c98
* Improve comment.thakis@chromium.org2011-04-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6882042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82127 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't always print dlopen errors from LoadNativeLibraryevan@chromium.org2011-04-185-19/+17
| | | | | | | | | | | Instead, return them to the caller and let the caller decide whether the error is worth notifying the user about. BUG=79068 Review URL: http://codereview.chromium.org/6864020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82008 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing outdated DCHECK(a == b) with DCHECK_EQ(a, b).david.mike.futcher@gmail.com2011-04-181-1/+1
| | | | | | | | | | | | | This is my first attempt at contributing, so please tell me where I'm going wrong. BUG=58409 TEST= Review URL: http://codereview.chromium.org/6851016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81988 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Correctly handle fdopen failure in CreateAndOpenTemporaryFileInDirphajdan.jr@chromium.org2011-04-181-1/+4
| | | | | | | | | | This avoids a possible fd leak when fdopen fails. BUG=none Review URL: http://codereview.chromium.org/6882014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81977 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some typos.maf@chromium.org2011-04-171-3/+3
| | | | | | | R=thakis@chromium.org Review URL: http://codereview.chromium.org/6873038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81919 0039d316-1c4b-4281-b951-d872f2087c98