summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* base/i18n: Remove unneeded includes in case_conversion.*tfarina@chromium.org2011-05-162-6/+3
| | | | | | | | | | | | | These includes are not needed anymore since r84855. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7032008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85559 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: Remove the ability to put wstrings in hash_map<>s.evan@chromium.org2011-05-161-7/+1
| | | | | | | | | | (On Windows, where wstring==string16, either will still work.) BUG=23581 Review URL: http://codereview.chromium.org/7031017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85558 0039d316-1c4b-4281-b951-d872f2087c98
* Support binding WeakPtr<> to methods with void return types.ajwong@chromium.org2011-05-169-76/+676
| | | | | | | | | | | | | | | This should give functionality similar to ScopedRunnableMethodFactory. Note that binding a WeakPtr only make sense with methods with void return types. If the return type is not void, then it is unclear what the function should return when the pointer is invalidated. This code adds a compile time assert to check the return type. BUG=35223 TEST=unittests Review URL: http://codereview.chromium.org/7015064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85549 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85359 because it did not reveal the site where the crashing task was ↵apatrick@chromium.org2011-05-161-6/+0
| | | | | | | | | | | | | | | | | | | | | posted. Original message: Added release build assert on attempt to create a RunnableFunction for a function pointer with address 1. This is actually happening. See http://crbug.com/81449. The generated code to invoke the callback puts the address of the function in the EAX register before doing CALL EAX. I see 0x00000001 in the EAX register when it crashes in the reported minidumps. I'll revert this after the next Canary. TEST=run locally and verify no assertion BUG=81449 Review URL: http://codereview.chromium.org/7013014 TEST=compiles BUG=81449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85547 0039d316-1c4b-4281-b951-d872f2087c98
* base/i18n: Put break_iterator* into namespace i18n.tfarina@chromium.org2011-05-163-17/+27
| | | | | | | | | | | BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/7034012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix data races in LazyInstance<>.dvyukov@google.com2011-05-162-9/+39
| | | | | | | | BUG=82122 Review URL: http://codereview.chromium.org/6997014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85487 0039d316-1c4b-4281-b951-d872f2087c98
* Reland old fix that was reverted incorrectly.mbelshe@chromium.org2011-05-153-8/+45
| | | | | | | | | | | | | | | Fix regression where high resolution timers could be activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Review URL: http://codereview.chromium.org/6904117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85413 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate most CommandLine code across platforms.msw@chromium.org2011-05-143-349/+340
| | | | | | | | | | | | | | | | | | | | | | Significant refactoring with some notable behavior changes: 1. Switches are appended preceding existing arguments (after other swtiches). 2. (Windows) command_line_string() is generated and properly quoted/escaped. 3. Appended switches will retain their (optional) included prefixes (--,-,/). Notable internal changes (shouldn't affect behavior): 1. (Windows) Generate the cl string, instead of storing&updating the original. 2. Explicitly retain switch prefixes (--,-,/) (was automatic in init*/ctor). Update (obvious) code expecting switches to be appended antecedent to args. Add Nico's test from: codereview.chromium.org/6728016/. An intermediary CL landed between patch set 3 and 4, see: http://codereview.chromium.org/6596020 BUG=73195,67764 TEST=Commandline usage. Review URL: http://codereview.chromium.org/6526040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85360 0039d316-1c4b-4281-b951-d872f2087c98
* Added release build assert on attempt to create a RunnableFunction for a ↵apatrick@chromium.org2011-05-141-0/+6
| | | | | | | | | | | | | | function pointer with address 1. This is actually happening. See http://crbug.com/81449. The generated code to invoke the callback puts the address of the function in the EAX register before doing CALL EAX. I see 0x00000001 in the EAX register when it crashes in the reported minidumps. I'll revert this after the next Canary. TEST=run locally and verify no assertion BUG=81449 Review URL: http://codereview.chromium.org/7013014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85359 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented threshold based trace events that only get added to the trace if ↵jbates@chromium.org2011-05-133-167/+478
| | | | | | | | | | | | | | | | | the elapsed time between begin and end is greater than a specified time. In order to reduce macro code duplication, created some additional internal helper macros. Improved performance on the critical trace-disabled code path by deferring some member initialization. Removed the unused __LINE__/__FILE__ data. Prefixed internal macros with "INTERNAL_" so that users ignore them. Moved all the internal macros below so that the user sees the relevant macros first. BUG=81565 TEST=base_unittests Review URL: http://codereview.chromium.org/7016012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85349 0039d316-1c4b-4281-b951-d872f2087c98
* Include "base/string_util.h" in "base/string_util_posix.h".asvitkine@chromium.org2011-05-131-0/+1
| | | | | | | | | | | | Needed for declaration of IsWprintfFormatPortable() which is used by a DHECK() in vswprintf(). BUG=none TEST=none Review URL: http://codereview.chromium.org/6973039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85339 0039d316-1c4b-4281-b951-d872f2087c98
* ObfuscatedFileSystemFileUtil classericu@google.com2011-05-133-9/+12
| | | | | | | | | | This is functional and reasonably well-tested, but we'll still have to adapt the system a bit in order to use it. BUG=none TEST=included unit tests Review URL: http://codereview.chromium.org/6955013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85332 0039d316-1c4b-4281-b951-d872f2087c98
* Add thread check to WatchFileDescriptor.dmaclach@chromium.org2011-05-134-1/+74
| | | | | | | | | | | | | I had a case where I was accidentally calling WatchFileDescriptor from another thread, and it took me a while to debug why I was having problems. This check would've immediately caught my error for me. BUG=none TEST=build Review URL: http://codereview.chromium.org/6410035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85271 0039d316-1c4b-4281-b951-d872f2087c98
* The gyp files don't have a way to refer to POSIX-like OS's as a group, so I ↵mark@chromium.org2011-05-123-13/+13
| | | | | | | | | | | | | | | | defined os_posix, toolkit_gtk, and use_x11 in common.gypi to handle them. I used something similar when porting Chromium 10 and 11 to OpenBSD and Solaris, plus a version of this patch has been tested on FreeBSD. Chromium has also been built on other BSDs, so rather than adding each Unix to every gyp file individually every time another port is added, these broad defines can be used instead and modified with specific logic only where necessary. I included a few modified gyp files so the usage can be seen. I also added sunos5 to some grd/html files and set the default host_arch on i86pc solaris to ia32. BUG=0 TEST={} Patch by ruben <chromium@hybridsource.org>. Review URL: http://codereview.chromium.org/6965007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85154 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-123-8/+8
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* X message pump: Allow adding observers for XEvents.sadrul@chromium.org2011-05-115-13/+48
| | | | | | | | | | | | | | | | | | These observers are slightly different from the normal observers, as in they can return a value to indicate if the XEvent should be dispatched or not. This will allow the event observers to act on an event (e.g. SystemKeyEventListener) and stop the event to be dispatched any farther. This is currently done using gdk_window_event_filter, but since the X message pump dispatches the X events before the event reaches GDK, that technique does not work. This is a fix for that. A future CL will add that support in SystemKeyEventListener using this observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/7013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85041 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include callback_old.h where appropriate, final.jhawkins@chromium.org2011-05-112-2/+0
| | | | | | | | | BUG=82098 TEST=none Review URL: http://codereview.chromium.org/7003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85003 0039d316-1c4b-4281-b951-d872f2087c98
* Do not redefine malloc&co when ADDRESS_SANITIZER macro is defined.timurrrr@chromium.org2011-05-111-2/+5
| | | | | | | | | | | | | ADDRESS_SANITIZER macro is defined when building the code using https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer This is a copy http://codereview.chromium.org/7004020/ the original patch was prepared by Konstantin Serebryany (kcc@) TBR=willchan Review URL: http://codereview.chromium.org/6995052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84978 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the dynamic annotations from ThreadSanitizer r3424.timurrrr@chromium.org2011-05-112-45/+137
| | | | | | | | | | | | This introduces two major changes: - each annotation has a non-trivial implementation which prevents identical code folding - ANNOTATE_HAPPENS_BEFORE and ANNOTATE_HAPPENS_AFTER are separated from ANNOTATE_CONDVAR_{SIGNAL,WAIT}. The corresponding annotation functions are supported by ThreadSanitizer as of r3075 TEST=trybots Review URL: http://codereview.chromium.org/6982022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84975 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of 83710 which reverted 83641 - DNS Host resolver changesrtenneti@chromium.org2011-05-111-0/+22
| | | | | | | | | | | | | | | | | with retry logic. Fix for bug Chromium cannot recover from a state when its DNS requests have been dropped. Whenever we try to resolve the host, we post a delayed task to check if host resolution (OnLookupComplete) is completed or not. If it hasn't completed, then we start a new job to resolve for the same request. BUG=73327 TEST=dns host resolver tests R=eroman,jar Review URL: http://codereview.chromium.org/6976006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84908 0039d316-1c4b-4281-b951-d872f2087c98
* Nits fix on trace_event.h and child_trace_message_filter.ccscheib@chromium.org2011-05-101-1/+1
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7004011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84893 0039d316-1c4b-4281-b951-d872f2087c98
* base: Replace "using namespace base;" by wrapping the tests around ↵tfarina@chromium.org2011-05-101-3/+4
| | | | | | | | | | | | | "namespace base { ... }" BUG=82078 TEST=base_unittests R=evan@chromium.org Review URL: http://codereview.chromium.org/7000011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84870 0039d316-1c4b-4281-b951-d872f2087c98
* Added CHECK for tasks passed to PostTask being null.apatrick@chromium.org2011-05-101-4/+8
| | | | | | | | | | | I hope this will make the crashes associated with posting null tasks fail fast so they can be more easily diagnosed. TEST=try BUG=none TBR=darin@chromium.org Review URL: http://codereview.chromium.org/6982004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84869 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Pepper proxy support in-process font rendering.brettw@chromium.org2011-05-101-3/+5
| | | | | | | | | | | | | This implements a WebKit thread in the PPAPI plugin process so we can do the font calls without IPC. The existing font support was refactored into a virtual class (to prevent PPAPI from depending on WebKit and creating a circular GYP dependency). This moves the renderer sandbox support into content/common so that it can be used by the PPAPI process. Review URL: http://codereview.chromium.org/6981001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84856 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove WideToUpper/WideToLowerevan@chromium.org2011-05-103-23/+0
| | | | | | | | | | | Also fix two instances of passing a single-char array to a function that expects a string (we must NUL-terminate the array). BUG=23581 Review URL: http://codereview.chromium.org/7000005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84855 0039d316-1c4b-4281-b951-d872f2087c98
* Add more ThreadSanitizer sanity teststimurrrr@chromium.org2011-05-101-32/+83
| | | | | | | | | | | | | | | 1) A test that makes sure we handle annotations correctly (BenignRace) 2) A test that makes sure we correctly use the ignore file These tests will help us in investigating http://code.google.com/p/chromium/issues/detail?id=82114 and prevent further mis-handling appear misteriously. BUG=82114 TEST=./tools/valgrind/chrome_tests.sh -t base --tool tsan --gtest_filter="*Sanity*" Review URL: http://codereview.chromium.org/6994009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84812 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstring version of TrimWhitespaceevan@chromium.org2011-05-103-19/+9
| | | | | | | | | | And fix the one caller. BUG=23581 Review URL: http://codereview.chromium.org/6932056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84806 0039d316-1c4b-4281-b951-d872f2087c98
* Add one-time randomization support for FieldTrial, and the ability tojoi@chromium.org2011-05-106-51/+298
| | | | | | | | | | | | | | | | | | | | | | | disable field trials. I am going to have a need for both soon. Update some documentation about empty trial names, add TrialExists() method and update many call-sites to use this (it simplifies the previous logic which checked for existence and then for non-empty name, which can no longer happen). Refactor a bit in browser_main. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. Initially committed as r84197. Rolled back due to DCHECK in official builds, r84373. Will re-submit with fix. BUG=81750 TEST=base_unittests Review URL: http://codereview.chromium.org/6883102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84801 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Remove more boilerplate from chrome://sync-internals js filesakalin@chromium.org2011-05-101-0/+5
| | | | | | | | | | | | | | | | | | Add new JsEventDetails class which encapsulates a DictionaryValue. Make JS events use that instead of JsArgList. Automate listening to log events in sync_log.js. Cleaned up javascript files a bit. Add Swap() method to DictionaryValue. BUG= TEST= Review URL: http://codereview.chromium.org/6951009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84767 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 1.jhawkins@chromium.org2011-05-105-6/+10
| | | | | | | | | | | BUG=82098 TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6997006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84754 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Use callback_old.h where appropriate, part 2.jhawkins@chromium.org2011-05-101-0/+1
| | | | | | | | | | | BUG=none TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6995007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84753 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cancel from RunnableFunctions.dmaclach@chromium.org2011-05-101-32/+19
| | | | | | | | | | | BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84060 Review URL: http://codereview.chromium.org/6690031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84740 0039d316-1c4b-4281-b951-d872f2087c98
* Merge gpu_trace_event back into base/debug/trace_event.scheib@chromium.org2011-05-108-307/+1244
| | | | | | | | | | | | | | | | | | | | | | | Initial land attempt at http://codereview.chromium.org/6551019/ gpu_trace_event fork at http://codereview.chromium.org/6691013 - gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug - Unit Tests implemented for trace_event - gpu_common library removed (was added only for gpu_trace_event) - Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019) - GPU trace calls renamed to new calls. - Tracing switch removed from test_shell, as linux log file support removed. BUG=79509 TEST=trace_event_win_unittest and about:gpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84486 Review URL: http://codereview.chromium.org/6862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84739 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Use callback_old.h where appropriate, part 1.jhawkins@chromium.org2011-05-103-3/+3
| | | | | | | | | | | BUG=none TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6985009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84725 0039d316-1c4b-4281-b951-d872f2087c98
* linux components: expose functions used by testsevan@chromium.org2011-05-091-5/+7
| | | | | | Review URL: http://codereview.chromium.org/6985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84693 0039d316-1c4b-4281-b951-d872f2087c98
* Add shutdown trace functionsdavemoore@chromium.org2011-05-091-1/+3
| | | | | | | | | BUG=chromium-os:14737 TEST=None Review URL: http://codereview.chromium.org/6943001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84662 0039d316-1c4b-4281-b951-d872f2087c98
* linux components: expose more functions from baseevan@chromium.org2011-05-061-6/+6
| | | | | | | | | | | These function calls are exposed below in the char_traits, which can then be inlined into user callsites. TEST=chrome builds in release mode Review URL: http://codereview.chromium.org/6949008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84486 - Merge gpu_trace_event back into ↵scheib@chromium.org2011-05-068-1194/+307
| | | | | | | | | base/debug/trace_event.Initial land attempt at http://codereview.chromium.org/6551019/gpu_trace_event fork at http://codereview.chromium.org/6691013- gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug- Unit Tests implemented for trace_event- gpu_common library removed (was added only for gpu_trace_event)- Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019)- GPU trace calls renamed to new calls.- Tracing switch removed from test_shell, as linux log file support removed.BUG=79509TEST=trace_event_win_unittest and about:gpuCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284Review URL: http://codereview.chromium.org/6862002 TBR=scheib@chromium.org Review URL: http://codereview.chromium.org/6955006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84494 0039d316-1c4b-4281-b951-d872f2087c98
* Merge gpu_trace_event back into base/debug/trace_event.scheib@chromium.org2011-05-068-307/+1194
| | | | | | | | | | | | | | | | | | | | | Initial land attempt at http://codereview.chromium.org/6551019/ gpu_trace_event fork at http://codereview.chromium.org/6691013 - gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug - Unit Tests implemented for trace_event - gpu_common library removed (was added only for gpu_trace_event) - Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019) - GPU trace calls renamed to new calls. - Tracing switch removed from test_shell, as linux log file support removed. BUG=79509 TEST=trace_event_win_unittest and about:gpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284 Review URL: http://codereview.chromium.org/6862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84486 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: split the directory listing parser test and re-enable it on TSan botsphajdan.jr@chromium.org2011-05-064-0/+103
| | | | | | | | | | | | | | The test was disabled on TSan bots becuase it was taking too much time. This change converts one huge test which parses ~30 directory listings to ~30 separate test cases. This change also moves ToLower/ToUpper from ui/base/l10n_util to base/i18n/case_conversion so that they can be used in net/ftp. BUG=79022 Review URL: http://codereview.chromium.org/6905027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84413 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84197 - Add one-time randomization support for FieldTrial, and the ↵joi@chromium.org2011-05-066-298/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | ability to disable field trials. I am going to have a need for both soon. Cleaning up some comments about empty trial names, adding static method TrialExists() and simplifying many call sites by using this method. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. BUG=none TEST=base_unittests TBR=jam@chromium.org R=jar@chromium.org,phajdan.jr@chromium.org,mark@chromium.org,wtc@chromium.org Reason for revert: See http://crbug.com/81750 BUG=81750 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6931048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84373 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstring version of SplitStringevan@chromium.org2011-05-053-16/+21
| | | | | | | | | | Retry of r84336. BUG=23581 Review URL: http://codereview.chromium.org/6930047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84355 0039d316-1c4b-4281-b951-d872f2087c98
* Move the implementations for the CF/NS casts to foundation_utilstuartmorgan@chromium.org2011-05-052-72/+73
| | | | | | | | | | | This should have been part of a previous CL; I missed that the header macros were *declaration* macros, not the casts themselves. BUG=None TEST=Existing unit tests Review URL: http://codereview.chromium.org/6928045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84345 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "wstring: remove wstring version of SplitString"evan@chromium.org2011-05-053-21/+16
| | | | | | This reverts commit r84336. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84339 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstring version of SplitStringevan@chromium.org2011-05-053-16/+21
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/6930047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84336 0039d316-1c4b-4281-b951-d872f2087c98
* Move some Foundation-specific utilities from mac_util to foundation_utilstuartmorgan@chromium.org2011-05-053-70/+70
| | | | | | | | | | | Since there's already a TODO for updating includes I only changed the include in the file I noticed this could be useful for. BUG=None TEST=Existing unit tests Review URL: http://codereview.chromium.org/6928040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84318 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: Add WARN_UNUSED_RESULT in more places.thakis@chromium.org2011-05-051-7/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6931030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84300 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84284 - Merge gpu_trace_event back into ↵scheib@chromium.org2011-05-058-1199/+307
| | | | | | | | | base/debug/trace_event.Initial land attempt at http://codereview.chromium.org/6551019/gpu_trace_event fork at http://codereview.chromium.org/6691013- gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug- Unit Tests implemented for trace_event- gpu_common library removed (was added only for gpu_trace_event)- Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019)- GPU trace calls renamed to new calls.- Tracing switch removed from test_shell, as linux log file support removed.BUG=79509TEST=trace_event_win_unittest and about:gpuReview URL: http://codereview.chromium.org/6862002 TBR=scheib@chromium.org Review URL: http://codereview.chromium.org/6933035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84293 0039d316-1c4b-4281-b951-d872f2087c98
* Merge gpu_trace_event back into base/debug/trace_event.scheib@chromium.org2011-05-058-307/+1199
| | | | | | | | | | | | | | | | | | | Initial land attempt at http://codereview.chromium.org/6551019/ gpu_trace_event fork at http://codereview.chromium.org/6691013 - gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug - Unit Tests implemented for trace_event - gpu_common library removed (was added only for gpu_trace_event) - Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019) - GPU trace calls renamed to new calls. - Tracing switch removed from test_shell, as linux log file support removed. BUG=79509 TEST=trace_event_win_unittest and about:gpu Review URL: http://codereview.chromium.org/6862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84284 0039d316-1c4b-4281-b951-d872f2087c98
* Move crypto_helpers from sync to cryptoqsr@google.com2011-05-053-12/+33
| | | | | | | | | | | | | crypto_helpers only depends on resources in base and is used by sync and password_manager. BUG= TEST= Review URL: http://codereview.chromium.org/6873156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84223 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 02:38:58 +0000