summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Make sure the parent directory always comes first when listing directories.estade@chromium.org2010-02-114-13/+26
| | | | | | | | | BUG=35288 TEST=see bug Review URL: http://codereview.chromium.org/596054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38854 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38766 - Temporarily land http://codereview.chromium.org/576001 to ↵glider@chromium.org2010-02-111-2/+20
| | | | | | | | | | | | | | | check the performance. TBR=antonm,jar Review URL: http://codereview.chromium.org/597040 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/598064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38772 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily land http://codereview.chromium.org/576001 to check theglider@chromium.org2010-02-111-20/+2
| | | | | | | | | | performance. TBR=antonm,jar Review URL: http://codereview.chromium.org/597040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38766 0039d316-1c4b-4281-b951-d872f2087c98
* This CL addresses 2 issues:jcampan@chromium.org2010-02-103-0/+46
| | | | | | | | | | | | | | | | - we were not computing the max request text size correctly in some cases (by forgetting the size of the &q= string) causing assertions. - the translate server might send inconsistent response in some cases, this CL makes sure we deal with them. A common case is when sending separators only strings, which we are not doing now anymore. Other more complicated case are less clear. BUG=35055 TEST=Visit www.spiegel.de and translate the page. The page should be translated correctly. Review URL: http://codereview.chromium.org/594023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38637 0039d316-1c4b-4281-b951-d872f2087c98
* Trigger the blocked cookie notification UI.darin@chromium.org2010-02-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This change involves two significant bits: 1- Add URLRequest::Delegate methods to report a blocked attempt to set a cookie or get cookies, respectively. 2- Generalize the mechanisms we use to proxy notifications to the RenderViewHost from the IO thread. See render_view_host_notification_task.h. Finally, these are used together in ResourceDispatcherHost. Note: Additional work is required to notify when JS attempts to set a cookie fail. R=brettw,eroman BUG=34573 TEST=Configure the browser to block cookies, and then visit a site that tries to set a cookie (e.g., cnn.com). You should see a cookie icon appear in the location bar. If you click that it should report that cookies were blocked. Review URL: http://codereview.chromium.org/600009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38527 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DirectoryWatcher and the only thing using it.phajdan.jr@chromium.org2010-02-099-1213/+2
| | | | | | | | | | | | | DirectoryWatcher was problematic. We couldn't get it right on Linux, it can hit the disk on UI thread on Windows (Really Bad, tm). And finally, the UserScriptMaster didn't work right with it. TEST=Covered by unit_tests and browser_tests BUG=8968, 6051, 6080, 20832 Review URL: http://codereview.chromium.org/586010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38456 0039d316-1c4b-4281-b951-d872f2087c98
* Take out intptr_t IPC serialization support to prevent people from sending ↵jam@chromium.org2010-02-092-18/+0
| | | | | | | | pointers between trusted and untrusted processes. Move HWNDs and other Windows HANDLEs serialization to use 32 bits even on 64 bit platforms since that's all that's needed. Review URL: http://codereview.chromium.org/565001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38455 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Use common Valgrind scripts to run Wine/Valgrind tests.thestig@chromium.org2010-02-081-0/+114
| | | | | | | | | Use test and valgrind suppressions from the same locations as the other valgrind bots. BUG=none TEST=none Review URL: http://codereview.chromium.org/561045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38399 0039d316-1c4b-4281-b951-d872f2087c98
* Make LASTCHANGE work properly for make build.mmoss@google.com2010-02-081-1/+3
| | | | | | | | BUG=22044 Review URL: http://codereview.chromium.org/579014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38366 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-053-4/+28
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* The RemoveChars utility function requires a NULL-terminated input string, so ↵jhawkins@chromium.org2010-02-051-1/+1
| | | | | | | | | | | fix the test accordingly. TBR=joth BUG=34731 TEST=StringUtilTest.RemoveChars Review URL: http://codereview.chromium.org/578018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38252 0039d316-1c4b-4281-b951-d872f2087c98
* Implement RemoveChars, a function to remove a list of characters from a ↵jhawkins@chromium.org2010-02-053-0/+68
| | | | | | | | | | string, and use it in PhoneNumber to remove extra phone number characters. BUG=none TEST=StringUtilTest.RemoveChars Review URL: http://codereview.chromium.org/572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38162 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Finish the interception manager support for x64.rvargas@google.com2010-02-042-3/+4
| | | | | | | | | | | | | | Unit tests and integration tests run (as long as they don't depend on IPCs), both regular and under SANDBOX_EXPORTS. The interception agent is there, but no EAT interceptions yet. BUG=27218 TEST=unit tests/ integration tests. Review URL: http://codereview.chromium.org/565026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38143 0039d316-1c4b-4281-b951-d872f2087c98
* linux: split xdg_mime into a separate targetevan@chromium.org2010-02-031-18/+26
| | | | | | | | | | This will allow for building it with different flags. BUG=34160 Review URL: http://codereview.chromium.org/561032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37933 0039d316-1c4b-4281-b951-d872f2087c98
* Support reordering of Browser Actions within the container. Currently does ↵finnur@chromium.org2010-02-032-2/+51
| | | | | | | | | | | | | | not support dragging to/from the chevron menu. Also fixed two bugs in the same code: - the container would be 0 width if a value for it hasn't been saved (part of bug 32101). - the default icon was not used when a tab specific icon was not found (bug 34317). BUG=http://crbug.com/26990, http://crbug.com/32101, http://crbug.com/34317 TEST=In both LTR and RTL locale, try reordering the browser actions and make sure to test dragging to the ends with and without a chevron visible. Install Send to Gmail extension and make sure it has an icon while in the overflow menu. Review URL: http://codereview.chromium.org/549224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37922 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for fine grained permissions to use LocalStorage.jorlow@chromium.org2010-02-021-1/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/565004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37856 0039d316-1c4b-4281-b951-d872f2087c98
* Hide/show cursor according to NSCursor requests.avi@chromium.org2010-02-022-0/+10
| | | | | | | | | BUG=http://crbug.com/32703 TEST=when hiding cursor (Flash 10.1), cursor hides (but doesn't stay hidden; that's a different bug) Review URL: http://codereview.chromium.org/560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37841 0039d316-1c4b-4281-b951-d872f2087c98
* linux: check the return value passed through HANDLE_EINTRevan@chromium.org2010-02-026-20/+40
| | | | | | | | | | A smarter compiler (clang) can notice that we were not using the return values being passed through HANDLE_EINTR, which meant most frequently that we were missing checking the return value of close(). Review URL: http://codereview.chromium.org/569003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37786 0039d316-1c4b-4281-b951-d872f2087c98
* linux: uncontroversial cleanups found by clangevan@chromium.org2010-02-022-6/+7
| | | | | | | | Part of a larger patch to use clang to warning-check our code. Review URL: http://codereview.chromium.org/561008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37781 0039d316-1c4b-4281-b951-d872f2087c98
* third_party/nspr OpenBSD supportpvalchev@google.com2010-02-022-0/+339
| | | | | | Review URL: http://codereview.chromium.org/563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37774 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily allow writing to the default malloc zone structure while ↵avi@chromium.org2010-02-011-0/+24
| | | | | | | | | | | modifying it. BUG=none TEST=no crash when launching Chromium next year Review URL: http://codereview.chromium.org/557084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37733 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 37721.avi@chromium.org2010-02-011-24/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37723 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily allow writing to the default malloc zone structure while ↵avi@chromium.org2010-02-011-0/+24
| | | | | | | | | | | modifying it. BUG=none TEST=no crash when launching Chromium next year Review URL: http://codereview.chromium.org/551229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37721 0039d316-1c4b-4281-b951-d872f2087c98
* Make acrobat work with --safe-plugins by giving it write accessnsylvain@chromium.org2010-02-012-1/+8
| | | | | | | | | | | | | | | to HKCU\Software\Adobe. Since we already have write access to HKCU\Software\Macromedia, I don't believe this is making it less secure than it actually is. We also give it write access to AppData\Adobe. Finally, we also need to let it do a directory listing in c:\users\<user> and c:\users\<user>\AppData, otherwise it crashes. Review URL: http://codereview.chromium.org/554095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37719 0039d316-1c4b-4281-b951-d872f2087c98
* A better way to fix the compilation issues on Windows x64wtc@chromium.org2010-02-012-54/+2
| | | | | | | | | | | | | | | | | | | | with NSPR headers. Test the Visual C++ predefined macros _M_X64 and _M_AMD64, so that we don't need to include <windows.h> for the definition of _AMD64_. Remove obsolete code for Windows NT Alpha. Based on upstream NSPR patch at https://bugzilla.mozilla.org/show_bug.cgi?id=541690 R=maruel BUG=none TEST=No compilation errors on Windows. Review URL: http://codereview.chromium.org/552182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37705 0039d316-1c4b-4281-b951-d872f2087c98
* Add a utility function to run a process as an arbitrary usercpu@chromium.org2010-02-015-15/+78
| | | | | | | | | | | | | - Only for windows - Needed in certain upgrade scenarios, useful for all BUG=32474 TEST= unit tests included Review URL: http://codereview.chromium.org/555192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37682 0039d316-1c4b-4281-b951-d872f2087c98
* Changes message_pump_glib not to crash if run without correspondingsky@chromium.org2010-01-301-2/+7
| | | | | | | | | | | | | run, or rather if run completes and another message comes through. This can happen during tests and the windows side explicitly allows this case to work. BUG=none TEST=none Review URL: http://codereview.chromium.org/558048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37586 0039d316-1c4b-4281-b951-d872f2087c98
* Load bundle resources when loading bundles on the Macstuartmorgan@chromium.org2010-01-282-2/+7
| | | | | | | | | BUG=32208 TEST=Right-click on a QuickTime movie; a context menu should come up. Review URL: http://codereview.chromium.org/551181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37408 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unnecessary includes.craig.schlenter@chromium.org2010-01-281-1/+0
| | | | | | | | | BUG=NONE TEST=compiles Review URL: http://codereview.chromium.org/557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37403 0039d316-1c4b-4281-b951-d872f2087c98
* Mention NSPR libs in NSS version check error message.craig.schlenter@chromium.org2010-01-281-1/+3
| | | | | | | | | | | | | Some Linux distributions don't have tightly controlled dependencies and allow older nspr libs in conjunction with newer nss libs that can lead to confusion. BUG=33163 TEST=none Review URL: http://codereview.chromium.org/558002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37401 0039d316-1c4b-4281-b951-d872f2087c98
* Use the USE_NSS macro to help porting to FreeBSD, OpenBSD, etc.wtc@chromium.org2010-01-281-2/+2
| | | | | | | | | | | Fix cpplint nits. R=evan,pvalchev BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/558008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37358 0039d316-1c4b-4281-b951-d872f2087c98
* Use nss_util.{h,cc} also on Windows. On Windows, NSS iswtc@chromium.org2010-01-275-16/+46
| | | | | | | | | | | | | | | | | initialized without databases because we'll continue to use the Windows system certificate store. base\third_party\nss is now compiled with -DNO_NSPR_10_SUPPORT (because the NSPR 1.0 types int8 - int64 and uint8 - uint64 conflict with the same-named types in "base/basictypes.h"), so the uint32 type needs to be replaced by unsigned int. R=agl,mark BUG=28744 TEST=No build errors. Review URL: http://codereview.chromium.org/557012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37289 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor EnsureNSSInit. Move the NSS SSL librarywtc@chromium.org2010-01-271-39/+2
| | | | | | | | | | | | | | | initialization to SSLClientSocketNSS in src/net so that src/base does not depend on the NSS SSL library. Call PL_ArenaFinish in the NSPRInitSingleton destructor instead of the NSSInitSingleton destructor because PLArena is part of NSPR. R=agl,ukai BUG=28744 TEST=covered by existing tests. Review URL: http://codereview.chromium.org/554096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37223 0039d316-1c4b-4281-b951-d872f2087c98
* Moved GetUserDirectory() into mac_util.mm.akalin@chromium.org2010-01-274-33/+47
| | | | | | | | | | | | | | | Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory(). Made firefox_importer_utils_mac.mm use PathService. Added unittests for GetUserDirectory(). BUG=22045 TEST=trybots Review URL: http://codereview.chromium.org/548123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37206 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanup in preparation for auto-linting base/.erg@google.com2010-01-2649-167/+193
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/552004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37164 0039d316-1c4b-4281-b951-d872f2087c98
* Import google-glog's Symbolize() and use it in debug_util_posix.cc.satorux@chromium.org2010-01-2613-16/+2256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike glibc's backtrace_symbols(), google-glog's Symbolize() can resolve symbols in binaries built with -fvisibility=hidden. This is because Symbolize() uses both dynamic and regular symbols, while backtrace_symbols() only uses dynamic symbols. As shown below, the new backtrace is slightly less informative as it does not have the binary name like out/Debug/base_unittests and the distance information like +0x20, but it should be ok. BUG=32762 TEST=out/Debug/base_unittests --gtest_filter='StackTrace*' --gtest_also_run_disabled_tests; and manually: BEFORE out/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x81d38f6] out/Debug/base_unittests(StackTrace_DISABLED_DebugOutputToStream_Test::TestBody()+0x17) [0x806633d] out/Debug/base_unittests(testing::Test::Run()+0x7a) [0x8242f96] out/Debug/base_unittests(testing::internal::TestInfoImpl::Run()+0xb9) [0x824347b] out/Debug/base_unittests(testing::TestCase::Run()+0xb7) [0x8243a7f] out/Debug/base_unittests(testing::internal::UnitTestImpl::RunAllTests()+0x256) [0x824777e] out/Debug/base_unittests(testing::UnitTest::Run()+0x14) [0x824680a] out/Debug/base_unittests [0x8048cc5] out/Debug/base_unittests(main+0x50) [0x80482a4] /lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6) [0xb6b41b56] out/Debug/base_unittests [0x80481c1] AFTER % out/Debug/base_unittests --gtest_filter='*DebugOutputToStream' --gtest_also_run_disabled_tests StackTrace::StackTrace() [0x81d3910] StackTrace_DISABLED_DebugOutputToStream_Test::TestBody() [0x806633d] testing::Test::Run() [0x8242f66] testing::internal::TestInfoImpl::Run() [0x824344b] testing::TestCase::Run() [0x8243a4f] testing::internal::UnitTestImpl::RunAllTests() [0x824774e] testing::UnitTest::Run() [0x82467da] TestSuite::Run() [0x8048cc5] main [0x80482a4] 0xb6c0db56 0x80481c1 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36997 Review URL: http://codereview.chromium.org/545148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37090 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD/FreeBSD ifdefs and GYP changes for base/pvalchev@google.com2010-01-256-11/+16
| | | | | | | | Based on original work by Sprewell and Ben Laurie on FreeBSD port Review URL: http://codereview.chromium.org/548129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37063 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Pepper device APIneb@chromium.org2010-01-252-13/+129
| | | | | | | | | Track Pepper DeviceContexts using ID (and reclaim them upon shutdown) Refactor device-specific code into pepper_devices.h Review URL: http://codereview.chromium.org/548100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37060 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix %cpu in task manager.thakis@chromium.org2010-01-251-4/+3
| | | | | | | | | | | I changed %cpu from int to double but left the +0.5 for rounding in. Duh. BUG=32464 TEST=Task Manager %cpu should match Activity Monitor's %cpu. In particular, inactive processes should have 0.0% cpu instead of 0.5%. Review URL: http://codereview.chromium.org/548135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37004 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36997 - Import googleglog's Symbolize() and use it in ↵satorux@chromium.org2010-01-2512-2253/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | debug_util_posix.cc. Unlike glibc's backtrace_symbols(), googleglog's Symbolize() can resolve symbols in binaries built with fvisibility=hidden. This is because Symbolize() uses both dynamic and regular symbols, while backtrace_symbols() only uses dynamic symbols. As shown below, the new backtrace is slightly less informative as it does not have the binary name like out/Debug/base_unittests and the distance information like +0x20, but it should be ok. BUG=32762 TEST=out/Debug/base_unittests gtest_filter='StackTrace*' gtest_also_run_disabled_tests; and manually: BEFORE out/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x81d38f6] out/Debug/base_unittests(StackTrace_DISABLED_DebugOutputToStream_Test::TestBody()+0x17) [0x806633d] out/Debug/base_unittests(testing::Test::Run()+0x7a) [0x8242f96] out/Debug/base_unittests(testing::internal::TestInfoImpl::Run()+0xb9) [0x824347b] out/Debug/base_unittests(testing::TestCase::Run()+0xb7) [0x8243a7f] out/Debug/base_unittests(testing::internal::UnitTestImpl::RunAllTests()+0x256) [0x824777e] out/Debug/base_unittests(testing::UnitTest::Run()+0x14) [0x824680a] out/Debug/base_unittests [0x8048cc5] out/Debug/base_unittests(main+0x50) [0x80482a4] /lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6) [0xb6b41b56] out/Debug/base_unittests [0x80481c1] AFTER % out/Debug/base_unittests gtest_filter='*DebugOutputToStream' gtest_also_run_disabled_tests StackTrace::StackTrace() [0x81d3910] StackTrace_DISABLED_DebugOutputToStream_Test::TestBody() [0x806633d] testing::Test::Run() [0x8242f66] testing::internal::TestInfoImpl::Run() [0x824344b] testing::TestCase::Run() [0x8243a4f] testing::internal::UnitTestImpl::RunAllTests() [0x824774e] testing::UnitTest::Run() [0x82467da] TestSuite::Run() [0x8048cc5] main [0x80482a4] 0xb6c0db56 0x80481c1 Review URL: http://codereview.chromium.org/545148 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/545185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36998 0039d316-1c4b-4281-b951-d872f2087c98
* Import google-glog's Symbolize() and use it in debug_util_posix.cc.satorux@chromium.org2010-01-2512-16/+2253
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike glibc's backtrace_symbols(), google-glog's Symbolize() can resolve symbols in binaries built with -fvisibility=hidden. This is because Symbolize() uses both dynamic and regular symbols, while backtrace_symbols() only uses dynamic symbols. As shown below, the new backtrace is slightly less informative as it does not have the binary name like out/Debug/base_unittests and the distance information like +0x20, but it should be ok. BUG=32762 TEST=out/Debug/base_unittests --gtest_filter='StackTrace*' --gtest_also_run_disabled_tests; and manually: BEFORE out/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x81d38f6] out/Debug/base_unittests(StackTrace_DISABLED_DebugOutputToStream_Test::TestBody()+0x17) [0x806633d] out/Debug/base_unittests(testing::Test::Run()+0x7a) [0x8242f96] out/Debug/base_unittests(testing::internal::TestInfoImpl::Run()+0xb9) [0x824347b] out/Debug/base_unittests(testing::TestCase::Run()+0xb7) [0x8243a7f] out/Debug/base_unittests(testing::internal::UnitTestImpl::RunAllTests()+0x256) [0x824777e] out/Debug/base_unittests(testing::UnitTest::Run()+0x14) [0x824680a] out/Debug/base_unittests [0x8048cc5] out/Debug/base_unittests(main+0x50) [0x80482a4] /lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6) [0xb6b41b56] out/Debug/base_unittests [0x80481c1] AFTER % out/Debug/base_unittests --gtest_filter='*DebugOutputToStream' --gtest_also_run_disabled_tests StackTrace::StackTrace() [0x81d3910] StackTrace_DISABLED_DebugOutputToStream_Test::TestBody() [0x806633d] testing::Test::Run() [0x8242f66] testing::internal::TestInfoImpl::Run() [0x824344b] testing::TestCase::Run() [0x8243a4f] testing::internal::UnitTestImpl::RunAllTests() [0x824774e] testing::UnitTest::Run() [0x82467da] TestSuite::Run() [0x8048cc5] main [0x80482a4] 0xb6c0db56 0x80481c1 Review URL: http://codereview.chromium.org/545148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36997 0039d316-1c4b-4281-b951-d872f2087c98
* Remove gtest_prod.h include from JSONReader.derat@chromium.org2010-01-211-1/+6
| | | | | | | | | | | | | I'd like to build this code for Chrome OS, but the gtest include path is different there. I'm removing the include and adding the FRIEND_TEST() macro directly to json_reader.h. BUG=none TEST=compiled Review URL: http://codereview.chromium.org/546100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36775 0039d316-1c4b-4281-b951-d872f2087c98
* Move two generic string split functions from sync API to their own API in ↵timsteele@google.com2010-01-216-0/+220
| | | | | | | | | | | | | | base/string_split. BUG=None TEST=base_unittests Original patch by Thiago Farina Original Review: http://codereview.chromium.org/464075 Review URL: http://codereview.chromium.org/502074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36774 0039d316-1c4b-4281-b951-d872f2087c98
* Linux, Mac: Don't test parent directories when checking if a path is writable.agl@chromium.org2010-01-211-8/+2
| | | | | | | | | | | | | | This additional check has existed since the code was first written, but wtc queried it in [1] and noted that it doesn't match the Windows version. [1] http://codereview.chromium.org/541022/diff/1/3#newcode309 Removing this additional test doesn't break any unittests so it looks like we can match the Windows code here. http://codereview.chromium.org/545156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36760 0039d316-1c4b-4281-b951-d872f2087c98
* linux: abort unless we have the proper version of NSSevan@chromium.org2010-01-201-0/+10
| | | | | | | | BUG=26448, 27948 and others Review URL: http://codereview.chromium.org/548090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36669 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36459 - Breaks 7 WebKit testsjschuh@chromium.org2010-01-166-30/+153
| | | | | | | | | | | | | | | | | | | | | | Changes are: * base::IsValidCodepoint() now returns false on noncharacter code points. * base::IsStringUTF8() now uses ICU library (removed old Mozilla implementation). * Removed base::IsStringWideUTF8() (was unused and confusing) * file_util::ReplaceIllegalCharactersInPath() now treats Unicode replacement character (U+FFFD) as invalid. * Associated unit tests updated. BUG=2759 BUG=30662 TEST=base_unittests gtest_filter=StringUtilTest.IsStringUTF8 TEST=base_unittests gtest_filter=UTFStringConversionsTest.* TEST=base_unittests gtest_filter=FileUtilICUTestReplaceIllegalCharactersInPathTest Review URL: http://codereview.chromium.org/548017 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/552026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36460 0039d316-1c4b-4281-b951-d872f2087c98
* Changes are:jschuh@chromium.org2010-01-166-153/+30
| | | | | | | | | | | | | | | | | * base::IsValidCodepoint() now returns false on non-character code points. * base::IsStringUTF8() now uses ICU library (removed old Mozilla implementation). * Removed base::IsStringWideUTF8() (was unused and confusing) * file_util::ReplaceIllegalCharactersInPath() now treats Unicode replacement character (U+FFFD) as invalid. * Associated unit tests updated. BUG=2759 BUG=30662 TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8 TEST=base_unittests --gtest_filter=UTFStringConversionsTest.* TEST=base_unittests --gtest_filter=FileUtilICUTestReplaceIllegalCharactersInPathTest Review URL: http://codereview.chromium.org/548017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36459 0039d316-1c4b-4281-b951-d872f2087c98
* Add string16 methods to JSON value classes.munjal@chromium.org2010-01-153-1/+109
| | | | | | | | | TEST=none BUG=32013 Review URL: http://codereview.chromium.org/543031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36397 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser.jianli@chromium.org2010-01-159-19/+86
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/351029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36378 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add Certificate Info dialog (part 1)mattm@chromium.org2010-01-148-16/+43
| | | | | | | | | | | Rename base/nss_init.{h,cc} to base/nss_util.{h,cc}, move PRTimeToBaseTime there. BUG=18119 TEST=Load https://www.google.com, compare to firefox cert dialog. Review URL: http://codereview.chromium.org/500141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36291 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 11:01:16 +0000