summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Mark the most common uses of MakeCheckOpString as extern templates on gcc ↵erg@google.com2010-09-302-8/+29
| | | | | | | | | | | | | | platforms. Remove broken template specializations that were never instantiated that references extern code that doesn't exist in the project (!). BUG=none TEST=compiles, smaller binaries on linux, chromeos and mac Review URL: http://codereview.chromium.org/3594003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61092 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flakey timer test.mbelshe@chromium.org2010-09-301-9/+16
| | | | | | | | | | | | | The goal of the test is to verify that the HighResNow() clock has faster than 15ms precision. Modify the test to not depend on how long Sleep() takes in order to verify this. BUG=50291 TEST=TimeTicks.HighResNow Review URL: http://codereview.chromium.org/3452018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61068 0039d316-1c4b-4281-b951-d872f2087c98
* If VlogTest.Perf is ran under Valgrind, decrease the number of benchmarkglider@chromium.org2010-09-301-3/+5
| | | | | | | | | | iterations. Otherwise the test may time out due to slowdown. TBR=akalin Review URL: http://codereview.chromium.org/3578004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61053 0039d316-1c4b-4281-b951-d872f2087c98
* Removed support for log prefix filters.akalin@chromium.org2010-09-302-24/+0
| | | | | | | | | | | No one is using this, and this is obsoleted by --vmodule. BUG=56965 TEST=None Review URL: http://codereview.chromium.org/3596003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61035 0039d316-1c4b-4281-b951-d872f2087c98
* symbolize: don't stringify errno if we're using google::Symbolize.evan@chromium.org2010-09-291-6/+13
| | | | | | | | | | | | This prevents us from printing out confusing error messages like: Unable to get symbols for backtrace (Success). BUG=57305 TEST=ran locally, saw no error Review URL: http://codereview.chromium.org/3544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61010 0039d316-1c4b-4281-b951-d872f2087c98
* [clang] Fixed clang compile failure introduced by 60976.akalin@chromium.org2010-09-291-3/+4
| | | | | | | | | | | | Put GetVlogLevelHelper definition before GetVlogLevel definition. gcc/msvc is fine with this, but not clang (correctly). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3525006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60991 0039d316-1c4b-4281-b951-d872f2087c98
* shared_memory: improve error messages on failure.evan@chromium.org2010-09-291-4/+11
| | | | | | | | | | | | | | | | | Be careful to leave errno untouched if the file open fails, so that the latter logging statements that print errno will print the right message. Also format the logging text such that the perror-like output (appending text like ": Permission denied") makes more sense. Previously we'd end up printing text like Try [...] to fix.: Permission denied BUG=57305 TEST=shared_memory_unittest should still pass Review URL: http://codereview.chromium.org/3517003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60986 0039d316-1c4b-4281-b951-d872f2087c98
* shared_memory: remove wstrings, fix callers.evan@chromium.org2010-09-296-36/+35
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/3555002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60985 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented VLOG() et al.akalin@chromium.org2010-09-2911-5/+322
| | | | | | | | | | | | | | Implemented VLOG(), VLOG_IF(), VLOG_IS_ON(). Added --v and --vmodule switches. Changed some spammy sync-related logs to use VLOG. BUG=56965 TEST=New unittests Review URL: http://codereview.chromium.org/3448028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60976 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Moves code to the headers.erg@google.com2010-09-2813-12/+86
| | | | | | | | | | | | | One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file. (Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3452030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
* base_unittests: cut a sleep down to 1 second by being more careful about time.evan@chromium.org2010-09-281-6/+23
| | | | | | | | TEST=WatchdogTest.DisarmTest doesn't go flaky Review URL: http://codereview.chromium.org/3545001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60853 0039d316-1c4b-4281-b951-d872f2087c98
* Try to preclude flakiness in test.jar@chromium.org2010-09-281-51/+61
| | | | | | | | | | | | | | | | | | | | I adjusted the test to not depend on timed waits, but instead to spin-wait until stable states are reached. This test will now fail (slowly) as though via an infinite loop, if ever the expected conditions are not met. It should also run very fast, and succeed quickly in the expected cases (and usually fail quickly when there is a minor regression). Bottom line: Hopefully flakiness is gone. BUG=10607 r=wtc Review URL: http://codereview.chromium.org/3462013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60797 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore error (especially don't log) from pthread_setname(), it's harmless.pinkerton@chromium.org2010-09-281-2/+3
| | | | | | | | BUG=47058 TEST=none Review URL: http://codereview.chromium.org/3415025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60783 0039d316-1c4b-4281-b951-d872f2087c98
* The return value of ClosePlatformFile() was reversed in r59041. Mostdumi@chromium.org2010-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | calls to ClosePlatformFile() ignore the return value, but there are two calls that do use it: 1. webkit/glue/webfileutilities_impl.cc, closeFile() method: i talked to jianli who changed that method most recently, and he said he prefers the handle to be reset to base::kInvalidPlatformFileValue if ClosePlatformFile() succeeded, so no change is needed to that code. 2. webkit/database/database_tracker.cc, CloseIncognitoFileHandle(): this code needs to be updated. TEST=WebSQLDBs don't crash in incognito mode. BUG=56237 Review URL: http://codereview.chromium.org/3387018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60685 0039d316-1c4b-4281-b951-d872f2087c98
* Fail to create a directory if there is a file in the path to be created.skerner@chromium.org2010-09-271-0/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3444023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60657 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the hack in string_util for RLZ library.tfarina@chromium.org2010-09-271-17/+0
| | | | | | | | | | | The rlz library was updated to include the right header from these string functions. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3506003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60636 0039d316-1c4b-4281-b951-d872f2087c98
* file_util_proxy: fix a typo that caused us to ignore a path.evan@chromium.org2010-09-241-1/+1
| | | | | | | | | | This was found by the Clang bot! TEST=compiles Review URL: http://codereview.chromium.org/3470015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in the string wrapper for SHA256HashString.bryner@chromium.org2010-09-242-1/+20
| | | | | | | | | | | | | The wrapper was using the size of the input string as the number of hash bytes to compute, rather than the size of the output string (SHA256_LENGTH). Added a test for this. BUG=none TEST=Sha256Test.Test1_String Review URL: http://codereview.chromium.org/3492008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60491 0039d316-1c4b-4281-b951-d872f2087c98
* Include log output in buildbot logs on Windows just as darin@chromium.org2010-09-241-15/+2
| | | | | | | | | | | | | we do on Linux and Mac. This can be very helpful when trying to debug flaky tests. R=erikkay BUG=none TEST=none Review URL: http://codereview.chromium.org/3435027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60472 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging for issue 35198.skerner@chromium.org2010-09-242-53/+8
| | | | | | | | | | | Remove switch --issue35198-logging . BUG=56664 TEST=Install an extension on all platforms. Review URL: http://codereview.chromium.org/3427019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60471 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-249-157/+151
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a FileUtilProxy::TouchFile() method that takes a FilePath as andumi@chromium.org2010-09-242-0/+45
| | | | | | | | | | | | argument (instead of PlatformFile). BUG=none TEST=none Review URL: http://codereview.chromium.org/3380024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60397 0039d316-1c4b-4281-b951-d872f2087c98
* base_unittests: Turn down the sleeps on the stats table tests.evan@chromium.org2010-09-231-15/+23
| | | | | | | | | | | | These tests are over 20% of the time taken by base_unittests. I don't think making these sleeps shorter should affect their reliability too much. BUG=10611 Review URL: http://codereview.chromium.org/3474009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60385 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TouchFile() function that takes a FilePath argument.dumi@chromium.org2010-09-237-24/+46
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3496005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60381 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move virtual methods to implementation files.erg@google.com2010-09-235-86/+136
| | | | | | | | | | | Remove logging.h and other headers where possible. BUG=none TEST=none Review URL: http://codereview.chromium.org/3461019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add a TouchFile function that operates on FilePaths + fixing a bug"maruel@chromium.org2010-09-237-46/+24
| | | | | | | | | | | | This reverts commit 60322. TBR=dumi TEST=none BUG=none Review URL: http://codereview.chromium.org/3439019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60327 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TouchFile function that operates on FilePaths + fixing a bugdumi@chromium.org2010-09-237-24/+46
| | | | | | | | | | | related to FILE_WRITE_ATTRIBUTES on Windows. BUG=none TEST=FileUtilTest::TouchFile Review URL: http://codereview.chromium.org/3404018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60322 0039d316-1c4b-4281-b951-d872f2087c98
* The submillisecond test was broken in at least two ways. First, thembelshe@chromium.org2010-09-233-16/+27
| | | | | | | | | | | | | | | | | high resolution clock is intentionally disabled on some systems (old AMDs). If QueryPerformanceCounter doesn't work on this system, we shouldn't run the test. Second, however, if the time between two HighResNow() calls is *always* 0us, then this test would fail. Due to speedstep technology with intentionally underclocked QPC (at the windows level), this is quite possible. BUG=42850 TEST=TimeTicks.SubMillisecondTimers Review URL: http://codereview.chromium.org/3387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60293 0039d316-1c4b-4281-b951-d872f2087c98
* Quick-fix the compliation error on Windowstimurrrr@chromium.org2010-09-231-1/+1
| | | | | | | TBR=phajdan.jr,glider Review URL: http://codereview.chromium.org/3413032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60272 0039d316-1c4b-4281-b951-d872f2087c98
* Add two tests for uninit reads to ToolsSanityTeststimurrrr@chromium.org2010-09-231-0/+9
| | | | | | | TEST=./tools/valgrind/chrome_tests.sh -t base --gtest_filter="Sanity*" on Linux and Mac Review URL: http://codereview.chromium.org/3470006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60271 0039d316-1c4b-4281-b951-d872f2087c98
* Pull latest PPAPI. Change key handling to support the new API.brettw@chromium.org2010-09-232-2/+23
| | | | | | | | TEST=PPAPI UI tests BUG=none Review URL: http://codereview.chromium.org/3386019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60258 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup orphaned testserver processes on posix.rsimha@chromium.org2010-09-222-3/+53
| | | | | | | | | | | If a chrome test that uses a testserver were to crash, the testserver process ends up being orphaned, potentially affecting subsequent tests. This patch causes child processes of a test case to be killed along with the test case if it were to be abruptly terminated. BUG=55808 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3423012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60192 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor some file_system classes to use chromium types instead ofdumi@chromium.org2010-09-221-1/+6
| | | | | | | | | | | WebKit API types. BUG=none TEST=none Review URL: http://codereview.chromium.org/3406008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60152 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of clang warnings/errors.thakis@chromium.org2010-09-213-24/+26
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60109 0039d316-1c4b-4281-b951-d872f2087c98
* Support for building Chrome using Clang.evan@chromium.org2010-09-181-1/+8
| | | | | | | | | | | | | | | | To build, set the clang=1 gyp_define. This patch is the culmination of many months of effort and many patches. It contains the minimal changes to Chrome that are Clang-specific. With this, I can build the "chrome" target. Once this patch is in, we can incrementally fix bits of Chrome and various tests and remove the Clang-specific workarounds. Review URL: http://codereview.chromium.org/522020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59882 0039d316-1c4b-4281-b951-d872f2087c98
* Fix removal of multiple observers in ObserverListThreadSafe.willchan@chromium.org2010-09-172-5/+49
| | | | | | | | | BUG=55725 TEST=ObserverListThreadSafeTest.RemoveMultipleObservers Review URL: http://codereview.chromium.org/3381009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59833 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Replace the existing browser-child mach ipc with a long-lived listener ↵rohitrao@chromium.org2010-09-174-131/+28
| | | | | | | | | | | | | | | | | on a well-known port. Before this CL: Before fork()ing a child, the browser process creates a mach receive port with a random name. After the fork() but before exec(), the child uses mach ipc to transmit send rights to its task port. The child has access to the random name because it inherits it from the browser process. Unfortunately, some of the library functions involved in sending a mach message are not safe to call after fork(). After this CL: Before forking the first child, the browser spins off a new thread that listens on a well-known port for mach ipc from any process. This well-known port is "com.google.Chrome.<browserpid>". When a child process starts up, it sends a mach message to its parent browser's well-known port. On the browser side, we listen for said message, extract the pid of the sending process, and ignore any messages from processes we did not personally fork(). This check is necessary because any arbitrary process on the system could send mach ipc to that port. BUG=35374 TEST=Browser should still start up. The task manager should still show correct cpu/memory data. There should be no perf regressions. TEST=Mac ui_tests and browser_tests should be less flaky. Review URL: http://codereview.chromium.org/3443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59782 0039d316-1c4b-4281-b951-d872f2087c98
* Make a destructor protected per darin@'s request in a previous code review.erg@google.com2010-09-161-2/+4
| | | | | | | | | | TBR=darin@chromium.org BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3390010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style guide errors in commentsdpolukhin@chromium.org2010-09-162-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3402004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59622 0039d316-1c4b-4281-b951-d872f2087c98
* Various style fixes (indenting, captitalization, adding some comments).levin@chromium.org2010-09-161-13/+16
| | | | | | | | | | | Also removed a function that is no longer called. BUG=None TEST=Build works. Review URL: http://codereview.chromium.org/3453006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59592 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move Extension::LaunchContainer to extension_constants.h.erg@google.com2010-09-162-0/+5
| | | | | | | | | | | This makes browser.h not depend on extension.h. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3399008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bad URLRequest leak detection. nss_ocsp creates asky@chromium.org2010-09-152-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URLRequest. This URLRequest, if valid, is deleted when the IO thread is being shutdown by way of a DestructionObserver attached to the IO thread. Prior to this patch this proves problematic as the LeakTracker is run before DestructionObservers, which means we were errorenously detecting a leak and causing random UI failures (and perhaps other tests). To fix this I've moved the LeakTracker to run after the IO thread MessageLoop has been deleted (which means DestructionObservers have been notified). Doing this triggered a DCHECK in ChromeNetLog::AddEntry: DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); Here's the full stack: StackTrace::StackTrace() [0xf247c1] logging::LogMessage::~LogMessage() [0xf3ef4f] ChromeNetLog::AddEntry() [0x5c9639] net::BoundNetLog::AddEntry() [0x147d8a3] net::BoundNetLog::AddEvent() [0x147d92a] net::internal::ClientSocketPoolBaseHelper::CancelRequest() [0x132d032] net::ClientSocketPoolBase<>::CancelRequest() [0x134aabd] net::TCPClientSocketPool::CancelRequest() [0x1348fdb] net::ClientSocketHandle::ResetInternal() [0x13273b7] net::ClientSocketHandle::Reset() [0x1327874] net::ClientSocketHandle::~ClientSocketHandle() [0x1327895] scoped_ptr<>::~scoped_ptr() [0x1304b97] net::HttpStreamRequest::~HttpStreamRequest() [0x1300933] base::RefCounted<>::Release() [0xa15b83] scoped_refptr<>::operator=() [0x12f2da4] net::HttpNetworkTransaction::~HttpNetworkTransaction() [0x12ee377] scoped_ptr<>::~scoped_ptr() [0x12e2724] net::HttpCache::Transaction::~Transaction() [0x12e10a6] scoped_ptr<>::reset() [0x12d1f0b] URLRequestHttpJob::DestroyTransaction() [0x142229e] URLRequestHttpJob::Kill() [0x14252e5] URLRequest::DoCancel() [0x137af1e] URLRequest::Cancel() [0x137b081] (anonymous namespace)::OCSPRequestSession::CancelURLRequest() [0x13142a7] (anonymous namespace)::OCSPRequestSession::WillDestroyCurrentMessageLoop() [0x1314b30] MessageLoop::~MessageLoop() [0xf421ab] base::Thread::ThreadMain() [0xf71395] ThreadFunc() [0xf54338] start_thread [0x7ff66c6d83f7] 0x7ff669d5cbbd This is still on the IO thread, but the DCHECK fails because at the time the DestructionObservers are run Thread::message_loop() returns NULL, which means the DCHECK fails. I've fixed this by changing the DCHECK to pass if the current thread's message loop is NULL. I feel a bit quesy about this as it seems a bit fragile (well, all this code is fragile). I would be inclined to make Thread::message_loop() return the MessageLoop until after the destructor has run, but this seems equally risky. Let me know what you prefer. BUG=52022 TEST=none Review URL: http://codereview.chromium.org/3402006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59566 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Fix FileUtilTest so multiple test instances can run in parallel.phajdan.jr@chromium.org2010-09-151-110/+106
| | | | | | | | | BUG=54098 TEST=base_unittests Review URL: http://codereview.chromium.org/3444003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59548 0039d316-1c4b-4281-b951-d872f2087c98
* Change platform_file_unittest.cc to report the time values when andumi@chromium.org2010-09-151-6/+9
| | | | | | | | | | | assertion fails. TEST=none BUG=55517 Review URL: http://codereview.chromium.org/3428003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome build for 10.6 SDK.jrg@chromium.org2010-09-151-2/+6
| | | | | | | | | | | Should fix Mac coverage bot compile errors. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3380005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59531 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitStringDontTrim functions from string_util.h to string_split.htfarina@chromium.org2010-09-157-47/+91
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3366011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some simple code typos spotted while investigating bug 54229.evan@chromium.org2010-09-141-3/+3
| | | | | | | | TEST=compiles Review URL: http://codereview.chromium.org/3432002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59446 0039d316-1c4b-4281-b951-d872f2087c98
* Lock log files when reiniting them.davemoore@chromium.org2010-09-141-100/+148
| | | | | | | | | | | | This is a second attempt of this cl: http://codereview.chromium.org/3195014/show BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/3347016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59439 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-141-1/+1
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a stupid bug in GetRunningOnValgrind, this is a copy of TSan r2453 changetimurrrr@chromium.org2010-09-141-1/+1
| | | | | | | | TEST=RunningOnValgrind() should be fixed on Windows TBR=glider Review URL: http://codereview.chromium.org/3437001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59359 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 07:55:35 +0000