summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Fix a couple of integer issues in Pickle deserialization. Neither representcevans@chromium.org2009-06-252-1/+32
| | | | | | | | | | | | | a significant risk because the code is not directly exposed to user input. In addition, neither error leads to memory corruption. At worse, there's a C++ exception or abort(). BUG=NONE TEST=PickleTest.EvilLengths Review URL: http://codereview.chromium.org/146121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19249 0039d316-1c4b-4281-b951-d872f2087c98
* change backing store cache to be memory-based rather than counterikkay@chromium.org2009-06-251-0/+2
| | | | | | | | | BUG=13763 TEST=none Review URL: http://codereview.chromium.org/146095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Linux sys_string_conversion changes.deanm@chromium.org2009-06-252-222/+4
| | | | | | | | | | | | This reverts r19239 and r19240. Tests are failing on the buildbots probably because they aren't in a UTF-8 locale. BUG=14826 Review URL: http://codereview.chromium.org/147148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19241 0039d316-1c4b-4281-b951-d872f2087c98
* Only run the UTF-8 assuming sys conversion tests on Linux.deanm@chromium.org2009-06-251-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/147146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19240 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Linux sys_string_conversions using the system APIs.deanm@chromium.org2009-06-252-4/+219
| | | | | | | | | BUG=14826 Review URL: http://codereview.chromium.org/140062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19239 0039d316-1c4b-4281-b951-d872f2087c98
* Run content scripts in their own isolated world. Hidden behind the ↵abarth@chromium.org2009-06-252-0/+5
| | | | | | | | --isolated-world command line argument to let us iterate on this feature.R=aaBUG=12218TEST=None :( (I have a testing plan we can put in place once the upstream half of this CL lands.) Review URL: http://codereview.chromium.org/118188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19225 0039d316-1c4b-4281-b951-d872f2087c98
* Replace std:;wstring with std::string and string16 in locale-name related APIs.jshin@chromium.org2009-06-242-17/+61
| | | | | | | | | | | | | | | 1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly. 2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring. This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. BUG=8647 (http://crbug.com/8647) TEST=Pass l10n_util_unittest and other unit tests Review URL: http://codereview.chromium.org/126223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathComponents from file_util to FilePath, add FilePath::IsParent()rafaelw@chromium.org2009-06-246-83/+186
| | | | | | | | r=erikkay,mark Review URL: http://codereview.chromium.org/145026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19174 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19131.glen@chromium.org2009-06-242-68/+3
| | | | | | Review URL: http://codereview.chromium.org/147095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19154 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in directory_watcher_inotify.cc: release lock before ↵phajdan.jr@chromium.org2009-06-241-16/+24
| | | | | | | | | signaling the event dtor waits on. http://crbug.com/15055 Review URL: http://codereview.chromium.org/147052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19151 0039d316-1c4b-4281-b951-d872f2087c98
* Pass through non-character codepoints in UTF-8,16,32 and Wide conversion ↵jshin@chromium.org2009-06-244-16/+56
| | | | | | | | | | | | | | | | | | | | functions. They're structurally valid code points unlike malformed byte/surrogate sequences. I believe it's better to leave them alone in conversion functions. This CL was triggered by file_util_unittest failure on Linux/Mac with my upcoming change to file_util::ReplaceIllegalCharacters (a part of http://codereview.chromium.org/126223 ). In addition, the upper bound for the output length in CodepageToWide was tightened. TEST=pass string_util and file_util unittests BUG=NONE Review URL: http://codereview.chromium.org/147038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19132 0039d316-1c4b-4281-b951-d872f2087c98
* PNGDecoder wasn't multiplying the alpha like PNGEncoder was. This lead to colorglen@chromium.org2009-06-242-3/+68
| | | | | | | | | | | | | | overflow. This intermediate fix makes everything correct, but will make alphaed pixels slightly darker until the user's cache is flushed (I have screenshots of the effect). BUG=13360 TEST=none Review URL: http://codereview.chromium.org/147049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19131 0039d316-1c4b-4281-b951-d872f2087c98
* Order posix file listings by type as well as name.estade@chromium.org2009-06-242-6/+44
| | | | | | | | | http://crbug.com/12812 TEST=go to /, see that directories are sorted before other files. Review URL: http://codereview.chromium.org/147063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19100 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore SIGPIPE when running tests.mark@chromium.org2009-06-231-1/+18
| | | | | | | | | | BUG=15046 TEST=unit_tests --gtest_filter=IPCSyncChannelTest.NoHang should complete and not be taken down by SIGPIPE; when EPIPE occurs, a harmless "broken pipe" message should be logged. Review URL: http://codereview.chromium.org/147019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19045 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions besides externally installed ones and themes.aa@chromium.org2009-06-231-258/+258
| | | | | | | | | | | | This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to undo the damage is ready. BUG=13467 TEST=Added unit tests Review URL: http://codereview.chromium.org/132003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19008 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Fix dead tree.aa@chromium.org2009-06-221-258/+258
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18964 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions besides externally installed ones and themes.aa@chromium.org2009-06-221-258/+258
| | | | | | | | | | | | This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to undo the damage is ready. BUG=13467 TEST=Added unit tests Review URL: http://codereview.chromium.org/132003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18959 0039d316-1c4b-4281-b951-d872f2087c98
* Add two new test cases to RSAPrivateKey.aa@chromium.org2009-06-221-51/+313
| | | | | | | | | These cover a special case of encoding and decoding ASN.1 integers. Review URL: http://codereview.chromium.org/140077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18943 0039d316-1c4b-4281-b951-d872f2087c98
* Fix decoding bug in RSAPrivateKey.aa@chromium.org2009-06-222-32/+52
| | | | | | | | | | | | | | | We were dropping the most significant byte from the input when decoding PrivateKeyInfo, whether or not it was part of the original data. This shouldn't matter, except that we need to get back the original byte lengths so that we can give them to CryptoAPI. BUG=14877 TEST=Stress tested the functions by creating 1000 random private keys, exporting them, then re-importing. Also tried stressing the edge cases in particular around extra trailing null bytes. Review URL: http://codereview.chromium.org/141036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18909 0039d316-1c4b-4281-b951-d872f2087c98
* Get correct request to finsh time for histogramjar@chromium.org2009-06-201-2/+18
| | | | | | | | | | | | | | | Corrected a typo in generating the stat, and evolved to a new histogram name to avoid confusion. Note that the time between start and finish still needs to be fixed, as that part of the regression is not handled. BUG=14678 r=davemoore Review URL: http://codereview.chromium.org/132072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18896 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Add more logging to try and track down flakey crypto tests.aa@chromium.org2009-06-201-0/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18885 0039d316-1c4b-4281-b951-d872f2087c98
* Minor no-op change to ASN.1 encoding of private key.aa@chromium.org2009-06-191-2/+2
| | | | | | | | | | | | | | | | | | | | | The logic for when to prepend a null byte to integers was reversed. Fortunately, this had no impact on anything, because: a) We ignore the null byte on the parse side because we know the integers we're interested in are always unsigned. b) It appears openssl does the same thing (I tried it both ways and it always came up with the same private key data). Still, better to be correct. Also, re-enable previously disabled unit tests. BUG=14640 Review URL: http://codereview.chromium.org/131095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18855 0039d316-1c4b-4281-b951-d872f2087c98
* Don't grant unnecessary handle privileges in OpenProcessHandle.phajdan.jr@chromium.org2009-06-191-5/+4
| | | | | | | | | This patch makes it harder for process handles with more privileges to leak to untrusted places. Review URL: http://codereview.chromium.org/125260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile on Jaunty.thestig@chromium.org2009-06-181-0/+1
| | | | | | | | | BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/132011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18684 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc. Take 2.willchan@chromium.org2009-06-181-0/+1
| | | | | | | | | | Relands r18641, original code review: http://codereview.chromium.org/125268 Expect a crash on Windows. The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1. Review URL: http://codereview.chromium.org/131007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move SyncIPC function from Skia to base.agl@chromium.org2009-06-182-0/+65
| | | | | | | | | I'll be needing in some pending WebKit changes. http://codereview.chromium.org/131006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18676 0039d316-1c4b-4281-b951-d872f2087c98
* linux: NULL-initialize an array.evan@chromium.org2009-06-181-32/+34
| | | | | | | | | | A guess at fixing a crash seen by users. BUG=14483 Review URL: http://codereview.chromium.org/132001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18673 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18641: "Linux: Enable metrics_service_uitest.cc."willchan@chromium.org2009-06-171-1/+0
| | | | | | | | Broke ui_tests. Review URL: http://codereview.chromium.org/125268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18646 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc.willchan@chromium.org2009-06-171-0/+1
| | | | | | | | | Add support for zygotes to call DidProcessCrash on renderers. TEST=metrics_server_uitest.cc Review URL: http://codereview.chromium.org/126264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18641 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently use int64 for integers holding number of milliseconds.phajdan.jr@chromium.org2009-06-175-22/+21
| | | | | | | | | | This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Review URL: http://codereview.chromium.org/126279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StatsTable::RegisterThread so that it doesn't crash if shared memoryevan@chromium.org2009-06-162-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | couldn't be allocated. Instead, it just returns 0. Also, fix StatsTable::AddCounter so that it's not a fatal error if shared memory couldn't be allocated. Instead, it just returns 0. In StatsTableTest::StatsCounter, we now assert that the counter could be created, rather than just expecting it. Much of the remainder of the test relies on the fact that foo.Pointer() is non-NULL, and would crash if it were NULL. TEST= StatsTableTest.* RenderViewTest.* Didn't test on Linux (still figuring out how to build on that plaform). Instead, tested on Mac OS X by modifying StatsTablePrivate::New to return NULL, and then ran: unit_tests --gtest_filter='Render*' base_unittests --gtest_filter='StatsTableTest.*' Both tests tests crashed. Then, I applied the changes in this CL, reran the tests, and verified the crashing no longer occured. BUG=13193 BUG=13196 Review URL: http://codereview.chromium.org/126100 Patch from Neil Rhodes <nrhodes@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18527 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: GCC 4.4 fix.agl@chromium.org2009-06-151-0/+3
| | | | | | | http://codereview.chromium.org/126149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18419 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add support for chrooted renderers.agl@chromium.org2009-06-151-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxSandboxIPC Without filesystem access from the renderers, we need another way of dealing with fontconfig and font loading. This add support for: * An "SBX_D" environment variable in the renderers which is used to signal the end of dynamic linking so that the chroot can be enforced. * A sandbox_host process, running outside the sandbox, to deal with fontconfig requests from the renderers. See the wiki page for the reasoning behind making it a separate process. * A new, custom SkFontHost for Skia. Because this is Chrome specific, it will live outside the upstream Skia tree. This FontHost can be configured either to drive fontconfig directly (for the browser process and for any unsandboxed renderers) or to use an IPC system. Since the same SkFontHost has to be linked into both the browser and renderer (they are the same binary), this switch has to be made at run time. Sandbox IPC calls are rare (a couple of dozen at page load time) and add about 50us of overhead for each call. (Reland of r17575 which was reverted in r17577) http://codereview.chromium.org/112074 BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the GLib message pump.deanm@chromium.org2009-06-153-10/+555
| | | | | | | | | | | This CL also adds a few comment updates that were lost in CL 115812 submission. Patch by Antoine Labour. Review URL: http://codereview.chromium.org/118155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18379 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the PlatformContext layer to have only one class.brettw@chromium.org2009-06-142-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Previously we had three classes of PlatformCanvas*, one for each platform. Then we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the specific platform. This means that it was almost impossible to forward-declare PlatformCanvas and there were a bunch of unnecessary includes of platform_canvas.h in header files. This change makes there be only one platform_canvas.h header with ifdefs, which removes a decent amount of duplicated code. There is a platform-independent file, and one platform-dependent file of platform_canvas for each platform. I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in this case I kept the separate headers since there was much less overlap. I also broke out CanvasPaint into separate headers so this template doesn't need to be included all over the project (only a couple of files actually need it). Review URL: http://codereview.chromium.org/125109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
* Include sys/types.h for ssize_t. This fixes compliation with gcc-4.3.darin@chromium.org2009-06-132-1/+1
| | | | | | | | | Patch contributed by Joel Stanley R=deanm Review URL: http://codereview.chromium.org/125097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18356 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file descriptor exhaustions a little more gracefully. This prevents ↵stuartmorgan@chromium.org2009-06-121-1/+8
| | | | | | | | | | the browser itself from crashing in Intl2 page cycler tests on the Mac (although the renderer still dies, at least in debug), so that seems like a good idea whatever larger solution we find for the file descriptor issue. TEST=none BUG=none Review URL: http://codereview.chromium.org/125024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18318 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-1214-1074/+246
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram count of number of command line argumentsjar@chromium.org2009-06-121-0/+3
| | | | | | | | | | This should help us evaluate which users are manually switching on non-standard options, which in turn may impact stability. r=huanr Review URL: http://codereview.chromium.org/126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18281 0039d316-1c4b-4281-b951-d872f2087c98
* Update the comments on why these really can't be done, and remove the notimpls.thomasvl@chromium.org2009-06-121-10/+11
| | | | | | Review URL: http://codereview.chromium.org/126011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18268 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix icon theme double free on shutdown by eliminating dupes from icon ↵estade@chromium.org2009-06-111-0/+10
| | | | | | | | | | theme array. Simplify some code in DownloadItemGtk that I previously thought was related to the crash, and so had made complicated. Review URL: http://codereview.chromium.org/124001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18222 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize an empty password for NSS databases (so that the databaseswtc@chromium.org2009-06-111-0/+11
| | | | | | | | | | | won't require login) if the password hasn't been initialized yet. R=ukai BUG=http://crbug.com/13699 TEST=none Review URL: http://codereview.chromium.org/119381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18185 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18159 since it wasn't using all the data it should be.thomasvl@chromium.org2009-06-112-46/+8
| | | | | | | | | TEST=none BUG=none TBR=mark Review URL: http://codereview.chromium.org/123016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18160 0039d316-1c4b-4281-b951-d872f2087c98
* Some basic memory api support that is needed for perf tests and i think the ↵thomasvl@chromium.org2009-06-112-8/+46
| | | | | | | | | | task window. BUG=none TEST=perf bots should have memory numbers now like linux. Review URL: http://codereview.chromium.org/118436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18159 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-102-0/+5
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18109, 18111: Windows UI tests failed.agl@chromium.org2009-06-1014-246/+1074
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: build fix; false-positive GCC warning.agl@chromium.org2009-06-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18111 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-1014-1074/+246
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: read subprocess output before waiting for termination.agl@chromium.org2009-06-101-8/+7
| | | | | | | | | | | | | Previously, GetAppOutput was designed only for fuser. However, it appears that Mac is using it to read the output of ps: which outputs rather more. In this case, ps can fill up the pipe buffer while we are waiting for it to exit, leading to deadlock depending on how many other process are running on the system at the time. http://codereview.chromium.org/118514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18068 0039d316-1c4b-4281-b951-d872f2087c98
* Liberalize the size limits in the PNG decoder to match the changes landed ↵pkasting@chromium.org2009-06-091-5/+7
| | | | | | | | | | upstream to all the WebKit image decoders. I'm not sure where this is used, hence no test. BUG=3643 TEST=none Review URL: http://codereview.chromium.org/118462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17988 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-05 02:57:54 +0000