summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Fix compile on Jaunty.thestig@chromium.org2009-06-181-0/+1
| | | | | | | | | BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/132011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18684 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc. Take 2.willchan@chromium.org2009-06-181-0/+1
| | | | | | | | | | Relands r18641, original code review: http://codereview.chromium.org/125268 Expect a crash on Windows. The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1. Review URL: http://codereview.chromium.org/131007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move SyncIPC function from Skia to base.agl@chromium.org2009-06-182-0/+65
| | | | | | | | | I'll be needing in some pending WebKit changes. http://codereview.chromium.org/131006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18676 0039d316-1c4b-4281-b951-d872f2087c98
* linux: NULL-initialize an array.evan@chromium.org2009-06-181-32/+34
| | | | | | | | | | A guess at fixing a crash seen by users. BUG=14483 Review URL: http://codereview.chromium.org/132001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18673 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18641: "Linux: Enable metrics_service_uitest.cc."willchan@chromium.org2009-06-171-1/+0
| | | | | | | | Broke ui_tests. Review URL: http://codereview.chromium.org/125268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18646 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc.willchan@chromium.org2009-06-171-0/+1
| | | | | | | | | Add support for zygotes to call DidProcessCrash on renderers. TEST=metrics_server_uitest.cc Review URL: http://codereview.chromium.org/126264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18641 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently use int64 for integers holding number of milliseconds.phajdan.jr@chromium.org2009-06-175-22/+21
| | | | | | | | | | This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Review URL: http://codereview.chromium.org/126279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StatsTable::RegisterThread so that it doesn't crash if shared memoryevan@chromium.org2009-06-162-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | couldn't be allocated. Instead, it just returns 0. Also, fix StatsTable::AddCounter so that it's not a fatal error if shared memory couldn't be allocated. Instead, it just returns 0. In StatsTableTest::StatsCounter, we now assert that the counter could be created, rather than just expecting it. Much of the remainder of the test relies on the fact that foo.Pointer() is non-NULL, and would crash if it were NULL. TEST= StatsTableTest.* RenderViewTest.* Didn't test on Linux (still figuring out how to build on that plaform). Instead, tested on Mac OS X by modifying StatsTablePrivate::New to return NULL, and then ran: unit_tests --gtest_filter='Render*' base_unittests --gtest_filter='StatsTableTest.*' Both tests tests crashed. Then, I applied the changes in this CL, reran the tests, and verified the crashing no longer occured. BUG=13193 BUG=13196 Review URL: http://codereview.chromium.org/126100 Patch from Neil Rhodes <nrhodes@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18527 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: GCC 4.4 fix.agl@chromium.org2009-06-151-0/+3
| | | | | | | http://codereview.chromium.org/126149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18419 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add support for chrooted renderers.agl@chromium.org2009-06-151-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxSandboxIPC Without filesystem access from the renderers, we need another way of dealing with fontconfig and font loading. This add support for: * An "SBX_D" environment variable in the renderers which is used to signal the end of dynamic linking so that the chroot can be enforced. * A sandbox_host process, running outside the sandbox, to deal with fontconfig requests from the renderers. See the wiki page for the reasoning behind making it a separate process. * A new, custom SkFontHost for Skia. Because this is Chrome specific, it will live outside the upstream Skia tree. This FontHost can be configured either to drive fontconfig directly (for the browser process and for any unsandboxed renderers) or to use an IPC system. Since the same SkFontHost has to be linked into both the browser and renderer (they are the same binary), this switch has to be made at run time. Sandbox IPC calls are rare (a couple of dozen at page load time) and add about 50us of overhead for each call. (Reland of r17575 which was reverted in r17577) http://codereview.chromium.org/112074 BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the GLib message pump.deanm@chromium.org2009-06-153-10/+555
| | | | | | | | | | | This CL also adds a few comment updates that were lost in CL 115812 submission. Patch by Antoine Labour. Review URL: http://codereview.chromium.org/118155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18379 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the PlatformContext layer to have only one class.brettw@chromium.org2009-06-142-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Previously we had three classes of PlatformCanvas*, one for each platform. Then we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the specific platform. This means that it was almost impossible to forward-declare PlatformCanvas and there were a bunch of unnecessary includes of platform_canvas.h in header files. This change makes there be only one platform_canvas.h header with ifdefs, which removes a decent amount of duplicated code. There is a platform-independent file, and one platform-dependent file of platform_canvas for each platform. I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in this case I kept the separate headers since there was much less overlap. I also broke out CanvasPaint into separate headers so this template doesn't need to be included all over the project (only a couple of files actually need it). Review URL: http://codereview.chromium.org/125109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
* Include sys/types.h for ssize_t. This fixes compliation with gcc-4.3.darin@chromium.org2009-06-132-1/+1
| | | | | | | | | Patch contributed by Joel Stanley R=deanm Review URL: http://codereview.chromium.org/125097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18356 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file descriptor exhaustions a little more gracefully. This prevents ↵stuartmorgan@chromium.org2009-06-121-1/+8
| | | | | | | | | | the browser itself from crashing in Intl2 page cycler tests on the Mac (although the renderer still dies, at least in debug), so that seems like a good idea whatever larger solution we find for the file descriptor issue. TEST=none BUG=none Review URL: http://codereview.chromium.org/125024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18318 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-1214-1074/+246
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram count of number of command line argumentsjar@chromium.org2009-06-121-0/+3
| | | | | | | | | | This should help us evaluate which users are manually switching on non-standard options, which in turn may impact stability. r=huanr Review URL: http://codereview.chromium.org/126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18281 0039d316-1c4b-4281-b951-d872f2087c98
* Update the comments on why these really can't be done, and remove the notimpls.thomasvl@chromium.org2009-06-121-10/+11
| | | | | | Review URL: http://codereview.chromium.org/126011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18268 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix icon theme double free on shutdown by eliminating dupes from icon ↵estade@chromium.org2009-06-111-0/+10
| | | | | | | | | | theme array. Simplify some code in DownloadItemGtk that I previously thought was related to the crash, and so had made complicated. Review URL: http://codereview.chromium.org/124001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18222 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize an empty password for NSS databases (so that the databaseswtc@chromium.org2009-06-111-0/+11
| | | | | | | | | | | won't require login) if the password hasn't been initialized yet. R=ukai BUG=http://crbug.com/13699 TEST=none Review URL: http://codereview.chromium.org/119381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18185 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18159 since it wasn't using all the data it should be.thomasvl@chromium.org2009-06-112-46/+8
| | | | | | | | | TEST=none BUG=none TBR=mark Review URL: http://codereview.chromium.org/123016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18160 0039d316-1c4b-4281-b951-d872f2087c98
* Some basic memory api support that is needed for perf tests and i think the ↵thomasvl@chromium.org2009-06-112-8/+46
| | | | | | | | | | task window. BUG=none TEST=perf bots should have memory numbers now like linux. Review URL: http://codereview.chromium.org/118436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18159 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-102-0/+5
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18109, 18111: Windows UI tests failed.agl@chromium.org2009-06-1014-246/+1074
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: build fix; false-positive GCC warning.agl@chromium.org2009-06-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18111 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-1014-1074/+246
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: read subprocess output before waiting for termination.agl@chromium.org2009-06-101-8/+7
| | | | | | | | | | | | | Previously, GetAppOutput was designed only for fuser. However, it appears that Mac is using it to read the output of ps: which outputs rather more. In this case, ps can fill up the pipe buffer while we are waiting for it to exit, leading to deadlock depending on how many other process are running on the system at the time. http://codereview.chromium.org/118514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18068 0039d316-1c4b-4281-b951-d872f2087c98
* Liberalize the size limits in the PNG decoder to match the changes landed ↵pkasting@chromium.org2009-06-091-5/+7
| | | | | | | | | | upstream to all the WebKit image decoders. I'm not sure where this is used, hence no test. BUG=3643 TEST=none Review URL: http://codereview.chromium.org/118462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17988 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stack-based class for property disabling and re-enabling screen ↵pinkerton@chromium.org2009-06-092-0/+36
| | | | | | | | | | updating without epic fail. Fixes issues where we weren't re-enabling updates in many cases which caused both jank and resize issues. BUG=13476 TEST=closing windows shouldn't have jank regardless of the # of tabs. Resizing a window shouldn't explode visually in the chrome. Review URL: http://codereview.chromium.org/119363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17956 0039d316-1c4b-4281-b951-d872f2087c98
* Make zygote mode not be the default; it screws with the valgrind bots,dkegel@google.com2009-06-091-1/+1
| | | | | | | | | | | | | | and there's a "double free or corruption" on atexit that we need valgrind for. To reenable, set ENABLE_ZYGOTE_MANAGER=1. It's going to be refactored anyway... BUG=none TEST=none Review URL: http://codereview.chromium.org/118440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17954 0039d316-1c4b-4281-b951-d872f2087c98
* Include a parent directory link in the file list for file:///somepathyuzo@chromium.org2009-06-095-19/+126
| | | | | | | | | | | | | | | Also, order files/directories lexicographically. TEST=on linux, type file:///usr/ in the address bar and make sure the contents are sorted and include an entry for '..', which is [parent directory]. On windows, type file:///C:/Users/ . BUG=12621, 12812 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17933 0039d316-1c4b-4281-b951-d872f2087c98
* Enable zygote manager by default.dkegel@google.com2009-06-087-18/+86
| | | | | | | | | | | | | | Fix broken recursion check. Make OpenFile warning less scary, indicate it's normal at start of ui tests. Make ui tests pass. Avoid generating extra code on Mac. BUG=11841 TEST=start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites. Review URL: http://codereview.chromium.org/119289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17909 0039d316-1c4b-4281-b951-d872f2087c98
* A new menu system for views.ben@chromium.org2009-06-081-0/+3
| | | | | | | | This is all the functionality needed for the page, app menus and browser system menus. Review URL: http://codereview.chromium.org/119237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17895 0039d316-1c4b-4281-b951-d872f2087c98
* Crash in a CHECK if we fail to load a data pack file. Running w/o ourtc@google.com2009-06-081-2/+4
| | | | | | | | | | | resources is crazy talk. We've had 20 crashes here from 7 users, hopefully this will gives us some more info. Review URL: http://codereview.chromium.org/118326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17869 0039d316-1c4b-4281-b951-d872f2087c98
* CloseSuperfluousFiles shouldn't close the directory it's reading fromdkegel@google.com2009-06-071-0/+3
| | | | | | | | | BUG=none TEST=none (found with strace while running e.g. ProcessUtilTest.FDRemapping) Review URL: http://codereview.chromium.org/115720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17847 0039d316-1c4b-4281-b951-d872f2087c98
* Prototype implementation of zygotes. dkegel@google.com2009-06-0613-6/+1375
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Limitations that need addressing still: - Doesn't forcibly terminate children that should have exited but haven't Enable with env var ENABLE_ZYGOTE_MANAGER=1. BUG=11841 TEST= start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites. Here's an example script to hide and unhide the .pak files (note: do not move the directory they're in, that doesn't work): #!/bin/sh chmod_all() { chmod $1 sconsbuild/Debug/chrome for path in . locales obj/chrome/app/intermediate/repack obj/global_intermediate/* themes do chmod $1 sconsbuild/Debug/$path/*.pak done } case $1 in hide) chmod_all 000 ;; show) chmod_all 755 ;; esac Review URL: http://codereview.chromium.org/115773 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17840 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in SignatureCreator and add some more tests.aa@chromium.org2009-06-063-12/+98
| | | | | | Review URL: http://codereview.chromium.org/119277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17824 0039d316-1c4b-4281-b951-d872f2087c98
* Re-Retry. This is the change from hell.glen@chromium.org2009-06-061-5/+34
| | | | | | | | | | | | | | | | | | | | | | | Revert DCHECKs to what they used to be - turns out a bunch of stuff in the code depended on input.empty() == true. --- I believe the code (with your width() * bbp fix) is correct. The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. TBR=Nick BUG=12891,12640 TEST=none Review URL: http://codereview.chromium.org/119271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert pngencoder changes.glen@chromium.org2009-06-051-36/+5
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17803 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pngencoder mac perf errors - the previous code was never actually doing ↵glen@chromium.org2009-06-051-4/+3
| | | | | | | | | | | | an input.empty() check. BUG=none TEST=none TBR=nick Review URL: http://codereview.chromium.org/118343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17801 0039d316-1c4b-4281-b951-d872f2087c98
* Retry. I believe the code (with your width() * bbp fix) is correct.glen@chromium.org2009-06-051-5/+37
| | | | | | | | | | | | | The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. BUG=12891,12640 TEST=none Review URL: http://codereview.chromium.org/118297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17792 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the browser tests to Unix.jcampan@chromium.org2009-06-055-12/+79
| | | | | | | | | | | | | The browser tests are an alternative to UI tests. They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes). In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/115896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
* openbsd: make platform_file_posix compileevan@chromium.org2009-06-051-1/+2
| | | | | | | | | | - switch errno from ENOTSUP to EOPNOTSUPP: Linux doesn't have ENOTSUP and errno.h just does 'define ENOTSUP EOPNOTSUPP', on BSD the alias is not available at all (despite POSIX specifying it) - pull in <sys/stat.h> for S_IRUSR defines Review URL: http://codereview.chromium.org/118295 Patch from Peter Valchev <pvalchev@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17749 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce SignatureCreator.aa@chromium.org2009-06-057-0/+726
| | | | | | Review URL: http://codereview.chromium.org/118277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17745 0039d316-1c4b-4281-b951-d872f2087c98
* Break up unit test to avoid internal timing interactions between parts.jar@chromium.org2009-06-052-29/+33
| | | | | | | | | | | | | | | Hopefully this will cure teh flaky problem under Valgrind. I also had to re-read my own code, and so I put in to minor changes to hopefully make it incrementally easier ot read. There should be no semantic changes caused by my coding changes, but the level of nested braces is reduced, which makes it easier ot see what is (supposed to be) going on. r=dank,phajdan Review URL: http://codereview.chromium.org/42266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17698 0039d316-1c4b-4281-b951-d872f2087c98
* sysconf(_SC_NPROCESSORS_ONLN) is not available on some POSIXevan@chromium.org2009-06-051-0/+16
| | | | | | | | | systems, use sysctl(3) for OpenBSD Review URL: http://codereview.chromium.org/118289 Patch from Peter Valchev <pvalchev@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17695 0039d316-1c4b-4281-b951-d872f2087c98
* add CollapseWhitespaceASCIIrafaelw@chromium.org2009-06-043-4/+47
| | | | | | | | R=erikkay Review URL: http://codereview.chromium.org/119199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17689 0039d316-1c4b-4281-b951-d872f2087c98
* Revert png encoder changes.glen@chromium.org2009-06-041-40/+4
| | | | | | | | | BUG=none TEST=none TBR=nick git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17688 0039d316-1c4b-4281-b951-d872f2087c98
* Twiddle some bits to get PNGEncoder to match ImageOperations. There's a ↵glen@chromium.org2009-06-041-9/+16
| | | | | | | | | | | Valgrind error that doesn't yet make sense. BUG=none TEST=none TBR=willchan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17680 0039d316-1c4b-4281-b951-d872f2087c98
* Only update files from .version templates when a file changesgk@google.com2009-06-041-11/+2
| | | | | | | | | | | | | indicates it's necessary (now that fetching the last change info is in a separate target executed every build) by getting rid of the never-built .bogus files in the rules. Update chrome/installer/installer.gyp with the new patterns. Make the use of the *_path variable names more consistent. BUG=none TEST=none Review URL: http://codereview.chromium.org/119181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17668 0039d316-1c4b-4281-b951-d872f2087c98
* On Linux, look in $HOME/.icons for mime icons as well for backwards ↵thestig@chromium.org2009-06-041-11/+14
| | | | | | | | | | compatibility. BUG=13001 TEST=Put an icon theme in $HOME/.icons, set it as the icon theme, and make sure Chromium picks it up on the download page. (May need to restart Chromium.) Review URL: http://codereview.chromium.org/119206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17667 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 02:21:27 +0000