summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Fix memory leak in corrupt JPEG decoding.thestig@chromium.org2009-05-191-2/+2
| | | | | | | BUG=10945 Review URL: http://codereview.chromium.org/113433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16352 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for breakpad not generating a minidump in certain cases on OSX.jeremy@chromium.org2009-05-191-2/+1
| | | | | | | | | | | | | | | | | | | | 1)Fix logic inversion in IsCrashReporterEnabled(). 2)Don't intercept SIGPIPE in non-branded builds since it isn't fatal. 3)Roll DEPS to pickup a bunch of Mac Breakpad fixes. When breakpad is disabled, we intercept a bunch of signals so that we can crash fast, without waiting for Apple's crash reporter. The problem was that the function we where using to test whether breakpad was enabled was wrong so we were always installing these signal handlers which where just calling exit(). By fixing the IsCrashReporterEnabled() call, we no longer install these signal handlers if Breakpad is enabled. In any case SIGPIPE is non-fatal so we remove it from the list of signals we intercept. There have been a number of fixes to the OSX version of Breakpad recently, so we pull those in as well. BUG=11929 Review URL: http://codereview.chromium.org/115493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16346 0039d316-1c4b-4281-b951-d872f2087c98
* Promotes Add/RemoveObserver to MessageLoop for linux. Becausesky@chromium.org2009-05-183-9/+29
| | | | | | | | | | | | message_loop.h now includes message_pump_glib.h I needed to update the dependencies of a couple of projects. BUG=none TEST=none Review URL: http://codereview.chromium.org/112032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16317 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SystemMonitor.* in base_unittests.phajdan.jr@chromium.org2009-05-181-1/+2
| | | | | | | | | | | | This should green the tree and is only a temporary workaround. http://crbug.com/12187 TBR=nsylvain Review URL: http://codereview.chromium.org/113542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16308 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in ResourceDispatcherhclam@chromium.org2009-05-183-0/+15
| | | | | | | | | | | | When we delete a ResourceLoaderBridge before OnCompletedRequest is received, bad things happen. There's a lot of leaks at the following points: 1. OnMessageReceived ignores the message. 2. RemovePendingRequest removes it's internal deferred_message_queue. But ViewHostMsg_Resource_DataReceived is not POD. We should also close the shared memory handle inside it. Review URL: http://codereview.chromium.org/115396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16297 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add file_util::ReplaceFile and use it in ImportantFileWriter."phajdan.jr@chromium.org2009-05-183-23/+0
| | | | | | | | | | http://crbug.com/11585 TBR=stoyan Review URL: http://codereview.chromium.org/113534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16296 0039d316-1c4b-4281-b951-d872f2087c98
* Add file_util::ReplaceFile and use it in ImportantFileWriter.phajdan.jr@chromium.org2009-05-183-0/+23
| | | | | | | | | | It has more strict semantics than file_util::Move. http://crbug.com/11585 Review URL: http://codereview.chromium.org/113207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16291 0039d316-1c4b-4281-b951-d872f2087c98
* Use RTLD_DEEPBIND to make sure plugins don't use Chrome's symbols instead of ↵evan@chromium.org2009-05-181-1/+1
| | | | | | | | | their own Review URL: http://codereview.chromium.org/112030 Patch from Antoine Labour <piman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16278 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Revert "Add connected socket function to ClientSocketPool ↵willchan@chromium.org2009-05-181-7/+0
| | | | | | | | | | | and ClientSocketHandle.""" Revert "Fix a memory leak in client_socket_pool_unittest.cc." Guess I still fail. kasperl pointed out that this managed to break layout tests and some reliability tests too. Review URL: http://codereview.chromium.org/113517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16269 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add connected socket function to ClientSocketPool and ↵willchan@chromium.org2009-05-171-0/+7
| | | | | | | | | | | | ClientSocketHandle."" This reverts commit c235c719f964cc8f7f9343177ae6d5af724be6c0. Fixes a use of deleted memory by making a copy instead of keeping a reference to the deleted memory. Review URL: http://codereview.chromium.org/113512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16263 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add connected socket function to ClientSocketPool and ↵willchan@chromium.org2009-05-171-7/+0
| | | | | | | | | | ClientSocketHandle." Broke net_unittests on windows. Review URL: http://codereview.chromium.org/113510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16261 0039d316-1c4b-4281-b951-d872f2087c98
* Add connected socket function to ClientSocketPool and ClientSocketHandle.willchan@chromium.org2009-05-171-0/+7
| | | | | | | | Provide a new api in ClientSocketPool and ClientSocketHandle for clients (notably HttpNetworkTransaction) to request connected sockets, rather than having to allocate and Connect() sockets themselves. Add a bunch of tests for it. Have not begun switching clients over to using this. Review URL: http://codereview.chromium.org/99143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16260 0039d316-1c4b-4281-b951-d872f2087c98
* Add xdg mime support on Linux.thestig@chromium.org2009-05-1622-2/+5344
| | | | | | | BUG=10049 Review URL: http://codereview.chromium.org/113168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16227 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite version.sh as version.py to work better with gyp and be moresgk@google.com2009-05-151-10/+23
| | | | | | | | | generic (no hard-coded list of substitution variables, only use file names specified from the command line). Update base.gyp with the to generate file_version_info_linux.h with the new calling convention. Review URL: http://codereview.chromium.org/113432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16211 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land of earlier NTP theme patch; now with mac and linux compatibility.glen@chromium.org2009-05-153-75/+80
| | | | | | Review URL: http://codereview.chromium.org/115413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16205 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an observer callback to Linux's MessagePumpForUI.sky@chromium.org2009-05-152-0/+50
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/112029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16204 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Take download shelf and infobar close animations into account during ↵estade@chromium.org2009-05-151-3/+3
| | | | | | | | | | render view sizing. http://crbug.com/11080 Review URL: http://codereview.chromium.org/113322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16193 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Introduce lightweight version of JSON serialization.pfeldman@chromium.org2009-05-152-11/+38
| | | | | | Review URL: http://codereview.chromium.org/115397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16153 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for almost-recursive watches in Linux DirectoryWatcherphajdan.jr@chromium.org2009-05-148-117/+294
| | | | | | | | | | | | | | | | | After this patch DirectoryWatcher when asked for recursive watch will scan the subtree and add inotify watches for each subfolder, but further changes to the tree structure won't trigger adding/removing watches. Support for really recursive watches is planned. This is just to divide the work, because the task is not easy. Based on patch by Janwar Dinata <j.dinata@gmail.com> reviewed at http://codereview.chromium.org/92151 http://crbug.com/8968 Review URL: http://codereview.chromium.org/115229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16070 0039d316-1c4b-4281-b951-d872f2087c98
* During shutdown delete any pending tasks if running under Valgrind.kuchhal@chromium.org2009-05-143-1/+3940
| | | | | | | | | BUG=10755 Review URL: http://codereview.chromium.org/115328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16060 0039d316-1c4b-4281-b951-d872f2087c98
* Add match count text to the GTK find bar. This also makes the bar wider.brettw@chromium.org2009-05-142-0/+5
| | | | | | | | | | | | | | | | The match count text doesn't currently show up realiably because the data in the find reply is bad. I believe this is bug 11761. The clicker checking code has been moved to the cross-platform FindBarController so it doesn't have to be duplicated for each platform. This also add IntToString16. I didnt add all the variants now. The *Wstring versions should all eventually be changed to string16. http://crbug.com/11750 Review URL: http://codereview.chromium.org/114023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16058 0039d316-1c4b-4281-b951-d872f2087c98
* Extract Windows-specific parts of TaskManager.phajdan.jr@chromium.org2009-05-141-0/+10
| | | | | | | | | | | | | | - task_manager.cc compiles on POSIX - task_manager_unittest.cc passes on Linux - stub TaskManagerViewImpl for Linux (so that the unit test can pass) TEST=Task manager should not be obviously broken on Windows. http://crbug.com/11461 Review URL: http://codereview.chromium.org/115295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15832 since this test is finished.hbono@chromium.org2009-05-142-26/+0
| | | | | | | BUG=11046 "Need to back out hbono's test fix" Review URL: http://codereview.chromium.org/112021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16047 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r16006.estade@chromium.org2009-05-142-0/+10
| | | | | | Review URL: http://codereview.chromium.org/113369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16025 0039d316-1c4b-4281-b951-d872f2087c98
* Undo 16020glen@chromium.org2009-05-143-79/+74
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16021 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the new tab page to be themed (you may want to review DOMUIThemeSource ↵glen@chromium.org2009-05-143-74/+79
| | | | | | | | | | | | | as a whole and not just these changes). Change global std::strings to chars* in browser theme provider. Add ability for ReplaceStringPlaceHolder to take up to 9 replacements. BUG=11235,11685 Review URL: http://codereview.chromium.org/115172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16020 0039d316-1c4b-4281-b951-d872f2087c98
* revert r16006 due to msvc warning.estade@chromium.org2009-05-132-10/+0
| | | | | | | | TBR=playmobil Review URL: http://codereview.chromium.org/113367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16007 0039d316-1c4b-4281-b951-d872f2087c98
* Properly convert from UTF8 to UTF16 in WebTextInputImpl.estade@chromium.org2009-05-132-0/+10
| | | | | | | | | String util changes by darin@chromium.org. BUG=11699 Review URL: http://codereview.chromium.org/115215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a dependency problem in base.gyp, so that file_version_info_linux.hphajdan.jr@chromium.org2009-05-131-0/+4
| | | | | | | | is generated before it is used. Review URL: http://codereview.chromium.org/113256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15960 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the explicit keyword from the ScopedComPtr constructor so it can be ↵maruel@chromium.org2009-05-132-1/+46
| | | | | | | | included in a STL container. Review URL: http://codereview.chromium.org/115247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15958 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-135-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Use thread-safe localtime_r instead of localtime.thestig@chromium.org2009-05-131-4/+4
| | | | | | | BUG=11588 Review URL: http://codereview.chromium.org/115272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15922 0039d316-1c4b-4281-b951-d872f2087c98
* posix: directories should only be readable by the user.evan@chromium.org2009-05-122-4/+3
| | | | | | | | | | | | | Almost all the data we store is private, so we shouldn't even allow it to be group-readable. Note that files still obey the user's umask and if someone wants to make their download directory world-readable we won't undo that. BUG=11776 Review URL: http://codereview.chromium.org/113287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15890 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental fix for Issue 11046.hbono@chromium.org2009-05-122-0/+26
| | | | | | | | | This change replaces some ImmAssociateContextEx() calls with a LoadLibrary() call and a GetProcAddress() call to prevent Chrome from loading "imm32.dll" on a PC which doesn't have valid "imm32.dll" installed. (Since I have not been able to reproduce this issue on my XP box, this is just a blind fix.) BUG=11046 "repeated crash on launch" Review URL: http://codereview.chromium.org/113096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15832 0039d316-1c4b-4281-b951-d872f2087c98
* Add new tab startup test to the linux & mac build.tc@google.com2009-05-121-2/+1
| | | | | | | Review URL: http://codereview.chromium.org/113229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15818 0039d316-1c4b-4281-b951-d872f2087c98
* Add memory stats for linux page cycler. On linux, we collecttc@google.com2009-05-114-3/+83
| | | | | | | | | the final RSS size and the total VM size. Review URL: http://codereview.chromium.org/113217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15814 0039d316-1c4b-4281-b951-d872f2087c98
* Remove executable bit from a bunch of files that shouldn't have it.evan@chromium.org2009-05-118-0/+0
| | | | | | | | | | (No code change.) git ls-tree -r HEAD | grep '^100755' | cut -f2 | egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' | xargs chmod a-x git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15809 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the popup blocking whitelist pref. This makes the whitelist ↵pkasting@chromium.org2009-05-092-18/+17
| | | | | | | | actually function.BUG=11440 Review URL: http://codereview.chromium.org/115149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15702 0039d316-1c4b-4281-b951-d872f2087c98
* Make Windows DirectoryWatcher also notify on directory operations (creation, ↵phajdan.jr@chromium.org2009-05-082-4/+2
| | | | | | | | | | | | etc). TEST=DirectoryWatcherTest.* from base_unittests should pass on Windows. http://crbug.com/11581 Review URL: http://codereview.chromium.org/115126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15637 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist test that crashes occasionally under Valgrind (and Purify).dkegel@google.com2009-05-071-0/+4
| | | | | | Review URL: http://codereview.chromium.org/115101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15581 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BreakDebugger for ARM.deanm@chromium.org2009-05-071-2/+4
| | | | | | | Review URL: http://codereview.chromium.org/115087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15548 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where we were inadvertently closing Valgrind-owned FDsrohitrao@chromium.org2009-05-061-23/+30
| | | | | | | | | | | when running under Valgrind. TEST=None http://crbug.com/11412 Review URL: http://codereview.chromium.org/108042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15414 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the key setting code in the constructor of HMAC class into the Initwtc@chromium.org2009-05-055-22/+100
| | | | | | | | | | | | | | | | | | method. Overload the Init method for char* and std::string. Add DCHECKs to the destruction methods in ~HMAC in hmac_win.cc. The patch is written by Takeshi Yoshino <tyoshino@google.com>. Original code review: http://codereview.chromium.org/88062 R=wtc http://crbug.com/2297 TEST=base_unittests should pass. Safe browsing should continue to work. Review URL: http://codereview.chromium.org/113001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15353 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang in DirectoryWatcherTest.WatchCreatedDirectory on Windows.phajdan.jr@chromium.org2009-05-051-2/+4
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/109008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15288 0039d316-1c4b-4281-b951-d872f2087c98
* Add more tests for recursive DirectoryWatcher watches.phajdan.jr@chromium.org2009-05-051-30/+114
| | | | | | Review URL: http://codereview.chromium.org/100346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15283 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-053-0/+504
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/99349 for Ryan.sky@chromium.org2009-05-042-0/+11
| | | | | | | | | | | | | | Comments from Ryan: Some small changes to get chromium building on ARM. I tested these using the standard Linux tool chain and crosstools-ng. BUG=none TEST=none Review URL: http://codereview.chromium.org/99365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15241 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r15232 with a warnings fix:tc@google.com2009-05-043-670/+1399
| | | | | | | | | | | | | | | | | | | Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc This should fix the gcc 4.4. strict aliasing issues. More info here: http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html Also update gcc_warnings.patch to match. BUG=9104 Original change by Craig Schlenter via http://codereview.chromium.org/99315 Review URL: http://codereview.chromium.org/99367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15236 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc"tc@google.com2009-05-043-1390/+670
| | | | | | | | | This reverts commit r15232. Review URL: http://codereview.chromium.org/99366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15233 0039d316-1c4b-4281-b951-d872f2087c98
* Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cctc@google.com2009-05-043-670/+1390
| | | | | | | | | | | | | | | | | This should fix the gcc 4.4. strict aliasing issues. More info here: http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html Also update gcc_warnings.patch to match. BUG=9104 Original change by Craig Schlenter <craig.schlenter@gmail.com> via http://codereview.chromium.org/99315 Review URL: http://codereview.chromium.org/99364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15232 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 22:12:33 +0000