| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allocator (instead of TCMalloc)
Force the default to change for the browser, and the default
to change for all subprocesses (such as the renderer).
TBB=laforge
Review URL: https://chromiumcodereview.appspot.com/9730012
TBR=jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9739001
TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9756003
TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9828001
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@128065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(instead of TCMalloc)
Force the default to change for the browser, and the default
to change for all subprocesses (such as the renderer).
TBB=laforge
Review URL: https://chromiumcodereview.appspot.com/9730012
TBR=jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9739001
TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9756003
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@127700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Force the default to change for the browser, and the default
to change for all subprocesses (such as the renderer).
TBB=laforge
Review URL: https://chromiumcodereview.appspot.com/9730012
TBR=jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9739001
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@127578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Force the default to change for the browser, and the default
to change for all subprocesses (such as the renderer).
TBB=laforge
Review URL: https://chromiumcodereview.appspot.com/9730012
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@127535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NVIDIA/Intel GPU
MacBook Pros by forcing Chrome to use and stay on the discrete GPU on
such systems.
BUG=113703
TEST=ran Gmail and WebGL demos on dual NVIDIA/Intel and AMD/Intel GPU MBPs
Review URL: http://codereview.chromium.org/9365066
TBR=kbr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9414021
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@122353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make NULL dereference crashes more obvious. Also matches scoped_ptr (which uses assert) and weak_ptr (which uses DCHECK).
DCHECK wasn't used because it pulls in logging.h, and that somehow conflicts with a webkit #define of LOG.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9232069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Various places in the code use NOTIMPLEMENTED() with << "message" like
the other logging macros; this doesn't work when NOTIMPLEMENTED expands
to a semicolon. Expand it to EAT_STREAM_PARAMETERS instead so any
parameters are simply compiled away in this case.
Review URL: http://codereview.chromium.org/9244006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
introducing static initializers.
Member variables can stay TLS::Slots and their behavior doesn't change.
Static instances use TLS::StaticSlot instead.
Kind of like http://codereview.chromium.org/8491043 but for TLS.
BUG=none
TEST=none
TBR=agl
Review URL: https://chromiumcodereview.appspot.com/9297010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119540
Review URL: http://codereview.chromium.org/9296002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't warn about an extra ; in a class definition
BUG=111583
Review URL: http://codereview.chromium.org/9121034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compile error in webrequest_api.cc.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9296002
TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9296027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a per-process ETW session name, and a per-test provider GUID to avoid name collisions under test sharding on trybots.
R=thakis@chromium.org,jar@chromium.org
BUG=111240
TEST=No more spurious failures on trybots.
Review URL: http://codereview.chromium.org/9288075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105513
TEST=This is one.
Review URL: http://codereview.chromium.org/9193024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9296002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=binji
Review URL: https://chromiumcodereview.appspot.com/9271061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead
BUG=109779
Review URL: https://chromiumcodereview.appspot.com/9223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9235084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mad
BUG=none
TEST=linux bot compiles without warning
Review URL: https://chromiumcodereview.appspot.com/9296008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
selected group ID.
Also returns the list of UIDs of all currently running Field Trials
BUG=None
TEST=FieldTrialTest.UIDs
Review URL: https://chromiumcodereview.appspot.com/9117037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allow to easily own protocol. The syntax is:
scoped_nsobject<id<MyProtocol> > object;
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/9290046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST='JSONValueConverterTest.*'
Review URL: http://codereview.chromium.org/9289040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9233018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9113075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- I want to refactor the windows version. But first I need a test.
BUG=none
TEST=yes it is.
Review URL: http://codereview.chromium.org/9283009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting
new users.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9117038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9288012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Should be equivalent, but simpler.
Review URL: http://codereview.chromium.org/9235021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, blocking SyncSocket operations can not be unblocked from other threads, but this is now supported by using the CancelableSyncSocket class.
The implementation on Mac and Linux is very simple and basically consists of adding a call to shutdown().
On Windows however things are a tiny bit more complex since we use named pipes with synchronous IO and canceling synchronous IO is simply not possible on XP and arguably tricky on Vista+. So, what we do instead is to use asynchronous IO in a synchronous fashion to support the SyncSocket semantics and as well as allowing the connection to be correctly shut down from another thread.
Review URL: https://chromiumcodereview.appspot.com/8965053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert some instances of [NSBundle mainBundle] to equivalent calls in base/mac/bundle_locations.h
BUG=None
TEST=Code should compile and all unit tests should pass.
Review URL: http://codereview.chromium.org/9240004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove unused TRACE_EVENT_API_ADD_COUNTER_EVENT and improve comments in trace_event.h.
Review URL: http://codereview.chromium.org/9234007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new PassAs<>() method can be used to explicitly upcast scoped_ptr instances.
Review URL: http://codereview.chromium.org/9283028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We won't build in -fstrict-aliasing mode anyway, so there's little
point putting it behind a flag. Anyone who wanted to experiment
with this could just as well edit the build file directly.
BUG=32204
Review URL: http://codereview.chromium.org/9117017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
mach_thread_self().
BUG=105513
TEST=none
Review URL: http://codereview.chromium.org/9281011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converted the first 20 or so hits for LeakyLazyInstanceTraits on codesearch to
demonstrate the benefit at callsites. The real change is base/lazy_instance.h;
everything else is example.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9192024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No new features here, this is just a code split and API glue.
(Good news! I copied over trace_event.h to WebKit and verified that this all works!)
Review URL: https://chromiumcodereview.appspot.com/9213013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No functionality change.
BUG=82385
TEST=none
Review URL: http://codereview.chromium.org/9200009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
match other platforms.
consequentially, in browser tests, add PROCESS_QUERY_INFORMATION to
the rights requested when opening a child serviceprocess handle so the
exit code can be queried.
BUG=106234
TEST=Ran base_unittests.exe --gtest_filter="ProcessUtilTest.SpawnChild" with the child custom-tweaked to fail and verified that prior to my change (with HEAD) the failure is NOT detected and the test passes; with this change the failure is detected.
Review URL: http://codereview.chromium.org/8964004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to expose crosh process to hterm (if pseudo terminal used for
communication between terminalPrivateApi and crosh process is not controlling, job
control in the crosh process won't work, and it won't be able to e.g. process signals).
TEST=None
BUG=chromium-os:23273
Review URL: https://chromiumcodereview.appspot.com/9176013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110651
TEST=
Review URL: https://chromiumcodereview.appspot.com/9159005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=nacl_integration goes green
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/9195035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedVector move-only.
Also:
* Add a lot of documentation explaining what this macro does.
* Change the implementation of RValue so it cannot be instantiated.
The change to always use RValue& makes for more efficent code in debug builds. Looking at the disassembly for a simple use case (calling a function with one parameter), it removes the creation of one temporary.
BUG=96118
TEST=new unittests. exist code still compiles.
Review URL: https://chromiumcodereview.appspot.com/9207021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove MainAppBundle() in favor of FrameworkBundle() and update all callsites + code comments.
BUG=None
TEST=Code should compile and all unit tests should pass.
Review URL: https://chromiumcodereview.appspot.com/9220005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initial transition steps, trying to do this in small steps so it's easier to review.
foundation_util.h:
* Remove SetOverride*() methods and modify all callsites to use bundle_location.h version.
* MainAppBundle() - call through to bundle_location version as an interim step.
* Rename PathForFrameworkBundleResource() and modify callers.
* Remove one instance of [NSBundle mainBundle].
BUG=None
TEST=Chrome/Mac should launch correctly and all unit tests should pass.
Review URL: http://codereview.chromium.org/9187053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
[re-land of 116816 http://codereview.chromium.org/9065009]
This does some refactoring of the static data in the browser thread so we only have one global object instead of a bunch fo separate arrays.
It also hooks up the visited link master's I/O to use this new system as a proof of concept.
Review URL: https://chromiumcodereview.appspot.com/9124033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Security-wise no change, we could do this already for a different prefix (chrome.nacl)
- Improve the sync socket as not to have silly infinite loop.
BUG=103975,103985
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/9252003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocking UI thread during Watchdog thread join.
StartupTimebomb deletes the startup_watchdog thread only if
it is joinable. This fixes the case when UI thread is blocked
until watchdog thread finishes generating the dump. StartupTimebomb
keeps calling IsJoinable on startup_watchdog thread every 10 secs
until it is joinable until it is deleted.
The delete method calls Cleanup to set the state to SHUTDOWN
for backward compatability.
BUG=110055
R=jar
TEST=base unit tests and browser ui and unit tests.
Review URL: http://codereview.chromium.org/9173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110555
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252014
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9250014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=110555
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9252014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+rvargas, who understands the code
+brettw, who is in OWNERS
BUG=109577
TEST=FileUtilTest.DevicePathToDriveLetter
Review URL: http://codereview.chromium.org/9167004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed to make net_unittests link.
Does not reference JNI so it was improperly excluded.
BUG=None
TEST=
Review URL: https://chromiumcodereview.appspot.com/9242023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117959 0039d316-1c4b-4281-b951-d872f2087c98
|