| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and paths we'll use in gyp-generated files.
Review URL: http://codereview.chromium.org/56158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is a preparation to land http://codereview.chromium.org/54003,
which replaces chrome_process_filter with more portable chrome_process_util.
Review URL: http://codereview.chromium.org/57062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/57078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/57051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/string16.h uses EOF thus #include <stdio.h>
net/disk_cache/trace.cc uses vsnprintf thus #include <stdio.h>
Patch by Craig Schlenter <craig.schlenter@gmail.com>
Review URL: http://codereview.chromium.org/46092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
added getTabsForWindow() to drive it.
Review URL: http://codereview.chromium.org/42680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, one can close a HANDLE which is currently being waited on. The MSDN
documentation says that the resulting behaviour is 'undefined', but it doesn't
crash. Currently, on POSIX, one couldn't use WaitableEventWatcher to watch an
event which gets deleted. This mismatch has bitten us several times now.
This patch allows WaitableEvents to be deleted while a WaitableEventWatcher is
still watching them. It applies only to watchers, the usual Wait() and
WaitMany() calls still require that all their target be valid until the end of
the call.
http://crbug.com/8809
Review URL: http://codereview.chromium.org/53026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
breakpad_mac.mm still needs some work, there's a bunch of scaffolding in there referring to a custom version of Breakpad I've got going locally.
Review URL: http://codereview.chromium.org/53075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance).
- Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome.
Review URL: http://codereview.chromium.org/49035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the ScopedVariant and a couple of new constructors for IDispatch and IUnknown. includes tests.
Review URL: http://codereview.chromium.org/42569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Writing a bitmap to the clipboard is a rather slow operation, as it involves piping it over IPC and then converting it to a PNG.
Review URL: http://codereview.chromium.org/42592
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- make more things const
- remove unreferenced declaration of GetGoButton
- fix indentation in one place
Review URL: http://codereview.chromium.org/53053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r12459 - it broke the world.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, one can close a HANDLE which is currently being waited on. The MSDN
documentation says that the resulting behaviour is 'undefined', but it doesn't
crash. Currently, on POSIX, one couldn't use WaitableEventWatcher to watch an
event which gets deleted. This mismatch has bitten us several times now.
This patch allows WaitableEvents to be deleted while a WaitableEventWatcher is
still watching them. It applies only to watchers, the usual Wait() and
WaitMany() calls still require that all their target be valid until the end of
the call.
http://crbug.com/8809
Review URL: http://codereview.chromium.org/53026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This lets you use regular full-optimization Release builds.
Review URL: http://codereview.chromium.org/53022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
needed.
Review URL: http://codereview.chromium.org/39102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
shared library builds and an Apple ld bug
Review URL: http://codereview.chromium.org/49023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, use chrome path calculated relative to version.sh, since the passed-in
path isn't correct on the buildbot.
Review URL: http://codereview.chromium.org/42574
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
There is no real change in functionality.
Review URL: http://codereview.chromium.org/42514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes use of, and scons-enables, the Linux version header in Issue 45028.
BUG=8132
Review URL: http://codereview.chromium.org/42542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't yet #included in file_version_info_linux.cc since we haven't
officially cutover to the gyp build.
BUG=8132
Review URL: http://codereview.chromium.org/45028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
earlier than Vista.
Review URL: http://codereview.chromium.org/42564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- enable test for it on Windows
- clean up directory_watcher_unittest.cc
http://crbug.com/5072
Review URL: http://codereview.chromium.org/42388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9197
TBR=jon
Review URL: http://codereview.chromium.org/47007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See http://crbug.com/9194
Review URL: http://codereview.chromium.org/52025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
C++ code.
Review URL: http://codereview.chromium.org/52014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is also meant to exercise the field trial infrastructure.
r=mbelshe
Review URL: http://codereview.chromium.org/50084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
type="range">.
This code will not be called until I land the upstream hooks to RenderThemeChromiumWin.cpp to use it.
BUG=8931
Review URL: http://codereview.chromium.org/42451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Linux settings to target_defaults in common.gypi so
gyp-generated SConscript files no longer depend on
build/SConscript.main or the Hammer infrastructure.
* Copy the FilterOut() function from Hammer to the chromium_builders.py
Tool module.
* Add a ChromiumLoadableModule() builder to chromium_builders.py.
* Add dependencies on the 'views' library to the chrome link (target 'app').
* Add missing views/*/*_unittest.cc modules to the 'unit_tests' target.
Exclude all but the one that builds on Linux from the non-Windows builds.
* Crib a list of chrome/views files to exclude from the Linux build
from the old SCons configuration.
* Add a new build/linux/system.gyp file with new 'settings' targets
to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2.
* Add depenedencies in the other targets on the new gtk, nss and
pangoft2 'settings' targets from build/linux/system.gyp.
* Add a pkg_config_wrapper.py script that keeps gyp happy by
simply exiting 0 if the package isn't found.
* DEPS roll for latest gyp changes to support the above.
Review URL: http://codereview.chromium.org/42340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=mbelshe,brettw
Review URL: http://codereview.chromium.org/50014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
more. No functional change.
Review URL: http://codereview.chromium.org/42418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Also changed Lock::AssertAcquired to be const function (it already was const, in practice, just not declared that way).
Review URL: http://codereview.chromium.org/42402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- check return value of write to self-pipe
Review URL: http://codereview.chromium.org/42403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to make nss play well with valgrind, as recommended by Wan-Teh in
http://groups.google.com/group/mozilla.dev.tech.crypto/msg/49fe8582df376d06
Set the same environment variables in chrome_test.sh/valgrind_test.py
and valgrind.sh, and explain which is which.
Review URL: http://codereview.chromium.org/42326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a kext) :)
Review URL: http://codereview.chromium.org/42391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A class for automatically freeing a COM VARIANT at the
end of a scope. Additionally provides a few functions to
make the encapsulated VARIANT easier to use.
Instead of inheriting from VARIANT, I took the containment
approach in order to have more control over the usage of the
variant and guard against memory leaks.
Review URL: http://codereview.chromium.org/46059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds. In debug builds, the method will DCHECK if the
current thread does not hold the lock.
I also removed a class that was not being used (AutoLockImpl) which seems like someone just copied the Lock.h file and blindly added
an Impl for the AutoLock class.
Thre are places in my code where I want to use the AutoUnlock class. I can't see why it was restricted to use by the condition variable
class only, so I just made it into a regular class with no restrictions.
I noticed that JamesR posted a CL about a month ago that made AutoUnlock a public class, but it was never committed, so I added him to this CL for review too.
Review URL: http://codereview.chromium.org/48109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- share more code between different platforms
- put more code inside anonymous namespace
- add more DISALLOW_COPY_AND_ASSIGNs
- small #include cleanup
Review URL: http://codereview.chromium.org/42343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes
244 bytes in 5 blocks are possibly lost in loss record 57 of 97
at operator new(unsigned int) m_replacemalloc/vg_replace_malloc.c:230
by std::string::_Rep::_S_create(unsigned int, unsigned int, std::allocator<char> const&) (in libstdc++.so.6.0.9)
by (within libstdc++.so.6.0.9)
by std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in libstdc++.so.6.0.9)
by CommandLine::CommandLine(int, char const* const*) src/base/command_line.cc:96
by CommandLine::Init(int, char const* const*) src/base/command_line.cc:177
by TestSuite::TestSuite(int, char**) src/base/test_suite.h:34
Review URL: http://codereview.chromium.org/42341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11999 0039d316-1c4b-4281-b951-d872f2087c98
|