| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4287
TEST=see bug
Review URL: http://codereview.chromium.org/10621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10848
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of test coverage, it was mis-handling the concept of idle work. This meant we were effectively polling the pump, causing full CPU usage. The new pump is greatly simplified, and follows the pattern used on Windows. All tests still pass.
Review URL: http://codereview.chromium.org/10833
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the way we capture tab thumbnail images so that
the capturing code can deal with failure.
BUG=3795
Review URL: http://codereview.chromium.org/9717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pamg
Review URL: http://codereview.chromium.org/10619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
get the process handle and PID directly from the corresponding Process object.
Review URL: http://codereview.chromium.org/10608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and deleting them for every widget drawn.
Review URL: http://codereview.chromium.org/9757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit 3bd600b37c5ee613c004c84736ee3cb69434562a.
Review URL: http://codereview.chromium.org/9774
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=4160
Review URL: http://codereview.chromium.org/9639
Patch from Paweł Hajdan jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
never building process_posix, but now the newly added unit tests use it.
Review URL: http://codereview.chromium.org/10221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9752
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
way it was written previous made it seem like it was supposed to be some sort of lock. It was just to manage acquiring the clipboard (which involves some Windows clipboard lock).
Review URL: http://codereview.chromium.org/9745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Ben's trailing whitespace. Really just want a buildbot run :\
Review URL: http://codereview.chromium.org/9730
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup the separation between MessagePumpForUI and
MessagePumpForIO, and convert the latter to use Completion
Ports instead of MsgWaitForMultipleobjects to sleep
when idle.
Remove all traces of Windows messages from MessagePumpForIO,
remove the transitional API of completion port notifications
and remove WatchObject API.
Modify all callers of RegisterIOHandler so that they are no
longer using RegisterIOContext, and also handle properly
the new semantics of completion ports (notifications even when
the IO completes immediately).
Add a new interface to allow proper cleanup of disk cache (to
replace code that was waiting for pending APCs from the destructor).
Add a way for the message pump to perform cleanup of abandoned IO.
BUG=B/1344358, 3497, 3630
TESt=unit tests
R=darin
Review URL: http://codereview.chromium.org/8156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
which is able to report allocation failures.
Review URL: http://codereview.chromium.org/9510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Skia platforms. I do this by making the calling of PlatformCanvas.initialize() able to be the same by using an evil default parameter.
Review URL: http://codereview.chromium.org/9695
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=1649
TEST=bring up bookmark manager and try out import/export from the
tools menu. Note that import ALWAYS creates a new folder under
the 'Other bookmarks folder' with the name of Imported (x). This
is by design.
Review URL: http://codereview.chromium.org/9471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2183
Review URL: http://codereview.chromium.org/8806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Initialize PAINTSTRUCT to prevent crash if BeginPaint fails.
* Sanitize width-height for empty bitmaps.
* Return failure from initialize instead of crashing at that point.
BUG=3795
Review URL: http://codereview.chromium.org/9459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make everything use ARGB order in registers (B.G.R.A order in memory on
little-endian systems)
Review URL: http://codereview.chromium.org/8227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
an infinite recursion of assertion messages during a painting error.
BUG=4139
Review URL: http://codereview.chromium.org/9608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in base, net and sandbox:
* Remove by-hand Install() and Alias() calls.
* Set $COMPONENT_PROGRAM_GROUPS and $COMPONENT_TEST_PROGRAM_GROUPS
(with in each foo\foo.scons file) so executables get added
automatically to the appropriate Alias.
* Set $TESTS_DIR and $STAGING_DIR so executables get linked
directly in their final resting place ($TARGET_ROOT).
Review URL: http://codereview.chromium.org/9188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup.
Listeners are set on the form text field in a similar fashion than for password save.
The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows.
The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown.
Review URL: http://codereview.chromium.org/8885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org
Review URL: http://codereview.chromium.org/9154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also do a little bit of the FilePath rewrite as it pertains to this test.
Review URL: http://codereview.chromium.org/9074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
existing stored pointer is NULL.
Review URL: http://codereview.chromium.org/9130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
asserting when encountering time overflow, use the most distant future or past
time representation possible. This fixes assertions that occur when handling
cookies that expire well in the future.
Review URL: http://codereview.chromium.org/8771
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we'll see if it makes a noticable impact on startup time.
Review URL: http://codereview.chromium.org/9059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=paulg
Review URL: http://codereview.chromium.org/9290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- the numbers were out of sync with result_codes.h
- can't use result_codes.h in base project so I extracted
the generic part of it.
Rahul: I hope I don't break installer assumptions here.
Dan: don't feel obligated to review.
Review URL: http://codereview.chromium.org/9012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://code.google.com/p/chromium/issues/detail?id=3661
Also change LaunchApp to check PATH,
and fixed a useful gcc-4.3 warning re operator precedence.
Review URL: http://codereview.chromium.org/7968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR mmentovai@chromium.org
Review URL: http://codereview.chromium.org/9274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also add a comment to explain the strange tls gyrations in
SlotReturnFunction.
Review URL: http://codereview.chromium.org/8972
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
times later than the UNIX epoch 32 bit rollover in 2038 (such as
cookie expirations). time_t is only 32 bits in MacOS X, so
we can't just use time_posix.cc
Review URL: http://codereview.chromium.org/9249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should increase reliability issues seen on
the bbots.
Review URL: http://codereview.chromium.org/9261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Disabled two flaky unittests.
Review URL: http://codereview.chromium.org/9258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests, but failed when all tests were run because
some tests run without a message loop. The
observer_list_threadsafe allowed AddObserver to run
with null message loops. But, if you call Notify
after doing so, then the notify call would attempt
to use the registered "null" ptr to a message loop.
This crashed, of course.
Review URL: http://codereview.chromium.org/9045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Not sure how I missed this!
Review URL: http://codereview.chromium.org/9250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sgk
Review URL: http://codereview.chromium.org/9043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4455 0039d316-1c4b-4281-b951-d872f2087c98
|