summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-291-0/+8
| | | | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27445 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-294-6/+20
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-282-14/+0
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-282-0/+14
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27397 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-281-8/+0
| | | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/235042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27400 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-281-0/+8
| | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27397 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-283-34/+8
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-283-8/+34
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove --google-internal-crash-reporting.agl@chromium.org2009-09-281-54/+0
| | | | | | | | | It's time to kill this. It's been marginally useful, but only marginally. http://codereview.chromium.org/222021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27375 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27324 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-261-8/+0
| | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Review URL: http://codereview.chromium.org/153002 TBR=bradnelson@google.com Review URL: http://codereview.chromium.org/244017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-261-0/+8
| | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-261-8/+0
| | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/244014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27317 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-261-0/+8
| | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27315 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedRunnableMethodFactory using WeakPtr.darin@chromium.org2009-09-258-238/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This required some changes to WeakPtr to support the addition of WeakPtrFactory::HasWeakPtrs(), which is used to implement ScopedRunnableMethodFactory::empty(). Now, the WeakReferenceOwner just holds a pointer to the Flag class, and the Flag holds a back-pointer that it can use to clear the WeakReferenceOwner's pointer when the Flag is destroyed. I use the null'ness of this back-pointer in place of the bool member that was previously used to indicate if the WeakReference is valid. It was also necessary to expose a HasOneRef method on RefCounted. I included one on RefCountedThreadSafe for completeness. Finally, I switched HttpCache over to using WeakPtr instead of RevocableStore so that I could delete RevocableStore. (I'm making this change to consolidate similar functionality.) R=abarth BUG=none TEST=none Review URL: http://codereview.chromium.org/235027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27287 0039d316-1c4b-4281-b951-d872f2087c98
* [Relanding erg's change with fix for toolkit_views shortcuts and jcampan@chromium.org2009-09-256-223/+701
| | | | | | | | | | | | | | | | | | | | | | | | | | | interactive ui tests. Note that this was originally reviewed in http://codereview.chromium.org/217022/show I originally Elliot suggestion of replacing the usage of int for keycode with the bae::Keycode type, but that led to the CL getting out of hands (as this is used in many different places). So this is only the patch set 1 of that CL, I'll replace the type in another CL] Use windows keycodes under linux (and all non-windows platforms). This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this wrong behaviour. Previously, keyboard_codes_linux defined all the VKEY_* constants as their GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve to windows key codes. BUG=22551 TEST=Make sure accelerators still work as expected on Chrome Linux and Chrome Linux with toolkit views. Test when the the accelerators with the focus in the location bar and also with the focus on the page. Review URL: http://codereview.chromium.org/235025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27284 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TODO comment to describe when we can remove the const_cast forwtc@chromium.org2009-09-251-0/+2
| | | | | | | | | | | the NSS function SGN_Update. R=rafaelw BUG=20669 TEST=none Review URL: http://codereview.chromium.org/218035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27163 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back Markus's CL ( http://codereview.chromium.org/196053)jshin@chromium.org2009-09-253-7/+1
| | | | | | | | | BUG=none TEST=UI test and valgrind test pass TBR=markus Review URL: http://codereview.chromium.org/222031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27160 0039d316-1c4b-4281-b951-d872f2087c98
* When converting between units of time or data types of different precision,markus@chromium.org2009-09-243-1/+7
| | | | | | | | | | | | | | | | | | | we have to be careful to consistently round in the same direction. Timeout checks usually check if Now() is less or equal to a deadline in order to determine if a timeout has occurred. This correctly handles the case where actual sleep times are equal or longer than requested sleep times. But if we round down when setting the sleep delay, this can result in unnecessary and expensive looping. Make sure, we always round up when converting to a format with less precision. BUG=none TEST=none Review URL: http://codereview.chromium.org/196053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27146 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27113, it breaks the ChomeOS build.jcampan@chromium.org2009-09-241-2/+0
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/231022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a process name setting bug that doesn't currently affect us.mdm@chromium.org2009-09-241-1/+1
| | | | | | | | | | We don't pass a format string starting with '-' to setproctitle(), but I was looking at doing that and found this small bug. BUG=none TEST=none Review URL: http://codereview.chromium.org/218033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27114 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring some of the NativeViewHost and NativeControl focus management so ↵jcampan@chromium.org2009-09-241-0/+2
| | | | | | | | | | | their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Review URL: http://codereview.chromium.org/214029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify failure codepaths of MessagePumpLibevent::WatchFileDescriptor()jeremy@chromium.org2009-09-241-21/+8
| | | | | | | | event_del is now called once if we reuse an event so there's no need to call it multiple times for each failure mode. Review URL: http://codereview.chromium.org/235007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27107 0039d316-1c4b-4281-b951-d872f2087c98
* Regression: Shift modifier on Find was reversed.finnur@chromium.org2009-09-241-3/+3
| | | | | | | | We were also not using GetKeyState correctly in win_util, as the documentation mentions. We should be looking at the high-order bit (&-ing with 0x8000, not 0x80). BUG=22849TEST=Try to use Enter during FindInPage. Notice it should search forwards when Shift key is not pressed and backwards when Shift is pressed. Review URL: http://codereview.chromium.org/218009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27074 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Linux (nss) implementations of RSAPrivateKey and SignatureCreator.rafaelw@chromium.org2009-09-246-13/+337
| | | | | | | | | | | | This relands: http://codereview.chromium.org/208032. Additionally, it fixes a memleak unconvered by valgrind, and adds a valgrind supression for a memleak discovered in the nss library. https://bugzilla.mozilla.org/show_bug.cgi?id=518443 BUG=20669 Review URL: http://codereview.chromium.org/218010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27033 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and reenable AppendRelativePathTest which was broken on Windows.mark@chromium.org2009-09-231-3/+13
| | | | | | | | | Patch by Fred Akalin <akalin@gmail.com> Review URL: http://codereview.chromium.org/205023 Review URL: http://codereview.chromium.org/209070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26968 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux (nss) implementations of RSAPrivateKey and SignatureCreator"rafaelw@chromium.org2009-09-236-337/+13
| | | | | | | | | | This reverts commit 4e0de697be80a0a91fbcceda63d3c85055f1afcc. TBR=davemoore Review URL: http://codereview.chromium.org/219013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26957 0039d316-1c4b-4281-b951-d872f2087c98
* Linux (nss) implementations of RSAPrivateKey and SignatureCreatorrafaelw@chromium.org2009-09-236-13/+337
| | | | | | | | BUG=20669 Review URL: http://codereview.chromium.org/208032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26950 0039d316-1c4b-4281-b951-d872f2087c98
* IPC & LibEvent fixjeremy@chromium.org2009-09-232-2/+19
| | | | | | | | | | | * Allow IPC::Listeners to send a message on OnChannelConnected. * Fix a bug in MessagePumpLibevent::WatchFileDescriptor causing a read-after-free. BUG=22451 Review URL: http://codereview.chromium.org/209061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26946 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26756 - "Use windows keycodes under linux (and all non-windows ↵stuartmorgan@chromium.org2009-09-224-3/+218
| | | | | | | | | | | | | | | platforms)." Caused BrowserFocusTest.FocusTraversal failures on Linux in interactive_ui_tests. TBR=erg BUG=22551 TEST=Linux interactive_ui_tests Review URL: http://codereview.chromium.org/212045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26777 0039d316-1c4b-4281-b951-d872f2087c98
* Enable LeakTracker on release builds.eroman@chromium.org2009-09-221-2/+10
| | | | | | | | | | | | | | | This is intended to be temporary, so we can get data from the dev channel on why URLRequest objects are leaking at shutdown. WARNING: it may cause a slight slowdown on page cycler. Also as part of this change, I switched the order that we check URLFetcher / URLRequest. This is simply so that if both URLFetcher and URLRequest have leaked, we will report the URLFetcher leak rather than the URLRequest leak. BUG=http://crbug.com/21199, http://crbug.com/18372 Review URL: http://codereview.chromium.org/217005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26765 0039d316-1c4b-4281-b951-d872f2087c98
* Use windows keycodes under linux (and all non-windows platforms).erg@google.com2009-09-214-218/+3
| | | | | | | | | | | | | | | | This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this wrong behaviour. Previously, keyboard_codes_linux defined all the VKEY_* constants as their GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve to windows key codes. BUG=22551 Review URL: http://codereview.chromium.org/214040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26756 0039d316-1c4b-4281-b951-d872f2087c98
* Switch application start time from Time to TimeTicks. jar@chromium.org2009-09-212-6/+5
| | | | | | | | | | This is a landing of a contribution by tfarina. See CL http://codereview.chromium.org/200038 r=tfarina Review URL: http://codereview.chromium.org/208046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26747 0039d316-1c4b-4281-b951-d872f2087c98
* Copy the leak callstacks onto the stack before crashing in ↵eroman@chromium.org2009-09-212-5/+27
| | | | | | | | | | LeakTracker::CheckForLeaks. This way if it is enabled in release builds, the mini-dump will contain the allocation stacktrace. Review URL: http://codereview.chromium.org/208001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a harmless data race in Threadtimurrrr@chromium.org2009-09-211-1/+1
| | | | | | | | | | | Currently, if StopSoon/Stop is called twice (like in ThreadTest.StopSoon) message_loop_ can be accessed simultaneously by ThreadMain():162 and in StopSoon():124. This data race is harmless since stopping_==true, so message_loop_ value is actually un-needed. I'd like to swap the conditions to avoid reading message_loop_ in case stopping_==true. This way ThreadTest.StopSoon will have no race reports under ThreadSanitizer. Currently, this is the only report on base_unittests on ThreadSanitizer linux bot. Review URL: http://codereview.chromium.org/207039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26691 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement GetCPUUsage() so the task manager shows CPUevan@chromium.org2009-09-194-6/+140
| | | | | | | | | | | | | Discussed in part here: http://groups.google.com/group/chromium-dev/browse_thread/thread/8e91f66f9af6ccec This implements option 3, which turned out to be pretty simple. BUG=19864 Review URL: http://codereview.chromium.org/215020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26647 0039d316-1c4b-4281-b951-d872f2087c98
* s/NDEBUG/NVALGRIND/g in base/dynamic_annotations.* to allowtimurrrr@chromium.org2009-09-182-11/+9
| | | | | | | | | | | | ThreadSanitizer runs on release binaries. This is a copy of http://codereview.chromium.org/201060 I wasn't a commiter at that time. Please note that http://codereview.chromium.org/195078 was submitted recently which defines NVALGRIND for non-valgrind Release builds. Review URL: http://codereview.chromium.org/195091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26576 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly compare to NULL when looking for weak_import symbols.craig.schlenter@chromium.org2009-09-181-3/+3
| | | | | | | | | | | | | | Changing the comparison form affects the warning messages generated in various circumstances. See the codereview for details. Also, Apple docs claim that !symbol comparisons will not work. Spotted by Matthew Vosburgh. Review URL: http://codereview.chromium.org/214012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26569 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing rollback in case things don't work out.bradnelson@google.com2009-09-181-8/+0
| | | | | | | | | | | This rolls back 26540, gregoryd's attempt at a nacl landing. BUG=None TEST=None Review URL: http://codereview.chromium.org/213019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
* This is a copy of http://codereview.chromium.org/153002/showgregoryd@google.com2009-09-181-0/+8
| | | | | | | | | | First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Review URL: http://codereview.chromium.org/207025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
* Add xdisplaycheck as a dependency on Linux for tests that use the UI. This ↵thestig@chromium.org2009-09-171-0/+1
| | | | | | | | | | way we don't have to explicitly build xdisplaycheck on all the bots where we run tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/207020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26487 0039d316-1c4b-4281-b951-d872f2087c98
* Use delegate protocols present in the 10.6 SDK. For previous SDKs, providemark@chromium.org2009-09-172-0/+37
| | | | | | | | | | empty protocol definitions for compatibility. BUG=20925 TEST=build Review URL: http://codereview.chromium.org/209004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26477 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress more clipboard tests in valgrind.dkegel@google.com2009-09-171-1/+1
| | | | | | | | BUG=22138 Review URL: http://codereview.chromium.org/213008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26462 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress ClipboardTest.ClearTest on valgrind as it hung the bot today (and ↵dank@chromium.org2009-09-171-1/+4
| | | | | | | | | | hung my local run two weeks ago) BUG=22138 Review URL: http://codereview.chromium.org/208006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26450 0039d316-1c4b-4281-b951-d872f2087c98
* A build fix for gcc 4.3 (and later).craig.schlenter@chromium.org2009-09-171-25/+35
| | | | | | | | | | | | Comparing a function with NULL has been prohibited since gcc 4.3 and produces a compilation error. This change encloses your code which compares a function with NULL with "#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5" and "#endif". BUG=none TEST=build chromium with gcc 4.3 (and later) Review URL: http://codereview.chromium.org/206024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26449 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r26431.craig.schlenter@chromium.org2009-09-171-6/+0
| | | | | | | | | It broke the tree which seems unrelated but Mark also wants hbono's patch landed instead of this one. Review URL: http://codereview.chromium.org/211007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26432 0039d316-1c4b-4281-b951-d872f2087c98
* Squash warnings about backtrace et. al. not being NULL on Linux.craig.schlenter@chromium.org2009-09-171-0/+6
| | | | | | | | | The warnings are legit but it seems cleaner to do this than to do tons of #if defined(OS_MACOSX) bits to handle the changes from r26285. Review URL: http://codereview.chromium.org/206026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26431 0039d316-1c4b-4281-b951-d872f2087c98
* Make WeakPtr harder to misuse.phajdan.jr@chromium.org2009-09-171-2/+20
| | | | | | | | | | | | Well, I managed to misuse it (issue caught in review), and these DCHECKS will catch it. TEST=none BUG=none Review URL: http://codereview.chromium.org/207005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26422 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FilePathTest.AppendRelativeTest from r26387.mark@chromium.org2009-09-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/194132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26390 0039d316-1c4b-4281-b951-d872f2087c98
* Make LeakTracker be enabled using ENABLE_LEAK_TRACKER, rather than NDEBUG.eroman@chromium.org2009-09-162-16/+20
| | | | | | | | This way it is easy to toggle it on in release builds. Review URL: http://codereview.chromium.org/196130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26389 0039d316-1c4b-4281-b951-d872f2087c98
* Set OS X cache directory to ~/Library/Caches/[app name]/[profile name] mark@chromium.org2009-09-166-3/+121
| | | | | | | | | | | | | - Added implementation of GetUserCacheDirectory() for OS X. - Added FilePath::GetRelativePath(). - Implemented per-profile cache directories for OS X. Patch by Fred Akalin <akalin@gmail.com> Code review URL: http://codereview.chromium.org/174053 Review URL: http://codereview.chromium.org/204043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26387 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 08:19:26 +0000