summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Invoke OnEventsDisabled before clearing the provider state to allow the ↵ericdingle@chromium.org2010-10-081-3/+3
| | | | | | | | | | | provider subclass to do last chance logging to the session. BUG=none TEST=none Review URL: http://codereview.chromium.org/3549030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62014 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Return better error messages when AmIBundled() fails. We're seeing ↵rohitrao@chromium.org2010-10-081-5/+7
| | | | | | | | | | this error on the bots, so better messages may help us track down the problem. BUG=None TEST=None Review URL: http://codereview.chromium.org/3625003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62005 0039d316-1c4b-4281-b951-d872f2087c98
* Add an OVERRIDE macro to our list of compiler-specific annotations.evan@chromium.org2010-10-081-11/+31
| | | | | | | | While I'm at it, add docs and examples to the other annotations. Review URL: http://codereview.chromium.org/3581016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61964 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: deprecate another function on non-Windowsevan@chromium.org2010-10-083-8/+9
| | | | | | | | | BUG=23581 TEST=CommandLine unit tests Review URL: http://codereview.chromium.org/3549023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61889 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove deprecated wstring APIevan@chromium.org2010-10-072-20/+10
| | | | | | | | | | | | (o3d still uses an older version of base; if they update past this change they will need to apply the change I reverted in r55433.) BUG=23581 TEST=compiles, existing tests still pass Review URL: http://codereview.chromium.org/3552011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61839 0039d316-1c4b-4281-b951-d872f2087c98
* Make ~GoogleURLChangeNotifier happen on the I/O thread.levin@chromium.org2010-10-077-5/+109
| | | | | | | | | | | | | | | | | | Also change the test code to allow for its destruction. One key problem was that the object containing WeakPtr is created on the UI thread but then always used on the I/O thread like everything else that hangs off of ResourceMessageFilter. The solution was to allow WeakPtr to detach from its thread (and automatically re-attach the next time the thread is checked). BUG=38475 TEST=base_unittest --gtest_filter=NonThread*:ThreadChecker* unit_tests --gtest_filter=SearchProviderInstallData* Review URL: http://codereview.chromium.org/3627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61836 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms to see if we can find out why we're failingtony@chromium.org2010-10-072-1/+36
| | | | | | | | | | to load resources.pak on Windows. BUG=58056 Review URL: http://codereview.chromium.org/3616007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61818 0039d316-1c4b-4281-b951-d872f2087c98
* #include <ostream> in base/string16.cc. This is required for the Mac OS X 10.6mark@chromium.org2010-10-071-0/+2
| | | | | | | | | | | SDK build. Otherwise, various bits of <ostream> that would be needed are declared but not defined. BUG=none TEST=none Review URL: http://codereview.chromium.org/3631001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61813 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 61613 that was reverted for false valgrind alarm.kinuko@chromium.org2010-10-073-59/+75
| | | | | | | | | | | | | Original issue: http://codereview.chromium.org/3567012/show BUG=none TEST=FileSystemOperationTest.* TBR=ericu,thestig Review URL: http://codereview.chromium.org/3603014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61613 - possible culprit for valgrind error. (Support ↵kinuko@chromium.org2010-10-063-75/+59
| | | | | | | | | | | removeRecursively and new copy/move) BUG=none TEST=none Review URL: http://codereview.chromium.org/3576017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61713 0039d316-1c4b-4281-b951-d872f2087c98
* fixes issue 52839 (MatchPattern timeout)andybons@chromium.org2010-10-063-0/+11
| | | | | | | | | | | | | Fixes issue 52839 by converting consecutive wildcards (******) into one wildcard (*) in MatchPattern. BUG=52839 TEST=MatchPattern Original patch from issue 3608005 (Jon Stritar) Review URL: http://codereview.chromium.org/3551016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61644 0039d316-1c4b-4281-b951-d872f2087c98
* Second try for support removeRecursively and new copy/move behaviors added ↵kinuko@chromium.org2010-10-063-59/+75
| | | | | | | | | | | | | | | | | | | | | | to the spec recently. http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html > For a move/copy of a file on top of existing file, or a directory on > top of an existing empty directory, you get an automatic overwrite. > A move/copy of a file on top of an existing directory, or of a > directory on top of an existing file, will always fail. > A move/copy of a file or directory on top of an existing non-empty > directory will always fail. original issue: http://codereview.chromium.org/3567012 BUG=none TEST=FileSystemOperationTest.* TBR=ericu Review URL: http://codereview.chromium.org/3531012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61613 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Continue fixing nits found by my automated source scanner.erg@google.com2010-10-052-1/+3
| | | | | | | | | | | (~1.3 megs off Debug linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up orphaned testserver processes before launching a new one in ↵rsimha@chromium.org2010-10-053-10/+56
| | | | | | | | | | | | | | | net::TestServer Several chrome tests have failed in recent days because some test cases crashed due to failures, leaving behind orphaned testserver processes. These test suites do not use out_of_proc_test_runner, and therefore, do not get the benefit of using the LaunchAppInNewProcessGroup()/KillProcessGroup() mechanism. This patch implements an added layer of safety, by causing TestServer::LaunchPython() to first kill any remaining orphaned instances of testserver.py before launching a new one. The check for an orphaned testserver process on POSIX is a process with exe_name "python", a parent_pid of "1" (indicating that it's an orphan), and command line parameters that contain the strings "testserver.py" and "<port>" where <port> is the port that is being used by the test server instance. BUG=55808,57253 TEST=Run a test that spawns a testserver and dies. Run another test. It shouldn't fail. Review URL: http://codereview.chromium.org/3537002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61584 0039d316-1c4b-4281-b951-d872f2087c98
* Move TestTimeouts from chrome/test to base/test.sergeyu@chromium.org2010-10-056-0/+201
| | | | | | | | | BUG=None TEST=unittests Review URL: http://codereview.chromium.org/3544008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61480 - Support removeRecursively and new copy/move behaviors added ↵kinuko@chromium.org2010-10-053-75/+59
| | | | | | | | | | | | | | | | | | | | | to the spec recently. http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html > For a move/copy of a file on top of existing file, or a directory on > top of an existing empty directory, you get an automatic overwrite. > A move/copy of a file on top of an existing directory, or of a > directory on top of an existing file, will always fail. > A move/copy of a file or directory on top of an existing non-empty > directory will always fail. BUG=32277 TEST=FileSystemOperationTest.* Review URL: http://codereview.chromium.org/3567012 TBR=kinuko@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61482 0039d316-1c4b-4281-b951-d872f2087c98
* Marks Test{Move,Copy}FailureContainsPath FAILS on Windows, also makes a fix ↵kinuko@chromium.org2010-10-051-1/+1
| | | | | | | | | | | | | | attempt for the failure. This patch also contains an attempt to fix the failure. TBR=ericu BUG=none TEST=green bot Review URL: http://codereview.chromium.org/3516014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61481 0039d316-1c4b-4281-b951-d872f2087c98
* Support removeRecursively and new copy/move behaviors added to the spec ↵kinuko@chromium.org2010-10-053-59/+75
| | | | | | | | | | | | | | | | | | | recently. http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html > For a move/copy of a file on top of existing file, or a directory on > top of an existing empty directory, you get an automatic overwrite. > A move/copy of a file on top of an existing directory, or of a > directory on top of an existing file, will always fail. > A move/copy of a file or directory on top of an existing non-empty > directory will always fail. BUG=32277 TEST=FileSystemOperationTest.* Review URL: http://codereview.chromium.org/3567012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61480 0039d316-1c4b-4281-b951-d872f2087c98
* Second try at submitting 61462.ericu@google.com2010-10-052-9/+61
| | | | | | | | | BUG=none TEST=in file_system_operation_unittest.cc Review URL: http://codereview.chromium.org/3526018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61468 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61462 - Add truncate and cancel for FileWriter; write and more tests ↵ericu@google.com2010-10-052-61/+9
| | | | | | | | | | | | | | | will come in later CLs. This CL also contains a fair amount of plumbing for the write call itself. BUG=none TEST=none Review URL: http://codereview.chromium.org/3599011 TBR=ericu@google.com Review URL: http://codereview.chromium.org/3604006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61463 0039d316-1c4b-4281-b951-d872f2087c98
* Add truncate and cancel for FileWriter; write and more tests will come in ↵ericu@google.com2010-10-052-9/+61
| | | | | | | | | | | | later CLs. This CL also contains a fair amount of plumbing for the write call itself. BUG=none TEST=none Review URL: http://codereview.chromium.org/3599011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61462 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r61237: FBTF: Another big ctor/dtor cleanup found by automated tools.erg@google.com2010-10-044-2/+9
| | | | | | | | | | | | | | | Removes changes to code in webkit/ that broke chrome_frame. Will debug that portion later. (Shaves ~2MB off Linux Debug .a files) BUG=none TEST=compiles First Review URL: http://codereview.chromium.org/3563004 Review URL: http://codereview.chromium.org/3621003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61435 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK for misused string resources.estade@chromium.org2010-10-041-5/+6
| | | | | | | | | | | When replacing a placeholder in a localized string, make sure the correct number of placeholders were found (i.e. the same number of strings that the calling code passed). BUG=none TEST=running/testing the browser in debug doesn't cause errors Review URL: http://codereview.chromium.org/3396025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61420 0039d316-1c4b-4281-b951-d872f2087c98
* clang/mac: Fix almost all problems when building all.xcodeproj.thakis@chromium.org2010-10-044-50/+6
| | | | | | | | BUG=None TEST=None TBR=hans git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61344 0039d316-1c4b-4281-b951-d872f2087c98
* clang/mac: Fix most problems in unittest targets in webkit.gypthakis@chromium.org2010-10-032-3/+3
| | | | | | | | | | | | This does to WebPoint/gfx::Point what we did to WebString/string16 last friday and fixes a bunch of other small issues. Also fix two tiny issues in the base unit tests target. BUG=None TEST=None TBR=hans git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61343 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the code for loading icons into the PageInfoModel.rsesek@chromium.org2010-10-023-0/+25
| | | | | | | | | | | | This code is basically duplicated twice on each platform. This consolidates all that into PageInfoModel::GetIconImage() and renames the SectionInfo.state to icon_id. BUG=none TEST=Page info windows and bubbles work as they did before across all platforms. Review URL: http://codereview.chromium.org/3560004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61269 (broke lots of browser and ui tests, like on your try run) - ↵thakis@chromium.org2010-10-022-12/+0
| | | | | | | | | | | | | | | | [GTK] delay reference count check in OwnedWidgetGtk It's a common problem that a GtkWidget will be referenced by an event that's currently on the callstack. These ref holders ignore the "destroy" signal, so when we go to destroy the owned widget, the refcount == 1 DCHECK fails. This change delays that DCHECK until the current stack has unwound, so we don't have to keep running into this. BUG=none TEST=in debug builds, Escape in a constrained window doesn't DCHECK, dragging a tab doesn't cause a DCHECK, pressing the custom frame [x] in lucid doesn't DCHECK; in general, no additional DCHECKs Review URL: http://codereview.chromium.org/3416032 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/3564007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61283 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61272 - Fix windows build (missing include).thakis@chromium.org2010-10-022-1/+1
| | | | | | | | | | | | | TBR=thakis BUG=none TEST=compile Review URL: http://codereview.chromium.org/3533011 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/3552006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61282 0039d316-1c4b-4281-b951-d872f2087c98
* Fix windows build (missing include).estade@chromium.org2010-10-022-1/+1
| | | | | | | | | | TBR=thakis BUG=none TEST=compile Review URL: http://codereview.chromium.org/3533011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61272 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] delay reference count check in OwnedWidgetGtkestade@chromium.org2010-10-022-0/+12
| | | | | | | | | | | It's a common problem that a GtkWidget will be referenced by an event that's currently on the callstack. These ref holders ignore the "destroy" signal, so when we go to destroy the owned widget, the refcount == 1 DCHECK fails. This change delays that DCHECK until the current stack has unwound, so we don't have to keep running into this. BUG=none TEST=in debug builds, Escape in a constrained window doesn't DCHECK, dragging a tab doesn't cause a DCHECK, pressing the custom frame [x] in lucid doesn't DCHECK; in general, no additional DCHECKs Review URL: http://codereview.chromium.org/3416032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61269 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ref counts mutable, so we can ref count const objects.willchan@chromium.org2010-10-024-19/+19
| | | | | | Review URL: http://codereview.chromium.org/1575024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61263 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-10-015-173/+320
| | | | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61142 Review URL: http://codereview.chromium.org/3575008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61249 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "FBTF: Another big ctor/dtor cleanup found by automated tools."erg@google.com2010-10-014-9/+2
| | | | | | | | | | | This reverts commit 27ea47d65cf8767f350113d5ad9e25170efde811 (r61237). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3609005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61240 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Another big ctor/dtor cleanup found by automated tools.erg@google.com2010-10-014-2/+9
| | | | | | | | | | | (Shaves ~2MB off Linux Debug .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61237 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: make DCHECK_EQ(string16, string16) work.thakis@chromium.org2010-10-012-0/+4
| | | | | | | | | | | | | | | | | | | The problem is that string16 is a typedef for a std::basic_string with a custom base::char_traits, hence ADL looks for operator<< only in std and base, not in the global namespace. Since adding stuff to the global namespace isn't permitted, move the operator to namespace base instead. Also give WebString an explicit operator<< because clang can't figure out that it can use WebString's |operator string16| to print WebStrings. string16 is just wstring on windows, and gtest has special code to make printing wstrings to non-wide ostreams work already, so nothing is required on windows. Fix a few other minor issues. Based on a patch by hans@chromium.org BUG=57294 TEST=still compiles with gcc, fewer build errors in tests with clang Review URL: http://codereview.chromium.org/3515003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61218 0039d316-1c4b-4281-b951-d872f2087c98
* Solved a problem where a string was supposed to be passed as a reference but ↵hansl@google.com2010-10-011-12/+22
| | | | | | | | | | | | was instead passed by value. Also, if CreateMutex returns NULL (for the lock), try to call the Debugger and return nicely. TEST=none BUG=none Review URL: http://codereview.chromium.org/3589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61191 0039d316-1c4b-4281-b951-d872f2087c98
* Update Dr. Memory suppressions, gtest_filters and also skip oob-write sanity ↵timurrrr@chromium.org2010-10-012-0/+9
| | | | | | | | | tests on Windows. TBR=glider Review URL: http://codereview.chromium.org/3616001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61171 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of consolidating zoom code for pepper plugins (i.e. pdf) and the ↵jam@chromium.org2010-10-012-0/+11
| | | | | | | | rest of Chrome. Allows plugins to have different zoom ranges, and also to update zoom on its own. Review URL: http://codereview.chromium.org/3419023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix official build breakage.akalin@chromium.org2010-10-011-2/+0
| | | | | | | | | | BUG=None TEST=Tested compile with official mode flags TBR=hbono Review URL: http://codereview.chromium.org/3528007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61142 - Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-10-015-286/+188
| | | | | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Review URL: http://codereview.chromium.org/3575008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/3527004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61143 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-10-015-188/+286
| | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Review URL: http://codereview.chromium.org/3575008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61142 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61127 - Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-09-305-259/+186
| | | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Review URL: http://codereview.chromium.org/3575008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/3606003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61129 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-09-305-186/+259
| | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Review URL: http://codereview.chromium.org/3575008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61127 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Consolidated duplicate definitions of DLOG.akalin@chromium.org2010-09-301-106/+98
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3551006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61113 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to ↵erg@google.com2010-09-302-15/+42
| | | | | | | | | | | | | | non-POD structs. Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on a whole bunch of virtual dtors that were missing it. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3522004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the most common uses of MakeCheckOpString as extern templates on gcc ↵erg@google.com2010-09-302-8/+29
| | | | | | | | | | | | | | platforms. Remove broken template specializations that were never instantiated that references extern code that doesn't exist in the project (!). BUG=none TEST=compiles, smaller binaries on linux, chromeos and mac Review URL: http://codereview.chromium.org/3594003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61092 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flakey timer test.mbelshe@chromium.org2010-09-301-9/+16
| | | | | | | | | | | | | The goal of the test is to verify that the HighResNow() clock has faster than 15ms precision. Modify the test to not depend on how long Sleep() takes in order to verify this. BUG=50291 TEST=TimeTicks.HighResNow Review URL: http://codereview.chromium.org/3452018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61068 0039d316-1c4b-4281-b951-d872f2087c98
* If VlogTest.Perf is ran under Valgrind, decrease the number of benchmarkglider@chromium.org2010-09-301-3/+5
| | | | | | | | | | iterations. Otherwise the test may time out due to slowdown. TBR=akalin Review URL: http://codereview.chromium.org/3578004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61053 0039d316-1c4b-4281-b951-d872f2087c98
* Removed support for log prefix filters.akalin@chromium.org2010-09-302-24/+0
| | | | | | | | | | | No one is using this, and this is obsoleted by --vmodule. BUG=56965 TEST=None Review URL: http://codereview.chromium.org/3596003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61035 0039d316-1c4b-4281-b951-d872f2087c98
* symbolize: don't stringify errno if we're using google::Symbolize.evan@chromium.org2010-09-291-6/+13
| | | | | | | | | | | | This prevents us from printing out confusing error messages like: Unable to get symbols for backtrace (Success). BUG=57305 TEST=ran locally, saw no error Review URL: http://codereview.chromium.org/3544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61010 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 03:33:14 +0000