summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* touchui: build fix for the buildbot.sadrul@chromium.org2010-12-201-4/+3
| | | | | | | | | BUG=http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Touch%20%28dbg%29/builds/755/steps/compile/logs/stdio TEST=touch buildbot should pass Review URL: http://codereview.chromium.org/6076001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69760 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up mac_util to use CFToNSCastdmaclach@chromium.org2010-12-201-12/+9
| | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6030003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69735 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly. Got it now looking ↵dmaclach@chromium.org2010-12-203-54/+28
| | | | | | | | | | | in the appropriate bundle. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build with -Duse_system_icu=1 and libicu-4.4.*phajdan.jr@chromium.org2010-12-201-4/+6
| | | | | | | | | | | | | | UBreakIterator is a struct in newer versions of libicu; must explicitly cast iter_, which is defined as a void*. Failing to do so causes gcc to complain about implicitly converting from a void*. Contributed by Mike Gilbert <floppymaster@gmail.com>. Original review: http://codereview.chromium.org/6047001 BUG=None TEST=Build with -Duse_system_icu=1 Review URL: http://codereview.chromium.org/6015003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69713 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WorkerPoolMac, rename WorkerPoolLinux to WorkerPoolPosix and use that ↵thakis@chromium.org2010-12-187-339/+48
| | | | | | | | | | | | | | | | | on mac. We currently use WorkerPoolLinux on mac (as an attempt to fix the fork issue -- didn't help, but didn't hurt either), so this should be safe. This removes the last @interfaces from libbase. Also add worker_pool_posix_unittest.cc back to base_unittests BUG=44392,46929 TEST=Chrome still works. The PDF plugin prints no more warnings when it's loaded. Review URL: http://codereview.chromium.org/6055001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69652 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebKitTools->Tools.tonyg@chromium.org2010-12-181-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=yurys Review URL: http://codereview.chromium.org/6015002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69627 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CrApplication dependency from basethakis@chromium.org2010-12-189-145/+67
| | | | | | | | | | | | | | | | | Add a @protocol CrAppProtocol that clients of base must implement in their NSApplication subclass, and let base depend only on this protocol. Let MessagePumpNSApplication::DoRun() no longer initialize NSApplication (fixes a TODO). Add a MockCrApplication that the simple unittests in base and app can use, move chrome_application to chrome/common. Test shell might run nested run loops, so I gave it a real but simplified CrAppProtocol implementation. BUG=62968,46929 TEST=Everything still works. The PDF plugin prints one fewer warning when loaded. Review URL: http://codereview.chromium.org/5950003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69615 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-183-34/+54
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-183-54/+34
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* Create self signed X509 certificatehclam@chromium.org2010-12-171-0/+1
| | | | | | | | | | | | | In order to run a SSL server certificate and private key is needed. In the case of Chromoting the first step is to use self signed cert. This change allows to issue self signed cert. This is only implemented in NSS. BUG=None TEST=net_unittests Review URL: http://codereview.chromium.org/5754001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up clang problemdmaclach@chromium.org2010-12-171-1/+1
| | | | | | | | | BUG=none TEST=BUILD Review URL: http://codereview.chromium.org/6013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69565 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for easily casting CFTypes to NSTypesdmaclach@chromium.org2010-12-171-4/+58
| | | | | | | | | | | BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69552 Review URL: http://codereview.chromium.org/5857006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69561 0039d316-1c4b-4281-b951-d872f2087c98
* Move ElideString() from base/string_util.cc to app/text_elider.cc to jschuh@google.com2010-12-173-72/+0
| | | | | | | | | | | | | reduce size of widely-included base libraries. Committing for tsepez. BUG=49747 TEST=TextEliderTest.* Review URL: http://codereview.chromium.org/6017001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69555 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69552 - Add support for easily casting CFTypes to NSTypesdmaclach@chromium.org2010-12-171-48/+0
| | | | | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5857006 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/5958004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69553 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for easily casting CFTypes to NSTypesdmaclach@chromium.org2010-12-171-0/+48
| | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5857006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69552 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated AbsolutePath.tfarina@chromium.org2010-12-172-10/+0
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5915005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69501 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69490 - base/version: remove wstring versionsanjeevr@chromium.org2010-12-172-3/+8
| | | | | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5905006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69491 0039d316-1c4b-4281-b951-d872f2087c98
* base/version: remove wstring versionevan@chromium.org2010-12-172-8/+3
| | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69490 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove the xmessage-based error dialogevan@chromium.org2010-12-161-17/+5
| | | | | | | | | | | | Since this is for developers only, developers use the console anyway. The dialog is cute but superfluous and actually kind of annoying. BUG=37026 Review URL: http://codereview.chromium.org/5905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69484 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Protect reading and writing startup_data_"agl@chromium.org2010-12-162-18/+3
| | | | | | This reverts commit r69438. It may have broken Linux dbg-shlib. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69466 0039d316-1c4b-4281-b951-d872f2087c98
* Clear obj_ before releasing the callee in RunnableMethod.cbentzel@chromium.org2010-12-163-4/+57
| | | | | | | | | | | | | I mistakenly did a Cancel in the callee's destructor, which would reinvoke traits_.ReleaseCallee Since this is a programming error, it's not a required change. BUG=None TEST=base_unittests --gtest_filter="TaskTest.TestCancelInDestructor" Review URL: http://codereview.chromium.org/5886002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69451 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: turn on the new message pump.sadrul@chromium.org2010-12-161-2/+1
| | | | | | | | | | | | | Many (most?) of the bugs related to the new message pump have been fixed, and it is ready for testing. It's stable enough that it shouldn't block other people's works. BUG=none TEST=none Review URL: http://codereview.chromium.org/5940003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69444 0039d316-1c4b-4281-b951-d872f2087c98
* Protect reading and writing startup_data_agl@chromium.org2010-12-162-3/+18
| | | | | | | | | | | | | | Protect reading and writing startup_data_ to ensure intruction order and to ensure the value is correctly read in the new thread. Contributed by phanna (Android) BUG=67145 TEST=none http://codereview.chromium.org/5933002/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69438 0039d316-1c4b-4281-b951-d872f2087c98
* Separate BufferedDataSource and BufferedResourceLoader into two files.annacc@chromium.org2010-12-164-1/+11
| | | | | | | | | | | | | | | It's time to finally separate the huge monster files buffered_data_source.[h/cc] into two. ericroman: There are some variables and short methods that both BufferedDataSource and BufferedResourceLoader rely on and that I have moved to src/net/http/http_util.h. Could you please verify that this is an ok place to put them? Also, appcache issues have been resolved (and approved by michaeln) so I've removed those comments. BUG=None. TEST=Compiles. Review URL: http://codereview.chromium.org/5756004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69429 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for temporarily trusting a certificate for the duration of unit ↵rsleevi@chromium.org2010-12-161-1/+3
| | | | | | | | | | | | | | | tests on Windows, rather than requiring the machine to be pre-configured out-of-band. Given the lack of a Microsoft-provided high-level API to supply application-level trusts to the verification routines, this implements a workaround that intercepts attempts to open the trusted system root store and injects the test certificates directly. This allows the unit tests to work without requiring that the Test CA be added to the machine's Trusted Certificates store. While doing so, clean up the interface to adding/removing trusted test certificates, so as to support more than one trusted certificate if necessary. BUG=8470 TEST=To follow Review URL: http://codereview.chromium.org/4646001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69351 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Allow IO in ProcessMetrics::GetWorkingSetKBytes().thestig@chromium.org2010-12-151-6/+17
| | | | | | | | BUG=61340 TEST=Opening up the task manager on Linux in debug mode does not assert. Review URL: http://codereview.chromium.org/5928001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69331 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting second word iterator patch for tsepez. this was originally ↵cdn@chromium.org2010-12-154-71/+73
| | | | | | | | reviewed at http://codereview.chromium.org/5796003/ Review URL: http://codereview.chromium.org/5707011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69278 0039d316-1c4b-4281-b951-d872f2087c98
* Take 3: Reland 69237 - Fix raw_scoped_refptr_mismatch_checker.h."willchan@chromium.org2010-12-154-141/+151
| | | | | | | | | | | If this one fails, I'm just reverting and calling it quits for tonight. BUG=28083 TEST=builds Review URL: http://codereview.chromium.org/5844002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69243 - Reland 69237 - Fix raw_scoped_refptr_mismatch_checker.h.willchan@chromium.org2010-12-154-151/+141
| | | | | | | | | | | | | | | | | | | | Damn, missed a unittest. BUG=28083 TEST=none Review URL: http://codereview.chromium.org/3549010 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5885001 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/5887001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5888001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69244 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 69237 - Fix raw_scoped_refptr_mismatch_checker.h.willchan@chromium.org2010-12-154-141/+151
| | | | | | | | | | | | | | | BUG=28083 TEST=none Review URL: http://codereview.chromium.org/3549010 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5885001 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/5887001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69243 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h.phajdan.jr@chromium.org2010-12-154-151/+141
| | | | | | | | | | | | BUG=28083 TEST=none Review URL: http://codereview.chromium.org/3549010 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5885001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix raw_scoped_refptr_mismatch_checker.h.willchan@chromium.org2010-12-154-141/+151
| | | | | | | | | BUG=28083 TEST=none Review URL: http://codereview.chromium.org/3549010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69237 0039d316-1c4b-4281-b951-d872f2087c98
* Add Debug Message Dialog Support for Mac OSdmaclach@chromium.org2010-12-141-3/+13
| | | | | | | | | BUG=37026 TEST=NONE Review URL: http://codereview.chromium.org/5804004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69138 0039d316-1c4b-4281-b951-d872f2087c98
* Fix openssl portability issuejoth@chromium.org2010-12-142-2/+4
| | | | | | | | | | | - in STL vector<> has no data() member. BUG=None TEST=Builds. base_unittest --gtest_filter=*Sym* Review URL: http://codereview.chromium.org/5705006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69128 0039d316-1c4b-4281-b951-d872f2087c98
* Fix openssl after singleton refactorjoth@chromium.org2010-12-141-3/+3
| | | | | | | | | BUG=65298 TEST=Builds Review URL: http://codereview.chromium.org/5767005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69123 0039d316-1c4b-4281-b951-d872f2087c98
* Build fixsatish@chromium.org2010-12-141-1/+2
| | | | | | TBR=thakis git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69108 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-146-137/+179
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some plumbing for propagating the status and error code of a ↵gspencer@chromium.org2010-12-144-78/+252
| | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r68893 after fixing allowing blocking IO on shutdown.willchan@chromium.org2010-12-142-0/+12
| | | | | | | | | | | | | | | | | | This time I just turned off the checking for Chrome/Windows because Chrome/Windows shutdown is a clusterf***. TODO(willchan): Give a shit about Windows, get a machine that runs Windows, debug Chrome shutdown on Windows, enable this ThreadRestrictions for Chrome/Windows. Consider PlatformThread::Join() to be blocking IO. Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530, 66077, 66082 TEST=existing Review URL: http://codereview.chromium.org/5750003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69079 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Eliminiate @interface NoOp from base.thakis@chromium.org2010-12-141-17/+3
| | | | | | | | | | | I don't think eliminating _all_ objc from base is the right answer -- the remaining objc has to move out of the static libbase. But if it's easy to have fewer objc to move, that's good. BUG=46929 TEST=One fewer duplicate symbol is reported when loading the pdf plugin. Review URL: http://codereview.chromium.org/5716007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69077 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-2/+2
| | | | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. This primarily covers files in chrome os and other directories, missed in the previous CL. In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-2/+2
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Log additional information when processing OpenSSL errors.rsleevi@chromium.org2010-12-121-7/+17
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5563009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68974 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension install UI for extensions with RTL Names.jeremy@chromium.org2010-12-122-0/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a version of AdjustStringForLocaleDirection() that handles the quirks of GTK/OSX label autodirectionality. Comment from the CL: // On OS X & GTK the directionality of a label is determined by the first // strongly directional character. // However, we want to make sure that in an LTR-language UI all strings are // left aligned and vice versa. // A problem can arise if we display a string which starts with user input. // User input may be the opposite directionality and so the whole string will // be displayed in the opposite directionality, e.g. if we want to display in // an LTR UI [such as US English]: // // EMAN_NOISNETXE is now installed. // // Since EXTENSION_NAME begins with a strong RTL char, the label's // directionality will be set to RTL and the string will be displayed visually // as: // // .is now installed EMAN_NOISNETXE // // In order to solve this issue, we prepend an LRM to the string which is a // strongly directional LTR char. // We also append an LRM at the end which ensures that we're in an LTR // context. // Unlike Windows, Linux and OS X can correctly display RTL glyphs out of the // box so there is no issue with displaying zero-width bidi control characters // on any system. Thus no need for the !IsRTL() check here. BUG=63303 TEST=1. Try scenario described in bug. 2. Make sure there areno regressions displaying RTL strings in LTR UI and vice versa on OS X. Review URL: http://codereview.chromium.org/5291009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68967 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-115-160/+89
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Fix base_unittests for GCC 4.5.1phajdan.jr@chromium.org2010-12-111-1/+1
| | | | | | | | | | | | | This is upstreaming a Gentoo Linux patch. I have encountered this tiny compile issue when using a more recent GCC. TEST=none BUG=none Review URL: http://codereview.chromium.org/5791001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68933 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-115-89/+160
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68893 - Consider PlatformThread::Join() to be blocking IO.csilv@chromium.org2010-12-112-8/+0
| | | | | | | | | | | | | | | | | Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530,66077,66082 TEST=none Review URL: http://codereview.chromium.org/5693003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5743005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68915 0039d316-1c4b-4281-b951-d872f2087c98
* Consider PlatformThread::Join() to be blocking IO.willchan@chromium.org2010-12-102-0/+8
| | | | | | | | | | | | | | Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530,66077,66082 TEST=none Review URL: http://codereview.chromium.org/5693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68893 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ICU header dependencies outside of /i18n directory.cdn@chromium.org2010-12-102-12/+22
| | | | | | | | | | Committing for tsepez. Original code review is here http://codereview.chromium.org/5682002/ BUG=49747 TEST=WordIteratorTest.* Review URL: http://codereview.chromium.org/5718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68867 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 01:30:23 +0000