summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Fix a typo in CBU16_IS_SURROGATEjshin@chromium.org2010-09-081-2/+2
| | | | | | | | | | | | It's pointing to U_IS_SURROGATE instead of CBU_IS_SURROGATE. BUG=NONE TEST=CBU16_IS_SURROGATE works fine in base. TBR=brettw Review URL: http://codereview.chromium.org/3294018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58866 0039d316-1c4b-4281-b951-d872f2087c98
* Adding debugging info for thread name.huanr@chromium.org2010-09-081-0/+18
| | | | | | | | | | | | This may not provide enough information to analyze the bug, but it is a start with minimal impact. BUG=54307 TEST=none Review URL: http://codereview.chromium.org/3337012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58786 0039d316-1c4b-4281-b951-d872f2087c98
* Add recursive flag to file_util_proxy::CreateDirectory.kinuko@chromium.org2010-09-082-3/+8
| | | | | | | | | BUG=54352 TEST=all the FileSystemOperationTest.TestCreateDir* should continue to pass Review URL: http://codereview.chromium.org/3293009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58781 0039d316-1c4b-4281-b951-d872f2087c98
* Change ICU_UTIL_DATA_IMPL on Linux to match the reality.jshin@chromium.org2010-09-071-4/+2
| | | | | | | | | | | | | | | | | We've bundled the ICU data file for 'ages' on Linux, but ICU_UTIL_DATA_IMPL on Linux is still set to ICU_UTIL_DATA_FILE. Apparently, this hasn't been noticed because u_setDataDirectory and udata_setFileAccess just set the global variable pointing to the data file location. This is not totally free because u_setDataDirectory does some locking/unlocking. BUG=NONE TEST=Builds go through on Linux and binaries (chrome, test, etc) run just fine. Review URL: http://codereview.chromium.org/3329012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58725 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd attempt: Write the outcome of the Toast Experiment for system-level ↵finnur@chromium.org2010-09-072-10/+31
| | | | | | | | | | | | | | installs to the right registry key. This time with the two boolean parameters in process_util_win.cc:281 flipped to match the function signature. TBR=cpu BUG=44378 TEST=None Review URL: http://codereview.chromium.org/3297015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58693 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58639 - nsylvain@chromium.org2010-09-072-31/+10
| | | | | | | | | | | | | | | | This seems to have caused some ui_tests to fail (AllowCookies, BlockCookies) Original comment: Write the outcome of the Toast Experiment for system-level installs to the right registry key. BUG=44378 TEST=None Review URL: http://codereview.chromium.org/3308003 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/3369002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58667 0039d316-1c4b-4281-b951-d872f2087c98
* Write the outcome of the Toast Experiment for system-level installs to the ↵finnur@chromium.org2010-09-062-10/+31
| | | | | | | | | | | right registry key. BUG=44378 TEST=None Review URL: http://codereview.chromium.org/3308003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58639 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate a benign race between task_.get() and task_.reset()glider@chromium.org2010-09-061-1/+5
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/3365009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58625 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some duplicated includes.tfarina@chromium.org2010-09-042-2/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3358014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58582 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58576 - Adds logging into fork_and_get_task() to test a hypothesis on ↵rohitrao@chromium.org2010-09-041-7/+0
| | | | | | | | | | | | | | | why WaitForInitialLoads() is failing. Will be reverted soon. BUG=None TEST=None Review URL: http://codereview.chromium.org/3353012 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3354009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58579 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging into fork_and_get_task() to test a hypothesis on why ↵rohitrao@chromium.org2010-09-041-0/+7
| | | | | | | | | | | | WaitForInitialLoads() is failing. Will be reverted soon. BUG=None TEST=None Review URL: http://codereview.chromium.org/3353012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58576 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move the reset of signal handlers to be very soon after the fork, ↵rohitrao@chromium.org2010-09-041-6/+16
| | | | | | | | | | | | | | | | | | | | | | | before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. This is take two. I couldn't reproduce the unit_tests failures either locally or on the release try bots. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3322013 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3360009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58572 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58558 - [Mac] Move the reset of signal handlers to be very soon after ↵rohitrao@chromium.org2010-09-031-16/+6
| | | | | | | | | | | | | | | | | | the fork, before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3322013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58560 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move the reset of signal handlers to be very soon after the fork, ↵rohitrao@chromium.org2010-09-031-6/+16
| | | | | | | | | | | | | | | before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58558 0039d316-1c4b-4281-b951-d872f2087c98
* Add a term feature extractor for client-side phishing detection.bryner@chromium.org2010-09-032-0/+11
| | | | | | | | | | | | | | | | | | | | This class creates features for n-grams in the page text that appear in the phishing classification model. It will eventually operate on the plain text that is extracted by RenderView::CaptureText(). To make it harder for phishers to enumerate the terms in the classification model, they will be supplied as SHA-256 hashes rather than plain text. The term feature extractor hashes the words in the document in order to check whether they match the model. Since this is potentially expensive, the term feature extractor limits how long it will run on each iteration, similar to the PhishingDOMFeatureExtractor. TEST=PhishingTermFeatureExtractorTest BUG=none Review URL: http://codereview.chromium.org/3214002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58537 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the default argument from RegKey::ReadValue.tfarina@chromium.org2010-09-031-6/+1
| | | | | | | | | BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3259005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58456 0039d316-1c4b-4281-b951-d872f2087c98
* Moving file_util::FileInfo to base::PlatformFileInfo, and adding thedumi@chromium.org2010-09-039-26/+38
| | | | | | | | | | | | last_accessed and creation_time fields. BUG=none TEST=none Review URL: http://codereview.chromium.org/3347005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58454 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-0316-1920/+0
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Change file_util_proxy::Entry::isDirectory to is_directory.kinuko@chromium.org2010-09-022-3/+5
| | | | | | | | | BUG=54228 TEST=none, just code cleanup Review URL: http://codereview.chromium.org/3357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58415 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-0215-0/+1909
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0215-1909/+0
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add comment explaining why we create the mach receive port when we do.rohitrao@chromium.org2010-09-021-0/+4
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3217010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58357 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ProcessUtilTest.CalcFreeMemory under TSan on Windowstimurrrr@chromium.org2010-09-021-0/+3
| | | | | | | | BUG=54229 TBR=glider Review URL: http://codereview.chromium.org/3290005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58333 0039d316-1c4b-4281-b951-d872f2087c98
* Changes for browser-side implementation for file api.kkanetkar@chromium.org2010-09-023-26/+303
| | | | | | | | | | BUG=32277 TEST=Separate CL for unit test. Review URL: http://codereview.chromium.org/3212002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58312 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitStringUsingSubstr functions from string_util.h to string_split.htfarina@chromium.org2010-09-026-87/+92
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3284005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58300 0039d316-1c4b-4281-b951-d872f2087c98
* Registered the service process to AutoRun (for Windows) if any service ↵sanjeevr@chromium.org2010-09-012-0/+23
| | | | | | | | | | | (CloudPrint or Remoting) is enabled. When all services are disabled, we delete the AutoRun key. Also remembered the enabled state of the Cloud Print Proxy in the service prefs. BUG=None TEST=After enabling cloud print or chromoting on Windows, the service process should auto start on user login. Review URL: http://codereview.chromium.org/3257011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-0116-0/+1921
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0116-1921/+0
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58091 - experiment to try and fix 'Cookies' test on Linux.tim@chromium.org2010-08-311-2/+0
| | | | | | | | | | | | | | Fix Time::FromDoubleT so that it will return null time when 0 is passed. BUG=none TEST=none Review URL: http://codereview.chromium.org/3175044 TBR=jianli@chromium.org Review URL: http://codereview.chromium.org/3262012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58103 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Time::FromDoubleT so that it will return null time when 0 is passed.jianli@chromium.org2010-08-311-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3175044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58091 0039d316-1c4b-4281-b951-d872f2087c98
* Allow NOTIFY_EXISTING_ONLY in ObserverListThreadSafe. Switch NCN to using it.willchan@chromium.org2010-08-311-2/+8
| | | | | | | | TEST=none Review URL: http://codereview.chromium.org/3235013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58074 - Lock all access to logging data, in case it's reinitializeddavemoore@chromium.org2010-08-311-148/+100
| | | | | | | | | | | Review URL: http://codereview.chromium.org/3195014 TBR=davemoore@chromium.org Problems with IE tests for ChromeFrame and heapcheck. Review URL: http://codereview.chromium.org/3229012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58079 0039d316-1c4b-4281-b951-d872f2087c98
* Add NSS cert trust setting, cert deleting, and CA cert import to CertDatabase.mattm@chromium.org2010-08-311-1/+3
| | | | | | | | | BUG=19991 TEST=net/base/cert_database_nss_unittest.cc Review URL: http://codereview.chromium.org/3106028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58077 0039d316-1c4b-4281-b951-d872f2087c98
* Lock all access to logging data, in case it's reinitializeddavemoore@chromium.org2010-08-311-100/+148
| | | | | | Review URL: http://codereview.chromium.org/3195014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58074 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for functionality added to ReplaceStringPlaceholders in r57966.aa@chromium.org2010-08-312-2/+12
| | | | | | | | TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceStringPlaceholders* Review URL: http://codereview.chromium.org/3266013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58047 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional parameter to CreatePlatformFile() to report the typedumi@chromium.org2010-08-316-35/+117
| | | | | | | | | | | | of error that occured while trying to open/create a file. TEST=none BUG=none Review URL: http://codereview.chromium.org/3223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58045 0039d316-1c4b-4281-b951-d872f2087c98
* Add test to check that IsStringUTF8 allows for embedded NULLs.ajwong@chromium.org2010-08-311-0/+9
| | | | | | | | | BUG=53507 TEST=new test for an embedded NULL. Review URL: http://codereview.chromium.org/3124049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57990 0039d316-1c4b-4281-b951-d872f2087c98
* Add an accordian effect to NTP.aa@chromium.org2010-08-311-1/+5
| | | | | | | | BUG=53248 Review URL: http://codereview.chromium.org/3250002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57966 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated version of file_util::ReadFileToString function.tfarina@chromium.org2010-08-312-5/+0
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/3250004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57944 0039d316-1c4b-4281-b951-d872f2087c98
* Support handling blob URL and resolve blob references in upload data.jianli@chromium.org2010-08-312-0/+52
| | | | | | | | | BUG=none TEST=unittest Review URL: http://codereview.chromium.org/3282003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57938 0039d316-1c4b-4281-b951-d872f2087c98
* Add RandomNumberGenerator adapter to base/rand_util.hisherman@chromium.org2010-08-303-5/+24
| | | | | | | | | BUG=46679 TEST=none (yet...) Review URL: http://codereview.chromium.org/3053050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57904 0039d316-1c4b-4281-b951-d872f2087c98
* Mac tabpose: Add thumbnailsthakis@chromium.org2010-08-301-0/+24
| | | | | | | | | | | | | | | | Most things actually work. Missing from this CL: * Reloading thumbnails for tabs that change. This is required to show non-white thumbnails for thumbnails that are still waiting on the net when tabpose is opened. * Showing infobars / bookmark bar in the thumbnail * Showing accelerated surfaces (youtube videos on 10.6, compositor on 10.6) BUG=50307 TEST=Enable tabpose. Should see thumbnails for all tabs (some loaded after a delay). Thumbnails should animate in correctly even if a tab has info bars, a detached NTP, or docked devtools. Tabs that haven't been frontmost since the window was last resized should look good. Opening many tabs and then immediately jumping into expose shouldn't crash. Review URL: http://codereview.chromium.org/3163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57901 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move some heavy, repeatedly emitted symbols to implementation files.erg@google.com2010-08-303-9/+15
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3162047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the default argument from RegKey::WriteValue.tfarina@chromium.org2010-08-281-1/+1
| | | | | | | | | BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3239005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57777 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r57575 - Remove the default argument from RegKey::Open.tfarina@chromium.org2010-08-281-1/+1
| | | | | | | | | | | This fix the bad rebase conflict. BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3185032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57758 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-278-15/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land. Fixed previous errors.dimich@chromium.org2010-08-272-0/+169
| | | | | | | | | | | | | | | | | | | | | | | | | | Implement OSX version for "Start on Login" for background-enabled extensions. When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List". Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon. Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case. Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion. Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX. BUG=43382 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569 Reverted Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57614 Reverted Review URL: http://codereview.chromium.org/3163029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57699 0039d316-1c4b-4281-b951-d872f2087c98
* This CL introduces the stack shadowing mechanism that should help TCMalloc'sglider@chromium.org2010-08-271-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | heap leak checker to unwind the memory allocation stacks better. Currently, if a memory region is allocated from a library built without frame pointers heapchecker is unable to unwind the stack and records only the top frame. This is inconvenient, because: -- several leaks from different places are treated as leaks from the same source -- it's hard to suppress such leaks, because a one-line suppression is uninformative linux_shadow_stacks.cc keeps the threads' IP and SP values in thread-local stacks upon each function entry/exit using gcc function instrumentation (-finstrument-functions). The GetStackTrace routine from stacktrace_shadow-inl.h unwinds the stack as usual (using frame pointers), but then updates the result with the shadow stack frames which SP values are below the bottom frame of the unwind result. Note that -finstrument-functions affects only Chromium code, not the libraries. This means that we cannot get more than one library function frame at the top of the stack. For example, consider a libfoo library that has a public foo_do_something() routine which allocates memory via foo_alloc(). If Chromium calls foo_do_something() from ChromeCallFoo(), then the following call chain effectively happens: main -> ChromeCallFoo -> foo_do_something -> foo_alloc If libfoo is built with -fomit-frame-pointers, heapcheck can unwind only the last stack frame: foo_alloc On the other hand, the shadow stack at the allocation site contains everything below the libfoo calls: main -> ChromeCallFoo As a result the following allocation stack is recorded: main -> ChromeCallFoo -> foo_alloc This is enough to distinguish between e.g. ChromeCallFoo1 and ChromeCallFoo2 Review URL: http://codereview.chromium.org/3120017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57658 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57614 - Re-land. Fixed previous build error.dimich@chromium.org2010-08-272-169/+0
| | | | | | | | | | | | | | | It looks like it broke browser_tests. Will revert and investigate. Implement OSX version for "Start on Login" for background-enabled extensions. Review URL: http://codereview.chromium.org/3163029 TBR=dimich@chromium.org Review URL: http://codereview.chromium.org/3226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57625 0039d316-1c4b-4281-b951-d872f2087c98
* Move the SingletonSocket to a temporary directorydavidben@chromium.org2010-08-272-3/+11
| | | | | | | | | | | | | | | | This is to workaround problems on certain network filesystems (notably AFS) which do not support Unix domain sockets. We move the sockets into a temporary folder and symlink. To avoid the possibility of a dangling link to a missing (and later intercepted) remote directory, we create and check cookie files and rely on the stickiness of /tmp/ to avoid a race condition in the check. R=mattm BUG=44606 TEST=ProcessSingletonLinuxTest.* Review URL: http://codereview.chromium.org/2838034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57623 0039d316-1c4b-4281-b951-d872f2087c98