| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
It's pointing to U_IS_SURROGATE instead of CBU_IS_SURROGATE.
BUG=NONE
TEST=CBU16_IS_SURROGATE works fine in base.
TBR=brettw
Review URL: http://codereview.chromium.org/3294018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may not provide enough information to analyze the bug,
but it is a start with minimal impact.
BUG=54307
TEST=none
Review URL: http://codereview.chromium.org/3337012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54352
TEST=all the FileSystemOperationTest.TestCreateDir* should continue to pass
Review URL: http://codereview.chromium.org/3293009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've bundled the ICU data file for 'ages' on Linux, but ICU_UTIL_DATA_IMPL on Linux
is still set to ICU_UTIL_DATA_FILE.
Apparently, this hasn't been noticed because u_setDataDirectory and
udata_setFileAccess just set the global variable pointing to the data file
location. This is not totally free because u_setDataDirectory does some
locking/unlocking.
BUG=NONE
TEST=Builds go through on Linux and binaries (chrome, test, etc) run just fine.
Review URL: http://codereview.chromium.org/3329012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installs to the right registry key.
This time with the two boolean parameters in process_util_win.cc:281 flipped to match the function signature.
TBR=cpu
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3297015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to have caused some ui_tests to fail (AllowCookies, BlockCookies)
Original comment:
Write the outcome of the Toast Experiment for system-level installs to the right registry key.
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3308003
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3369002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
right registry key.
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3308003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/3365009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3358014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
why WaitForInitialLoads() is failing.
Will be reverted soon.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3353012
TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/3354009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WaitForInitialLoads() is failing.
Will be reverted soon.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3353012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before we do any mach IPC.
The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible.
Nico would like me to mention that this was his idea.
This is take two. I couldn't reproduce the unit_tests failures either locally or on the release try bots.
BUG=35374
TEST=If in the forever backwards spinner state, closing the tab should not quit the browser.
TEST=In general, renderers and extensions and plugins should still work.
Review URL: http://codereview.chromium.org/3302009
TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/3322013
TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/3360009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the fork, before we do any mach IPC.
The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible.
Nico would like me to mention that this was his idea.
BUG=35374
TEST=If in the forever backwards spinner state, closing the tab should not quit the browser.
TEST=In general, renderers and extensions and plugins should still work.
Review URL: http://codereview.chromium.org/3302009
TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/3322013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before we do any mach IPC.
The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible.
Nico would like me to mention that this was his idea.
BUG=35374
TEST=If in the forever backwards spinner state, closing the tab should not quit the browser.
TEST=In general, renderers and extensions and plugins should still work.
Review URL: http://codereview.chromium.org/3302009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class creates features for n-grams in the page text that appear in the
phishing classification model. It will eventually operate on the plain text
that is extracted by RenderView::CaptureText().
To make it harder for phishers to enumerate the terms in the classification
model, they will be supplied as SHA-256 hashes rather than plain text. The
term feature extractor hashes the words in the document in order to check
whether they match the model. Since this is potentially expensive, the term
feature extractor limits how long it will run on each iteration, similar to
the PhishingDOMFeatureExtractor.
TEST=PhishingTermFeatureExtractorTest
BUG=none
Review URL: http://codereview.chromium.org/3214002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3259005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
last_accessed and creation_time fields.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3347005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original message:
"""
Move the keyboard files from base/ to app/.
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
"""
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3354005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54228
TEST=none, just code cleanup
Review URL: http://codereview.chromium.org/3357003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/ to app/.
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
TBR=bryeung@chromium.org
Review URL: http://codereview.chromium.org/3337006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3217010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=54229
TBR=glider
Review URL: http://codereview.chromium.org/3290005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32277
TEST=Separate CL for unit test.
Review URL: http://codereview.chromium.org/3212002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3284005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(CloudPrint or Remoting) is enabled. When all services are disabled, we delete the AutoRun key. Also remembered the enabled state of the Cloud Print Proxy in the service prefs.
BUG=None
TEST=After enabling cloud print or chromoting on Windows, the service process should auto start on user login.
Review URL: http://codereview.chromium.org/3257011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix Time::FromDoubleT so that it will return null time when 0 is passed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3175044
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3262012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3175044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/3235013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3195014
TBR=davemoore@chromium.org
Problems with IE tests for ChromeFrame and heapcheck.
Review URL: http://codereview.chromium.org/3229012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=net/base/cert_database_nss_unittest.cc
Review URL: http://codereview.chromium.org/3106028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3195014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceStringPlaceholders*
Review URL: http://codereview.chromium.org/3266013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of error that occured while trying to open/create a file.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3223007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53507
TEST=new test for an embedded NULL.
Review URL: http://codereview.chromium.org/3124049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53248
Review URL: http://codereview.chromium.org/3250002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/3250004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unittest
Review URL: http://codereview.chromium.org/3282003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46679
TEST=none (yet...)
Review URL: http://codereview.chromium.org/3053050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most things actually work.
Missing from this CL:
* Reloading thumbnails for tabs that change. This is required to show non-white thumbnails for thumbnails that are still waiting on the net when tabpose is opened.
* Showing infobars / bookmark bar in the thumbnail
* Showing accelerated surfaces (youtube videos on 10.6, compositor on 10.6)
BUG=50307
TEST=Enable tabpose. Should see thumbnails for all tabs (some loaded after a delay). Thumbnails should animate in correctly even if a tab has info bars, a detached NTP, or docked devtools. Tabs that haven't been frontmost since the window was last resized should look good. Opening many tabs and then immediately jumping into expose shouldn't crash.
Review URL: http://codereview.chromium.org/3163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3162047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3239005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fix the bad rebase conflict.
BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3185032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3176026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement OSX version for "Start on Login" for background-enabled extensions.
When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List".
Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon.
Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case.
Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion.
Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX.
BUG=43382
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569
Reverted
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57614
Reverted
Review URL: http://codereview.chromium.org/3163029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
heap leak checker to unwind the memory allocation stacks better.
Currently, if a memory region is allocated from a library built without frame
pointers heapchecker is unable to unwind the stack and records only the top
frame. This is inconvenient, because:
-- several leaks from different places are treated as leaks from the same
source
-- it's hard to suppress such leaks, because a one-line suppression is
uninformative
linux_shadow_stacks.cc keeps the threads' IP and SP values in thread-local
stacks upon each function entry/exit using gcc function instrumentation
(-finstrument-functions).
The GetStackTrace routine from stacktrace_shadow-inl.h unwinds the stack as
usual (using frame pointers), but then updates the result with the shadow stack
frames which SP values are below the bottom frame of the unwind result.
Note that -finstrument-functions affects only Chromium code, not the libraries.
This means that we cannot get more than one library function frame at the top
of the stack.
For example, consider a libfoo library that has a public foo_do_something()
routine which allocates memory via foo_alloc(). If Chromium calls
foo_do_something() from ChromeCallFoo(), then the following call chain
effectively happens:
main -> ChromeCallFoo -> foo_do_something -> foo_alloc
If libfoo is built with -fomit-frame-pointers, heapcheck can unwind only the
last stack frame:
foo_alloc
On the other hand, the shadow stack at the allocation site contains everything
below the libfoo calls:
main -> ChromeCallFoo
As a result the following allocation stack is recorded:
main -> ChromeCallFoo -> foo_alloc
This is enough to distinguish between e.g. ChromeCallFoo1 and ChromeCallFoo2
Review URL: http://codereview.chromium.org/3120017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like it broke browser_tests. Will revert and investigate.
Implement OSX version for "Start on Login" for background-enabled extensions.
Review URL: http://codereview.chromium.org/3163029
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/3226002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to workaround problems on certain network filesystems (notably AFS)
which do not support Unix domain sockets. We move the sockets into a temporary
folder and symlink. To avoid the possibility of a dangling link to a missing
(and later intercepted) remote directory, we create and check cookie files
and rely on the stickiness of /tmp/ to avoid a race condition in the check.
R=mattm
BUG=44606
TEST=ProcessSingletonLinuxTest.*
Review URL: http://codereview.chromium.org/2838034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57623 0039d316-1c4b-4281-b951-d872f2087c98
|