| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Switch to using TimeTicks rather than Time so that we
are not dependent on changes in the system clock.
r=mbelshe,darin
Review URL: http://codereview.chromium.org/3884001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix users of same.
BUG=none
TEST=unittests
Review URL: http://codereview.chromium.org/4517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adapts things to use the Linux WorkerPool code by default, with
--disable-linux-workerpool to switch back to the old version.
The old implementation uses NSOperationQueue, which is implemented in
terms of pthread workqueues. These are implicated by the stack traces
from the recent unit test flakiness. This change attempts to
influence that flakiness.
BUG=20471, 60426
TEST=Tree green.
Review URL: http://codereview.chromium.org/4595001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62119
TEST=none
Review URL: http://codereview.chromium.org/4565003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Chrome Frame.
BUG=61383
TEST=Run IE with version X of CF loaded. Register version Y of CF. Run a second IE process, notice that version Y when loaded defers to version X.
Review URL: http://codereview.chromium.org/4144008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4521001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The call to Now() uses a lock to handle roll over events, and that
might make the call more expensive in some scenarios.
Reduce the number of times we need to call Time::Now() when processing
timer events by processing all (fully ripe, and ready to run) events
with only one call to Now(). This should make the queue run faster as
we fall further behind.
I was hoping to see some perf improvement, but I think this will only
have an impact when we are overloaded, which problably doesn't happen
often on the bots. I did some local histogramming, and I do see cases
where we get away with processing several (2-3) events with one call
to Now(), but that is apparently not enough to move the needle on the
perf bots.
r=darin
Review URL: http://codereview.chromium.org/4247003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because this causes problems on valgrind (for ChromeOS only).
Turns out that TabStripModel is not thread safe, and I'm calling from
another thread.
Review URL: http://codereview.chromium.org/4446002
TBR=gspencer@chromium.org
Review URL: http://codereview.chromium.org/4417006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change extends the log severities into the negative for VLOG verbosities.
It also keeps track of file/line information and passes it to any registered log handler.
The log level is naturally controlled by translating ETW log levels to the severities.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4164011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I actually did this two months ago, and though I had committed it, but
due to the "git cl push" vs "git cl dcommit" craziness, it was never
in the tree.]
It was previously reviewed and LGTM'd here:
http://codereview.chromium.org/3235007/show
BUG=none
TEST=Tested on device, both using large numbers of tabs, and
small tabs that used lots of memory.
Review URL: http://codereview.chromium.org/4446002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The location of the definition we want has moved over time.
See the bug for why this location is better.
BUG=52269
TEST=compiles
Review URL: http://codereview.chromium.org/4455001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a relanding of http://codereview.chromium.org/4174002
The change in this CL is that I've made the function
to look for errors virtual, and over-rode it in StatsHistograms.
The current override doesn't actually check for inconsistencies,
so that the UMA checks (and renderer-to-histogram checks) won't
complain and refuse to transport the histograms.
BUG=61281
r=rvargas
Review URL: http://codereview.chromium.org/4364001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
header (RFC 5987).
It's not generic, but is only used for 'filename' param.
The CL is originally by James Simonsen I reviewed at http://codereview.chromium.org/4254001/show
I added a check for ASCIIness for RFC 5987 extended header and a few tests to NetUti*.GetFileNameFromCD
(net_unittests) and I*.ConvertCo*Norma* (base_unittests). I also replaced '\uxxxx' notation with
the corresponding UTF-8 byte sequence because Visual Studio does not understand it yet.
BUG=57830
TEST="net_unittests --gtest_filter=NetU*.GetFil*", "base_unittests --gtest_filter=I*.Conver*Norm*" and tests
at http://greenbytes.de/tech/tc2231/
Original CL / Review: By James Simonsen; at http://codereview.chromium.org/4254001/show
Review URL: http://codereview.chromium.org/4435001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It isn't quite ready.
BUG=none
TEST=build and run chrome, can type in the omnibox again
Review URL: http://codereview.chromium.org/4425001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/4431001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/4262001/show
The r64883 broke most unit tests in CEEE that relied on disabling logs while testing error paths.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4390001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61510
TEST=New unittests in base_unittests
Review URL: http://codereview.chromium.org/4262001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4371001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix conflicts like:
2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope
2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare'
Reported-by: Jeff Timanus <twiz@google.com>
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Callers should append base:: when calling StringPrintV now.
BUG=None
TEST=locally and trybots
Review URL: http://codereview.chromium.org/4296004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Corruptions can include changes in bucket boundaries,
large changes in sample counts (in a bucket), etc.
We now detect problems, and don't forward the corrupt
data any further. This means it won't exit the renderer
and go to the browser if corrupt, and it won't exit
the browser and be sent up via UMA if corrupt.
IF the would-be corruption is caused by a race to
snapshot the data, then a later snapshot should get
the clean copy, and all data (across the precluded
period) will be sent onward.
BUG=61281
r=mbelshe
Review URL: http://codereview.chromium.org/4174002
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/4349002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::FileUtilProxy
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4261001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
above 127.
BUG=None
TEST=base_unittests --gtest_filter=*StringToInt*
Review URL: http://codereview.chromium.org/4129012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61589
TEST=SharedMemoryProcessTest.Tasks
Review URL: http://codereview.chromium.org/4228003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Corruptions can include changes in bucket boundaries,
large changes in sample counts (in a bucket), etc.
We now detect problems, and don't forward the corrupt
data any further. This means it won't exit the renderer
and go to the browser if corrupt, and it won't exit
the browser and be sent up via UMA if corrupt.
IF the would-be corruption is caused by a race to
snapshot the data, then a later snapshot should get
the clean copy, and all data (across the precluded
period) will be sent onward.
BUG=61281
r=mbelshe
Review URL: http://codereview.chromium.org/4174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and "chmod" might or might not actually fix the problem, we should never
give advice that actually introduces more problems. Changing permissions
to 777 is bad, as it drops the sticky bit. Instead, the instructions should
say 1777.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4245001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Moved DEFINE_CHECK_OP_IMPL to be closer to the CHECK_EQ et al. macros.
BUG=9913
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/4140012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The custom pattern matcher matches any slash (forward or backward) to any
slash. It also does not do escaping like MatchPattern(). Finally, '?'
matches exactly one character, which matches google-glog behavior
(MatchPattern() matches '?' to 0 or 1 character).
BUG=61123
TEST=New unittests
Review URL: http://codereview.chromium.org/4205005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This object is primarily available to work around bugs, but it
is also sometimes necessary, which is why it describes its usage
as *almost* always incorrect.
Review URL: http://codereview.chromium.org/4213009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58998
TEST=New unit tests
Review URL: http://codereview.chromium.org/4199005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc
Review URL: http://codereview.chromium.org/4166011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reading files /proc is effectively just a kernel API; it's not unsafe
like accessing normal disk files is.
BUG=61136
TEST=no more DCHECKs in task manager
Review URL: http://codereview.chromium.org/4135015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch to using GLib, instead of having a Chromium specific implementation, for
parsing environment variables for language preferences for all POSIX systems
that use GTK+. If we have a non-GTK port in the future, we have to resurrect
our custom code.
This will guarantee that UI language selection in Chromium works just like for
all other GTK+ applications, and simplify the code.
While doing this, also do some cleaning-up of the language preferences code and
add a test case to verify that the prioritization is done correctly.
Original CL by Fredrik Roubert at http://codereview.chromium.org/2901004/show
BUG=NONE
TEST=app_unittest with "--gtest_filter=L10nUt*.*Loc*" passes.
Review URL: http://codereview.chromium.org/4217004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adapt the file watching code we already had for ConfigDirPolicyProvider to support a loader delegate, make the old code use it and change the Mac policy provider to watch for changes to the plist file in /Library/Managed Preferences/<username>.
BUG=52040
TEST=unit tests
Review URL: http://codereview.chromium.org/4062002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4211004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gfx/gtk_util.h
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4150006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also cleaned up spurious warning when --vmodule is used but --v is not.
Removed slow perf unittest from vlog_unittest.cc.
BUG=61123
TEST=New vlog unittests
Review URL: http://codereview.chromium.org/4140007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/4215003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
TEST=trybots
Review URL: http://codereview.chromium.org/4133005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Most functions moved to chrome/browser/gtk/gtk_util.h because they're only
used within chrome/browser.
* BGRAToRGBA() is used within chrome/ and app/ so moved it to base/gtk_util.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4170002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_.
BUG=28372,32048,32070,35341,45561,48544,48562,52858
TEST=N/A
Review URL: http://codereview.chromium.org/4087009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
new tabs.
BUG=914 (http://code.google.com/p/nativeclient/issues/detail?id=914)
TEST=none
Relied on trybots and manually checking "about:histograms"
Review URL: http://codereview.chromium.org/4065005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to log to instead of going to the timestamped files directly, so that
the browser process can more precisely control the output file being
used. It still creates timestamped logs, and the regular chrome
operations should be unchanged.
Added a bool return value to InitLogging so we know when it fails,
because failing needs to be handled properly in ChromeOS to remove
hanging symbolic links.
[This change has already been reviewed and approved here:
http://codereview.chromium.org/3983004/show
Somehow the dcommit failed without me noticing, so I'm trying
again.]
BUG=http://crosbug.com/6343
TEST=ran on device in incognito and regular mode, looked at logs.
Review URL: http://codereview.chromium.org/4167004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=BUILD
BUG=NONE
Review URL: http://codereview.chromium.org/3961006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
running under Heapchecker.
BUG=50345
TEST=Suppression no longer gets used.
Original Review URL: http://codereview.chromium.org/3791006
Revert Review URL: http://codereview.chromium.org/3779008
Review URL: http://codereview.chromium.org/4111005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vs Posix and enforces exclusive creates.
Clean up some naming to make it clearer what size you are getting by changing max_size to created_size.
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/4034006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No one else is including it anymore.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4200003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64059 0039d316-1c4b-4281-b951-d872f2087c98
|