summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Use base::WindowImpl instead of CWindowImpl to reduce dependencies on ATL.jhawkins@chromium.org2009-08-082-3/+13
| | | | | | | | BUG=5022 TEST=test_shell_tests Review URL: http://codereview.chromium.org/165188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22864 0039d316-1c4b-4281-b951-d872f2087c98
* Add short circuit case for self assignment, and add virtual destructorjar@chromium.org2009-08-072-3/+8
| | | | | | | | | | | | | | | | | | | Pickle is a base class of Message, which has a virtual destructor, so it is better to have Pickle have a virtual destructor as well. Add more defensive code in the case of self assignment. **IF** self assignment was used, and the target was read-only, then the existing code would have a memory fault. I don't think this is currently possible in use cases, but the defensize code is much better. (per suggestion from CPU on last CL). BUG=17027 BUG=17088 r=cpu Review URL: http://codereview.chromium.org/159800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22826 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out window creation into base::WindowImpl. This class will be used ↵jhawkins@chromium.org2009-08-073-0/+324
| | | | | | | | | | in place of CWindowImpl to reduce our dependency on ATL. BUG=none TEST=none Review URL: http://codereview.chromium.org/165022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22787 0039d316-1c4b-4281-b951-d872f2087c98
* Define _FILE_OFFSET_BITS=64 in order to support large files (>2GB).thestig@chromium.org2009-08-063-282/+252
| | | | | | | | | | | | | | | | | | _FILE_OFFSET_BITS=64 is incompatible with fts (issue 17492), so file_util::Delete, file_util::CopyDirectory file_util::FileEnumerator are reimplemented without fts. Delete and CopyDirectory are now implemented using FileEnumerator. Patch from vandebo@google.com, original review: http://codereview.chromium.org/160479 BUG=13718,17492 TEST=none Review URL: http://codereview.chromium.org/165085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22670 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Mac-specific implementation of LaunchApp, and share the Linux ↵stuartmorgan@google.com2009-08-064-151/+77
| | | | | | | | | | | | | version. Fixes a race condition with file descriptors, and gives the Mac access to the environment-alterning version of LaunchApp BUG=11174 TEST=Launching render/plugin/utility processes should still work on the Mac Review URL: http://codereview.chromium.org/165067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22649 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system jpeg.agl@chromium.org2009-08-061-0/+4
| | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. http://codereview.chromium.org/164080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22645 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement bookmark manager copy/paste.estade@chromium.org2009-08-047-28/+159
| | | | | | | | | | | | - Refactor bookmark util clipboard code to be cross platform. - Add a CBF_DATA format for writing arbitrary data to the clipboard. - Change MenuGtk so that showing a menu only makes the menu items update asynchronously. This way we can show the menu immediately and we won't get in trouble if the delegate's IsCommandEnabled() runs a nested message loop. I did not do any mac-side implementation of the new clipboard stuff. The implementation should be easy when they get around to writing the bookmark manager. Review URL: http://codereview.chromium.org/159815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22419 0039d316-1c4b-4281-b951-d872f2087c98
* linux: improve warnings when NSS/PR shutdowns failevan@chromium.org2009-08-041-5/+12
| | | | | | | | | | | Make one into a LOG(INFO) since it's relatively harmless; add comments on the other with a link to the bug. BUG=4609,18410 Review URL: http://codereview.chromium.org/159836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22394 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't try and read shmmax in the sandbox.agl@chromium.org2009-08-042-0/+23
| | | | | | | | | | | In the sandbox, reading shmmax from proc always fails. Thus, we move the function into base and call it before starting the sandbox. The value is then cached. http://codereview.chromium.org/159843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22393 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-process Message Port implementation.jam@chromium.org2009-08-041-0/+11
| | | | | | | | | I'm sending this first, then I'll add support to workers in another changelist to avoid making this change larger. TEST=running message port related layout tests in ui_tests Review URL: http://codereview.chromium.org/159372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22356 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even the logging statement from ~LogMessage. We shouldn't be using ↵phajdan.jr@chromium.org2009-08-031-7/+6
| | | | | | | | | | | LOG macros there. TEST=none http://crbug.com/18028 Review URL: http://codereview.chromium.org/159789 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22292 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_file_util out of libbase. Test code should not be mixed with ↵phajdan.jr@chromium.org2009-08-031-5/+36
| | | | | | | | | | | | | | | production code. Rename previous test_support_base to test_support_perf. I couldn't just add things to test_support_base because one file there defined main, and it would produce link conflict for new users of test_support_base. TEST=none http://crbug.com/18101 Review URL: http://codereview.chromium.org/159791 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22291 0039d316-1c4b-4281-b951-d872f2087c98
* Use intptr_t for casting pointers for 64-bit.deanm@chromium.org2009-08-031-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/160522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22269 0039d316-1c4b-4281-b951-d872f2087c98
* Add defensive code in pickle to preclude realloc of shared header_ memory.jar@chromium.org2009-08-031-2/+7
| | | | | | | | | | | | | | | | Since I was able to (some how) generate a problem with header_ being double freed (perhaps, because it was shared in some way??), this change adds several lines of defensive coding. The current assignment operator appears very dangerous, as it allowed Resize to be called when the header_ was not owned by the instance (it was read-only). I haven't found a path to cause a problem, but we may as well be defensive. BUG=17027 BUG=17088 r=CPU Review URL: http://codereview.chromium.org/160490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22261 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an unused function in clipboard_linux as well as unused methodsky@chromium.org2009-07-312-18/+0
| | | | | | | | | | | declaration. BUG=none TEST=none Review URL: http://codereview.chromium.org/159735 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22223 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds accelerators to the Linux toolkit views.jcampan@chromium.org2009-07-317-52/+294
| | | | | | | | | | | The MessageLoop had to be modified to support Dispatchers on Linux. BUG=None TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests. Review URL: http://codereview.chromium.org/159046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
* Do not abort the process if thread owning the log mutex has crashed.phajdan.jr@chromium.org2009-07-311-1/+6
| | | | | | | | | | | It makes UI tests even more flaky. However, we still log that event. TEST=none http://crbug.com/18028 Review URL: http://codereview.chromium.org/159723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22195 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Safari Import - Home Page & History Only.jeremy@chromium.org2009-07-313-0/+24
| | | | | | Review URL: http://codereview.chromium.org/159668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac plugin background snapshotsstuartmorgan@google.com2009-07-311-0/+14
| | | | | | | | | BUG=none TEST=Compose an email in Gmail with plugins enabled; scroll around and mouse over the "Add attachment" link; it should always draw correctly instead of sometimes showing another part of the page. Review URL: http://codereview.chromium.org/159712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22178 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplication of DieFileDie, and move it to proper location.phajdan.jr@chromium.org2009-07-303-0/+30
| | | | | | | | | TEST=none http://crbug.com/18085 Review URL: http://codereview.chromium.org/159658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux versioninfo its own lib so it can be linked in only where needed.mmoss@chromium.org2009-07-291-48/+59
| | | | | | | | | | This moves it out of libbase, and thus avoids relinking everything that touches base just because the versioninfo changed. Review URL: http://codereview.chromium.org/160358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22014 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21938 (done with experiment).willchan@chromium.org2009-07-291-1/+0
| | | | | | Review URL: http://codereview.chromium.org/160314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21939 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment: Enable tcmalloc for linux (Take 2). Will revert after a ↵willchan@chromium.org2009-07-291-0/+1
| | | | | | | | buildbot cycle. Review URL: http://codereview.chromium.org/160313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21938 0039d316-1c4b-4281-b951-d872f2087c98
* linux: unload plugin libraries after extracting mime typesevan@chromium.org2009-07-291-2/+4
| | | | | | | | | | | | | I had not unloaded them as a premature optimization, thinking it'd be better to leave 'em around since they'll eventually be loaded by a page. But that happens in the plugin process and reading the mime type happens in the browser process, so it didn't help anyway. BUG=17444 Review URL: http://codereview.chromium.org/160303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21929 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove RTLD_DEEPBIND from dlopen()evan@chromium.org2009-07-291-1/+1
| | | | | | | | | | Plugins need to keep their symbol visibility correct. BUG=17557 Review URL: http://codereview.chromium.org/160302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21926 0039d316-1c4b-4281-b951-d872f2087c98
* Change for building dtoa on 64-bit.deanm@chromium.org2009-07-283-1/+31
| | | | | | | Review URL: http://codereview.chromium.org/159541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a FORWARD_NULL defect reported by Coverity. We shouldwtc@chromium.org2009-07-283-31/+35
| | | | | | | | | | | | | | | | | | allow the src_url argument of Clipboard::ReadHTML and the html and base_url arguments of ClipboardUtil::CFHtmlToHtml to be NULL. Fix nits reported by cpplint.py. In Clipboard::SetGtkClipboard, use strdup to duplicate strings. R=tony BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/160247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21888 0039d316-1c4b-4281-b951-d872f2087c98
* WriteData and BeginWriteData should fail if length iswtc@chromium.org2009-07-282-4/+17
| | | | | | | | | | | | | negative. Add a unit test for WriteData(NULL, 0). R=darin BUG=none TEST=new unit test should pass Review URL: http://codereview.chromium.org/159310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21886 0039d316-1c4b-4281-b951-d872f2087c98
* Reset static data in Watchdog to better isolate the tests.phajdan.jr@chromium.org2009-07-283-6/+21
| | | | | | | | | TEST=none http://crbug.com/17839 Review URL: http://codereview.chromium.org/160217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21883 0039d316-1c4b-4281-b951-d872f2087c98
* Remove *.vsprops files that are no longer referenced (or only havesgk@google.com2009-07-283-24/+0
| | | | | | | | | references to each other) anywhere in the Chromium code base. BUG=none TEST=rebuild Review URL: http://codereview.chromium.org/159523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite StringToInt traits for dealing with non-32-bit longs.deanm@chromium.org2009-07-281-29/+45
| | | | | | | Review URL: http://codereview.chromium.org/159510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21855 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Experiment: Enable tcmalloc for linux. Will revert after a buildbot ↵willchan@chromium.org2009-07-281-1/+0
| | | | | | | | | | cycle." This reverts r21826. Review URL: http://codereview.chromium.org/160261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21827 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment: Enable tcmalloc for linux. Will revert after a buildbot cycle.willchan@chromium.org2009-07-281-0/+1
| | | | | | | | TBR=willchan Review URL: http://codereview.chromium.org/159491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21826 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add internal core dump reporting.agl@chromium.org2009-07-281-0/+54
| | | | | | | | | | | | | | | In order to get a handle on a number of browser crashes, this patch adds an options for Google internal folks to upload full core files when the browser crashes. The core files are uploaded to an internal IP address and will be available to other developers. This is only enabled for Chrome branded builds and then, only if --google-internal-crash-reporting is given on the command line. http://codereview.chromium.org/160212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21782 0039d316-1c4b-4281-b951-d872f2087c98
* Adding HTML5 DB support to Chromium: Chromium changesdumi@chromium.org2009-07-272-1/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/74001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21736 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ifdef 32-bit clause in json tests. ints are 32-bit everywhere.deanm@chromium.org2009-07-271-14/+0
| | | | | | | Review URL: http://codereview.chromium.org/159434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21716 0039d316-1c4b-4281-b951-d872f2087c98
* Some base/ progress towards building on Linux x86-64.deanm@chromium.org2009-07-273-4/+36
| | | | | | | | | | - Use long for int64 (still 64 bits) to avoid annoying nspr clash. - Fix some incorrect define guards and add some functions to atomicops. Review URL: http://codereview.chromium.org/159428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21709 0039d316-1c4b-4281-b951-d872f2087c98
* Move base::va_copy from a function to a macro.deanm@chromium.org2009-07-273-11/+5
| | | | | | | | | va_copy is a builtin, you can't just pass it references like we did previously. Review URL: http://codereview.chromium.org/160191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21706 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: A gtkrc file can now override our choice of frame color byerg@google.com2009-07-271-1/+4
| | | | | | | | | | | | | | | | | specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme. Also attempts to do a better job matching the frame color. Most window managers (defined as metacity default theme and xfwm's default theme) take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it will be wrong a smaller percentage of the time then our current behaviour. http://crbug.com/16271 (dark theme bug) http://crbug.com/13967 (theme color metabug) Review URL: http://codereview.chromium.org/160188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21704 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP variable to use the system libpng.agl@chromium.org2009-07-272-0/+8
| | | | | | | | | | | | Since our packagers have been requesting that we support using more system libraries, I'm starting to commit these sorts of changes. However, please note that one MUST NOT use the system libpng on, at least, Ubuntu 64-bit. Because Chromium on Linux is still a 32-bit build we end up with the 32-bit compat versions of libraries and, on Ubuntu at least, this includes a very old libpng with security issues. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21663 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid runtime linker warning dkegel@google.com2009-07-271-2/+13
| | | | | | | | | | | | "Symbol `SSL_ImplementedCiphers' has different size in shared object, consider re-linking" if SSL_ImplementedCiphers is different size on target system than it was on build system. BUG=12826 TEST=run on Jaunty, look for "Symbol `SSL_ImplementedCiphers' has different size in shared object" in console output Review URL: http://codereview.chromium.org/118367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21649 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor blits to be more cross-platform.piman@chromium.org2009-07-243-0/+136
| | | | | | | Review URL: http://codereview.chromium.org/159190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21565 0039d316-1c4b-4281-b951-d872f2087c98
* Adding last modified time to file_utilbrettw@chromium.org2009-07-243-0/+7
| | | | | | | | | Original review: http://codereview.chromium.org/160050 Patch by dhg@google.com Review URL: http://codereview.chromium.org/159347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21533 0039d316-1c4b-4281-b951-d872f2087c98
* I'm apparently the first one who's tried to do hash_map<string16, ...>. ↵jorlow@chromium.org2009-07-241-0/+28
| | | | | | | | | | | | | | Unfortunately, hash_map<> does not know how to hash a string16 when string16 isn't a wstring. I looked in <tr1/functional> and saw that only std::string and std::wstring have hashing functions. This change adds a hashing function for string16's when they're not the same as a std::wstring. BUG=none TEST=none Review URL: http://codereview.chromium.org/160062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21494 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SVG icons for linux.estade@chromium.org2009-07-241-23/+7
| | | | | | | | | | | get rid of kEnableSVG BUG=12272 TEST=I made it load an svg for the download shelf and it worked. SVGZ did not work. Review URL: http://codereview.chromium.org/159247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21481 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r21429 - Cleanup pending tasks under Valgrind as well.kuchhal@chromium.org2009-07-231-9/+10
| | | | | | | | BUG=16095 Review URL: http://codereview.chromium.org/160035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21459 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generalize desktop environment guessing to encompass KDEevan@chromium.org2009-07-232-13/+30
| | | | | | | | BUG=17363 Review URL: http://codereview.chromium.org/159297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21455 0039d316-1c4b-4281-b951-d872f2087c98
* Silence a false coverity warning by changing the code a bit.munjal@chromium.org2009-07-232-8/+22
| | | | | | Review URL: http://codereview.chromium.org/159104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21447 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup:phajdan.jr@chromium.org2009-07-236-14/+24
| | | | | | | | | - reduce header dependencies by using bookmark_model_observer.h - replace #include <iostream> by #include <iosfwd> in headers Review URL: http://codereview.chromium.org/159280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21444 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Cleanup pending tasks under Valgrind as well." (r21429)kuchhal@chromium.org2009-07-231-10/+6
| | | | | | | | This reverts commit 26f9edf949e1678d4f8a3479518568b8a6e1972c. Review URL: http://codereview.chromium.org/160033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21430 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 03:56:12 +0000