| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
- Modify InitApplicationContext() to take a ScopedJavaRef
- Clarify documentation
Review URL: http://codereview.chromium.org/8894002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That matches the CQ bots, and they're significantly faster.
The global trybots are added to all subdirectory PRESUBMITs automatically, so remove win, linux, mac from subdirectory PRESUBMITs (instead of changing them too).
BUG=99521
TEST=`git try` creates faster tryjobs.
TBR=willchan (net), akalin (sync)
Review URL: http://codereview.chromium.org/8162009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8894033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
now always compiled
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8890067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK user interface show up on the chrome://tracing hierarchical profiler.
These were useful for tracking down tab changing speed problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8800029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scoped_array....
Add Pass(), which implements move semantics, to scoped_ptr, scoped_array, and scoped_ptr_malloc.
This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>.
With this, is now possible to use scopers as an argument type or a return type. This signifies, in the type system, transfer of ownership into a function or out of a function respectively. Calling, or returning such a function MUST use the temporary resultin
This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer.
Also adds a Passed() helper that allows using a scoper with Bind().
BUG=96118
TEST=new unittests
Original review URL: http://codereview.chromium.org/8774032
Review URL: http://codereview.chromium.org/8897005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pasteboard corruption or bad third-party code can cause
+[NSSpellChecker sharedSpellChecker] to throw NSExceptions. Chrome
treats NSExceptions as fatal, because they generally mean things are
awry. Since this call can happen in response to calls from the
renderer, and the exceptions are not thrown from Chrome code, this
change enables them while retrieving the shared instance.
BUG=92399,95728
Review URL: http://codereview.chromium.org/8883040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8888021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104248
TEST=chrome: about:gpu and webgl pages (both aura and gtk), compositor_unittests, views_unittests
Review URL: http://codereview.chromium.org/8890042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.
Review URL: http://codereview.chromium.org/8894007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed the branch-free macro. I really need to
use a profiler to see if such changes are valuable.
I cleaned up the placement of slots, putting the
rare-to-use values together (so they'll probably get
better handled by cache lines.
r=rtenneti
Review URL: http://codereview.chromium.org/8888004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8836003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scoped_array, and scoped_ptr_malloc.
This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>.
With this, is now possible to use scopers as an argument type or a return type. This signifies, in the type system, transfer of ownership into a function or out of a function respectively. Calling, or returning such a function MUST use the temporary resulting from the scoper's Pass() function. You CANNOT just pass the scoper by copy as there is still no copy constructor or assignment operator; trying to do so will yield a compilation error.
This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer.
Also adds a Passed() helper that allows using a scoper with Bind().
BUG=96118
TEST=new unittests
Review URL: http://codereview.chromium.org/8774032
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8890060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and scoped_ptr_malloc.
This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>.
With this, is now possible to use scopers as an argument type or a return type. This signifies, in the type system, transfer of ownership into a function or out of a function respectively. Calling, or returning such a function MUST use the temporary resulting from the scoper's Pass() function. You CANNOT just pass the scoper by copy as there is still no copy constructor or assignment operator; trying to do so will yield a compilation error.
This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer.
Also adds a Passed() helper that allows using a scoper with Bind().
BUG=96118
TEST=new unittests
Review URL: http://codereview.chromium.org/8774032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This initialization must have been implicit with gtk. On ChromeOS we go down a different code path for these tests.
TBR=phajdan.jr@chromium.org
BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.
Review URL: http://codereview.chromium.org/8889002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8803022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declaration.
The first bit is designed to ensure that the correctness of callback_forward.h is tested by the callback unittests. The second bit is designed to increase the likelihood of developers actually using callback_forward.h as intended.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8846003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move windows implementation to pimpl idiom
http://c2.com/cgi/wiki?PimplIdiom
There should be no behavior change.
BUG=none
TEST=ConditionVariableTest in base_unittests suffice
Review URL: http://codereview.chromium.org/8823012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other problems)
- Provide windows notifictaion of thread termination
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8550009
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8839001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Save pipelining capabilities for the most used hosts between sessions.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/8770035
TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/8833003
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8832003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Save pipelining capabilities for the most used hosts between sessions.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/8770035
TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/8833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8550009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/8770035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull the CrAppProtocol autorelease-pool handling down into
MessagePumpCrApplication, which is selected at Create() if NSApp
implements the right protocol. UsingCrApp() allows clients to
confirm the correct setup (unfortunately, synchronizing NSApp
initialization and MessagePump::Create() would be intrusive).
Also push CrAppProtocol and CrAppControlProtocol implementation into
BrowserCrApplication, and reparent that class from NSApplication.
Reparent ServiceCrApplication on NSApplication and rename.
Remove CrApplication registration from gpu, plugin, and renderer
mains.
Remove MockCrApp dependency from remoting sample code.
BUG=102224
Review URL: http://codereview.chromium.org/8771028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=
Review URL: http://codereview.chromium.org/8822003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This call was already in place on Win/Posix, but
it was not checked in on the Mac
r=rtenneti
BUG=106287
Review URL: http://codereview.chromium.org/8803021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On some Linux systems, files from /dev/shm cannot have PROT_EXEC applied to
their mappings. This depends on picayune setup details that vary between
distributions and kernels and could vary between installations. So just
use an empirical test of whether it works or not, and fall back to using
generic temporary space instead of /dev/shm for the executable case if needed.
BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= SharedMemory.AnonymousExecutable with /dev/shm mounted noexec
R=mark@chromium.org
Review URL: http://codereview.chromium.org/8800025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mac header is using conditional compilation to become neutral for other platforms.
Unfortunately it won't work for all gyp backends, as the gyp file is removing the header
from the sources for non mac platforms. Better use conditionals in the few places
where we use it. That also spares us to explain the hack.
Review URL: http://codereview.chromium.org/8822010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jar@chromium.org
BUG=106326
TEST=valgrind bots go greener
Review URL: http://codereview.chromium.org/8800008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Java Bridge makes repeated use of numerous JNI method IDs. We wish to avoid
repeatedly looking up these IDS, so we cache them.
Currently we use Singleton objects to achieve this. However, this seems
inappropriate for several reasons ...
- Requires excessive boilerplate
- Thread safety not required
- Exit cleanup not required
We can avoid using Singleton, without introducing static initializers, by
simply using a static local.
See http://codereview.chromium.org/8659007 for background.
TBR=avi
BUG=105547
Review URL: http://codereview.chromium.org/8769005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is really re-landing 112937 and attempting to avoid a warning from the
Linux builder.
R=jar@chromium.org
BUG=106326
TEST=needs to run on the CQ
Review URL: http://codereview.chromium.org/8796006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm going to TBR this, since it causes a bunch of redness
on the tree, and is really a supression.
tbr=rtenneti,mk
bug=106326
Review URL: http://codereview.chromium.org/8792005
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8796005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm going to TBR this, since it causes a bunch of redness
on the tree, and is really a supression.
tbr=rtenneti,mk
bug=106326
Review URL: http://codereview.chromium.org/8792005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
this change is the first part of the FreeBSD support
BUG=
TEST=
Review URL: http://codereview.chromium.org/8773051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=rtenneti
Review URL: http://codereview.chromium.org/8793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also did some cleaning and refactoring in
tracked_objects. We had a lot of functionality that
has migrated to JS, that we didn't need (a lot of
acccessors that are supplanted by the ToValue()
methods.
I'm anticipating that we'll move to an asynhcronous
collecting of data from the profiler, so that we can
bounce around to various threads and more cleanly
collect samples (without risking races during
data snapshots). Several of the refactors are
heading in that direction.
r=rtenneti
tbr=jam (for microscopic content change)
BUG=106291,106293
Review URL: http://codereview.chromium.org/8775061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
copied text while pasting text, droping text and creating right click popup for omnibox.
BUG=82181, 103703
TEST=Copy a string with line breaks "\n" or tabs "\t".
Then right click on omnibox.
Chromium should not trigger DCHECKS.
Review URL: http://codereview.chromium.org/8702002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WillProcessXEvent returns false to indicate continue normal dispatch. The check worked because EVENT_CONTINUE happens to be 0.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8769049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exposes several new states and attributes and fires new notifications
when the selection changes. Adds general-purpose implementations of
IUnknown and IEnumVARIANT to base/win/, which will be used in the future
as we remote ATL from accessibility code.
BUG=5027,98984
TEST=manual testing with JAWS and NVDA
Review URL: http://codereview.chromium.org/8588036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a race on startup. See issue for details.
BUG=chromium-os:20865
TEST=Ensure logging, including VLOG, works.
TBR=willchen@chromium.org
Review URL: http://codereview.chromium.org/8757002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the accelerated html pages to use raf to draw multiple frames. Changed the webgl and canvas2d pages to draw onscreen rather than offscreen to make sure the compositor draws the page.
BUG=105785,104142
Review URL: http://codereview.chromium.org/8692013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/8772049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8682027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=100131
Review URL: http://codereview.chromium.org/8590015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This broke because an incompatible change was made to Process, and because there was no test that would catch it. I've fixed the underlying problem for both Linux and ChromeOS and made it testable.
BUG=102726
TEST=Added new RenderProcessHostTest.Backgrounding
Review URL: http://codereview.chromium.org/8506036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependent target for base and reused as a dependency in gtest.
R=brettw
BUG=105855
TEST=
Review URL: http://codereview.chromium.org/8201001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, sort headers to the extent possible.
BUG=none
Review URL: http://codereview.chromium.org/8776008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cuts down on the number of strings in the executable, as well as
executable code to print them.
On Linux, this saves 208kb on a stripped official build
(chrome executable file went from 64569072 bytes -> 64782064 bytes)
On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes)
On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes)
Fix test failure in logging_unittest.cc in official builds.
Add new executable check_example for easy testing of changes to the
CHECK macros.
BUG=101561
TEST=
Review URL: http://codereview.chromium.org/8734021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Accomodate shmem changes in http://codereview.chromium.org/8585002.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/8771022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also merge content/ MockCrControlApp into base/ MockCrApp.
Also use MockCrApp in test_shell_tests, and slight tweak to autorelease pool in test_shell's initialization.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112578 0039d316-1c4b-4281-b951-d872f2087c98
|