summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-133-43/+16
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92393 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Don't delete the previous command line when callingrvargas@google.com2011-07-132-1/+15
| | | | | | | | | | | | | | CommandLine::Init() In the multi-DLL build, we can end up initializing the object twice at startup (once in chrome.exe and once in chrome.dll). It should be harmless. BUG=76996 TEST=base_unittests Review URL: http://codereview.chromium.org/7273053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92380 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add COMPONENT_BUILD global define. "yurys@chromium.org2011-07-135-42/+19
| | | | | | | | | | | | | The change broke compilation on Linux Builder (dbg)(shared): http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio TBR=darin BUG=None TEST=None Review URL: http://codereview.chromium.org/7352014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-135-19/+42
| | | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92325 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up users of a deprecated base::LaunchApp API."evan@chromium.org2011-07-123-16/+43
| | | | | | This reverts commit r92240, ChromeOS failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92244 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-123-43/+16
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92240 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/values.h into the base namespace. This includes a cros DEPS rolldmazzoni@chromium.org2011-07-124-6/+27
| | | | | | | | | | with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Review URL: http://codereview.chromium.org/7259019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-122-24/+13
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7258005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92200 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly ShutdownOnUIThread the HostContentSettingsMap when destroying the ↵bauerb@chromium.org2011-07-122-0/+12
| | | | | | | | | | | | Profile. Also, get rid of Profile dependencies while we're at it. BUG=88037,88557 Review URL: http://codereview.chromium.org/7218073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92128 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-112-12/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android debug and log related filesmichaelbai@google.com2011-07-0711-7/+137
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7238012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91748 0039d316-1c4b-4281-b951-d872f2087c98
* Extend TTS extension API to support richer events returned from the enginedmazzoni@chromium.org2011-07-071-1/+2
| | | | | | | | | | | | | | | | | | to the client. Previously we just had a completed event; this adds start, word boundary, sentence boundary, and marker boundary. In addition, interrupted and canceled, which were previously errors, now become events. Mac and Windows implementations extended to support as many of these events as possible. BUG=67713 BUG=70198 BUG=75106 BUG=83404 TEST=Updates all TTS API tests to be event-based, and adds new tests. Review URL: http://codereview.chromium.org/6792014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91665 0039d316-1c4b-4281-b951-d872f2087c98
* Move kLocalePak into ui/base/ from base/. Fixes component build of ↵sadrul@chromium.org2011-07-062-5/+0
| | | | | | | | | | | views_desktop. BUG=none TEST=none Review URL: http://codereview.chromium.org/7312010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91621 0039d316-1c4b-4281-b951-d872f2087c98
* posix: remove LaunchAppInNewProcessGroupevan@chromium.org2011-07-061-16/+0
| | | | | | | | Due to refactoring, we can use the common API for this. Review URL: http://codereview.chromium.org/7284018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Time::Explode on Windows and PepperMessageFilter::OnGetLocalTimeZoneOffset.yzshen@chromium.org2011-07-061-18/+32
| | | | | | | | | BUG=None TEST=All time unittests pass. Review URL: http://codereview.chromium.org/7282018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91602 0039d316-1c4b-4281-b951-d872f2087c98
* Added ability to run a command, getting output and exit status on POSIX.benwells@chromium.org2011-07-063-22/+106
| | | | | | | | | | | | | | | Register protocol handler needs to check the return value of scripts it runs and collects output from. There needs a variant of GetAppOutput which returns the exit code of the application run, not just a success or failure, so this function has been added. BUG=83557 TEST=Unit test added Review URL: http://codereview.chromium.org/7198034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91527 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Split SystemMonitor initialization so it's not blocked by the Sandbox.jeremy@chromium.org2011-07-043-17/+40
| | | | | | | | | | | | | In OS X 10.7 Lion, the IO port we listen on to monitor system power events is blocked by the Sandbox. Move the allocation of the IO port so it happens early on during Chrome startup. BUG=83783 TEST=When putting a system to sleep with Chrome running, the browser shouldn't crash. Also, need to monitor crash logs to see that this crash goes away. Review URL: http://codereview.chromium.org/7235023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91462 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure tests check the return of SpawnChild() when they may wait without ↵rsleevi@chromium.org2011-07-021-0/+1
| | | | | | | | | | | | | | | | | | timeouts Ensure that the result of SpawnChild() is consistently checked for unittests. If an child fails to launch, SpawnChild() will return base::kNullProcessHandle. Waiting on this handle is equivalent to waiting for any child to terminate - and if there are no children, this may wait indefinitely, causing the whole test executable to timeout after 10 minutes. BUG=none TEST=none Review URL: http://codereview.chromium.org/7304008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91430 0039d316-1c4b-4281-b951-d872f2087c98
* Change MessagePumpLibevent::Run to process I/O events before doing idlewtc@chromium.org2011-07-012-0/+12
| | | | | | | | | | | | work. R=jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7291010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91252 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add NET_API to more code to enable buildingrvargas@google.com2011-06-301-3/+6
| | | | | | | | | | | a shared net library on Linux, and update base and crypto API definitions. BUG=76997 TEST=none Review URL: http://codereview.chromium.org/7240021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91234 0039d316-1c4b-4281-b951-d872f2087c98
* base: refactor LaunchApp variants into a single functionevan@chromium.org2011-06-303-197/+243
| | | | | | | | | | | | | | | base provides a bunch of process-spawning functions that only differ by one or two arguments; worse, they're all backed by the same implementation anyway. Unify all the functions into one LaunchProcess() function, which takes a struct containing a bunch of optional arguments. For this change, I'm trying to not change the base API. Follow up changes can fix callers. Because of this, I made temporary shims for all of the old API. Review URL: http://codereview.chromium.org/7283019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91220 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use a macro for getting at the process environment.evan@chromium.org2011-06-301-3/+23
| | | | | | | | | I had a struct field named "environ" that was mysteriously not working on OS X until I noticed this code. Review URL: http://codereview.chromium.org/7278004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91184 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91137 - Change MessagePumpLibevent::Run to process I/O events before ↵torne@chromium.org2011-06-302-10/+0
| | | | | | | | | | | | | | | | | doing idle work. R=agl@chromium.org,jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7262011 TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/7210028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91141 0039d316-1c4b-4281-b951-d872f2087c98
* Change MessagePumpLibevent::Run to process I/O events before doing idlewtc@chromium.org2011-06-302-0/+10
| | | | | | | | | | | | work. R=agl@chromium.org,jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7262011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91137 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream process and thread related code.michaelbai@google.com2011-06-294-4/+19
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7247015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91009 0039d316-1c4b-4281-b951-d872f2087c98
* base: Use TEST() macro in Value unittests.tfarina@chromium.org2011-06-283-32/+29
| | | | | | | | | | | | | | | While I'm here: - Add 'base' namespace to this test file. - Remove unnecessary typedefs of testing::Test. BUG=None TEST=base_unittests R=evan@chromium.org Review URL: http://codereview.chromium.org/7275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90862 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90805 - I am submitting this with LGTMs from agl@ and evanm@. I'm ↵fischman@chromium.org2011-06-282-41/+5
| | | | | | | | | | | | | | | | | | | | | | | marking this as TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7230057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90813 0039d316-1c4b-4281-b951-d872f2087c98
* I am submitting this with LGTMs from agl@ and evanm@. I'm marking this as ↵bradchen@google.com2011-06-282-5/+41
| | | | | | | | | | | | | | | | | | | | TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90805 0039d316-1c4b-4281-b951-d872f2087c98
* Apply CSP to chrome: and about: pagestsepez@chromium.org2011-06-283-45/+5
| | | | | | | Apply Content Security Policy to the chrome://credits page, and the other pages handled by browser_about_handler.cc while we're at it. Move inline JS out of several html files. Move top-level page generation to the about_handler.cc, with tracked_objects.cc/hisogram.cc generating markup fragments to be included. This keeps this files agnostic to CSP issues. Also fix an output encoding issue in the <title> of some pages. Review URL: http://codereview.chromium.org/7215034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90788 0039d316-1c4b-4281-b951-d872f2087c98
* Added last_modified field to TemplateURL and database. Updated unit tests, ↵stevet@chromium.org2011-06-283-0/+99
| | | | | | | | | | including refactoring MockTimeProvider out of media/. BUG=None TEST=No visible changes. Ensure that changed unittests all pass. Review URL: http://codereview.chromium.org/7232023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90764 0039d316-1c4b-4281-b951-d872f2087c98
* Move the thread test helper to base/testjochen@chromium.org2011-06-283-0/+84
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7239023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comment in base/auto_reset.h to refer to AutoReset instead ofmark@chromium.org2011-06-281-9/+8
| | | | | | | | | | | | | | | | AutoResetValue. This inconsistency was introduced in r48644. The review history for that change, http://codereview.chromium.org/2394001, indicates that AutoResetValue was initially used in this file but not at any of the use sites. When it changed to AutoReset in patch set 2, matching the use sites, the comment still was not updated. BUG=none, cleanup TEST=none Review URL: http://codereview.chromium.org/7253032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90707 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90681 - New NaCl zygote implementation 2, in which Chrome zygote ↵fischman@chromium.org2011-06-282-40/+4
| | | | | | | | | | | | | | | | forks a NaCl helper. This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7274011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90682 0039d316-1c4b-4281-b951-d872f2087c98
* New NaCl zygote implementation 2, in which Chrome zygote forks a NaCl helper.bradchen@google.com2011-06-272-4/+40
| | | | | | | | | | | This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90681 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android string implementation etc.michaelbai@google.com2011-06-275-16/+46
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7238018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90616 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixes CID=15870,13529 Check pointer before assign, resource leak.gbillock@chromium.org2011-06-272-4/+11
| | | | | | Review URL: http://codereview.chromium.org/7222010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90599 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity Fixlet: UNINIT_CTORscr@chromium.org2011-06-271-2/+2
| | | | | | | | | | | CID=5172 BUG= TEST= Review URL: http://codereview.chromium.org/7219008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90598 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPILE_ASSERT to ensure the result of Bind matches the Callback's type.ajwong@chromium.org2011-06-2611-4/+399
| | | | | | | | | | | | | | Required because we abstract the storage of the funciton pointer out using a reinterpret_cast to reduce template bloat. This effectively readds the failure that would have happened had we stored the function pointer directly in the template class. BUG=86008 TEST=new unittests. Review URL: http://codereview.chromium.org/7241015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90525 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Move app/win/* files to base/win/, ui/base/win and chrome/common/ ↵tfarina@chromium.org2011-06-254-4/+418
| | | | | | | | | | | | | | | | directories." The issue with the r90464 was that in the win shared build we build dlls and we need BASE_API to export functions and symbols. BUG=72317 TEST=None TBR=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7263009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90505 0039d316-1c4b-4281-b951-d872f2087c98
* Patch for Solaris support, mostly ifdefs and header files, plus adds ↵chromium@hybridsource.org2011-06-258-13/+227
| | | | | | | | | | | libevent configuration. BUG=30101 TEST=compiles Review URL: http://codereview.chromium.org/7238021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90494 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up of -Wunused-but-set-variable (gcc 4.6)pph34r@gmail.com2011-06-252-7/+3
| | | | | | | | | | BUG=80071 TEST=base_unittests Review URL: http://codereview.chromium.org/7232025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90489 0039d316-1c4b-4281-b951-d872f2087c98
* TCPServerSocketLibevent should call StopWatchingFileDescriptor()wtc@chromium.org2011-06-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | when Accept() completes asynchronously (because Accept() calls WatchFileDescriptor() in persistent mode) or before it closes socket_. This matches what TCPClientSocketLibevent does. Without this fix, the TCPServerSocketTest.Accept2Connections unit test may crash in accept_callback.WaitForResult() for some message loop scheduling policies because two connections are ready to be accepted but only one accept_socket_ is provided. Fix a comment typo in object_watcher.h. Avoid a redundant StopWatchingFileDescriptor call in TCPClientSocketLibevent. R=sergeyu@chromium.org,willchan@chromium.org BUG=none TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7239018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90476 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90464 - Move app/win/* files to base/win/, ui/base/win and ↵tfarina@chromium.org2011-06-254-417/+4
| | | | | | | | | | | | | | | | chrome/common/ directories. BUG=72317 TEST=None R=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7231016 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/7265009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90471 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win/* files to base/win/, ui/base/win and chrome/common/ directories.tfarina@chromium.org2011-06-254-4/+417
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7231016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90464 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the glib message-pump, and use it as the base for a gtk message ↵sadrul@chromium.org2011-06-2410-226/+293
| | | | | | | | | | | | | | | | | | | pump and an X message pump. The changes: * Rename MessagePumpGlibX to MessagePumpX. * Rename MessagePumpForUI to MessagePumpGlib. * Move some stuff out of MessagePumpGlib, and into MessagePumpGtk and MessagePumpX. * Rename MessagePumpForUI::Observer to MessageObserver, moved the platform-specific implementations into MessagePumpGtk and MessagePumpX. Ditto for MessagePumpForUI::Dispatcher. MessagePumpX is independent of MessagePumpGtk. At the moment, MessagePumpX does process some GDK event, but once we have a complete native_widget_x, we can take out the GDK processing and things should continue to work. BUG=none TEST=existing message-pump tests. Review URL: http://codereview.chromium.org/7250001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90418 0039d316-1c4b-4281-b951-d872f2087c98
* Fix relaunches on the Mac.mark@chromium.org2011-06-242-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relaunches that go through browser_shutdown and relaunches after install-from-disk-image should both be improved. browser_shutdown relaunches include those that occur when Chrome detects a new version and offers to relaunch itself, and those that occur when you change about:flags and click "Relaunch Now." When relaunching Chrome in the same location via browser_shutdown, the same Dock tile should now always be reused, provided that the tile is persistent, meaning that the user has chosen "Keep in Dock" from the tile's contextual menu. The relaunched process' activation status (foreground or background application) should now track the original process' activation status. BUG=42962, 85073 TEST=1a. Change something in about:flags and hit "Relaunch Now" at the bottom. If you had a persistent Dock tile, the same tile should be used for the relaunched browser every time, without fail. 1b. Same, but once you're running a version of Chrome (including a canary) with this fix, when an update is applied and you relaunch from within the application via the "Update Google Chrome" item in the wrench menu or the "Relaunch" button in the about window, the same tile should be used for the relaunched browser every time, without fail. 2. Relaunch after install from disk image. Remove Chrome from /Applications and double-click the Chrome icon in a read-only disk image carrying a version that has this fix. (Our official or canary disk images will work). Chrome will offer to install itself. Let it. Upon completion of the installation, Chrome should launch out of /Applications properly. If you had a persistent Dock tile pointing to a copy in /Applications, it will be used. Activation status (foreground or background) in the relaunched browser will match the status in the process that had run out of the disk image at the time that the installation completed. Review URL: http://codereview.chromium.org/7215040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90371 0039d316-1c4b-4281-b951-d872f2087c98
* Remove default initializtion of BirthPlace in Tracked.ajwong@chromium.org2011-06-232-6/+7
| | | | | | | | | | | | | | | | | | | | | | | Previously, MessageLoop::PostTask set the BirthPlace of the Task object (subclass of Tracked), which would decrement the counter for the Location("NoFunctionName", "NeedToSetBirthPlace", -1) Birth, and replace it with a more appropriate Location provided by the FROM_HERE argument. With the MessageLoop restructuring in r82300, tracking of Births is moved up from the Task object into the MessageLoop::PendingTask structure. The side-effect is that the default birth is never decremented, and we double count each task's creation. This default Birth is effectively a count of "tasks that were created, but not posted" without a stored reference to location, so removing it is the simplest fix to the double counting. BUG=none TEST=about:tasks looks sane. Review URL: http://codereview.chromium.org/7029038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90290 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a check for improper usage of IsOneTimeRandomizationEnabled.joi@chromium.org2011-06-222-11/+11
| | | | | | | | | BUG=none TEST=existing Review URL: http://codereview.chromium.org/7204004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90135 0039d316-1c4b-4281-b951-d872f2087c98
* Localize strings, speeds.avi@chromium.org2011-06-227-151/+189
| | | | | | | | | BUG=86527 TEST=run in non-English. For European languages, during a download the decimal separators should be commas (e.g. "0,0 MB"). (The speeds are in strings files and might take a little time to run through the translation machinery.) Review URL: http://codereview.chromium.org/7189076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90092 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flag to open files in share delete modejochen@chromium.org2011-06-223-0/+40
| | | | | | | | | | BUG=86928 TEST=base_unittests Review URL: http://codereview.chromium.org/7233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90071 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 02:07:42 +0000