summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Mirror Windows implementation of CancelOnMessageLoopThread.dominich@chromium.org2011-08-181-9/+11
| | | | | | | | | | | | | | Before this change, there was a code path where the FilePathWatcher could have been canceled but the delegate_ was not set to NULL. At exit, the destructor would then call Cancel() which would try to post a task to the message loop. With this change, the delegate is correctly set to NULL when the MessageLoop is destroyed even if the FilePathWatcher itself has been canceled. This allows Cancel() from the destructor to do the right thing and not call into the MessageLoop. This implementation matches the Windows version which does not crash. BUG=83190 TEST=FilePathWatcherTest.* Review URL: http://codereview.chromium.org/7655028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97248 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Purify and Quantify.Doing so will reduce substantially the size of ↵jeanluc@chromium.org2011-08-1712-417/+7
| | | | | | | | | the project files. BUG=92102 Review URL: http://codereview.chromium.org/7528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
* Adding checks to guard against buffer overruns in QuotaFileIO::Write and ↵sanga@chromium.org2011-08-172-0/+3
| | | | | | | | | | | | | base::FileUtilProxy::Write Also made some minor changes to fix lint warnings. There are no tests for base::FileUtilProxy. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2076 TEST= test_shell_tests Review URL: http://codereview.chromium.org/7651002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97147 0039d316-1c4b-4281-b951-d872f2087c98
* Adding guards against heap overflow in PPB_FileIO::Readsanga@chromium.org2011-08-171-0/+2
| | | | | | | | BUG= http://code.google.com/p/chromium/issues/detail?id=92750 TEST= none at this time. FileIO tests are turned off for ui_tests. Review URL: http://codereview.chromium.org/7655009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97141 0039d316-1c4b-4281-b951-d872f2087c98
* Include base/stringprintf.h in base/debug/profiler.cc.hans@chromium.org2011-08-171-1/+1
| | | | | | | | | | | | This is needed after r97067. BUG=none TEST=building with GYP_DEFINES="profiling=1" works TBR=tfarina Review URL: http://codereview.chromium.org/7624014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97128 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add DCHECK that double Values are finite.derat@chromium.org2011-08-171-0/+3
| | | | | | | | | | | | | | JSON doesn't support NaN or positive/negative infinity. I'm hoping that this DCHECK will slightly increase the odds that bugs are caught before they start corrupting pref files. BUG=73856 TEST=none Review URL: http://codereview.chromium.org/7646032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97111 0039d316-1c4b-4281-b951-d872f2087c98
* base: Fix the TODO in string_util.htfarina@chromium.org2011-08-171-5/+0
| | | | | | | | | | | | | This removes the include of stringprintf.h from string_util.h and fix the clients. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7633055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97067 0039d316-1c4b-4281-b951-d872f2087c98
* Create ipc.dll.darin@chromium.org2011-08-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7633042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96820 0039d316-1c4b-4281-b951-d872f2087c98
* Add MessageLoopProxy::currentnduca@chromium.org2011-08-1514-41/+55
| | | | | | Review URL: http://codereview.chromium.org/7583053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96819 0039d316-1c4b-4281-b951-d872f2087c98
* Call ntdll.dll!NtTerminateProcess directly, without going through theapatrick@chromium.org2011-08-151-3/+26
| | | | | | | | | | | import table for kernel31.dll!TerminateProcess to determine if TerminateProcess is being hooked. This is an attempt to diagnose the bug referenced below. BUG=81449 Review URL: http://codereview.chromium.org/7640008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96807 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename FileEnumerator::FILE_TYPE to FileEnumerator::FileType.tfarina@chromium.org2011-08-157-25/+25
| | | | | | | | | | | | | | enum types should be named using CamelCase as class and function names, not using MACRO_STYLE. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7618037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96766 0039d316-1c4b-4281-b951-d872f2087c98
* base: Fix the TODO in ListValue::Remove().tfarina@chromium.org2011-08-133-11/+12
| | | | | | | | | | | | | Change the return type of Remove() to bool, and add a size_t output parameter. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7618021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96702 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename ValueType to something less redundant as _just_ Type.tfarina@chromium.org2011-08-122-7/+7
| | | | | | | | | | | | | | | | | | | So instead of: base::Value::ValueType We write a nice: base::Value::Type BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7634018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96614 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a corner case bug in the HexStringToInt conversion function which ↵ali.akbar@gmail.com2011-08-122-2/+3
| | | | | | | | | | | | | | | | | | | | | caused the string "0x" to be treated as a valid hexadecimal number. Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than *or equal* to 2 If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result Changed the condition from "greater than or equal to" to "greater than" Added another test cases which now properly treats "0x" as an invalid hex string Contributed by ali.akbar@gmail.com BUG=92054 Review URL: http://codereview.chromium.org/7584031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add missing OVERRIDE annotations to overridden methods from Value.tfarina@chromium.org2011-08-111-24/+25
| | | | | | | | | | | BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7617016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96452 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Wayland message loop and gyp build depsdnicoara@chromium.org2011-08-115-6/+126
| | | | | | | | | | | | This CL depends on http://codereview.chromium.org/7457023 BUG= TEST= Review URL: http://codereview.chromium.org/7473010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96428 0039d316-1c4b-4281-b951-d872f2087c98
* CrOS - Memory debug widget shows anonymous memory and renderer kills.jamescook@chromium.org2011-08-112-19/+37
| | | | | | | | | | | | | | | Change the status area memory widget to display anonymous memory allocated, which is a good proxy for "total memory allocated" and what we use in the UMA histograms (Platform.MemuseAnon[0-5]). Also display renderer kills, which will tick up when we run out of memory and the OOM killer starts running. Refactor GetSystemMemoryInfo to use a struct. BUG=chromium-os:18969 TEST=manual, turn on memory status widget in about:flags and restart, open some tabs and watch memory consumption increase, use Task Manager / End Process to kill a process and watch the kill count increase Review URL: http://codereview.chromium.org/7607035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96423 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove CreateBinaryValue() function as it's redundant.tfarina@chromium.org2011-08-113-11/+2
| | | | | | | | | | | | | | It does the same thing of BinaryValue::Create(), it's more verbose, and used only in unittest. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7623017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96413 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove using declaration of FundamentalValue as it's no longer necessary.tfarina@chromium.org2011-08-111-1/+0
| | | | | | | | | | | BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7619006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96400 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, ↵mnissler@chromium.org2011-08-113-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7623015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96391 0039d316-1c4b-4281-b951-d872f2087c98
* Update base/android to use new ScopedJava(Global)Referencesteveblock@google.com2011-08-114-19/+15
| | | | | | | | | | | | See http://src.chromium.org/viewvc/chrome?view=rev&revision=95821 BUG= TEST= Review URL: http://codereview.chromium.org/7491099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96359 0039d316-1c4b-4281-b951-d872f2087c98
* Added code to verify whether TerminateProcess is hooked before calling it.apatrick@chromium.org2011-08-111-0/+9
| | | | | | | | | | | | This is to diagnose the bug referenced below. I think it is possible that a third party DLL is hooking TerminateProcess with a replacement that uses the wrong calling convention or has the wrong number of arguments, which causes Process::Terminate to return to the wrong address, causing a crash. I put it in ThreadFunc because this is visible on the stack when the crash happens and because it is a windows specific .cc file. BUG=81449 Review URL: http://codereview.chromium.org/7606016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96266 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95910 - Revert 95907 - Clean up SSL false start blacklist code.pkasting@chromium.org2011-08-103-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host. Original comments follow. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 TBR=fischman@chromium.org Review URL: http://codereview.chromium.org/7587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96211 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Lion: Chrome opens new window on restart when no windows were previously ↵dhollowa@chromium.org2011-08-102-24/+33
| | | | | | | | | | | | | open Changes startup / restore behavior to better match Lion resume expectations. Chrome can get launched by the |loginwindow| process due to the resume feature on Lion. In this case, if there were no windows open in Chrome when restarting, Chrome re-opens with no windows upon login. This is also the expectation under previous OSs when Chrome is a login item, so that's been changed here too. BUG=90249 TEST=Manual. On Lion. Turn Chrome session restore on, close all windows (but don't quit), restart computer. Expect Chrome launches on startup with no open windows. Review URL: http://codereview.chromium.org/7497056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96198 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize phishing page term feature extraction.gcasto@chromium.org2011-08-096-9/+458
| | | | | | | | | | | | | | | | | | | | | | | We've been seeing in the histograms that for some users, page feature extraction is taking much longer than we would like, up to 200ms between stops. This could possibly contribute to jankiness in the UI. These are some timings from my desktop for how long it takes to extract features before and after these changes. Obviously this is on much better hardware than the use case we are worried about, but hopefully the increase is speed is proportional. Before After CNN 19 7.5 ESPN 22 9.5 Google 12 4 Salon 40 12 BUG= TEST=Ran associated unit tests. Review URL: http://codereview.chromium.org/7549003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96097 0039d316-1c4b-4281-b951-d872f2087c98
* Use MessageLoopProxy instead of MessageLoop to dispatch notifications in ↵adamk@chromium.org2011-08-092-23/+71
| | | | | | | | | | | | | | | ObserverListThreadsafe. This is nearly identical to the reverted r96013, with the modification that std::map::insert isn't used. Its invocation was complex (such that it worked in some compilers but not in others) and the performance gain is negligible in any use case I've seen in Chromium. BUG=91589 Review URL: http://codereview.chromium.org/7604006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96076 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove a file that is no longer used.tfarina@chromium.org2011-08-091-22/+0
| | | | | | | | | | | | | Probably since it was added at revision r8. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7558023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96026 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 96013 - Use MessageLoopProxy instead of MessageLoop to dispatch ↵adamk@chromium.org2011-08-092-75/+24
| | | | | | | | | | | | | notifications in ObserverListThreadsafe. BUG=91589 Review URL: http://codereview.chromium.org/7584016 TBR=adamk@chromium.org Review URL: http://codereview.chromium.org/7605002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96024 0039d316-1c4b-4281-b951-d872f2087c98
* Use MessageLoopProxy instead of MessageLoop to dispatch notifications in ↵adamk@chromium.org2011-08-092-24/+75
| | | | | | | | | | ObserverListThreadsafe. BUG=91589 Review URL: http://codereview.chromium.org/7584016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96013 0039d316-1c4b-4281-b951-d872f2087c98
* Implement backend for thread names and process names.nduca@chromium.org2011-08-097-69/+262
| | | | | | | | | | | | | | | | | Added a new trace event phase 'M'/TRACE_EVENT_PHASE_METADATA, which can become a general mechanism for adding metadata to traces. The two M-type events that we then add are: {ph=M pid=<pid> name="process_name" args={ name="name of pid" }} {ph=M pid=<pid> tid=<tid> name="thread_name" args={ name="name of tid" }} base::thread is instrumented to set names automatically. I will do a followon changelist to add instrumentation to Chrome for its various processes and threads. Review URL: http://codereview.chromium.org/7495031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95997 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95441apatrick@chromium.org2011-08-091-5/+3
| | | | | | | | | | | | | | | | This attempted fix for the bug referenced below did not help. Original message: TaskClosureAdapter::Run does not invoke the task if it is null. This is an attempt to fix http://crbug.com/81449. If this actually fixes it then there is probably something more fundamentally wrong. BUG=81449 Review URL: http://codereview.chromium.org/7598015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95931 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, ↵fischman@chromium.org2011-08-083-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95910 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SSL false start blacklist code. Numerous changes, including:pkasting@chromium.org2011-08-083-0/+5
| | | | | | | | | | | | | | | | | | | | | | | * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95907 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeout to 45s.thakis@chromium.org2011-08-081-1/+1
| | | | | | | | | | | | | This is so that long running tests don't flakily bump into the timeout every now and then. BUG=none TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7595008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95860 0039d316-1c4b-4281-b951-d872f2087c98
* Add AutoJObject and AutoGlobalJObjectbulach@chromium.org2011-08-083-0/+138
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7480016 Patch from Steve Block <steveblock@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95821 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove using declaration of MD5Digest now that hunspell was fixed.tfarina@chromium.org2011-08-081-3/+0
| | | | | | | | | | | BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7585029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95804 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeout by 2 more seconds.thakis@chromium.org2011-08-071-1/+1
| | | | | | | | | | | | | | | | | | The previous increase made almost all interactive_ui_tests pass in Debug, but DevToolsSanityTest.TestShowScriptsTab DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh are still failing. They used to take 23.3s and 24s with gcc, and the DevToolsSanityTests got about 5s slower in Debug on 10.5 (less on 10.6). BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7583029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95771 0039d316-1c4b-4281-b951-d872f2087c98
* Increase test timeout for out of process tests by 4 seconds.thakis@chromium.org2011-08-071-1/+1
| | | | | | | | | | | | | | This is to test if the browser_test and interactive_ui_test failures on the mac dbg builds after the switch to clang are due to tests narrowly missing their timeout -- that's what it looks like locally. BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7569033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95770 0039d316-1c4b-4281-b951-d872f2087c98
* Add acquire/release calls in one-time init for histogramsjar@chromium.org2011-08-071-93/+110
| | | | | | | | | | | | Clean up macros which do one-time initialization of static pointer to histograms to use subtle atomic operators. r=willchan, dvyukov BUG=7535006 Review URL: http://codereview.chromium.org/7535006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95762 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove using declaration of BinaryValue as it's no longer necessary.tfarina@chromium.org2011-08-051-5/+3
| | | | | | | | | | | BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7550026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95638 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-05126-950/+978
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove unnecessary using declarations from values.htfarina@chromium.org2011-08-042-3/+4
| | | | | | | | | | | BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7572032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95538 0039d316-1c4b-4281-b951-d872f2087c98
* Fix obsolete dependencies so that needless recompilation does not happen.jeanluc@chromium.org2011-08-041-1/+1
| | | | | | | BUG=71130 Review URL: http://codereview.chromium.org/7545020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95527 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix build with system libevent.phajdan.jr@chromium.org2011-08-041-0/+3
| | | | | | | | | | | | message_pump_libevent_unittest.cc uses libevent directly, and it must get USE_SYSTEM_LIBEVENT symbol to work correctly with libevent. To make that work, base_unittests must depend on libevent.gyp, which uses direct_dependent_settings to set USE_SYSTEM_LIBEVENT. This is upstreaming a Gentoo Linux patch. BUG=none Review URL: http://codereview.chromium.org/7578011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95519 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of a deprecated version of file_util::GetFileExtensionFromPath().tfarina@chromium.org2011-08-042-14/+5
| | | | | | | | | | | BUG=76112 TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7461132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95467 0039d316-1c4b-4281-b951-d872f2087c98
* TaskClosureAdapter::Run does not invoke the task if it is null.apatrick@chromium.org2011-08-041-3/+5
| | | | | | | | | This is an attempt to fix http://crbug.com/81449. If this actually fixes it then there is probably something more fundamentally wrong. BUG=81449 Review URL: http://codereview.chromium.org/7563025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95441 0039d316-1c4b-4281-b951-d872f2087c98
* In test_file_util_mac.cc, when evicting file from cache, do not map a file ↵hnguyen@chromium.org2011-08-031-3/+16
| | | | | | | | | | | | when it is empty. BUG=none TEST=none Review URL: http://codereview.chromium.org/7484052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95334 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchat_t from Time::FromString.shinyak@google.com2011-08-036-134/+224
| | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unittests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7492063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95207 0039d316-1c4b-4281-b951-d872f2087c98
* Added the comment for GetApplicationContext()michaelbai@google.com2011-08-021-1/+3
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7551018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95094 0039d316-1c4b-4281-b951-d872f2087c98
* CrOS - Add memory consumption status bar widget behind flagjamescook@chromium.org2011-08-022-10/+35
| | | | | | | | | | | Pass --memory-widget on CrOS to get a real-time display, updated every 5 seconds, of the system's free memory. Tooltip and menu itself detail the data from /proc/meminfo. Also made base::GetSystemMemoryInfo() available on Linux systems to provide detailed data. BUG=chromium-os:18446 TEST=manual Review URL: http://codereview.chromium.org/7518010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95089 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 08:55:19 +0000