summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup in LaunchApp:phajdan.jr@chromium.org2009-04-181-17/+11
| | | | | | | | | | - don't copy argv strings - use pid_t instead of int - simplify the control flow a bit Review URL: http://codereview.chromium.org/77024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14004 0039d316-1c4b-4281-b951-d872f2087c98
* Retrial of the first step to port file_util::CountFilesCreatedAfter()erikkay@google.com2009-04-187-19/+47
| | | | | | | | | Submitting http://codereview.chromium.org/75033 on behalf of hamaji Review URL: http://codereview.chromium.org/67276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13993 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetAppOutput function, a better replacement for popen.phajdan.jr@chromium.org2009-04-173-0/+92
| | | | | | | | | | | | It will replace popen call in chrome_process_util_linux. I don't see much benefit in having a Windows implementation (not many useful programs you can launch and get output), so POSIX-only. Review URL: http://codereview.chromium.org/67226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13920 0039d316-1c4b-4281-b951-d872f2087c98
* Minor tweaks to deal with the split between CFBundleVersionjrg@chromium.org2009-04-161-1/+6
| | | | | | | | | (which has numerical limits) and Chrome version (which does not). Use Chrome version when we can. Review URL: http://codereview.chromium.org/79021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13881 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include needed for malloc.thestig@chromium.org2009-04-161-0/+1
| | | | | | | | Patch by Craig Schlenter <craig.schlenter@gmail.com> Review URL: http://codereview.chromium.org/67228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13864 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit previous change with GYP files fixed.erg@google.com2009-04-162-68/+0
| | | | | | | | | | | | | Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements. Also: - Fixes window dispositions (shift-click works on bookmark bar items). - Reorganizes gtk_utils Original Review URL: http://codereview.chromium.org/76002 Review URL: http://codereview.chromium.org/67223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13857 0039d316-1c4b-4281-b951-d872f2087c98
* Have ResourceBundle own GdkPixbufs.tc@google.com2009-04-161-2/+0
| | | | | | | | | | | | | | | | | This is the same as how ResourceBundle owns the SkBitmaps it loads. This should be faster than before because ResourceBundle will only load each bitmap once and cache the image. Also fix a memory leak in GdkPixbufFromSkBitmap. valgrind says we're not leaking here. BUG=9988 Review URL: http://codereview.chromium.org/67179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13847 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts the previous two commits. (r13812 and r13811).erg@google.com2009-04-152-0/+70
| | | | | | Review URL: http://codereview.chromium.org/75023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13813 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.erg@google.com2009-04-152-70/+0
| | | | | | | | | | Also: - Fixes window dispositions (shift-click works on bookmark bar items). - Reorganizes gtk_utils Review URL: http://codereview.chromium.org/76002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13811 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TimerTest.RepeatingTimer the suspected test in base_unittests whichnirnimesh@chromium.org2009-04-151-0/+5
| | | | | | | | hangs under Valgrind on Mac. Review URL: http://codereview.chromium.org/73054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13791 0039d316-1c4b-4281-b951-d872f2087c98
* base_unittests.exe is still timing out in the testwtc@chromium.org2009-04-151-0/+3
| | | | | | | | | | | SignatureVerifierTest.BasicTest on the Purify bot, so we still need to disable this test. R=erikkay BUG=10031 Review URL: http://codereview.chromium.org/67172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13754 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13748.erikkay@google.com2009-04-153-21/+18
| | | | | | Review URL: http://codereview.chromium.org/73084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13751 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/73075 on behalf of ↵erikkay@google.com2009-04-153-18/+21
| | | | | | | | shinichiro.hamaji@gmail.com Review URL: http://codereview.chromium.org/73083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13748 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the negative test cases in the testwtc@chromium.org2009-04-152-3/+9
| | | | | | | | | | | SignatureVerifierTest.BasicTest when running inside Purify because Purify disables digital signature verification. R=erikkay BUG=10031 Review URL: http://codereview.chromium.org/69010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13724 0039d316-1c4b-4281-b951-d872f2087c98
* Few changes to the NTP remove thumbnails:jcampan@chromium.org2009-04-151-2/+5
| | | | | | | | | | | | | | - some minor string changes - there is now a Cancel button next to the Done button to restore the thumbnails removed during the current editing session - link and favico are opacified as well in remove mode - now using a dictionary instead of a list to store the URL blacklist for faster access - now storing URL hashes instead of URLs (for privacy and also because the DictionaryValue breaks down keys on . characters) BUG=None TEST=Make sure removing thumbnails works as expected. Start removing thumbnails then click Cancel, verify that the thumbnails just removed are restored. Review URL: http://codereview.chromium.org/69007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13723 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up icon loader/manager in preparation for porting.estade@chromium.org2009-04-141-0/+4
| | | | | | | | Remove a bunch of unused functions and change wstrings to filepaths and remove an obsolete enum. Review URL: http://codereview.chromium.org/73007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13718 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore the value of GetLastError() when [D]LOG/[D]CHECK etc on ↵tommi@google.com2009-04-142-0/+28
| | | | | | | | | | Windows. Also for log levels higher than INFO, the value of GLE is tagged onto the log message. Review URL: http://codereview.chromium.org/73010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13667 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the internal GetStringF to use string16. This saves atc@google.com2009-04-143-50/+54
| | | | | | | | | | | | | | | conversion from string16 to wstring on the linux side when calling GetStringFUTF8 methods. It actually adds extra conversions when calling GetStringF, but we're going to get rid of all those, right? BUG=9911 Review URL: http://codereview.chromium.org/67112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13666 0039d316-1c4b-4281-b951-d872f2087c98
* Typo in test is exposed as a flaky testjar@chromium.org2009-04-141-1/+1
| | | | | | | | | | | | | I recently updated these tests to reduce flakiness, but there was a typo in one line of the update. Since tasks were run serially, the total time to run N-1 tasks should be greater than or EQUAL to the task durtaion, times N-1. r=mark Review URL: http://codereview.chromium.org/74003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cast style.erg@google.com2009-04-131-1/+1
| | | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/67084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13603 0039d316-1c4b-4281-b951-d872f2087c98
* Report what went wrong when initializing NSS_NoDB_Init.erg@google.com2009-04-131-2/+10
| | | | | | | | BUG=9857 Review URL: http://codereview.chromium.org/71009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13602 0039d316-1c4b-4281-b951-d872f2087c98
* Disable gcc 4.4 warnings about hash_map and hash_set beingtc@google.com2009-04-131-0/+14
| | | | | | | | | | | deprecated. backward_warning.h in gcc 4.4.0 wraps the warning around an ifdef __DEPRECATED. Review URL: http://codereview.chromium.org/67056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13599 0039d316-1c4b-4281-b951-d872f2087c98
* Disables the test SignatureVerifierTest.BasicTest on the purify bot assky@chromium.org2009-04-131-0/+3
| | | | | | | | | | | | | it's either crashing or hanging server. I've filed bug 10031 to track this. BUG=10031 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/67081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13594 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce flakiness of condition var unit test by reducing timing dependence.jar@chromium.org2009-04-111-40/+75
| | | | | | | | | | | | | Re-enable test, with hopes that external changes plus my changes reduce flakyness sufficiently. Also switch to using standard sleep method for better readability. bug=3599 r=mark Review URL: http://codereview.chromium.org/19729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13557 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style properties of these new files to LF.wtc@chromium.org2009-04-102-10/+10
| | | | | | | | | | | Normalize the CRLF line endings to LF in signature_verifier.h and signature_verifier_unittest.cc. R=erikkay BUG=6305 Review URL: http://codereview.chromium.org/67060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13548 0039d316-1c4b-4281-b951-d872f2087c98
* Remove histogram connection to base classes in stats_counterjar@chromium.org2009-04-102-14/+11
| | | | | | | | | | | | | | | | Now that histograms move data from renderer to browser, there is less reason to connect to stats counters. Stats counters were using shared memory, and now they may plausibly use the histogram's IPC mechanism instead to move data to the browser. The first step is remove the inheritance, and teh next (plausible/future) step would be to implement counters as histograms with only one bucket. r=mbelshe Review URL: http://codereview.chromium.org/66029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13544 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor spelling typo.ericroman@google.com2009-04-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/67045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13524 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the signature verification API.wtc@chromium.org2009-04-108-0/+876
| | | | | | | | R=erikkay,avi BUG=6305 Review URL: http://codereview.chromium.org/63089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13508 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some ifdefs so that test_shell can be compiled on linuxsky@chromium.org2009-04-104-14/+20
| | | | | | | | | | | | | without GTK. I had to recreate this patch as my workspace for various resonds. UGH! BUG=none TEST=none Review URL: http://codereview.chromium.org/67024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13503 0039d316-1c4b-4281-b951-d872f2087c98
* Restore -Wall to Linux build and set up for -Werror.sgk@google.com2009-04-091-1/+0
| | | | | | | | | | | | | | | * Add -Wall to build/common.gypi (and -Werror, commented out for now). * Have build/external_code.gypi remove -Wall (and -Werror). * Remove chromium_code definition from build/all.gyp. * Remove chromium_code definitions from third_party/ *.gyp files. * Remove scons-specific -Werror removal in webkit.gyp. * Remove unused variables from: base/clipboard_linux.cc chrome/browser/gtk/download_shelf_gtk.cc chrome/browser/gtk/bookmark_bar_gtk.cc Review URL: http://codereview.chromium.org/66001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98
* Replace chrome_process_filter with chrome_process_util.estade@chromium.org2009-04-091-1/+4
| | | | | | | | | | | | | | - move code only used by tests to chrome/test - make a better, more portable abstraction For now, it still only works on Windows. But this is the first step to porting this part of code. Patch by phajdan.jr@chromium.org: <http://codereview.chromium.org/54003> Review URL: http://codereview.chromium.org/67004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13476 0039d316-1c4b-4281-b951-d872f2087c98
* posix: make ctl-C work within gdb for dropping to a console.evan@chromium.org2009-04-081-1/+1
| | | | | | | | See comment in commit for gory details. Review URL: http://codereview.chromium.org/53113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13374 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unused stuff from basictypes.h.deanm@chromium.org2009-04-081-48/+0
| | | | | | | | | | | | My original goal was just to remove down_cast, since it uses RTTI, and I am going to update the build with -fno-rtti. The other stuff I just noticed is unrelated and unused in our code, so we might as well remove it, since it hasn't proven to be useful. Review URL: http://codereview.chromium.org/63121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13349 0039d316-1c4b-4281-b951-d872f2087c98
* Basic underpinnings of the gyp equivalent of the Linux SHARED=1 build:sgk@google.com2009-04-081-3/+3
| | | | | | | | | parameterize the 'type' setting of the various library targets, with a default of 'static_library'. (Hat tip to Craig Schlenter.) Review URL: http://codereview.chromium.org/62127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out file_util functions that use ICU into their own file.sra@chromium.org2009-04-073-72/+92
| | | | | | | | This prevents ~300K of ICU being linked into chrome.exe due to a false dependency. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13281 0039d316-1c4b-4281-b951-d872f2087c98
* Include correct header for uint8_t in gtk_util.hevan@chromium.org2009-04-071-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/63065 Patch from Craig Schlenter <craig.schlenter@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13272 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: store clipboard image as bmp rather than converting to PNG.estade@chromium.org2009-04-073-39/+68
| | | | | | Review URL: http://codereview.chromium.org/63040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13218 0039d316-1c4b-4281-b951-d872f2087c98
* Basic infobars on linux.estade@chromium.org2009-04-062-0/+16
| | | | | | | | All infobars consist of nothing but a non-functioning close button. Review URL: http://codereview.chromium.org/62070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13206 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of refactoring dialogs.avi@chromium.org2009-04-062-2/+11
| | | | | | Review URL: http://codereview.chromium.org/60110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused variable from POSIX SharedMemory implementation.thestig@chromium.org2009-04-042-8/+5
| | | | | | Review URL: http://codereview.chromium.org/62027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13129 0039d316-1c4b-4281-b951-d872f2087c98
* - Added support for keeping track of load times.davemoore@chromium.org2009-04-032-1/+9
| | | | | | | | | | | | | | | | | For each document loaded we record the time the page was requested by the user (or as close as we can get to that), the time the load process started, the time the document and it's dependent resources (scripts) have been loaded (before onload()) and the time all the document's resources have been loaded. We use this data for two things: 1) We histogram the deltas between the time marks 2) We expose the times to javascript running on the page which was loaded Review URL: http://codereview.chromium.org/42527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13116 0039d316-1c4b-4281-b951-d872f2087c98
* Add DirectoryWatcherTest back to the Linux build.thestig@chromium.org2009-04-031-3/+6
| | | | | | Review URL: http://codereview.chromium.org/62014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13102 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/pickle.h. Add some explicit #includes.thestig@chromium.org2009-04-032-4/+6
| | | | | | Review URL: http://codereview.chromium.org/60095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13093 0039d316-1c4b-4281-b951-d872f2087c98
* Put a border around the find bar text entry field.estade@chromium.org2009-04-032-1/+3
| | | | | | Review URL: http://codereview.chromium.org/56207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13091 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce usage of {To,From}WStringHack in file_util_unittest.ccphajdan.jr@chromium.org2009-04-031-58/+60
| | | | | | Review URL: http://codereview.chromium.org/62008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13087 0039d316-1c4b-4281-b951-d872f2087c98
* Make OpenProcessHandle report an error when it couldn't open the handle.phajdan.jr@chromium.org2009-04-033-6/+14
| | | | | | | | One more step to land http://codereview.chromium.org/54003 (chrome_process_util). Review URL: http://codereview.chromium.org/62004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13086 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove dependency on GTK from base/test_suite.h"agl@chromium.org2009-04-031-0/+5
| | | | | | | This reverts commit r13064. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13073 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on GTK from base/test_suite.hagl@chromium.org2009-04-031-5/+0
| | | | | | | (try servers are busted, using the builders) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13064 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move IPC code to ipc/"agl@chromium.org2009-04-033-8/+2
| | | | | | | This reverts commit r13062 which, unsurprisingly, broke the build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13063 0039d316-1c4b-4281-b951-d872f2087c98
* Move IPC code to ipc/agl@chromium.org2009-04-033-2/+8
| | | | | | | (No review URL: Rietvelt couldn't cope) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13062 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 06:15:51 +0000