summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Wrap some lines that are > 80 columns.tc@google.com2008-10-161-9/+13
| | | | | | Review URL: http://codereview.chromium.org/7158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we were truncating the last byte of imagestc@google.com2008-10-161-2/+1
| | | | | | | | | | | | | | | dragged from web content. This was caused by using the wrong helper method to create the storage in os_exchange_data. The method GetStorageForString adds an extra null byte to the data that we were removing at the wrong place in the code. BUG=http://crbug.com/2414 TEST=unit_tests still pass; drag an image from a web page and open it in photoshop Review URL: http://codereview.chromium.org/7372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FileEnumerator (win) for non-recursive, directory-only enumerations.tim@chromium.org2008-10-162-4/+9
| | | | | | | | It previously only actually returned directories for recursive traversals. Review URL: http://codereview.chromium.org/7157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3450 0039d316-1c4b-4281-b951-d872f2087c98
* Store the command line in a more convenient format on non-windows platforms.estade@chromium.org2008-10-153-23/+103
| | | | | | Review URL: http://codereview.chromium.org/7249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3426 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-151-0/+5
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* get webframe_impl.cc to compile on linuxtc@google.com2008-10-144-0/+32
| | | | | | | | | Includes changes from http://codereview.chromium.org/7244 by icefox (Torchmobile Inc.) Review URL: http://codereview.chromium.org/7319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3366 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-141-0/+5
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Port parts of base/process_util to Linux.evanm@google.com2008-10-147-4/+136
| | | | | | | | Review URL: http://codereview.chromium.org/6492 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3363 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-141-0/+5
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up idletimer unittest on Mac port.jeremy@chromium.org2008-10-134-38/+71
| | | | | | Review URL: http://codereview.chromium.org/7243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3328 0039d316-1c4b-4281-b951-d872f2087c98
* Add a templatized scoped GDI handle object. Use this to implement ↵ben@chromium.org2008-10-131-37/+26
| | | | | | | | ScopedBitmap and ScopedHRGN. Review URL: http://codereview.chromium.org/7275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3305 0039d316-1c4b-4281-b951-d872f2087c98
* Basic GTK test shell: links in the SConscript and brings up a window with ↵evanm@google.com2008-10-131-1/+7
| | | | | | | | | nonfunctioning UI. Review URL: http://codereview.chromium.org/2983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3299 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in command line unit test.estade@chromium.org2008-10-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3246 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-106-2/+89
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to register for completion-ports based async operations to be handledrvargas@google.com2008-10-095-7/+223
| | | | | | | | | | | through the windows version of the message pump. As a first step, actual IO processing is still performed using WatchObject instead of using completion ports. Review URL: http://codereview.chromium.org/1950 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3157 0039d316-1c4b-4281-b951-d872f2087c98
* base\gfx file changes from r3137: + gdi_util.cc, - bitmap_header.ccsgk@google.com2008-10-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3150 0039d316-1c4b-4281-b951-d872f2087c98
* Patch by Thatcher Ulrich <tulrich@google.com>.ojan@google.com2008-10-0910-24/+176
| | | | | | | | | | | | | | | Implement "iframe shim" behavior for windowed plugins. In FF and IE on windows, iframes are implemented as native HWNDs. This has the side effect that iframes display on top of windowed plugins. This side effect has long been known as a workaround for allowing HTML elements to appear above plugin content. BUG=1788 Review URL: http://codereview.chromium.org/7032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3137 0039d316-1c4b-4281-b951-d872f2087c98
* Comments out the DCHECK in lock as it causes failures.sky@google.com2008-10-091-1/+3
| | | | | | | | TBR=jar TEST=none Review URL: http://codereview.chromium.org/6604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3129 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkModel to not grab the same lock twice.sky@google.com2008-10-091-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3127 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow recursive locking via the Lock classjar@google.com2008-10-092-113/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | Change contract so that Posix locks (which deadlock on attempts by a single thread to acquire a mutex recursively) and windows critical sections can both be used to implement the Lock() cass, by disallowing recursive locking. In DEBUG mode only, we watch for (now) illegal use of recursive locking. Also remove a pile of cruft that has built up in this file as various folks have re-re-refactored and moved around code. Note that Window's condition variable implementation still uses the AutoUnlock() helper class, but now the implementation (sans nested locking) is very trivial. Posix will probably use their own CV implementation. r=mbelshe Review URL: http://codereview.chromium.org/5630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3105 0039d316-1c4b-4281-b951-d872f2087c98
* remove unneeded webkit_glue:: and wrap windows functions in ifdefserg@google.com2008-10-081-1/+3
| | | | | | | | Review URL: http://codereview.chromium.org/6413 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3065 0039d316-1c4b-4281-b951-d872f2087c98
* Change the font search order to try Lucida Sans Unicode before Arial Unicode ↵jungshik@google.com2008-10-081-1/+1
| | | | | | | | | | | | | | | | | | MS because the former is available on Windows XP or later while the latter is only available with MS Office installed. This is partly to make font-dependent layout test results 'invariant' with or without Arial Unicode MS installed. Eventually, we may want to make those tests more robust against the font availability by removing some Unicode characters not commonly available. BUG=2304 TEST=pass the layout tests affected Review URL: http://codereview.chromium.org/6495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3062 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac clipboard code tolerant of nil clipboard without crashing. Add amark@chromium.org2008-10-081-30/+36
| | | | | | | DCHECK to catch this case, and clean up some of the clipboard code. Review URL: http://codereview.chromium.org/6580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3051 0039d316-1c4b-4281-b951-d872f2087c98
* Provide converters to and from NSString* in sys_string_conversionsmark@chromium.org2008-10-085-8/+77
| | | | | | Review URL: http://codereview.chromium.org/6355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3050 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo I noticed when looking at object tracking. The wrong argument wasbrettw@google.com2008-10-081-1/+1
| | | | | | | given to the printf. Review URL: http://codereview.chromium.org/6356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3041 0039d316-1c4b-4281-b951-d872f2087c98
* Klocwork bug. Checking the wrong variable.cpu@google.com2008-10-081-7/+12
| | | | | | | | BUG = 3103 Review URL: http://codereview.chromium.org/6453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some problems with machine level install.kuchhal@chromium.org2008-10-082-0/+11
| | | | | | | | BUG=2380 Review URL: http://codereview.chromium.org/6402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3015 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac BeingDebugged implementationmark@chromium.org2008-10-081-7/+33
| | | | | | Review URL: http://codereview.chromium.org/6582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3009 0039d316-1c4b-4281-b951-d872f2087c98
* backing out debugging changes now that we know the problem.pinkerton@google.com2008-10-081-5/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3006 0039d316-1c4b-4281-b951-d872f2087c98
* checking debug output for failing test on buildbot. to be backed out in a ↵pinkerton@google.com2008-10-081-0/+5
| | | | | | minute. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3005 0039d316-1c4b-4281-b951-d872f2087c98
* Add -- as a command line switch parsing terminator. This allows you to ↵deanm@chromium.org2008-10-063-8/+41
| | | | | | | | launch chrome to a given URL safely, without having to validate the URL and worry it might be interpreted as a dangerous command line argument. Review URL: http://codereview.chromium.org/6480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2876 0039d316-1c4b-4281-b951-d872f2087c98
* Make ClipboardTest a PlatformTest to get autorelease pool management, neededmark@chromium.org2008-10-031-15/+13
| | | | | | | on the Mac Review URL: http://codereview.chromium.org/6455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2845 0039d316-1c4b-4281-b951-d872f2087c98
* Use the full src-relative path to gtest.hmark@chromium.org2008-10-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2841 0039d316-1c4b-4281-b951-d872f2087c98
* Add a FilePath objectmark@chromium.org2008-10-037-5/+725
| | | | | | Review URL: http://codereview.chromium.org/6025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2838 0039d316-1c4b-4281-b951-d872f2087c98
* Implement MessageLoopForUI using GLib. This gets some exercise fromdsh@google.com2008-10-034-7/+413
| | | | | | | | | | base_unittest. BUG=1319 Review URL: http://codereview.chromium.org/4261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2834 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up clipboard_unittest.cc on the Mac.jeremy@chromium.org2008-10-025-74/+252
| | | | | | Review URL: http://codereview.chromium.org/6424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2815 0039d316-1c4b-4281-b951-d872f2087c98
* Don't throw the thread name setting exception unless a debugger is attached.deanm@chromium.org2008-10-021-0/+5
| | | | | | Review URL: http://codereview.chromium.org/5671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2792 0039d316-1c4b-4281-b951-d872f2087c98
* Add platform_canvas_unittest.ccjeremy@chromium.org2008-10-016-39/+58
| | | | | | | Also fixes issue 2977. Review URL: http://codereview.chromium.org/5644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2777 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform wrappers for fopen, _wfopen_s, etc.mark@chromium.org2008-10-019-61/+69
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>. http://codereview.chromium.org/6005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2760 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where JSON reader errored on reading vertical tabs (\v). Thesky@google.com2008-10-013-2/+7
| | | | | | | | | | | | writer properly escapes a vertical tab, but the readed instead errored on the vertical this. This resulted in lost bookmarks:( BUG=3031 TEST=covered by unit tests Review URL: http://codereview.chromium.org/5628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2759 0039d316-1c4b-4281-b951-d872f2087c98
* Enable error checking on Posix locks in debug, and make release lock ↵deanm@chromium.org2008-10-011-1/+7
| | | | | | | | creation do a little bit less work. Based on suggestions by Gaetano Mendola. Review URL: http://codereview.chromium.org/6038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2755 0039d316-1c4b-4281-b951-d872f2087c98
* Some small cleanups to Lock suggested by Gaetano Mendola.deanm@chromium.org2008-10-012-3/+3
| | | | | | Review URL: http://codereview.chromium.org/6037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix painting problem with transparent plugins because plugins were ignoring ↵jam@chromium.org2008-10-011-0/+8
| | | | | | | | | | | | | | | the alpha channel sometimes. This change introduces another buffer which holds the background image for transparent plugins. Before painting these plugins, their backing store is overwritten with the background data. This change also uses an ACK from the renderer to figure out when it can paint, similar to how the renderer does it, which gives us throttling and also doesn't lead to painting when the tab is hidden. Review URL: http://codereview.chromium.org/5040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2744 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=772,iyengar@google.com2008-10-011-3/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | which was an issue with the browser UI thread entering a tight loop at times. The thread inputs of the browser UI thread and the plugin thread are attached due to the parent child relationship between the windows. As a result at times the MsgWaitForMultipleObjectsEx API returns the fact that there are messages in the queue (mouse messages). The subsequent peek fails to return any messages causing us to enter a loop for a while. This also happens when the plugin has capture and just before it releases capture, some mousemoves end up in the browser ui thread causing a tight loop. The fix is to check if there are mouse messages in the queue by invoking GetQueueStatus and attempting to peek them out with PM_NOREMOVE. If this fails we call WaitMessage to block until the next message. The other fix is to return true from ProcessNextWindowsMessage if PeekMessage returns false and there were sent messages in the queue, as this is as expected. This will ensure that we go back up and peek again instead of calling MsgWaitForMultipleObjectsEx again. Bug=772 R=darin Review URL: http://codereview.chromium.org/6021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2740 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues found looking at the code.maruel@google.com2008-09-3011-61/+51
| | | | | | | | | | Patch from Gaetano Mendola <mendola@gmail.com> Original review: http://codereview.chromium.org/4273 I added some additions on my part and two unit test fix due to the added DCHECK. Reduced atl header inclusion. Review URL: http://codereview.chromium.org/5009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2730 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce RandDouble to one call to ldexp, add one bit of precisionmark@chromium.org2008-09-302-18/+18
| | | | | | Review URL: http://codereview.chromium.org/5801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2712 0039d316-1c4b-4281-b951-d872f2087c98
* Sync Mac canvas implementation with Windows version, still a work in progress,jeremy@chromium.org2008-09-296-138/+102
| | | | | | | | not all unit tests pass yet. Review URL: http://codereview.chromium.org/4339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2702 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring for portability:mark@chromium.org2008-09-2913-0/+333
| | | | | | | | | | | | | - Move chrome/common/env_util to base/sys_info - Move chrome/common/rand_util to base/rand_util (new), simplify its public interface, and fix its implementation Patch by Paweł Hajdan, Jr. <phajdan.jr@gmail.com> http://codereview.chromium.org/4079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2697 0039d316-1c4b-4281-b951-d872f2087c98
* Silence this unit test on Windows 2003 until bug 2732 is fixed.maruel@google.com2008-09-291-0/+4
| | | | | | Review URL: http://codereview.chromium.org/4335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2687 0039d316-1c4b-4281-b951-d872f2087c98
* Display the tmp path to help debug an issue with a build bot.maruel@google.com2008-09-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/4336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2686 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 23:20:11 +0000