summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Update include guard style.agl@chromium.org2008-11-182-6/+6
| | | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/11237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5617 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include guards for scoped_handleagl@chromium.org2008-11-182-6/+6
| | | | | | | | | | For a previous commit, the include guards couldn't be changed otherwise a file move wasn't correctly detected. Review URL: http://codereview.chromium.org/11236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5616 0039d316-1c4b-4281-b951-d872f2087c98
* Add scoped stdio handles.agl@chromium.org2008-11-182-180/+232
| | | | | | | | | | Since file_util uses stdio handles, we'll need this. Specifically, _ph has a review out at the moment which requires them. Review URL: http://codereview.chromium.org/11422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5612 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 5607 because it caused a base_unittest failure.maruel@chromium.org2008-11-181-0/+3
| | | | | | Review URL: http://codereview.chromium.org/11234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5608 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-181-3/+0
| | | | | | | Add more DCHECKs. Review URL: http://codereview.chromium.org/10957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5607 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a proto-type mismatch on a virtual override.deanm@chromium.org2008-11-182-3/+6
| | | | | | | | This was causing us to create a SkDevice instead of creating our special platform device type instead. This fixes one of the main Linux crashes. Review URL: http://codereview.chromium.org/11225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5600 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get the TLS for invalid TLS indexes. Thisnsylvain@chromium.org2008-11-181-0/+3
| | | | | | | | | is making App Verifier complain. This case happens early when the process starts. Review URL: http://codereview.chromium.org/11207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the glib pump getting wedged.deanm@chromium.org2008-11-182-1/+33
| | | | | | | | I had previously used g_main_context_wakeup which uses glib's internal wakeup pipe. However, this won't ensure that our Dispatch method is called, so I think the poll() was returning, but our events never realized this so we kept on blocking infinitely. We need to make sure our Dispatch() is run when there is a wakeup, which means we have to use our own wakeup pipe so we can handle the event. Review URL: http://codereview.chromium.org/11432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5590 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an inaccurate comment.evanm@google.com2008-11-181-1/+2
| | | | | | | Review URL: http://codereview.chromium.org/11221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5588 0039d316-1c4b-4281-b951-d872f2087c98
* addressing commentsagl@chromium.org2008-11-181-9/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5587 0039d316-1c4b-4281-b951-d872f2087c98
* Check ftruncate resultagl@chromium.org2008-11-181-13/+17
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5586 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the locale parameter from the StringToDouble andtc@google.com2008-11-186-131/+78
| | | | | | | | | | | | DoubleToString methods and only leave the locale independent methods. It turns out this code is only used in the json code and if people want locale formatting, they should use ICU. Review URL: http://codereview.chromium.org/11423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5585 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some missing file util functions.estade@chromium.org2008-11-176-21/+25
| | | | | | Review URL: http://codereview.chromium.org/11208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5571 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the uniscribe unittest from the scons build that moved to WebKit.brettw@google.com2008-11-171-2/+0
| | | | | | Review URL: http://codereview.chromium.org/11419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5569 0039d316-1c4b-4281-b951-d872f2087c98
* Debase our Uniscribe code. This moves FontUtils and all our Uniscribe code frombrettw@google.com2008-11-178-1801/+0
| | | | | | | | base/gfx to webkit/port/platform/graphics. I fixed the indenting and naming of the moved code. Review URL: http://codereview.chromium.org/10785 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5561 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the WebSmartPaste pasteboard type on Mac, stub it out on Linux, ↵pinkerton@google.com2008-11-176-4/+33
| | | | | | | | remove the platform ifdefs in common code. Review URL: http://codereview.chromium.org/10955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build to add dmg_fp to the libbase.a.tony@chromium.org2008-11-153-48/+12
| | | | | | | | | Remove third_party/dmg_fp complete since nothing else depends on it. Review URL: http://codereview.chromium.org/10963 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5525 0039d316-1c4b-4281-b951-d872f2087c98
* Move dmg_fp in scons build to compile fromtc@google.com2008-11-153-3/+21
| | | | | | | | base/third_party/dmg_fp and compile it into base_lib. Review URL: http://codereview.chromium.org/10769 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5521 0039d316-1c4b-4281-b951-d872f2087c98
* RandUInt -> RandUint to match the style of other Uint functions.deanm@chromium.org2008-11-144-8/+8
| | | | | | Review URL: http://codereview.chromium.org/10767 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5517 0039d316-1c4b-4281-b951-d872f2087c98
* Move dmg_fp to base/third_party/dmg_fp and include thetc@google.com2008-11-146-12/+3540
| | | | | | | | | | | | files directly in base.vcproj. Remove the old dmg_fp.vcproj file and remove it from the *.sln files. I've kept third_party/dmg_fp around for the mac and scons build which I will fix up in follow up changes. Review URL: http://codereview.chromium.org/10716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5514 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10958mbelshe@google.com2008-11-141-4/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5509 0039d316-1c4b-4281-b951-d872f2087c98
* Don't include system headers inside a namespace.evanm@google.com2008-11-141-1/+6
| | | | | | | Review URL: http://codereview.chromium.org/10950 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5498 0039d316-1c4b-4281-b951-d872f2087c98
* Change to integrate SystemMonitor changes into chrome.mbelshe@google.com2008-11-141-2/+4
| | | | | | | | | | | | This enables the dynamic detection of battery status changes so that we can turn on/off the hi-res timer. Review URL: http://codereview.chromium.org/10264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5489 0039d316-1c4b-4281-b951-d872f2087c98
* Next round of SCons changes:sgk@google.com2008-11-141-0/+2
| | | | | | | | | | | | | | | | | | | * Add 'gdm_fp' to the $LIBS setting in base\using_base.scons (to be removed when that library moves into base\third_party). * Have the grit Scanner search the Repository() copy of the source file (necessary now that $TARGET_ROOT has changed). * Change all the SConscript files underneath chrome\test and chrome\tools to *.scons files, including updating their contents with the current patterns. * Add dependencies of the local_settings_*.res files on the corresponding google_chrome_string_*.rc files, so they get generated properly. * Add generation of the chrome_exe.res resource file. * Comment out some unnecessary .lib settings in the base construction environment. Review URL: http://codereview.chromium.org/10745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5480 0039d316-1c4b-4281-b951-d872f2087c98
* fix bug in locale dependence checktc@google.com2008-11-141-1/+1
| | | | | | | | | this caused us to always go down the language independent path Review URL: http://codereview.chromium.org/10713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5479 0039d316-1c4b-4281-b951-d872f2087c98
* More Mac & Linux fixes for base namespaces.brettw@google.com2008-11-143-8/+8
| | | | | | Review URL: http://codereview.chromium.org/10739 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5450 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build bustage fix.brettw@google.com2008-11-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10737 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5449 0039d316-1c4b-4281-b951-d872f2087c98
* Move process utils into the base namespace (fix build bustage).brettw@google.com2008-11-141-2/+2
| | | | | | Review URL: http://codereview.chromium.org/10736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5447 0039d316-1c4b-4281-b951-d872f2087c98
* Add Terminate() to the Process object, have RenderProcessHost use this to ↵brettw@google.com2008-11-1421-73/+112
| | | | | | | | | | avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Review URL: http://codereview.chromium.org/10895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-141-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork test_shell_main_gtk back into test_shell_main.erg@google.com2008-11-142-0/+9
| | | | | | | | | Still doesn't run layout tests, but it's unforked and runs. Review URL: http://codereview.chromium.org/10905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5413 0039d316-1c4b-4281-b951-d872f2087c98
* Restructure the the pump for nested loops.deanm@chromium.org2008-11-132-42/+83
| | | | | | | | Change our work dispatching to be based around an event source. This will allow us to still participate when a message loop is pumped by outside code (nested message loops). Review URL: http://codereview.chromium.org/10854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5331 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac buildtony@chromium.org2008-11-131-2/+2
| | | | | | | | | | | need to include dmg_fp config settings in debug and release tbr=playmobil Review URL: http://codereview.chromium.org/10665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5325 0039d316-1c4b-4281-b951-d872f2087c98
* fix check depstc@google.com2008-11-121-0/+1
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/10858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5322 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests pass with pt_BR.UTF-8 locale.tc@google.com2008-11-127-46/+232
| | | | | | | | | | | BUG=3675 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> original issue: http://codereview.chromium.org/9509 Review URL: http://codereview.chromium.org/11002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5319 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10610dsh@google.com2008-11-121-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5314 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for save dialogs to take a default extension.sky@google.com2008-11-122-0/+79
| | | | | | | | | BUG=4287 TEST=see bug Review URL: http://codereview.chromium.org/10621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
* Drop the wakeup pipe completely and use the builtin glib wakeup.deanm@chromium.org2008-11-122-39/+3
| | | | | | Review URL: http://codereview.chromium.org/10848 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5296 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite the glib UI pump. Although the previous pump was correct in terms ↵deanm@chromium.org2008-11-122-258/+130
| | | | | | | | of test coverage, it was mis-handling the concept of idle work. This meant we were effectively polling the pump, causing full CPU usage. The new pump is greatly simplified, and follows the pattern used on Windows. All tests still pass. Review URL: http://codereview.chromium.org/10833 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5278 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent crash due to DIB allocation failure joshia@google.com2008-11-122-9/+10
| | | | | | | | | | | | | Change the way we capture tab thumbnail images so that the capturing code can deal with failure. BUG=3795 Review URL: http://codereview.chromium.org/9717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5244 0039d316-1c4b-4281-b951-d872f2087c98
* Force the line endings on .sln files to be CRLF.tc@google.com2008-11-121-103/+103
| | | | | | | TBR=pamg Review URL: http://codereview.chromium.org/10619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5234 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some Windows-specific stuff from RenderProcessHost by having callers ↵brettw@google.com2008-11-113-5/+6
| | | | | | | | get the process handle and PID directly from the corresponding Process object. Review URL: http://codereview.chromium.org/10608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5219 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the GdkSkia object in PlatformContextSkia so that we aren't creatingagl@chromium.org2008-11-111-2/+0
| | | | | | | | | and deleting them for every widget drawn. Review URL: http://codereview.chromium.org/9757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5195 0039d316-1c4b-4281-b951-d872f2087c98
* * Revert "Por rt flush_cache tool."agl@chromium.org2008-11-114-63/+0
| | | | | | | | | This reverts commit 3bd600b37c5ee613c004c84736ee3cb69434562a. Review URL: http://codereview.chromium.org/9774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5184 0039d316-1c4b-4281-b951-d872f2087c98
* Port flush_cache tool.agl@chromium.org2008-11-114-0/+63
| | | | | | | | | | BUG=4160 Review URL: http://codereview.chromium.org/9639 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5182 0039d316-1c4b-4281-b951-d872f2087c98
* make sure we match all the tests and files that linux has running. We were ↵pinkerton@google.com2008-11-112-2/+13
| | | | | | | | never building process_posix, but now the newly added unit tests use it. Review URL: http://codereview.chromium.org/10221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5175 0039d316-1c4b-4281-b951-d872f2087c98
* Added CreateTemporaryFileName that takes a FilePath argument.estade@chromium.org2008-11-115-18/+32
| | | | | | Review URL: http://codereview.chromium.org/9752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5142 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some confusing naming of ClipboardLock. It isn't a lock, and the ↵deanm@chromium.org2008-11-101-44/+38
| | | | | | | | way it was written previous made it seem like it was supposed to be some sort of lock. It was just to manage acquiring the clipboard (which involves some Windows clipboard lock). Review URL: http://codereview.chromium.org/9745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5122 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE. Update string_piece.h to new include style, and remove ↵deanm@chromium.org2008-11-083-6/+3
| | | | | | | | Ben's trailing whitespace. Really just want a buildbot run :\ Review URL: http://codereview.chromium.org/9730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5075 0039d316-1c4b-4281-b951-d872f2087c98
* Dramatically improve the link time in release mode. Today's MC Hammer Xcodemark@chromium.org2008-11-071-0/+16
| | | | | | | | Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake" .dSYM that contains the original unstripped Mach-O file. Review URL: http://codereview.chromium.org/9659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98