summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Drop redundant CommandLine::Terminate.evan@chromium.org2009-10-123-13/+7
| | | | | | | | | We had two functions that did the same thing. Though Terminate came first, I think Reset better conveys the intent. Review URL: http://codereview.chromium.org/267047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28708 0039d316-1c4b-4281-b951-d872f2087c98
* Trim the list of signals used by debug_util::DisableOSCrashDumps() on Mac.mark@chromium.org2009-10-122-19/+16
| | | | | | | | | | | | | | | | | | The list was too long and was catching signals corresponding to Mach exceptions that Apple Crash Reporter never attempts to catch, and signals that don't even map to Mach exceptions. The default signal handlers are fine in these cases. BUG=24568 TEST=Crash reporting still disabled when appropriate (see chrome/app/chrome_dll_main.cc and the comment before DisableOSCrashDumps in ChromeMain) Specifically, with stats reporting disabled, about:crash should result in a sad tab but no silent crash report generated in ~/Library/Logs/CrashReporter Review URL: http://codereview.chromium.org/272025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28701 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-117-726/+0
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Change Mac fullscreen mode to be a stack, not a flag. This fixes crashes andamanda@chromium.org2009-10-112-0/+34
| | | | | | | | | | | | | misbehavior of fullscreen browser windows and plugins, especially when they interact. BUG=23571,24216 TEST=open up multiple browser windows, make them fullscreen, and go to pages (such as video players) that can invoke full screen plugins. The menu bar should hide when the first window becomes fullscreen, show again after the last window stops being fullscreen, and not crash at any of those transitions. Review URL: http://codereview.chromium.org/269022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28690 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on i18n/icu_string_conversions from base/string_util.h.brettw@chromium.org2009-10-108-281/+372
| | | | | | | | | | | | Fix up all files requireing this header to include it directly. Split out the ICU-dependent string util unit tests into a new file base/i18n/icu_string_util_unittest.cc TEST=none BUG=none Review URL: http://codereview.chromium.org/269034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28674 0039d316-1c4b-4281-b951-d872f2087c98
* linux: include stdio.h for snprintfcraig.schlenter@chromium.org2009-10-101-0/+1
| | | | | | | | | | | | | Fixes the following error with gcc-4.4 on Ubuntu: base/safe_strerror_posix.cc: In function ‘void wrap_posix_strerror_r(int (*)(int, char*, size_t), int, char*, size_t)’: base/safe_strerror_posix.cc:86: error: ‘snprintf’ was not declared in this scope Patch by Joel Stanley <joel@jms.id.au> Review URL: http://codereview.chromium.org/269046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28662 0039d316-1c4b-4281-b951-d872f2087c98
* posix: avoid using printf when we're not sure of the types involvedevan@chromium.org2009-10-091-8/+12
| | | | | | | | | It was totally bogus to pass char* to StringPrintf("%ls", ...). I hate this code so much. Review URL: http://codereview.chromium.org/271040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28634 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging macros that automatically append the last system error in string ↵tschmelcher@chromium.org2009-10-095-8/+407
| | | | | | | | | | | | | form. Also add thread-safe, portable variants for strerror() and strerror_r() on POSIX so that existing error logging code that calls strerror() for something other than LOG, LOG_IF, or CHECK can be changed to use safe versions too. After this CL I will eliminate all unsafe uses of strerror() in our code. TEST=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests); trybots for Win, Mac, and Linux 32-bit; built locally for Linux 32-bit and 64-bit and tested base_unittests and also running Chromium itself; wrote the upcoming CL that switches strerror() calls to use PLOG and verified that it builds and works for both Linux 32-bit and Linux 64-bit; lint BUG=none Review URL: http://codereview.chromium.org/265052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove deprecated AbsolutePath function."evan@chromium.org2009-10-092-0/+9
| | | | | | This reverts commit r28593. Random guess at build breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28596 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated AbsolutePath function.evan@chromium.org2009-10-092-9/+0
| | | | | | Review URL: http://codereview.chromium.org/271037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28593 0039d316-1c4b-4281-b951-d872f2087c98
* Add a FilePath version of the CommandLine constructor. Mark the wstring ↵thestig@chromium.org2009-10-092-2/+20
| | | | | | | | | | version as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/271031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28590 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-0918-55/+56
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing scoped_ptr misusage in base/win_util.cctimurrrr@chromium.org2009-10-091-7/+10
| | | | | | | | | BUG=24266 This patch was originally created by Alexander Potapenko (cc'ed) as http://codereview.chromium.org/264013 Review URL: http://codereview.chromium.org/262023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28537 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug that .crx can not be installed by "Could not createtkent@chromium.org2009-10-092-4/+31
| | | | | | | | | | | directory for unzipping." in the case that the environment variable TMP is set to a root directory of a drive such as "C:\" TEST=Add new tests to base_unittest BUG=23911 Review URL: http://codereview.chromium.org/257061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28529 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the missing memory information functions that memory_test uses.vandebo@chromium.org2009-10-082-2/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28486 0039d316-1c4b-4281-b951-d872f2087c98
* Use static_cast in LinkNode<T>::value() so that it works withdarin@chromium.org2009-10-082-3/+19
| | | | | | | | | | | | multiple inheritance. R=eroman BUG=none TEST=LinkedList.MultipleInheritanceNode Review URL: http://codereview.chromium.org/266020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28439 0039d316-1c4b-4281-b951-d872f2087c98
* MD5 header cleanup for lint and items brought up when reviewing code based ↵fbarchard@chromium.org2009-10-081-16/+24
| | | | | | | | on md5. Review URL: http://codereview.chromium.org/266021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28433 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the FileUtilICUTest.ReplaceIllegalCharactersTest as ignored since it is ↵brettw@chromium.org2009-10-081-0/+3
| | | | | | | | | | hanging. TEST=none BUG=none Review URL: http://codereview.chromium.org/261027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28424 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out some more ICU from base and into base/i18n.brettw@chromium.org2009-10-0812-317/+250
| | | | | | | | | | | | | | | | | | | | This moves string_util_icu. I moved the number formatting function into base/i18n/number_formatting and just removed the other function in string_util_icu which was TrimWhitespaceUTF8. It is only used in a few places and isn't actually helpful (and the fact that it round-trips through UTF-16 is better for the caller to see). This takes out the sorting from the FileEnumerator. The comment says the sorting is not guaranteed. I moved it into file_util_icu as a standalone function for callers of FileEnumerator to call manually if they need sorted results. I modified the directory lister to use this sorting instead, and filed a bug on doing more optimal JS-based sorting. TEST=none BUG=none Review URL: http://codereview.chromium.org/267001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28405 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support.rafaelw@chromium.org2009-10-084-7/+17
| | | | | | | | | | | | | | | | | | original issue: http://codereview.chromium.org/207062 The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots. HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI. Additionally, support is added for packaging extensions via ---pack-extension on linux and mac BUG=20668, 20669 TBR=aa,wtc Review URL: http://codereview.chromium.org/265032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28365 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove the concept of physical memory from the task manager.agl@chromium.org2009-10-071-6/+4
| | | | | | | | | | | | | | | Physical memory isn't a concept on Linux. We have private pages and proportional set size. This patch matches the task manager up with about:memory. 'Private memory' gets you the number of private pages and 'Shared memory' is the PSS (except on systems with old kernels that don't have PSS, where it'll be zero). http://codereview.chromium.org/242096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28337 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-0716-1453/+0
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Move all resources into the framework.mark@chromium.org2009-10-072-0/+6
| | | | | | | | | | | | | | BUG=14610 (in support of unbreaking auto-update) TEST=The .app's Contents/Resources folder should not contain the resources that are moving to the .framework's Resources folder; The .app's Contents/Resources folder should still contain app.icns, document.icns, the helper .app, and a whole slew of .lprojs that only contain InfoPlist.strings; Make sure Breakpad still works in the browser, renderer, and other process types. Review URL: http://codereview.chromium.org/256062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28262 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use OCMock in autocomplete_text_field_unittest.mm.shess@chromium.org2009-10-071-0/+1
| | | | | | | | | BUGS=none TEST=unit tests continue to work. Review URL: http://codereview.chromium.org/257063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28256 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ASN1 parsing/serializationrafaelw@chromium.org2009-10-077-633/+574
| | | | | | Review URL: http://codereview.chromium.org/242136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28223 0039d316-1c4b-4281-b951-d872f2087c98
* Copy the relevant parts of ICU to a new file base/third_party/icu/icu_utf.*brettw@chromium.org2009-10-0725-434/+1127
| | | | | | | | | | | | | | so we can do basic UTF8/16/32 conversions without linking all of ICU. Change callers who used to call SysUTF8ToWide/SysWideToUTF8 in base to using these new functions. I will remove the Sys versions of these functions in a later patch. TEST=none BUG=none Review URL: http://codereview.chromium.org/243102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28219 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28166.ojan@chromium.org2009-10-062-337/+8
| | | | | | Review URL: http://codereview.chromium.org/242167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28170 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging macros that automatically append the last system error in string ↵tschmelcher@google.com2009-10-062-8/+337
| | | | | | | | | | form. TESTED=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests) Review URL: http://codereview.chromium.org/255093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28166 0039d316-1c4b-4281-b951-d872f2087c98
* Implement signature_creator_mac. Also moved CSSM memory functions to a ↵rafaelw@chromium.org2009-10-067-66/+129
| | | | | | | | | | common shared location. BUG=20669 Review URL: http://codereview.chromium.org/259026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28135 0039d316-1c4b-4281-b951-d872f2087c98
* Modify extension request IPC messages to pass a ListValue instead of a string.mpcomplete@chromium.org2009-10-062-2/+4
| | | | | | | | | | | | This allows us to pass binary values through extension requests. I use this in my next CL to pass SkBitmaps. BUG=23269 TEST=no Review URL: http://codereview.chromium.org/251093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-061-0/+6
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-051-2/+0
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* Move nsimage_cache into base so that it can be accessed from outside of chrome.mark@chromium.org2009-10-053-0/+101
| | | | | | | | | | This is in support of the next round of rebundling. TEST=does it still build, do the unit tests still pass, does it still work? BUG=14610 Review URL: http://codereview.chromium.org/243100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28016 0039d316-1c4b-4281-b951-d872f2087c98
* Display the flaky test count only if it's bigger than 0.nsylvain@chromium.org2009-10-031-2/+4
| | | | | | Review URL: http://codereview.chromium.org/255072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27962 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for flaky gtests.nsylvain@chromium.org2009-10-031-0/+45
| | | | | | | | BUG:21793 Review URL: http://codereview.chromium.org/243088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27957 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-0311-2879/+0
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-0310-1742/+0
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ICU string conversions into its own file. This new file is includedbrettw@chromium.org2009-10-025-701/+733
| | | | | | | | | | from the old string_util to avoid changing any callers at this time. BUG=none TEST=none Review URL: http://codereview.chromium.org/257032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27914 0039d316-1c4b-4281-b951-d872f2087c98
* Implement RSAPrivateKey for Mac OS Xhawk@chromium.org2009-10-023-2/+406
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/243070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27897 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: initialize timer_.mattm@chromium.org2009-10-011-2/+1
| | | | | | | | | | CID=3805 TEST=None BUG=None Review URL: http://codereview.chromium.org/244050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27773 0039d316-1c4b-4281-b951-d872f2087c98
* The "Copy URL" link is always greyed out in the Chrome menu on popups ↵ericu@google.com2009-10-015-9/+86
| | | | | | | | | | | | | | [crbug.com/13488]. This turns out to be because it was never implemented. Tested manually on Windows; I'll test on Linux before submitting. BUG=13488 TEST=Tested manually on Windows and added a unit test for the new Clipboard function. Review URL: http://codereview.chromium.org/210042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27772 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the PowerObserver API by removing unneeded args and providing ↵pkasting@chromium.org2009-10-014-33/+37
| | | | | | | | | | | | default implementations. This also makes all the subclasses use the same code to add/remove observers. BUG=none TEST=none Review URL: http://codereview.chromium.org/244054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27740 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove a check that can never be true. result is unsigned, so it ↵jhawkins@chromium.org2009-09-301-1/+1
| | | | | | | | | | | can't be less than 0. CID=577 BUG=none TEST=none Review URL: http://codereview.chromium.org/249049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27678 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove the check for index < 0 because index is a size_t and can ↵jhawkins@chromium.org2009-09-301-1/+1
| | | | | | | | | | | never be < 0. CID=6072 BUG=none TEST=none Review URL: http://codereview.chromium.org/243052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27659 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IdleTimer, which no one uses.pkasting@chromium.org2009-09-305-536/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/244049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27658 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all MemoryModel-related code, since we're unlikely to use it again. ↵pkasting@chromium.org2009-09-304-107/+3
| | | | | | | | | | | | Also changes some sample code to use a random generic name ("PruningAlgorithm") instead of MemoryModel in hopes that no one will be confused. This does not remove IdleTimer, even though it now has no users. I do plan to remove it, but I want to do that in a separate commit so it's easy to reference and revert if at some later point we want this functionality. BUG=none TEST=none Review URL: http://codereview.chromium.org/242079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27652 0039d316-1c4b-4281-b951-d872f2087c98
* Don't fire two wake notifications for user-initiated system wake-from-sleep.pkasting@chromium.org2009-09-301-2/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/242070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27627 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-303-8/+34
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the leak tracking of URLRequests.eroman@chromium.org2009-09-301-10/+2
| | | | | | | | | | | | | | This doesn't fix anything, it just prevents asserting (and consequently crashing) when the leak is observed, restoring the earlier behavior. There are already a couple of know leaks, so crashing during shutdown isn't real useful until the known issues are fixed. BUG=18372,23284 TBR=darin Review URL: http://codereview.chromium.org/255017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27586 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-291-0/+2
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 18:58:49 +0000