| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10662038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
So we can move the metro bits to src\
BUG=127799
Review URL: https://chromiumcodereview.appspot.com/10661041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the documentation for base::ThreadChecker to provide context for
deciding whether to publicly inherit from base::NonThreadSafe vs privately
having a base::ThreadChecker member. As per the Google and Chromium C++
style guides, the preference is for composition, rather than inheritance,
combined with good documentation.
BUG=none
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10659012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change content::ResourceResponse to be base::RefCountedData<> rather than
directly inheriting from both ResourceResponseHead and base::RefCounted.
BUG=123295
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10416003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the .isolate file must be specified with --isolate foo.isolate and the
previous --mode option must be the first argument.
This is similar to the last CL done on trace_inputs.py.
The motivating reason is to be able to add command-specific options.
For example, I want to have 'run' and 'trace' to be able to run parallel jobs,
like trace_test_cases.py. This requires a --jobs argument, and possibly
--whitelist and --blacklist too. Also, this permitted to have mode run doesn't
require --result anymore. So this CL creates a base OptionParserIsolate class
that implements the basic options needed to support any gyp foo_test_run
target, then each command can add other options. This will permit to embed all
trace_test_cases.py and run_test_cases.py functionality.
Move all the code to be exception based instead of passing parser.error
function reference around.
Errors are now consistently printed to stderr.
R=cmp@chromium.org
TBR=thakis@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10582036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an almost complete overhaul of how activation works.
oshima@ recently changed ActivationController/FocusManager so that there was a single one per desktop instead of per RootWindow. Because of this, our code that listens for activation changes from X11 is wrong, and has been moved to its own class which also owns the singleton ActivationController.
DesktopActivationController had a wrong model. It should be activating the toplevel window like BrowserFrameAura, even across RootWindows. This has been fixed.
Also moved the utility class ScopedObserver to base/.
TODO: This fixes all activation problems I've seen except for trying to cause a bubble to show when the chrome window is deactivated while a non-chrome window is active.
BUG=130798,133055,133089
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10631008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sergeyu
Review URL: https://chromiumcodereview.appspot.com/10647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables us to pass more file descriptors down to the child process. This
will be used by the Android port.
As part of this, I cleaned up a
ChildProcessLauncher::Context::LaunchInternal to be a little more
generic. This can result in a little extra work but cleans up the
zygote/non-zygote code paths.
Review URL: https://chromiumcodereview.appspot.com/10584007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces two new annotations for the JNI:
@JNINamespace: class-level annotation that indicates all natives methods
are in the specified namespace.
@NativeClassQualifiedName: method-level annotation that indicates the native
method should be bound to the specific class (for instance,
OuterContainer::InnerDelegate). This annotation removes the previously used
feature of commenting the p0 param with the class name.
BUG=
TEST=jni_generator_tests
Review URL: https://chromiumcodereview.appspot.com/10578035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Something isn't being cleaned up properly and we're seeing crashes where we call
into a destroyed class.
BUG=121086
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10535041
TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10633015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is intended for the beta channel.
BUG=134029
TEST=none
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10634015
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10626008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is intended for the beta channel.
BUG=134029
TEST=none
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10634015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TimeDelta.
The previous version of this patch was reverted due to crashing cros_x86 and cros_tegra2 builds. See: http://codereview.chromium.org/9703053/
BUG=108171
Review URL: https://chromiumcodereview.appspot.com/10572030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10579050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust DCHECKs in base::win::SetAppIdForPropertyStore() to reflect the new appid standard which requires less than 64 characters, not 128 (as of Windows 8, see Metro guidelines for details).
BUG=133176
TEST=Chrome installs, launches, and multi-profile OS integration works for user-level installs (on a user with a space in username).
Review URL: https://chromiumcodereview.appspot.com/10559097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Something isn't being cleaned up properly and we're seeing crashes where we call
into a destroyed class.
BUG=121086
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10535041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromiumcodereview.appspot.com/10412045
While at it, clarify the const-ness of the other char* and
use an initializer list for them.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10581035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
location.
Note: This was a TODO for akalin@.
This patch was generated by:
$ find . -name '*.h' -o -name '*.cc' -o -name '*.mm' | xargs sed -i -e "s/base\/message_loop_helpers.h/base\/sequenced_task_runner_helpers.h/g"
R=akalin@chromium.org
TBR=willchan@chromium.org,ben@chromium.org,jam@chromium.org,tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10578026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Invoking "other.release()" where other is of type RValue invokes undefined behavior, because the given pointer is actually of type scoped_ptr<C>. With the NaCl toolchain, this doesn't work as intended, and the pointed-to object gets destructed twice.
BUG=116317
TEST=
Review URL: https://chromiumcodereview.appspot.com/10579030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should be faster, and just as correct.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10565006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable ::testing::IsNull and ::testing::NotNull on scoped_refptr. It
was not working because GetRawPointer needs element_type to be defined in the
Pointer type.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10558017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Create a CurrentProcessInfo class as a central storage place for information about the current process. For now store the process creation time there.
* Move RecordBrowserStartupTime() int browser_main.cc.
The motivation for this is that we will want to add some more UMA measurements which require knowledge of the process startup time.
BUG=None
Test=Chrome should continue to compile on all platforms.
TEST=
Review URL: https://chromiumcodereview.appspot.com/10561009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change suppresses assertion-failure dialogs of VC++ and outputs assertion messages to stderr on Windows. This change calls _CrtSetReportMode and _CrtSetReportFile only when it enables exceptions on Debug. (_CrtSetReportFile seems to depend on them.)
BUG=132037,133313
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10583011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The native targets for base/net/etc should not depend on the
base_java/net_java/etc targets, as they don't actually use the Java code
(only the JNI headers generated from them by
base_jni_headers/net_jni_headers/etc). Removing this dependency allows
the native code to be built without causing ant to run.
The targets which build Android APKs (like base_unittests_apk) already
depend on the Java targets.
Review URL: https://chromiumcodereview.appspot.com/10553036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126838
TEST=build success
Review URL: https://chromiumcodereview.appspot.com/10569002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen supports
integrated touch.
BUG=132362
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10532176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10565038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change GetMetroModule callers that don't need the HMODULE.
TBR=stevenjb@chromium.org,brettw@chromium.org,mirandac@chromium.org,sky@chromium.org,kalman@chromium.org
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10560015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change suppresses assertion-failure dialogs of VC++ and outputs assertion messages to stderr on Windows.
This broke windows tsan and drmemory bot
TBR=hbono@chromium.org
BUG=132037,133313
TEST=drmemroy and windows tsan bot cycles green
Review URL: https://chromiumcodereview.appspot.com/10580002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependency.
This broke base_unittests_swarm on linux.
I guess I did too many lines shuffle today.
TBR=thakis@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10560041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was missing icudt.dll! Oops.
Removed invalid entry '<(PRODUCT_DIR)'.
Minor line shuffling happened due to the different sorting used by
merge_isolate.py.
autogenerated with:
cd tools\isolate
python ..\..\testing\test_env.py trace_test_cases.py out\Release\base_unittests -V PRODUCT_DIR out\Release -c base --root-dir ..\.. --index 0 --shards 10
python merge_isolate.py ..\..\base\base_unittests.isolate ..\..\out\Release\base_unittests.test_cases.isolate -o ..\..\base\base_unittests.isolate
TBR=thakis@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10562043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates differences vs. downstream.
CommandLine, TraceEvent -> content/common, since they are used from browser, renderer, app
LibraryLoader.java -> content/app to match native
Remove JNIHelper which has bitmap helper tools. It was misleadingly
named and incorrectly included (nothing depends on it upstream).
It yet needs to find its right place.
Review URL: https://chromiumcodereview.appspot.com/10532155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change suppresses assertion-failure dialogs of VC++ and outputs assertion messages to stderr on Windows.
BUG=132037
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10565028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initial commit for atomic operations on MIPS architecture.
BUG=https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome
Review URL: https://chromiumcodereview.appspot.com/10448043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10554009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy.
BUG=116317
TEST=compiles, runs HelloWorld and GetURL SDK examples.
Review URL: https://chromiumcodereview.appspot.com/10565015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, Server 2008 R2 and Server 2012 had been treated like Server 2008, which was bad. I debated adding enum values for these two, but I can't think of a compelling argument for it. The big argument against doing so would be that any code that currently has some logic based on the version bearing some relation to VERSION_WIN7, for example, would be broken one way or another on a 2008 R2 box
BUG=129217
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10408084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove statics that are windows only from the
header file, and relocated them the windows only file.
FIx up a few names to make things a bit more readable.
r=rvargas
Review URL: https://chromiumcodereview.appspot.com/8890003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy.
BUG=116317
TEST=compiles, runs HelloWorld and GetURL SDK examples.
Review URL: https://chromiumcodereview.appspot.com/10546140
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10565012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy.
BUG=116317
TEST=compiles, runs HelloWorld and GetURL SDK examples.
Review URL: https://chromiumcodereview.appspot.com/10546140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turned out we were only recording this information on Windows.
Bug=None
TEST=All unit tests should pass
BUG=
Review URL: https://chromiumcodereview.appspot.com/10557007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows classes to more naturally extend classes using WeakPtr.
TEST=None
BUG=
Review URL: https://chromiumcodereview.appspot.com/10537127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessagePumpLibevent::FileDescriptorWatcher::is_persistent_ is not used at all.
BUG=none
TEST=base_unittests
Review URL: https://chromiumcodereview.appspot.com/10534169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting classes for content view, content view client. Includes some
relevant deps needed to build or pass a sanity check.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10536066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10536173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will be needed in webkit/dom_storage/.
BUG=NONE
TEST=Existing tests.
Review URL: https://chromiumcodereview.appspot.com/10540003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-F$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks
It wasn't ever correct to compile or link with this, and it just encourages
people to do stupid things that aren't guaranteed to work at runtime in future
OS releases or with future SDKs. Just #include
<ApplicationServices/ApplicationServices.h> or link against
ApplicationServices.framework by adding
$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework to your
'link_settings': {'libraries': []} section.
The WebKit portion was fixed at https://bugs.webkit.org/show_bug.cgi?id=88569 .
Review URL: https://chromiumcodereview.appspot.com/10535059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=131129
Review URL: https://chromiumcodereview.appspot.com/10538045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
'browser' -> 'app'
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10546119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=122817
TEST=Created an extension with absolute delays under 5 minutes away,
and watched that they didn't fire for 5 minutes.
Review URL: https://chromiumcodereview.appspot.com/10545104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142037 0039d316-1c4b-4281-b951-d872f2087c98
|