| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Windows secondary tiles deletion functions are only available to Chrome itself when running in metro mode. To get around this, the folder containing the installation's secondarty tiles is removed entirely.
BUG=140559
Review URL: https://chromiumcodereview.appspot.com/10876057
TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916109
git-svn-id: svn://svn.chromium.org/chrome/branches/1229/src@154892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we find out the reason of corruption.
See previous change for debugging: http://codereview.chromium.org/10826293/
BUG=140688
TBR=jar
Review URL: https://chromiumcodereview.appspot.com/10857025
TBR=kaiwang@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872023
git-svn-id: svn://svn.chromium.org/chrome/branches/1229/src@152868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when histogram is created.
We will back out this change. This is temporary to catch
corruptions as early as possible.
TBR=jar,kaiwang
TEST=base unittests
BUG=140688
Review URL: https://chromiumcodereview.appspot.com/10826293
TBR=rtenneti@google.com
Review URL: https://chromiumcodereview.appspot.com/10876026
git-svn-id: svn://svn.chromium.org/chrome/branches/1229/src@152867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intended for the beta channel.
BUG=143505
TEST=none
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857064
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10823415
git-svn-id: svn://svn.chromium.org/chrome/branches/1229/src@152355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ChromeOS more consistent with Linux, which uses the DISTRIB_DESCRIPTION from /etc/lsb-release here. We have a different pre-existing mechanism in the code for reading the value (since ChromeOS doesn't have the lsb_release tool), but it's conceptually the same thing.
This makes it possible to search / catagorize ChromeOS crash reports based on the build, or other information about the ChromeOS version. It also allows the matching build/symbols to be more easily found given a crash report.
There's no need for Aura customization of distro anymore - that was added when
Aura was experimental. All ChromeOS is now Aura.
BUG=142630
Review URL: https://chromiumcodereview.appspot.com/10827322
TBR=rbyers@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832393
git-svn-id: svn://svn.chromium.org/chrome/branches/1229/src@152346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the second try of
https://src.chromium.org/viewvc/chrome?view=rev&revision=150240
TBR=jar
Review URL: https://chromiumcodereview.appspot.com/10829212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- CHECK -> DCHECK to prevent breaking exisitng histograms.
Review URL: https://chromiumcodereview.appspot.com/10826180
TBR=kaiwang@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138142
Review URL: https://chromiumcodereview.appspot.com/10821116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10826180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Task is dead.
TBR=ananta@chromium.org,apatrick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes a refactoring of the Ant xml scripts to use a common template (contributed by shashishekhar@chromium.org). As part of this, I also continued Torne's effort of removing our reliance on environment variables. Unfortunately this currently means that you have to specify 5 gyp flags:
ANDROID_SDK, ANDROID_SDK_ROOT, ANDROID_SDK_TOOLS, ANDROID_SDK_VERSION, ANDROID_TOOLCHAIN.
This'll get better as we make further use of the checked in sdk both upstream and downstream. The problem stems from the android tree and released sdk having different configurations.
Review URL: https://chromiumcodereview.appspot.com/10830012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10827175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Gyp targets shouldn't contain source with identical basenames.
Fallout from http://src.chromium.org/viewvc/chrome?view=rev&revision=149842
Review URL: https://chromiumcodereview.appspot.com/10828152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make the LICENSE file more explicit about the fact that the headers used by Chromium use a BSD license.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10843032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139611
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10843041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found with:
$ cppcheck --enable=all -j4 --force base 2> base-errors
R=jar@chromium.org
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/10827112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
2. Fixed another bug in CustomHistogram ranges counting
Review URL: https://chromiumcodereview.appspot.com/10823137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we a) have a PRESUBMIT check for wstring in new code and b) this code isn't used any more.... might as well kill it.
TBR=rsesek@chromium.org
R=mark@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10818016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add memory leak suppressing for StatisticsRecorderTest.
Review URL: https://chromiumcodereview.appspot.com/10827132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=133109
R=robertshield
Review URL: https://chromiumcodereview.appspot.com/10823170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pak files and native libraries.
This patch adds a new value to the PathService to implement the resource pak override and update the places that load pak files to take advantage of it.
Also adds a function for embedders to set the path to native libraries.
Review URL: https://chromiumcodereview.appspot.com/10802065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For problem description and other info please see the BUG page.
This is for ListValue.
BUG=138946
TEST=N/A (no fix & no new feature)
TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj
Review URL: https://chromiumcodereview.appspot.com/10837044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented a skeleton code to handle media file systems.
BUG=140332
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10781014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=137792
Review URL: https://chromiumcodereview.appspot.com/10843038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For classes with long package/class names, this can extend over 80 characters
when preceded by a #ifndef, etc..
BUG=
Review URL: https://chromiumcodereview.appspot.com/10850030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like the existing MIT license was added incorrectly in
http://codereview.chromium.org/1121003. The README file and source headers
state that the correct license is Academic Free License version 2.0 or LGPL v2.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10843034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10831119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added a cryptographic random-number generator to crypto/.
Modified sync to use this function instead.
May also be used by Cloud Print in the future.
Review URL: https://chromiumcodereview.appspot.com/10698177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Java ContentViewCore object may be garbage
collected without first destroying the native object. Because of this,
all C++->Java calls to ContentViewCore must be guarded with a null
check.
BUG=139386,138237
Review URL: https://chromiumcodereview.appspot.com/10827125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=140145
Review URL: https://chromiumcodereview.appspot.com/10829133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As titled, pipes the Windows specific methods to the appropriate
internal allocators.
BUG=none
TEST=manual test with each allocator over various alignments.
Review URL: https://chromiumcodereview.appspot.com/10828054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/10843029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. Remove duplicated code from histogram.h/.cc,
including validating related code and BucketRanges related.
2. Constness of BucketRanges from Histograms, to prevent accidentally modification and provide a simpler interface.
3. Add/move tests.
Review URL: https://chromiumcodereview.appspot.com/10834011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will simplify the addition of a tool to check licenses for the purpose of
the Android WebView build.
See also http://codereview.chromium.org/10827099
Also adds other missing fields to these README.chromium files as required by
presubmit checks and fixes a regex used to enforce this.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10821103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On iOS, once an application goes into the background, it receives no CPU cycles until it is moved to foreground. At any time the OS may kill the application, but the application itself is never told or given any chance to clean up. Thus the time before going into the background is critical to ensure certain tasks have chance to complete.
Luckily, an application may ask for a little more time when going into the background by calling certain methods that let the OS know it wants to perform some short-lived work in the background. This cl provides APIs to protect critical tasks in this case.
- A class is provided to mark the beginning and end of a critical task for iOS.
- A wrapper around a task is introduced that annotates that a class is "critical". Right now we have the wrapping code for iOS and it is just a no-op for other platforms.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/10835032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This annotation is used to disable specific instrumentation tests.
While at it, disable the failing testBaseStartup.
BUG=139365,139870
TEST=Android FYI tester bot is green.
Review URL: https://chromiumcodereview.appspot.com/10829104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic to calculate where the SDK should be is already done by
envsetup and made available to gyp as a variable, so just have gyp pass
this as a command line argument to ant. The behaviour is identical.
This change is to move toward making it possible to build the Android
port without having envsetup.sh sourced at build time (only at
gyp-generation time), making it more like other platforms. It also
simplifies the ant buildfiles.
Review URL: https://chromiumcodereview.appspot.com/10821105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=137864
TEST=StringPrintfTest
Review URL: https://chromiumcodereview.appspot.com/10800078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DIR_APP_DATA.
This implementation creates a DIR_APP_DATA directory if it does not exist. This is needed for iOS because on iOS NSApplicationSupportDirectory directory does not exist unless it is created explicitly.
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10795010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108171
Review URL: https://chromiumcodereview.appspot.com/10821062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Lets -Wunused-private-field find more stuff
* Fixes an ASan problem on precise
* Improves the plugin's handling of inner classes (off by default,
can be enabled with |-Xclang -plugin-arg-find-bad-constructs
-Xclang check-inner-classes|)
* Makes addr2line much faster on linux
BUG=139346
TBR=mark for base (the change was reviewed as part of https://chromiumcodereview.appspot.com/10833055/)
Review URL: https://chromiumcodereview.appspot.com/10825104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found with:
$ ./build/gyp_chromium -Dclang=1 -Dclang_use_chrome_plugins=1
$ ninja -C out/Debug base -k4 -j4 2>&1 | tee errors
And a tweak in plugin_flags.sh
BUG=115047
R=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This allows DevicesChangedObserver to listen to desired events, instead of being woken up by change of uninterested devices.
BUG=137799
Review URL: https://chromiumcodereview.appspot.com/10836004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of including singleton.h in header files we can forward declare it,
and include only in the source file.
There is also a presubmit check for this, I didn't know ;)
R=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10835029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When the sum of the buckets is "significantly" different from a second counter, which is incremented when any bucket is bumped, then we declare the histogram to be potentially "spammed." The limit was a difference by 1, but examination of the UMA uploads shows that for some histograms, this can grow larger. This CL increases the threshold from "as much as 1 away" to "as much as 5 away."
r=rtenneti
Review URL: https://chromiumcodereview.appspot.com/10833026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mimic code seen in message_loop.cc (since these tasks are run on named
threads) to support tracking of sequenced worker pool runs of tasks.
We surround the *.Run() method with a call to get the time before we
start, and then call to tally the time it took to run after task.Run()
returns.
r=brettw
BUG=139035
Review URL: https://chromiumcodereview.appspot.com/10825022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JNI generator was being confused by the word 'native' appearing
in a block comment in ChromeBrowserProvider.java. This patch ensures
that all comments are stripped out correctly.
BUG=138941
TEST=jni_generator_tests.py
Review URL: https://chromiumcodereview.appspot.com/10830035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On newer JB builds, the JNINativeInterface struct appears to be held
in read-only memory so attempting to repoint individual function pointers
in it causes segfault. So instead we repoint the top-level struct pointer
to refer to our own copy held in read/write memory.
BUG=137348
TEST=JNIAndroidTest
Review URL: https://chromiumcodereview.appspot.com/10828050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the default value. It can be overridden with GYP_DEFINES. It is with
the swarm master.
Also remove the corresponding XXX_run targets. These can be problematic when
developers are moving files around, especially with DEPS rolls.
This simplifies build slave management during the deployment as the .isolate
files are being rolled out.
TBR=cmp@chromium.org
NOTRY=true
BUG=139426
Review URL: https://chromiumcodereview.appspot.com/10828061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Compile
Review URL: https://chromiumcodereview.appspot.com/10825048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148846 0039d316-1c4b-4281-b951-d872f2087c98
|