summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Fix nacl_sandbox_tests dependency:victorw@chromium.org2010-07-191-1/+1
| | | | | | | | | | | | | | | allocator target should be added as dependency only when win_use_allocator_shim is 1. Also fix a typo in allocator_shim.cc R=jvoung@google.com, mbelshe@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/3011011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52947 0039d316-1c4b-4281-b951-d872f2087c98
* Compress and checksum pending logs that are going to be persisted. Persisted ↵ziadh@chromium.org2010-07-193-5/+5
| | | | | | | | | | | | | | | | logs now have the following format: [list_size, log1, log2, ..., log_n, checksum]. where each log is bzipped before being written. Upon reading the logs from disk, we verify the data and register whether we faced corruptions or not. r=jar Review URL: http://codereview.chromium.org/2936005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52885 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: deprecate remaining wstring functionsevan@chromium.org2010-07-161-6/+6
| | | | | | | | | | | This removes the last wstring-accepting functions from file_util on non-Windows platforms. BUG=24672 Review URL: http://codereview.chromium.org/3005005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52755 0039d316-1c4b-4281-b951-d872f2087c98
* Remove lock.h from resource_bundle.h and histogram.h.erg@chromium.org2010-07-162-2/+4
| | | | | | | | | | | Use a scoped_ptr<Lock> instead of Lock in resource bundle. BUG=none TEST=none Review URL: http://codereview.chromium.org/3038005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52730 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Guess the thread id for crashing renderers in a different PID namespace.thestig@chromium.org2010-07-162-0/+53
| | | | | | | | BUG=48997 TEST=Google Chrome gets valid crash reports for about:crash most of the time. Review URL: http://codereview.chromium.org/2961008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52723 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more definitions from header files.erg@chromium.org2010-07-164-8/+30
| | | | | | | | | | | This patch only concerns itself with places where we have more than 100 copies of methods being generated. (For example, the destructor and other random methods in FilePath weren't being inlined, leading to several hundred copies being generated.) BUG=none TEST=none Review URL: http://codereview.chromium.org/3039001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52694 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52608 - Add and alternative GetAppOutput() to process_util that takes ↵viettrungluu@chromium.org2010-07-163-141/+19
| | | | | | | | | | | | | | | | | | | | a timeout. ["base_unittests" didn't exit cleanly on "Chromium Linux x64" but was killed due to timeout.] Contributed by tessamac@chromium.org TEST=none BUG=47356 Review URL: http://codereview.chromium.org/2810014 Patch from Tessa MacDuff <tessamac@chromium.org>. TBR=viettrungluu@chromium.org, tessamac@chromium.org Review URL: http://codereview.chromium.org/3012004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52613 0039d316-1c4b-4281-b951-d872f2087c98
* Add and alternative GetAppOutput() to process_util that takes a timeout.viettrungluu@chromium.org2010-07-163-19/+141
| | | | | | | | | | | | Contributed by tessamac@chromium.org TEST=none BUG=47356 Review URL: http://codereview.chromium.org/2810014 Patch from Tessa MacDuff <tessamac@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52608 0039d316-1c4b-4281-b951-d872f2087c98
* base: Return bool instead of void in EnvVarGetter::SetEnv.tfarina@chromium.org2010-07-164-9/+12
| | | | | | | | | | | | | | | Returning bool instead of void in this function is better, because with that we can know if we had succeeded when tried to set an environment variable or not. Also it makes this function more testable. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.* Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2891024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52602 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill credit cards should be encrypted on the Macdhollowa@chromium.org2010-07-161-1/+1
| | | | | | | | | | | These changes add encryption support on Mac for the Encryptor class. AES 128 bit is used for the encryption, and the auto-generated password is stored now in the Mac Keychain. This implies the Encryptor class on Mac can now block for user input, and can fail if access is denied. BUG=42038, 49131 TEST=EncryptorTest.CypherTextDiffers, EncryptorTest.DecryptError, EncryptorPasswordTest.* Review URL: http://codereview.chromium.org/2943014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52590 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementation from header to source.erg@chromium.org2010-07-1515-69/+182
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt four at landing the "histogram.h removed from message_loop.h" patch.erg@chromium.org2010-07-155-45/+47
| | | | | | | | | | | | | | Previously committed as r52349 and r52336. Related commits: r52367, r52364 and r52343. Rerunning trybots due to previous trybot breakage. TEST=none BUG=none Review URL: http://codereview.chromium.org/2965015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a DCHECK with DCHECK_EQ.thestig@chromium.org2010-07-151-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2919013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52429 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some helper tools to use FilePaths for file names.evan@chromium.org2010-07-141-1/+4
| | | | | | | | | | | | | | Add a "PRFilePath" macro to file_path.h for use in printf'ing a FilePath. These are some of the last users of deprecated file_util functions (e.g. OpenFile(wstring, ...)). BUG=24672 Review URL: http://codereview.chromium.org/2929002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52391 0039d316-1c4b-4281-b951-d872f2087c98
* NSS's filesystem speed detection doesn't work with the latest versionswtc@chromium.org2010-07-141-28/+56
| | | | | | | | | | | | | | | | | | | of sqlite, such as 3.6.22. Set the NSS_SDB_USE_CACHE environment variable to "yes" to override NSS's detection if the database is on NFS. Get rid of the USE_NSS_FOR_SSL_ONLY macro because it is simply the opposite of USE_NSS. Use EnvVarGetter to get and set environment variables. Use FilePath instead of std::string to represent path names. R=thestig BUG=48585 TEST=Run Chrome on Ubuntu Lucid with a home directory on "slow" NFS. HTTPS connection setup shoud not be very slow. Review URL: http://codereview.chromium.org/2895015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52379 0039d316-1c4b-4281-b951-d872f2087c98
* Revert everything related to the relanding.erg@chromium.org2010-07-145-47/+45
| | | | | | Review URL: http://codereview.chromium.org/2982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52336.erg@chromium.org2010-07-145-45/+47
| | | | | | | | | | | | | | (I accidentally committed a previous version of the patch (the fixed version was in codereview since I had switched to my mac to address this exact compile failure.) BUG=none TEST=none TBR=evan Review URL: http://codereview.chromium.org/2937010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52336 - More header cleanup:erg@chromium.org2010-07-145-47/+45
| | | | | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52343 0039d316-1c4b-4281-b951-d872f2087c98
* More header cleanup:erg@chromium.org2010-07-145-45/+47
| | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52336 0039d316-1c4b-4281-b951-d872f2087c98
* Use file_util::GetHomeDir instead of getenv("HOME").tfarina@chromium.org2010-07-142-7/+7
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52272 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Tweak content settings window.thakis@chromium.org2010-07-131-0/+1
| | | | | | | | | | | | | | Add "Features" label to source list. xib change: Add some vertical space at the top of each tab, change outline view cell size to "small", hook up new outlet. http://i.imgur.com/KGES6.png BUG=45546 TEST=Content settings window still works: Current pane is still remembered, and opening the window from a bubble selects the right pane. Review URL: http://codereview.chromium.org/2932009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52199 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add support for SymmetricKey to import raw keys when using NSS."albertb@chromium.org2010-07-125-93/+23
| | | | | | | | | | | | This reverts commit e9757388eb66acc907c79a3c82b0006c36e0714a. BUG=none TEST=none TBR=arv Review URL: http://codereview.chromium.org/2962010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52138 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for SymmetricKey to import raw keys when using NSS.albertb@chromium.org2010-07-125-23/+93
| | | | | | | | | BUG=48512 TEST=unittests Review URL: http://codereview.chromium.org/2811045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52136 0039d316-1c4b-4281-b951-d872f2087c98
* Roll GTM r330:375.rsesek@chromium.org2010-07-122-2/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2969003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52127 0039d316-1c4b-4281-b951-d872f2087c98
* Added DISALLOW_COPY_AND_ASSIGN to ScopedNativeLibrary.apatrick@chromium.org2010-07-121-0/+1
| | | | | | | | | TEST=try BUG=none Review URL: http://codereview.chromium.org/2845034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52103 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flakeyness in the timer test.mbelshe@chromium.org2010-07-121-1/+8
| | | | | | | | | | | | | | | | | | | | There were two problems. First, I changed the API so you need to activate high resolution timers, and that was not getting called. So if nobody else was activating them, the timers were definitely not high resolution anymore. Secondarily, the test was too aggressive. We set the resolution to 1ms (via timeBeginPeriod on windows), which means that we could get up to ~1.5 * 1ms of slop. Without the change, I was getting failures in about 1/800 runs. With the new value (8500ms instead of 9000ms), I get zero failures in 5000 runs before I stopped trying. BUG=none TEST=self Review URL: http://codereview.chromium.org/2927005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52080 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add SetEnvVar test to env_var_unittest.cctfarina@chromium.org2010-07-091-0/+14
| | | | | | | | | BUG=None TEST=env_var_unittest.cc. out/Debug/base_unittests --gtest_filter=EnvVarTest.SetEnvVar Review URL: http://codereview.chromium.org/2935002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52017 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: Move deprecated function UpOneDirectoryOrEmpty into an anonymous ↵tfarina@chromium.org2010-07-092-12/+0
| | | | | | | | | | | | | | namespace. This function is used in one place and is deprecated, so would be good to move it there so no one can make other uses of it. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/2809049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51963 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: Get rid of most uses of UpOneDirectory.tfarina@chromium.org2010-07-091-5/+1
| | | | | | | | | | | (Remaining one usage to be fixed, until we can remove it completly.) BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/2841039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51952 0039d316-1c4b-4281-b951-d872f2087c98
* Define USE_SYMBOLIZE for Solaris because we build the 'symbolize' targetwtc@chromium.org2010-07-091-6/+2
| | | | | | | | | | | | | on Solaris. This allows us to merge two conditionals. R=evan,mark BUG=none TEST=no build errors on any platform. Review URL: http://codereview.chromium.org/2924002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51919 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: uninitialized member in posix WaitableEventWatcher constructor.mattm@chromium.org2010-07-091-0/+1
| | | | | | | | | | CID=9290 TEST=builds BUG=none Review URL: http://codereview.chromium.org/2954001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51917 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Minimize usage of gtk headers.erg@chromium.org2010-07-081-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51898 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate most of the remaining wstring file_util functions.evan@chromium.org2010-07-082-18/+30
| | | | | | | | | | | | | These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. (I am already finding new code using some of these! I am glad to be rid of them.) BUG=24672 Review URL: http://codereview.chromium.org/2850042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51862 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sources/ exclude and sources! rules that apply only towtc@chromium.org2010-07-081-9/+16
| | | | | | | | | | | | | | base_extra_target to the base_extra_target block. Test base_extra_target==1 for consistency with the base_target==1 conditional in the same file (just a style nit). R=jam,mark BUG=none TEST=no build errors on any platforms Review URL: http://codereview.chromium.org/2878027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51852 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add SetEnv() to EnvVarGetter class and get rid of the some ifdefs.tfarina@chromium.org2010-07-083-2/+19
| | | | | | | | | | | (Note: This was a TODO) BUG=None TEST=included Review URL: http://codereview.chromium.org/2843048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51840 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of the deprecated SysInfo::GetEnvVar.tfarina@chromium.org2010-07-084-32/+0
| | | | | | | | | | | Use the new EnvVarGetter::GetEnv instead. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2876045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51829 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add unittests for the EnvVarGetter class.tfarina@chromium.org2010-07-082-0/+25
| | | | | | | | | BUG=None TEST=env_var_unittest.cc Review URL: http://codereview.chromium.org/2811044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51822 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock for OS X CSSM wrapper APIsdavidben@chromium.org2010-07-072-0/+33
| | | | | | | | | | | | They're apparently problematic with threads. R=agl BUG=48006 TEST=KeygenHandler.ConcurrencyTest Review URL: http://codereview.chromium.org/2832047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51734 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of the deprecated SysInfo::HasEnvVar.tfarina@chromium.org2010-07-054-23/+3
| | | | | | | | | | | Use the new EnvVarGetter::HasEnv instead. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2819042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51648 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the pre-reading of chrome.dll to read it as an image section ↵ananta@chromium.org2010-07-032-0/+34
| | | | | | | | | | | | | | | | | | | instead. XP ignores pages read as data while mapping image sections. This shows a reasonable improvement in cold startup performance on XP. This change only comes into effect for headless mode which enables us to try out the effect on the perf bots and for chrome frame processes. Code mostly written by Amit. Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading. Bug=45510 Review URL: http://codereview.chromium.org/2805064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51594 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos]Set GtkWidget's default direction correctly.suzhe@chromium.org2010-07-021-1/+10
| | | | | | | | | BUG=41558 TEST=Login ChromeOS with a RTL language, the text in the omnibox should be right aligned. Review URL: http://codereview.chromium.org/2833052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51471 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Undo a bit of tcmalloc gyp change from r49597. The reverted change ↵thestig@chromium.org2010-07-021-11/+11
| | | | | | | | | | puts direct_dependent_settings inside a configuration dictionary, which is invalid. BUG=45067 TEST=GYP_DEFINES='linux_use_tcmalloc=0' gclient runhooks works. Review URL: http://codereview.chromium.org/2819031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51470 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate more old filepath functions.evan@chromium.org2010-07-012-8/+11
| | | | | | | | | | | | These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. BUG=24672 Review URL: http://codereview.chromium.org/2861042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51453 0039d316-1c4b-4281-b951-d872f2087c98
* Loosen permission on extension temp dir when a flag is used.skerner@chromium.org2010-07-017-7/+94
| | | | | | | | | | | | | | | | | | | Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome: --issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped. --issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process. --issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory. BUG=35198 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51231 Review URL: http://codereview.chromium.org/2802018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51416 0039d316-1c4b-4281-b951-d872f2087c98
* Moves gtk accelerator processing functions to base/gtk_util so I cansky@chromium.org2010-07-013-3/+75
| | | | | | | | | | | | | use them from views and gfx. Sorry for the new patch on this and not an update. Not sure what happened. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
* Catch OOMs in purgeable memory.avi@chromium.org2010-07-013-7/+172
| | | | | | | | | | | Recommit of r51371, this time not crashy. BUG=http://crbug.com/47980 TEST=unit tested Review URL: http://codereview.chromium.org/2817048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51407 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51371 - Catch OOMs in purgeable memory.avi@chromium.org2010-07-013-170/+7
| | | | | | | | | | | | BUG=http://crbug.com/47980 TEST=unit tested Review URL: http://codereview.chromium.org/2859036 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/2883014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51373 0039d316-1c4b-4281-b951-d872f2087c98
* Catch OOMs in purgeable memory.avi@chromium.org2010-07-013-7/+170
| | | | | | | | | BUG=http://crbug.com/47980 TEST=unit tested Review URL: http://codereview.chromium.org/2859036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51371 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51231 - Loosen permission on extension temp dir when a flag is used.skerner@chromium.org2010-06-307-95/+12
| | | | | | | | | | | | | | | | | | | | Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome: --issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped. --issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process. --issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory. BUG=35198 TEST=manual Review URL: http://codereview.chromium.org/2802018 TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/2861039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51238 0039d316-1c4b-4281-b951-d872f2087c98
* Loosen permission on extension temp dir when a flag is used.skerner@chromium.org2010-06-307-12/+95
| | | | | | | | | | | | | | | | | Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome: --issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped. --issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process. --issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory. BUG=35198 TEST=manual Review URL: http://codereview.chromium.org/2802018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51231 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-25 14:01:55 +0000