| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currying, and use less types.
The main API change IgnoreResult() and fully currying. See unittest for what the new API looks like. The rest of the changes are done to support that.
Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object. Now, IgnoreResult() wraps the function like Unretained().
As an incidental benefit, the new implementation gave us fully currying for free.
Also, the new implementation scales better when supporting higher arities of functions. The new type growth is:
(n^2 + 20n) / 2
as opposed to
(3n^2 + 17n) / 2
where n == arity.
For n = 6 and n=10, the new implementation has 81 and 155 templates respectively.
The old implementation had 105 and 235 templates respectively.
BUG=35233,98919,98542
TEST=existing unittests
Review URL: http://codereview.chromium.org/8483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8354008
Review URL: http://codereview.chromium.org/8354008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds necessary pieces to get the WebKit compositor working with
compositor_unittests target on Mac. Required gyp build flags are:
'use_aura': 1,
'use_webkit_compositor': 1,
'use_skia': 1,
BUG=104390, 104555
TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.* passes and shows correct visual results.
Review URL: http://codereview.chromium.org/8486020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal was to avoid alloc/free during the thread
teardown callback, and this CL provides a very simple
and clear implementation.
r=rtenneti
BUG=104696
Review URL: http://codereview.chromium.org/8597017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=102903
TEST=compile
Change-Id: I96c63b55a6be4623f8edd202a1642ae6f7a6eb7a
R=mark@chromium.org,oshima@chromium.org,dnicoara@chromium.org
Review URL: http://codereview.chromium.org/8561018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8555001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Main motivation for this is webkit's createFile.
While creating files with permission 0600 is not an issue on other platforms,
on ChromeOs FileBrowser may access external filesystem, so it makes sense to
create files with permission 0644.
Further more creating files with mode 0600 on ChromeOS external fielsystem may
cause some problems with zip file support (see bug).
Note this is M16 release blocker...
BUG=chromium-os:22263
TEST=linux_chromeos trybots
verified copying files in FileBrowser on ChromeOs creates files with permission 644
Review URL: http://codereview.chromium.org/8590020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GIven that TCMalloc might get its thread teardown
notifgication ahead of the profiler, we need to be
careful to not do an alloc in the teardown handler.
If we did, we might bring TCMalloc back to life on
this thread... and it might not get a second teardown
notification.
r=rtenneti
BUG=104696
Review URL: http://codereview.chromium.org/8587031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8579001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add BASE_EXPORT to classes that were previously exported via MessageLoop
BUG=none
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8549017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instructed to do so.
Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c
BUG=None
TEST=base_unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110021
Review URL: http://codereview.chromium.org/8505033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=willchan@chromium.org,stoyan@chromium.org
Review URL: http://codereview.chromium.org/8591009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not really part of the JSON standard but a common practice and is
harmless in most of the cases so we can enable it for JSON policy files.
BUG=101141
TEST=none
Review URL: http://codereview.chromium.org/8423079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=mark@chromium.org
Review URL: http://codereview.chromium.org/8513019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles and passes tests
Review URL: http://codereview.chromium.org/8570022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybot compile
Review URL: http://codereview.chromium.org/8572034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It has been subsumed by about:profiler.
I also added a button to about:profiler that matches the behavior of "about:tracking/reset" (nukes the tracked objects). That way there shouldn't be any functionality loss in deleting about:tracking.
BUG=100992
Review URL: http://codereview.chromium.org/8568036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8520018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Null time values can appear if the profiler is
not ACTIVE, and the Now() function returns a Null
value (to avoid wasting time and calling the OS Time).
r=rtenneti
Review URL: http://codereview.chromium.org/8573017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't pollute the namespace with defines from C header files and forward
declare WaylandEvent.
BUG=102903
TEST=compiles
Change-Id: I5cd50c04361d4d053bdf8c193071a4c7808c51d7
R=oshima@chromium.org,dnicoara@chromium.org,mark@chromium.org
Review URL: http://codereview.chromium.org/8572030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also removes copy/pasted instances of this class.
BUG=none
TEST=none
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8565024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
r=rvargas
bug=102940
Review URL: http://codereview.chromium.org/8487004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialization of the profiler is supposed to happen while
single threaded. The tests however often skip affirmative
initialization, and rely on lazy initialization. This
CL tightens up that process, to reduce changes of races
(even benign races) during testing.
I also added a suppression for examination of the state,
which is always a benign race. At initialization time
we rely on a lock (now) to ensure race freedom (if we
get a racy value of state).
r=rtenneti
Review URL: http://codereview.chromium.org/8570007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NaCl processes need an unusually large amount of address space, because
they do huge PROT_NONE mappings to reserve contiguous regions much larger
than the memory that will actually be used. An ambient RLIMIT_AS setting
can break this, so we need to raise the soft limit to the hard limit (which
is usually unlimited).
We cannot rely on doing this inside the nacl_helper child itself, so we
must do it in the zygote before it exec's nacl_helper_bootstrap. That exec
itself could fail if the limit is too small, because nacl_helper_bootstrap
uses ELF program headers to reserve a large region of address space.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2438
TEST= nacl apps work when "ulimit -S -v 5376320" was run before starting chrome
R=mark@chromium.org,bsy@google.com,bradchen@google.com
Review URL: http://codereview.chromium.org/8528041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I've preferred using kTimeoutMultiplier only once to duplicating it for each timeout.
This however makes InitializeTimeout(0, 0, &value) non-unipotent.
BUG=103371
Review URL: http://codereview.chromium.org/8510053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow JSONWriter and JSONValueSerializer to ignore binary values when instructed to do so.
Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c
BUG=None
TEST=base_unittests
Review URL: http://codereview.chromium.org/8505033
TBR=ericdingle@chromium.org
Review URL: http://codereview.chromium.org/8528051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instructed to do so.
Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c
BUG=None
TEST=base_unittests
Review URL: http://codereview.chromium.org/8505033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8137002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_DEVICECHANGE is sent when there's been a change to devices or the computer;
specifically when a USB device is connected or disconnected. This is intended
for use in support of Gamepads for more performant polling and
connect/disconnect testing. Currently only on Windows, though seems reasonable
to add for other platforms in the future.
BUG=79050
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109960
Review URL: http://codereview.chromium.org/8523021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will automatically catch thread names in several of the
child processes we are after, and it also catches the name
for a webkcore thread.
The underlying function uses a try/catch clause, which
contaminates the entire function. As a result, I needed
to factor out that section, so that I could still call
to set the profiler thread name. Without this, the
shared dbg build will fail to compile.
r=rtenneti
Review URL: http://codereview.chromium.org/8565036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
jingle, and media.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8511045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=compile
Review URL: http://codereview.chromium.org/8564020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The interface now conforms to base::mac::GetValueFromDictionary<>(dictionary, key). The tests written have loosely compared it against the original base::mac::GetValueFromDictionary method for expectations.
TEST=FoundationUtilTest.GetValueFromDictionary
Review URL: http://codereview.chromium.org/8540021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
name at a central place
[I've removed the code, via a separate CL, that DCHECK() earlier today]
This will automatically catch thread names in several of the
child processes we are after, and it also catches the name
for a webkcore thread.
r=rtenneti
Review URL: http://codereview.chromium.org/8558003
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8564014
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8565030
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8555022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_DEVICECHANGE is sent when there's been a change to devices or the computer;
specifically when a USB device is connected or disconnected. This is intended
for use in support of Gamepads for more performant polling and
connect/disconnect testing. Currently only on Windows, though seems reasonable
to add for other platforms in the future.
BUG=79050
Review URL: http://codereview.chromium.org/8523021
TBR=scottmg@chromium.org
Review URL: http://codereview.chromium.org/8528044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: If343fbc83fdb0d0720bd7292e1db6e81188404b1
R=dnicoara@chromium.org,sadrul@chromium.org,tfarina@chromium.org
BUG=chromium:102903
TEST=compiles
Review URL: http://codereview.chromium.org/8508039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
place
[I've removed the code, via a separate CL, that DCHECK() earlier today]
This will automatically catch thread names in several of the
child processes we are after, and it also catches the name
for a webkcore thread.
r=rtenneti
Review URL: http://codereview.chromium.org/8558003
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8564014
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8565030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_DEVICECHANGE is sent when there's been a change to devices or the computer;
specifically when a USB device is connected or disconnected. This is intended
for use in support of Gamepads for more performant polling and
connect/disconnect testing. Currently only on Windows, though seems reasonable
to add for other platforms in the future.
BUG=79050
Review URL: http://codereview.chromium.org/8523021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The master lock is very rarely used, so we can afford
to use a lazy instance of this lock.
r=rtenneti
BUG=104167
Review URL: http://codereview.chromium.org/8567007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the use_wayland build which was broken by this commit:
http://codereview.chromium.org/8113028
Similar to win, we create a wayland namespace inside base
and define WaylandEvent there.
Historical note:
Wayland does not have a "native" event structure. Instead, the client
is made aware of events via a callback executed in the context
of display_run():
http://git.chromium.org/gitweb/?p=chromiumos/third_party/wayland-demos.git;a=blob;f=clients/window.c
So we create WaylandEvent structure which takes the parameters from
the callback and wraps them into a structure. For details, see:
src/ui/wayland/events/wayland_event.h
BUG=chromium:102903
TEST=Compiles but doesn't yet link with this change plus a series of
others I'm working on.
R=msw@chromium.org,oshima@chromium.org,mark@chromium.org
Review URL: http://codereview.chromium.org/8378005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The os_bsd variable is only available on FreeBSD and OpenBSD.
Later on others like NetBSD and DragonflyBSD can be added.
This variable was introduced in order to have shorter
conditions in the gyp files.
BUG=
TEST=compile
Patch by Robert Nagy <robert.nagy@gmail.com>
Review URL: http://codereview.chromium.org/8567001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will automatically catch thread names in several of the
child processes we are after, and it also catches the name
for a webkcore thread.
r=rtenneti
Review URL: http://codereview.chromium.org/8558003
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8564014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will automatically catch thread names in several of the
child processes we are after, and it also catches the name
for a webkcore thread.
r=rtenneti
Review URL: http://codereview.chromium.org/8558003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should have no change whatever in function,
but simply changes the names of calls for
tracking time so that the ThreadData can know if
a new trackig has started or ended.
This will be helpful in (a future CL) measuring
when the thread is doing something that is not
tracked at all (e.g., processing UI events, etc.)
r=rtenneti
Review URL: http://codereview.chromium.org/8548005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103633
TEST=trybots & manually checking that chrome://histograms/Aspect now shows the two custom enum histograms from r108951, with correctly specific buckets.
Review URL: http://codereview.chromium.org/8506038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8544003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Transition from internal used of "class Duration" (which is
kindred of base::TimeDelta) to using an integral type.
This is in preparation for handling durations that are
not time based, such as memmory allocation units.
r=rtenneti
BUG=103321
Review URL: http://codereview.chromium.org/8502001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This represents a Java object for use in the Java bridge. It handles all of the
JNI required to interrogate the Java object and call methods on it.
Also adds some JNI utility methods to simpify the new code.
BUG=96703
Review URL: http://codereview.chromium.org/8509019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109645 0039d316-1c4b-4281-b951-d872f2087c98
|