summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Adding CHECKs to troubleshoot the crash issue ↵oshima@chromium.org2010-11-101-0/+7
| | | | | | | | | | | | | intuple.h/browser_render_process_host.cc (see bug description) This is chromeos only and will be removed once I correct data. BUG=chromium-os:7327 TEST=none Review URL: http://codereview.chromium.org/4752003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65729 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some DCHECKs to DCHECK_EQ.thestig@chromium.org2010-11-101-6/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4766002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65699 0039d316-1c4b-4281-b951-d872f2087c98
* Include the Version class in the 64 bit version of base. This is needed so ↵robertshield@chromium.org2010-11-102-4/+4
| | | | | | | | | | | | that it can be used from client_utils.cc which is included in both the chrome target and the chrome_nacl_win64 target. BUG=61609 TEST=None Review URL: http://codereview.chromium.org/4676002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65674 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a new process type for running PPAPI plugins. The process itself isbrettw@chromium.org2010-11-103-13/+69
| | | | | | | | | | | | | | | quite simple and just sets up the PPAPI dispatcher and loads the library. There is a new command line switch --ppapi-out-of-process which runs PPAPI plugins out of process using the new code path. There is some logic in RenderView and PepperPluginModule for setting up this connection, but it should be straightforward. TEST=none BUG=none Review URL: http://codereview.chromium.org/3915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65614 0039d316-1c4b-4281-b951-d872f2087c98
* Make Singleton::OnExit explicity not-threadsafetimurrrr@chromium.org2010-11-091-3/+5
| | | | | | | | | This should help track down Singleton mis-usage, e.g. BUG=61753 TEST=trybots Review URL: http://codereview.chromium.org/4430003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65527 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove 'using' declaration of SStringPrintf.tfarina@chromium.org2010-11-081-1/+0
| | | | | | | | | | | Update the callers to append base:: when calling SStringPrintf. BUG=None TEST=locally and trybots Review URL: http://codereview.chromium.org/4330002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65446 0039d316-1c4b-4281-b951-d872f2087c98
* Erase base/move. The pattern we use is pass by const ref and this is ↵brettw@chromium.org2010-11-082-56/+0
| | | | | | | | | | confusing people. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/4682003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65444 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typos in commentsjar@chromium.org2010-11-081-14/+13
| | | | | | | | | | about:objects became about:tasks a while back, but there were somem lingering references. tbr=wtc Review URL: http://codereview.chromium.org/4662002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65431 0039d316-1c4b-4281-b951-d872f2087c98
* Removed few unused lines.neb@chromium.org2010-11-081-1/+0
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/4572002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65403 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using TimeTicks rather than Time in message loopsjar@chromium.org2010-11-0613-46/+57
| | | | | | | | | | Switch to using TimeTicks rather than Time so that we are not dependent on changes in the system clock. r=mbelshe,darin Review URL: http://codereview.chromium.org/3884001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65322 0039d316-1c4b-4281-b951-d872f2087c98
* Move Windows-specific Event Tracing for Windows implementation to base/win. siggi@chromium.org2010-11-0615-37/+88
| | | | | | | | | | | fix users of same. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/4517004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use Linux WorkerPool code.shess@chromium.org2010-11-055-1/+63
| | | | | | | | | | | | | | | | | Adapts things to use the Linux WorkerPool code by default, with --disable-linux-workerpool to switch back to the old version. The old implementation uses NSOperationQueue, which is implemented in terms of pthread workqueues. These are implicated by the stack traces from the recent unit test flakiness. This change attempts to influence that flakiness. BUG=20471, 60426 TEST=Tree green. Review URL: http://codereview.chromium.org/4595001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65273 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WaitableEventWatcherTest.DeleteUnder on win.mattm@chromium.org2010-11-051-1/+7
| | | | | | | | | BUG=62119 TEST=none Review URL: http://codereview.chromium.org/4565003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65256 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of single-module-per-logon-session-per-profile implementation ↵robertshield@chromium.org2010-11-052-2/+31
| | | | | | | | | | | | for Chrome Frame. BUG=61383 TEST=Run IE with version X of CF loaded. Register version Y of CF. Run a second IE process, notice that version Y when loaded defers to version X. Review URL: http://codereview.chromium.org/4144008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile with 10.6 SDKjrg@chromium.org2010-11-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/4521001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65159 0039d316-1c4b-4281-b951-d872f2087c98
* Try to improve message_loop efficiency when backloggedjar@chromium.org2010-11-042-4/+17
| | | | | | | | | | | | | | | | | | | | | | The call to Now() uses a lock to handle roll over events, and that might make the call more expensive in some scenarios. Reduce the number of times we need to call Time::Now() when processing timer events by processing all (fully ripe, and ready to run) events with only one call to Now(). This should make the queue run faster as we fall further behind. I was hoping to see some perf improvement, but I think this will only have an impact when we are overloaded, which problably doesn't happen often on the bots. I did some local histogramming, and I do see cases where we get away with processing several (2-3) events with one call to Now(), but that is apparently not enough to move the needle on the perf bots. r=darin Review URL: http://codereview.chromium.org/4247003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65131 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65010 - Adding OOM priority management for renderers on ChromeOS.gspencer@chromium.org2010-11-041-1/+1
| | | | | | | | | | | | | | Reverting because this causes problems on valgrind (for ChromeOS only). Turns out that TabStripModel is not thread safe, and I'm calling from another thread. Review URL: http://codereview.chromium.org/4446002 TBR=gspencer@chromium.org Review URL: http://codereview.chromium.org/4417006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65091 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-046-2/+116
| | | | | | | | | BUG=60211 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate ETW with VLOG logging.siggi@chromium.org2010-11-047-77/+165
| | | | | | | | | | | | | This change extends the log severities into the negative for VLOG verbosities. It also keeps track of file/line information and passes it to any registered log handler. The log level is naturally controlled by translating ETW log levels to the severities. BUG=none TEST=none Review URL: http://codereview.chromium.org/4164011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
* Adding OOM priority management for renderers on ChromeOS.gspencer@chromium.org2010-11-041-1/+1
| | | | | | | | | | | | | | | | | [I actually did this two months ago, and though I had committed it, but due to the "git cl push" vs "git cl dcommit" craziness, it was never in the tree.] It was previously reviewed and LGTM'd here: http://codereview.chromium.org/3235007/show BUG=none TEST=Tested on device, both using large numbers of tabs, and small tabs that used lots of memory. Review URL: http://codereview.chromium.org/4446002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65010 0039d316-1c4b-4281-b951-d872f2087c98
* linux: include linux/nfs_fs.h for NFS superblock magicevan@chromium.org2010-11-041-1/+1
| | | | | | | | | | | | The location of the definition we want has moved over time. See the bug for why this location is better. BUG=52269 TEST=compiles Review URL: http://codereview.chromium.org/4455001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65000 0039d316-1c4b-4281-b951-d872f2087c98
* Allow histograms in cache stats.cc to bypass corruption checksjar@chromium.org2010-11-033-14/+206
| | | | | | | | | | | | | | | | This is a relanding of http://codereview.chromium.org/4174002 The change in this CL is that I've made the function to look for errors virtual, and over-rode it in StatsHistograms. The current override doesn't actually check for inconsistencies, so that the UMA checks (and renderer-to-histogram checks) won't complain and refuse to transport the histograms. BUG=61281 r=rvargas Review URL: http://codereview.chromium.org/4364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64990 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the extended header parameter syntax in Content-Disposition ↵jshin@chromium.org2010-11-033-0/+62
| | | | | | | | | | | | | | | | | | | | | | header (RFC 5987). It's not generic, but is only used for 'filename' param. The CL is originally by James Simonsen I reviewed at http://codereview.chromium.org/4254001/show I added a check for ASCIIness for RFC 5987 extended header and a few tests to NetUti*.GetFileNameFromCD (net_unittests) and I*.ConvertCo*Norma* (base_unittests). I also replaced '\uxxxx' notation with the corresponding UTF-8 byte sequence because Visual Studio does not understand it yet. BUG=57830 TEST="net_unittests --gtest_filter=NetU*.GetFil*", "base_unittests --gtest_filter=I*.Conver*Norm*" and tests at http://greenbytes.de/tech/tc2231/ Original CL / Review: By James Simonsen; at http://codereview.chromium.org/4254001/show Review URL: http://codereview.chromium.org/4435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64987 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use the new message pump for TOUCH_UI yet.bryeung@google.com2010-11-031-1/+2
| | | | | | | | | | | It isn't quite ready. BUG=none TEST=build and run chrome, can type in the omnibox again Review URL: http://codereview.chromium.org/4425001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64975 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64960 - Turn on file access checks on Win.rafaelw@chromium.org2010-11-036-116/+2
| | | | | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/4431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-036-2/+116
| | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the testing::LogDisabler for the change r64883. See ↵hansl@google.com2010-11-032-0/+6
| | | | | | | | | | | | | http://codereview.chromium.org/4262001/show The r64883 broke most unit tests in CEEE that relied on disabling logs while testing error paths. BUG=None TEST=None Review URL: http://codereview.chromium.org/4390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64948 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where CHECKs don't fire if min_log_level > FATALakalin@chromium.org2010-11-033-34/+89
| | | | | | | | | BUG=61510 TEST=New unittests in base_unittests Review URL: http://codereview.chromium.org/4262001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build by moving ToLowerASCII into base namespace.tfarina@chromium.org2010-11-032-8/+8
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4371001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64879 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move CaseInsensitiveCompare traits into the base namespace.tfarina@chromium.org2010-11-032-19/+20
| | | | | | | | | | | | | | | This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by: Jeff Timanus <twiz@google.com> BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove 'using' declaration of StringPrintV.tfarina@chromium.org2010-11-031-1/+0
| | | | | | | | | | | Callers should append base:: when calling StringPrintV now. BUG=None TEST=locally and trybots Review URL: http://codereview.chromium.org/4296004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64687 - Try to detect internal corruption of histogram instances.jar@chromium.org2010-11-023-206/+14
| | | | | | | | | | | | | | | | | | | | | | | | Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/4349002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64846 0039d316-1c4b-4281-b951-d872f2087c98
* Moving Entry from base::file_util_proxy namespace to within class ↵kkanetkar@chromium.org2010-11-022-37/+31
| | | | | | | | | | | | base::FileUtilProxy BUG=None TEST=None Review URL: http://codereview.chromium.org/4261001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64806 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that could occur when converting strings with leading characters ↵erikwright@chromium.org2010-11-022-1/+8
| | | | | | | | | | | above 127. BUG=None TEST=base_unittests --gtest_filter=*StringToInt* Review URL: http://codereview.chromium.org/4129012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64789 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SharedMemoryProcessTest.Tasks as flaky on Mac.bauerb@chromium.org2010-11-021-1/+7
| | | | | | | | | BUG=61589 TEST=SharedMemoryProcessTest.Tasks Review URL: http://codereview.chromium.org/4228003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64749 0039d316-1c4b-4281-b951-d872f2087c98
* Try to detect internal corruption of histogram instances.jar@chromium.org2010-11-013-14/+206
| | | | | | | | | | | | | | | | | | | | | Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64687 0039d316-1c4b-4281-b951-d872f2087c98
* While there are all sorts of reasons for "/dev/shm" to be inaccessible,markus@chromium.org2010-11-011-1/+1
| | | | | | | | | | | | | and "chmod" might or might not actually fix the problem, we should never give advice that actually introduces more problems. Changing permissions to 777 is bad, as it drops the sticky bit. Instead, the instructions should say 1777. BUG=none TEST=none Review URL: http://codereview.chromium.org/4245001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64673 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unused (and broken) logging functions.akalin@chromium.org2010-11-011-80/+22
| | | | | | | | | | | Moved DEFINE_CHECK_OP_IMPL to be closer to the CHECK_EQ et al. macros. BUG=9913 TEST=Existing unit tests Review URL: http://codereview.chromium.org/4140012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64671 0039d316-1c4b-4281-b951-d872f2087c98
* Wrote a custom pattern matcher for vmodule.akalin@chromium.org2010-11-014-15/+123
| | | | | | | | | | | | | | The custom pattern matcher matches any slash (forward or backward) to any slash. It also does not do escaping like MatchPattern(). Finally, '?' matches exactly one character, which matches google-glog behavior (MatchPattern() matches '?' to 0 or 1 character). BUG=61123 TEST=New unittests Review URL: http://codereview.chromium.org/4205005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64661 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify a comment.evan@chromium.org2010-11-011-2/+1
| | | | | | | | | | This object is primarily available to work around bugs, but it is also sometimes necessary, which is why it describes its usage as *almost* always incorrect. Review URL: http://codereview.chromium.org/4213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64656 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed subtle difference in behavior between DCHECK and DCHECK_EQ et al.akalin@chromium.org2010-11-012-14/+59
| | | | | | | | | BUG=58998 TEST=New unit tests Review URL: http://codereview.chromium.org/4199005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64650 0039d316-1c4b-4281-b951-d872f2087c98
* Minor typo cleanup of header title for about:tasksjar@chromium.org2010-11-011-1/+1
| | | | | | | r=wtc Review URL: http://codereview.chromium.org/4166011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64648 0039d316-1c4b-4281-b951-d872f2087c98
* process_util_linux: mark functions that use /proc as safe for disk IOevan@chromium.org2010-11-011-0/+22
| | | | | | | | | | | | Reading files /proc is effectively just a kernel API; it's not unsafe like accessing normal disk files is. BUG=61136 TEST=no more DCHECKs in task manager Review URL: http://codereview.chromium.org/4135015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64640 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-014-7/+7
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Use GLib to parse environment variables to determine the default locale.jshin@chromium.org2010-10-302-10/+53
| | | | | | | | | | | | | | | | | | | | | | Switch to using GLib, instead of having a Chromium specific implementation, for parsing environment variables for language preferences for all POSIX systems that use GTK+. If we have a non-GTK port in the future, we have to resurrect our custom code. This will guarantee that UI language selection in Chromium works just like for all other GTK+ applications, and simplify the code. While doing this, also do some cleaning-up of the language preferences code and add a test case to verify that the prioritization is done correctly. Original CL by Fredrik Roubert at http://codereview.chromium.org/2901004/show BUG=NONE TEST=app_unittest with "--gtest_filter=L10nUt*.*Loc*" passes. Review URL: http://codereview.chromium.org/4217004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64524 0039d316-1c4b-4281-b951-d872f2087c98
* Dynamic policy refresh support for the Mac.mnissler@chromium.org2010-10-292-2/+26
| | | | | | | | | | | Adapt the file watching code we already had for ConfigDirPolicyProvider to support a loader delegate, make the old code use it and change the Mac policy provider to watch for changes to the plist file in /Library/Managed Preferences/<username>. BUG=52040 TEST=unit tests Review URL: http://codereview.chromium.org/4062002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64415 0039d316-1c4b-4281-b951-d872f2087c98
* Rlz fix.tfarina@chromium.org2010-10-291-29/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4211004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64411 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-293-101/+0
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for filtering on the entire pathname to --vmodule.akalin@chromium.org2010-10-295-90/+111
| | | | | | | | | | | | | Also cleaned up spurious warning when --vmodule is used but --v is not. Removed slow perf unittest from vlog_unittest.cc. BUG=61123 TEST=New vlog unittests Review URL: http://codereview.chromium.org/4140007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64346 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where the entire file path was being printed for logs on non-Windowsakalin@chromium.org2010-10-291-5/+5
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/4215003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64345 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 16:25:08 +0000