| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no change
Review URL: http://codereview.chromium.org/9839017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to threadsafety ambiguity, it's not generally safe to call env()
on a random Ref you've been passed, so this removes the temptation.
The useful LocalRef optimizations are retained though, just in that
sub-class.
(upstreaming CL, cherrypicked cleanly)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9584014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No logical code changes in this CL. This moves some Mac utilities from
chrome/browser/mac to base/mac, so they can be used by the Remoting Host
plugin code in remoting/host/plugin
BUG=None
TEST=Compiles, unit_tests run
Review URL: https://chromiumcodereview.appspot.com/9764013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to support std::back_inserter.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9804002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make all the places that include run_all_unittests.cc manually depend
on this target instead.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9691067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for making a change to the JSONReader and it makes
verifying the change easier.
BUG=111581
TEST=base_unittests --gtest_filter=JSON\*
Review URL: http://codereview.chromium.org/9754005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid bugs like http://code.google.com/p/chromium/issues/detail?id=118064 in the future. Positional parameters are supported by the VC++ runtime via the set of "_p" flavored printf-like routines. MSDN claims that "By default the positional functions behave identically to the non position ones, if no positional formatting is present."
There is a little difference that require some attention though. Currently base::vsnprintf and base::vswprintf wrappers use "_s" functions (so called "security enhanced versions"). Judging by looking at the CRT code, _p functions implement the same checks as _s ones do. The base wrappers call the CRT routines so that count == (sizeOfBuffer - 1). This reduces most of the additional code in _vsnprintf_s (comparing to _vsprintf_p) to no-op. Namely:
1. When truncation happens the tail of the buffer is filled with a pattern:
_SECURECRT__FILL_STRING(string, sizeInBytes, count + 1);
This does not happen in our case because sizeInBytes == count + 1.
2. The special case check shown below was never true since sizeInBytes != count in our case:
if (count == 0 && string == NULL && sizeInBytes == 0)
3. The following checks in _vsnprintf_s are also implemented in _vsnprintf_helper:
_VALIDATE_RETURN(format != NULL, EINVAL, -1);
_VALIDATE_RETURN(string != NULL && sizeInBytes > 0, EINVAL, -1);
The only remaining difference between _vsnprintf_s and _vsprintf_p is that the former NULL-terminates the buffer and fills the rest a pattern if _vsnprintf_helper failed because of any reason other than truncation:
string[0] = 0;
_SECURECRT__FILL_STRING(string, sizeInBytes, 1);
This CL write NULL to the end of the buffer in any error case (truncation or other reason).
Review URL: http://codereview.chromium.org/9702002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure the expanded arg is in a paren to guard against possible
side effects.
BUG=chromium:115686
TEST=None
Review URL: http://codereview.chromium.org/9460022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files don't use message loops, so drop those includes and add
the standard headers they actually need.
BUG=None
TEST=building libbase in ChromeOS
Review URL: http://codereview.chromium.org/9705110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't build on Linux and Mac.
BUG=118376
TEST=none
Review URL: http://codereview.chromium.org/9720046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing linker errors.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Assert that the constructor message loop is non-NULL only when
the SequencedWorkerPool is about to be destroyed.
Revert now-unneccessary test changes that adds MessagePools for
SequenedWorkerPool.
BUG=117940
TEST=
Review URL: http://codereview.chromium.org/9699115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components can use it.
plus, a couple of cleanups including
- removed unnecessary includes
- removed unnecessary ifdef chromeos in chromeos only code.
BUG=115967
TEST=none
Review URL: http://codereview.chromium.org/9546013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like failure was just Windows flakiness.
original review URL: https://chromiumcodereview.appspot.com/9703126
BUG=none
TEST=SharedMemoryProcessTest.Tasks
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9722010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky@chromium.org,dmazzoni@chromium.org,thestig@chromium.org,joaodasilva@chromium.org,willchan@chromium.org,hclam@chromium.org
Review URL: http://codereview.chromium.org/9703098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=SharedMemoryProcessTest.Tasks
Review URL: https://chromiumcodereview.appspot.com/9703126
TBR=tbreisacher@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9716002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=SharedMemoryProcessTest.Tasks
Review URL: https://chromiumcodereview.appspot.com/9703126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for performance.
This change will be reverted soon.
BUG=114301
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9701097
TBR=dmikurube@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9706107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change will be reverted soon.
BUG=114301
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9701097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=base_unittests
TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org
Review URL: http://codereview.chromium.org/9590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/9702062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a need to look at the implementation to confirm that process_handle would never be assigned to if the call failed. So I added a comment for future readers.
While doing so, I found an edge case where I think the process handle could be leaked.
BUG=None
TEST=Ask a random developer whether they must check process_handle if LaunchProcess returns false. If they look at process_util_*.cc, fail.
Review URL: http://codereview.chromium.org/9689081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add OnHasWork() method to TestingObserver.
Make TestingObserver a constructor parameter, so it can
be read outside the lock.
BUG=117469
TEST=
Review URL: http://codereview.chromium.org/9689028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=117476
TEST=run base_unittests on Mountain Lion
Review URL: http://codereview.chromium.org/9701031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=The "DumpRenderTree" target on the FYI bot should link.
Review URL: http://codereview.chromium.org/9706022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=none
Review URL: http://codereview.chromium.org/9691059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OpenProcess returns NULL on error, see http://msdn.microsoft.com/en-us/library/windows/desktop/ms684320(v=vs.85).aspx
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/9703019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Careful review by Mark. And a unittest.
Review URL: http://codereview.chromium.org/9706001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the dependency to the base target, causing Java to be compiled on all
configurations (including trybots and the main waterfall bot). We currently
build two source files.
BUG=
TEST=Build output should execute the "base_java" action.
Review URL: http://codereview.chromium.org/9699018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9443018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this one slipped through recently. Almost done!
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9689053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on CLs 9568003 and 9570005.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9355050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of data, in histogram pickles. (The goal is to remove that method entirely.
Uses that never persist or send pickles over the network are [probably] safe,
but having the method around is waiting for accidental misuses.)
Review URL: https://chromiumcodereview.appspot.com/9696001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9695040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
checking for overflows.
BUG=117704
TBR=willchan
Review URL: https://chromiumcodereview.appspot.com/9694034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromium-specific changes.
This change is retry of r124832. The original review discussion is at http://codereview.chromium.org/9311003/.
The major reason for us is to enable a fix for HEAP_PROFILE_MMAP. The change is created by 3-way merge from 1) the original google-perftools r109 ( = vendor base), 2) the original gperftools 2.0 r144 ( = branch), and 3) the chromium branch ( = another branch) with the following additional changes :
* base/allocator/allocator.gyp is modified.
* Many [#include "third_party/tcmalloc/chromium/src/google/..."] are replaced with "gperftools/". (Many files in Chromium)
* gperftools/tcmalloc.h (formerly google/tcmalloc.h) is replaced with the original (generated) one.
* windows/gperftools/tcmalloc.h (formerly windows/google/tcmalloc.h) is replaced with the original (generated) one.
* malloc_hook-like functions are moved to libc_override*.h in gperftools 2.0. Some changes due to it.
* MALLOC_HOOK_MAYBE_VOLATILE is redefined using __MALLOC_HOOK_VOLATILE. (config.h, tcmalloc.cc and libc_override_glibc.h)
* The macro "CRASH(...)" is replaced with "Log(kCrash, __FILE__, __LINE__, ...)". (Many files)
* LARGE_PAGE-related parameters (which may affect performance?) are merged. (common.h)
* RAW_VLOG() calls are removed. (base/googleinit.h)
* sys_{mmap|munmap|mremap}(...) calls are tentatively replaced with syscall(SYS_{mmap|munmap|mremap}, ...). (malloc_hook_mmap_linux.h)
* tc_mallinfo is declared only when HAVE_STRUCT_MALLINFO is defined. (gperftools/tcmalloc.h)
* "libc_override_redefine.h" is not included in Windows. (libc_override.h)
* Chromium-original "sys_alloc" is not declared. (windows/port.cc)
* base/spinlock_win32-inl.h is reverted from r144 because 64-bit atomicops are not implemented on Windows. (base/atomicops-internals-windows.h)
The vendor branch is updated in another change.
BUG=114302
TEST=run all existing tests.
Review URL: https://chromiumcodereview.appspot.com/9584046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch also replaces the global AtomicSequenceNumber variables with
StaticAtomicSequenceNumber in order to remove static initializers.
BUG=94925
Review URL: http://codereview.chromium.org/9415039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=none
Review URL: http://codereview.chromium.org/9585001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9553007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cast char to unsigned char before passing it to isalpha to prevent
it from becoming a negative integer if char is a signed type. See
https://bugzilla.mozilla.org/show_bug.cgi?id=689188.
R=mark@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9691017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The previous implementation left a window where an empty destination file had been created yet the replace hadn't yet happened. This was causing flakes in the Chrome Frame integration tests since chrome.exe is killed shortly after startup over and over again. When the stars aligned (more often than you may think), ReplaceFile would have time to create an empty Preferences file, but didn't have time to complete the ReplaceFile. Subsequent tests would then fail because an empty prefs file is an invalid prefs file.
BUG=81479
TEST=none
Review URL: http://codereview.chromium.org/9689013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add unit test for spurious work signal behavior.
Split cond_var_ into multiple condition variables; one for each distinct
condition. Document exactly when each condition variable is waited on.
Restrict the thread that SWP::Shutdown() can be called from.
Fix brace usage in destructor.
BUG=117469
TEST=
Review URL: https://chromiumcodereview.appspot.com/9651026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This infrastructure allows Google Test-based tests to opt-in to some magic that results in extremely verbose logs appearing in test output for only those tests that fail. This includes all LOG() messages generated by chrome.exe, npchrome_frame.exe, and the test executable itself, as well as all TRACE_EVENT_*_ETW events. The interesting entrypoints are in test_log_collector_win.h, file_logger_win.h, and log_file_printer_win.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9584017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9669028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90078
TEST=debug components build
TBR=mark
Review URL: http://codereview.chromium.org/9666048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(gperftools 2.0).
This change will be reverted soon.
BUG=114302
TEST=run all existing tests.
Review URL: https://chromiumcodereview.appspot.com/9666033
TBR=dmikurube@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9667026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change will be reverted soon.
BUG=114302
TEST=run all existing tests.
Review URL: https://chromiumcodereview.appspot.com/9666033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114732
TEST="existing tests"
Review URL: http://codereview.chromium.org/9638002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9584024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jamesr,zmo
BUG=114914
Review URL: http://codereview.chromium.org/9580021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125891 0039d316-1c4b-4281-b951-d872f2087c98
|