summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* r226421 added 10.9 as a variant, so it should be valid.avi@chromium.org2013-10-021-1/+2
| | | | | | | | | TEST=none BUG= Review URL: https://codereview.chromium.org/25657007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226593 0039d316-1c4b-4281-b951-d872f2087c98
* A few improvements to make jni_generator work outside of chromium.bulach@chromium.org2013-10-023-42/+76
| | | | | | | | | | | | | | | * Print a usage message if called with no (valid) arguments. * Determine the script name by stripping before either 'base' or 'third_party', or strip nothing if neither name can be found in the path. * Allow overriding the script name, and use this in the tests to be path-agnostic. TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/23702057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226503 0039d316-1c4b-4281-b951-d872f2087c98
* base: Fix MemoryPressureListener documentationboliu@chromium.org2013-10-021-5/+2
| | | | | | | | | | | | | | ObserverListThreadSafe will call PostTask on all observer callbacks, even those on the same thread. So correct the comment in MemoryPressureListener which states callbacks on the same thread as the system broadcast are called synchronously. BUG= NOTRY=true Review URL: https://codereview.chromium.org/25676002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226497 0039d316-1c4b-4281-b951-d872f2087c98
* Added the AutomaticProfileResetter service.engedy@chromium.org2013-10-022-0/+23
| | | | | | | | | BUG=298036 NOTRY=True Review URL: https://codereview.chromium.org/24533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226473 0039d316-1c4b-4281-b951-d872f2087c98
* Update OS version functions.avi@chromium.org2013-10-025-19/+67
| | | | | | | | | BUG=none TEST=covered Review URL: https://codereview.chromium.org/25286002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226421 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WaitableEvent and ConditionVariable::TimedWait to use monotonic time on ↵piman@chromium.org2013-10-023-14/+107
| | | | | | | | | | | | | | | | | non-Mac non-NaCl posix Both use a relative time, and it's important that this relative time is consistent with the wall clock when the system time gets adjusted (e.g. NTP, tlsdate, etc.). The monotonic clock, when available, has that property. Unfortunately, by default, pthread_cond_timedwait takes the system time which doesn't have that property. On Linux/Chrome OS, we use pthread_condattr_setclock which lets us use the monotonic clock. On Android, we use the non-portable pthread_cond_timedwait_monotonic_np which has the same effect. Unfortunately, neither is supported by NaCl. Mac can use the non-portable pthread_cond_timedwait_relative_np which uses a relative time. BUG=293736 R=thakis@chromium.org Review URL: https://codereview.chromium.org/24158005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226378 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when ECHO_TO_CONSOLEwangxianzhu@chromium.org2013-10-011-8/+8
| | | | | | | | | | | | | | | | | TraceEvent's copy constructor has a side-effect that the ownership of the convertable values will be passed from the source TraceEvent to the target TraceEvent. Handle ECHO_TO_CONSOLE before the event is added to the buffer. The copy constructor will be obsoleted soon to avoid such issues. BUG=302676 TEST=Run cc_unittests with --trace_to_console Review URL: https://codereview.chromium.org/25453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226319 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Fix test launcher multiple test iterations.phajdan.jr@chromium.org2013-09-303-0/+9
| | | | | | | | | BUG=299282 R=sky@chromium.org Review URL: https://codereview.chromium.org/24996007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226025 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move PerfTimer out of test/ directory.tfarina@chromium.org2013-09-297-83/+52
| | | | | | | | | | | | | | | | | | Reason: PerfTimer is used by production code, so it doesn't make sense to have it as test only. - Rename it to ElapsedTimer. - Move into base namespace. - Move into timer/ directory. BUG=None TEST=None, no functional change R=brettw@chromium.org TBR=grt@chromium.org # for chrome_frame Review URL: https://codereview.chromium.org/24265005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225898 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsRunningOnChromeOS to SysInfostevenjb@chromium.org2013-09-277-54/+54
| | | | | | | | | | | | | | | | | Also, use lsb-release/CHROMEOS_RELEASE_NAME instead of the USER env variable. This CL depends on https://codereview.chromium.org/23588009/ BUG=270135 For trivial base/ changes: R=derat@chromium.org, satorux@chromium.org, sky@chromium.org TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/23904025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225761 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Fix handling of PRE_ testsphajdan.jr@chromium.org2013-09-274-57/+10
| | | | | | | | | | | | - skip dependent tests if a PRE_ test failed - simplify ParallelTestLauncher code now that we don't need sequencing BUG=236893 R=jam@chromium.org Review URL: https://codereview.chromium.org/24892002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225741 0039d316-1c4b-4281-b951-d872f2087c98
* Minor clean-up in base/guid.*vabr@chromium.org2013-09-272-6/+3
| | | | | | | | | BUG=None R=thakis@chromium.org Review URL: https://codereview.chromium.org/24767002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225681 0039d316-1c4b-4281-b951-d872f2087c98
* Move ui/base/x/x11_error_tracker to base/x11.kcwu@chromium.org2013-09-274-0/+112
| | | | | | | | | | This is to share common x11 code for ui/x and chromeos/display. R=thakis@chromium.org Review URL: https://codereview.chromium.org/24160005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225662 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in base/sequence_checker.h.thestig@chromium.org2013-09-271-1/+1
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/24899002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225630 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test for 23588009stevenjb@chromium.org2013-09-261-3/+4
| | | | | | | | | BUG=266903 TBR=derat@chromium.org, petewil@chromium.org Review URL: https://codereview.chromium.org/24878002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225596 0039d316-1c4b-4281-b951-d872f2087c98
* Parse /etc/lsb-release only once on ChromeOSstevenjb@chromium.org2013-09-263-109/+204
| | | | | | | | | | | | | | | | | | This moves all parsing and caching of the contents of /etc/lsb-release to base::SysInfo. This eliminates redundant parsing from: * LsbReleaseLogSource * VersionLoader * StatisticsProvider BUG=266903 For chrome_main_deleagate.cc (code removal only) R=brettw@chromium.org, derat@chromium.org, pneubeck@chromium.org, xiyuan@chromium.org TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/23588009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225581 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CallbackRegistry to CallbackListcaitkp@chromium.org2013-09-266-144/+145
| | | | | | | | | TBR=darin@chromium.org R=ajwong@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/24648002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225534 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProcessUtilTest.GetAppOutputRestrictedNoZombies under ASan on 64-bit ↵glider@chromium.org2013-09-261-1/+10
| | | | | | | | | | | OS X BUG=298197 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/24742002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225474 0039d316-1c4b-4281-b951-d872f2087c98
* Android: cleanup jni_android to minimize external dependencies.bulach@chromium.org2013-09-263-239/+0
| | | | | | | | | | | | | | Other projects will be using the JNI bindings. - Move GetMethodIDFromClassName down to content/browser/renderer_host/java, the only place where it's used. - Remove a few methods that are no longer in use. - Trim down dependencies. BUG= Review URL: https://codereview.chromium.org/23835020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225471 0039d316-1c4b-4281-b951-d872f2087c98
* FieldTrial: Remove friend declarations for non-existing testsvabr@chromium.org2013-09-261-3/+0
| | | | | | | | | | | | | | The tests were removed in https://codereview.chromium.org/10151017 and https://codereview.chromium.org/10830318 but are still referenced as friends. BUG=143239 Review URL: https://codereview.chromium.org/24571002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225445 0039d316-1c4b-4281-b951-d872f2087c98
* Log an error in release builds when NOTREACHED is hit in ChromiumOS builds. ↵zork@chromium.org2013-09-261-0/+5
| | | | | | | | | | This data can be collected on ChromiumOS when the user consents to it; this should help us collect more data about what shouldn't be happening in prod that happens anyways. BUG=288014 Review URL: https://codereview.chromium.org/24313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225383 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make temp file deletion failures non-fatal on Windowsphajdan.jr@chromium.org2013-09-261-1/+4
| | | | | | | | | | | It turns out they may happen. BUG=236893 R=sky@chromium.org Review URL: https://codereview.chromium.org/24472002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225283 0039d316-1c4b-4281-b951-d872f2087c98
* Allow typing label names on Windows by not treating things that start with ↵brettw@chromium.org2013-09-252-1/+26
| | | | | | | | | | | | | | | slashes as arguments rather than switches. The old command line parsing is still run so some code could get confused later since / will also be treated as a switch if you ask for it. This seems not as likely to happen that the label will match a switch. If it does, we'll have to change the CommandLine class to make the "/" behavior optional. Fix a "desc" crash attributing blame due to a null pointer. BUG= R=scottmg@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/24613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225277 0039d316-1c4b-4281-b951-d872f2087c98
* Reland linux_aura: Implement most of DesktopScreenX11.erg@chromium.org2013-09-255-0/+436
| | | | | | | | | | | | | | | | | | | | | | [[Making changes to '_toolset=="target"' section in system.gyp to fix cros compiling.]] The linux_aura port didn't deal with multiple monitors very well because it was treating the X root window as one big display. When xrandr is present, get the screen areas from it, and exposes this data back to chrome. This patch also factors out the EDID parser than chromeos was using into a common directory. Like chromeos, we use it to assign stable display IDs. BUG=287972 TBR=brettw@chromium.org, derat@chromium.org, sky@chromium.org First Review URL: https://codereview.chromium.org/23536057 Review URL: https://codereview.chromium.org/24459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225254 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few unused globals.thakis@chromium.org2013-09-257-121/+4
| | | | | | | | | | | Found by clang's new -Wunused-const-variable. BUG=290204 R=akalin@chromium.org, brettw@chromium.org, sergeyu@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/24616002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225235 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 222826 "Copy the thread name to the stack for debugging p..."rsesek@chromium.org2013-09-251-18/+0
| | | | | | | | | | | | | | | | | | | | > Copy the thread name to the stack for debugging purposes. > > The this ptr in Thread is getting smashed after the MessageLoop ends, which > leaves very little to go on. This is kind of a stab in the dark, but hopefully > it makes something bleed in a general direction. > > BUG=274705 > TEST=Minidumps contain 47 bytes of thread name data way high on the stack. > R=mark@chromium.org > > Review URL: https://codereview.chromium.org/23606030 TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/24508003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225228 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused method PrefService::ReloadPersistentPrefs().gab@chromium.org2013-09-252-10/+0
| | | | | | | | | | | This was removed as part of removing the import process in issue 219419. BUG=219419 R=battre@chromium.org Review URL: https://codereview.chromium.org/24453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225185 0039d316-1c4b-4281-b951-d872f2087c98
* Function-type templated CallbackRegistrycaitkp@google.com2013-09-255-46/+578
| | | | | | | | | BUG=268984 R=ajwong@chromium.org, erikwright@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/23514056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225184 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 225054 "linux_aura: Implement most of DesktopScreenX11."erg@chromium.org2013-09-245-436/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Compiled on linux_chromeos, but doesn't compile in cros. > linux_aura: Implement most of DesktopScreenX11. > > The linux_aura port didn't deal with multiple monitors very well because > it was treating the X root window as one big display. When xrandr is > present, get the screen areas from it, and exposes this data back to > chrome. > > This patch also factors out the EDID parser than chromeos was using into > a common directory. Like chromeos, we use it to assign stable display > IDs. > > BUG=287972 > R=brettw@chromium.org, derat@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/23536057 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/24365012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225061 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Implement most of DesktopScreenX11.erg@chromium.org2013-09-245-0/+436
| | | | | | | | | | | | | | | | | | The linux_aura port didn't deal with multiple monitors very well because it was treating the X root window as one big display. When xrandr is present, get the screen areas from it, and exposes this data back to chrome. This patch also factors out the EDID parser than chromeos was using into a common directory. Like chromeos, we use it to assign stable display IDs. BUG=287972 R=brettw@chromium.org, derat@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/23536057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225054 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: add independent test timeout for the test launcherphajdan.jr@chromium.org2013-09-245-1/+30
| | | | | | | | | | | | | | | | Otherwise when increasing action timeout some tests actually start taking longer (they probably sleep). Also change test status to timeout for tests in a batch that completed but took longer than the timeout so that the outcome is not dependent on test order and similar factors. BUG=236893 R=sky@chromium.org Review URL: https://codereview.chromium.org/24255017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225013 0039d316-1c4b-4281-b951-d872f2087c98
* Fix possible naming conflict in macro.finnur@chromium.org2013-09-241-8/+9
| | | | | | | | | | | | | The ObserverList macro (FOR_EACH_OBSERVER) uses an iterator named |it|, which can in some cases conflict with locally defined variables. Make the iterator variable name slightly more unique BUG=None R=jar@chromium.org Review URL: https://codereview.chromium.org/23672052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224985 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove unused code in the message-loop.sadrul@chromium.org2013-09-242-10/+0
| | | | | | | | | BUG=none R=darin@chromium.org Review URL: https://codereview.chromium.org/24350011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224853 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: instantiate ThreadChecker early in the test launcherphajdan.jr@chromium.org2013-09-233-8/+11
| | | | | | | | | | | | | | This makes sure it's also available during destructions. While the immediate problem happened only with ParallelTestLauncher, I'm proactively fixing similar pattern in other places. BUG=236893 R=sky@chromium.org Review URL: https://codereview.chromium.org/24398002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224838 0039d316-1c4b-4281-b951-d872f2087c98
* Added method to convert base::Time to a Java timestamp.apiccion@chromium.org2013-09-232-0/+17
| | | | | | | | BUG=247382 Review URL: https://chromiumcodereview.appspot.com/22791013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224744 0039d316-1c4b-4281-b951-d872f2087c98
* Add more support for FreeBSDGeo.Liaskos@gmail.com2013-09-211-1/+7
| | | | | | | | BUG= Review URL: https://chromiumcodereview.appspot.com/16206002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224546 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Support running browser tests in parallelphajdan.jr@chromium.org2013-09-195-45/+127
| | | | | | | | | | | This still defaults to serialized execution while I perform more testing. BUG=236893 R=sky@chromium.org Review URL: https://codereview.chromium.org/23757033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224200 0039d316-1c4b-4281-b951-d872f2087c98
* Fix inconsistent FieldTrial group assignment due to float errors.asvitkine@chromium.org2013-09-193-3/+52
| | | | | | | | | | | | | This was discovered by the InstantExtended field trial that was using very small group percentages and discovered several groups of the same size were getting different user counts. BUG=290438 TEST=New unit test that fails without the fix. Review URL: https://chromiumcodereview.appspot.com/23710041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224011 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate WorkerPool::PostTaskAndReply as leaky.earthdok@chromium.org2013-09-181-0/+7
| | | | | | | | | | | | | | Tests which use WorkerPool have no way to pump it during teardown, so they will sometimes have leaks of PostTaskAndReply Closures that we can't do anything about. Since we're deprecating WorkerPool anyway, we can just annotate those leaks and forget about them. BUG=290897,248513 R=ajwong@chromium.org Review URL: https://chromiumcodereview.appspot.com/23514070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223960 0039d316-1c4b-4281-b951-d872f2087c98
* Fix --trace-shutdown with thread-local tracing.wangxianzhu@chromium.org2013-09-182-0/+3
| | | | | | | | | | | | | | | | | | | | | | | With thread-local tracing (r221766), TraceLog::Flush() is async and needs to be called from a thread having a message loop. It also requires that tracing has been stopped. BrowserShutdownProfileDumper is a special caller that TraceLog::Flush() was originally called from a thread without message loop. Now start another thread for flushing, and call TraceLog::SetDisabled() before TraceLog::Flush(). The calling thread needs to wait for the completion of the flush, otherwise the browser may shutdown before all trace events written. Temporarily allow the thread to wait in ThreadRestrictions. BUG=none TEST=manual run chrome with --trace-shutdown. Should not assert. Should generate correct trace file. Review URL: https://chromiumcodereview.appspot.com/24047007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223819 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome tracing for system-wide performance stats.jwmak@chromium.org2013-09-186-0/+276
| | | | | | | | | | | | Trace memory, swap, ZRAM, and disk activity and place the data in JSON to be displayed by trace-viewer. BUG=236763 TEST=base_unittests TraceSystemStatsMonitorTest.* Review URL: https://chromiumcodereview.appspot.com/22836004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223806 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Make TRIM_MEMORY_COMPLETE check >= rather than ==rmcilroy@chromium.org2013-09-171-2/+4
| | | | | | | | BUG=None Review URL: https://chromiumcodereview.appspot.com/22911017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223727 0039d316-1c4b-4281-b951-d872f2087c98
* [Aura] Always use IMM32 on desktop Chrome (non-Ash mode)yukawa@chromium.org2013-09-171-4/+0
| | | | | | | | | | | | | | | | | | | | This CL partially reverts r194205, which aimed to support IME for Ash. With this partial rollback, we can assume that all the instances of Aura-Win Chrome running in desktop use IMM32 regardless of the OS version. Given that Ash IME support is not functional yet, there is no strong reason to force TSF only on Win8+. Actually our IMM32 implemenation is more robust than that of TSF. This way should lower the risk of successful launch of Aura for Windows in M31. BUG=164964 TEST=manually confirmed that we can use IME with Win8 Aura build Review URL: https://chromiumcodereview.appspot.com/23875022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223589 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where killing pages doesn't yield a sad-tabccameron@chromium.org2013-09-172-8/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The determination of whether or not to put up a sad tab page is made based on the termination status of the renderer process. The termination status of the renderer process is checked when the channel between the browser and the renderer stops working. There is a race here because there is no reason to believe that the renderer process has finished terminating at the time that the browser detects that its channel to the renderer is dead. If renderer process is believed to be still running at the moment when the decision to put up the sad tab page is taken, then no sad tab will be put up, the view of the renderer will be removed (eventually), and a transparent window will result. This bug was previously fixed on Linux with with https://chromiumcodereview.appspot.com/11316261 this patch expands that fix to Mac. In particular, if the renderer process is known to be dead, wait for the process to terminate before taking its termination status. To be sure that the browser does not wait forever on a renderer that is not exiting, send a kill signal to the renderer before doing the wait. BUG=167538 Review URL: https://chromiumcodereview.appspot.com/23866011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223526 0039d316-1c4b-4281-b951-d872f2087c98
* base: Split logging functions and PerfTimeLogger out of perftimer.htfarina@chromium.org2013-09-177-61/+145
| | | | | | | | | | | | | | | | Soon PerfTimer will move into base/timer/ directory as it is already used by production code. This splits the logging stuff into their owns files and also moves PerfTimeLogger into its own files. BUG=None TEST=base_unittests, ipc_perftests, etc... R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/23985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223486 0039d316-1c4b-4281-b951-d872f2087c98
* Change method of activity tracking done in ActivityStatus.tedchoc@chromium.org2013-09-163-68/+158
| | | | | | | | | | | | | Use the ability to track activity changes by registering a listener on the application. Also, this will manage the state of various activities on the java side. BUG=286071 Review URL: https://chromiumcodereview.appspot.com/23522032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223437 0039d316-1c4b-4281-b951-d872f2087c98
* Use webview classic cookies file to create the chromium basedsgurun@chromium.org2013-09-163-0/+22
| | | | | | | | | | | | | | | | | | webview's cookies file, for the first instance of the app, so cookies are not lost. BUG=b/9962984 TBRing safebrowsing_service and profile_impl_io_data changes since these are mechanical in nature. TBR=mattm@chromium.org,mmenke@chromiumorg adding no try since we have comments that are longer than 80 chars, and since this is allowed under style guidance. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23964011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223400 0039d316-1c4b-4281-b951-d872f2087c98
* Include What You Use: #include <errno.h> where errno is used, or use DPLOGmark@chromium.org2013-09-161-2/+2
| | | | | | | | R=thakis@chromium.org Review URL: https://codereview.chromium.org/23526052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223370 0039d316-1c4b-4281-b951-d872f2087c98
* Use close$NOCANCEL on the Mac, so that it has deterministic behavior whenmark@chromium.org2013-09-162-0/+80
| | | | | | | | | | | | it fails with EINTR. Specifically, in this case, the FD will already have been closed. BUG=269623 R=thakis@chromium.org Review URL: https://codereview.chromium.org/23455051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223369 0039d316-1c4b-4281-b951-d872f2087c98
* Prefs refactoring is done, removing myself from OWNERS.joi@chromium.org2013-09-161-3/+0
| | | | | | | | BUG=155525 Review URL: https://chromiumcodereview.appspot.com/24123005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223365 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 19:07:34 +0000